]> git.koha-community.org Git - koha.git/log
koha.git
8 years ago Bug 15228: Switch "Items in batch number"
Hector Castro [Mon, 23 Nov 2015 01:52:39 +0000 (19:52 -0600)]
 Bug 15228: Switch "Items in batch number"

Yet another line to switch "Items in batch number" to
"Patrons in batch number"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit e89714ea84acd8300a629a7acccc6eee90ff0ff0)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 008e3805ff1f6b59422286a33b55f4b509edca87)

8 years ago Bug 15101: Correct typo AllowPkiAuth vs AllowPKIAuth
Jonathan Druart [Wed, 25 Nov 2015 16:45:50 +0000 (16:45 +0000)]
 Bug 15101: Correct typo AllowPkiAuth vs AllowPKIAuth

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit d36280e36e1fa8779bf845fb0cc0de2ea835d486)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 87ce8e85ec6d4c8a447a4d595bf3b975a9ea3cb3)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 15101: Don't display sys pref AllowPkiAuth under CAS heading
Katrin Fischer [Sun, 22 Nov 2015 01:43:36 +0000 (02:43 +0100)]
Bug 15101: Don't display sys pref AllowPkiAuth under CAS heading

The system preference AllowPkiAuth display under the heading
CAS authentication, but is actually a separate authentication
option. Patch creates a separate heading for it.

To test:
- Go to Administration > System preferences > Tab Administration
- Verify that AllowPkiAuth is now displayed separately

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit cee796629fb131966a8ebfa77ecbcf054c46fd02)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 30bfb13466e875205f8052590e800247fb263952)

8 years ago Bug 15229: Same fix for circulation.tt template (normal checkouts)
Jonathan Druart [Wed, 25 Nov 2015 16:14:35 +0000 (16:14 +0000)]
 Bug 15229: Same fix for circulation.tt template (normal checkouts)

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit acf586a45ab4a27939f0ba34cba58ae8ff500993)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit b1e931f7bbcc7e9c0b03ca59a96fc0a67027191c)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years ago Bug 15220: Fix typo in circ rules help
Nicole C. Engard [Thu, 19 Nov 2015 15:31:01 +0000 (09:31 -0600)]
 Bug 15220: Fix typo in circ rules help

MaxFinesystem should be MaxFine system

To test:

* visit circ & fine rules
* click help
* confirm typo fixed

Signed-off-by: Thomas Misilo <misilot@fit.edu>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 391c8ec0bc682491faaf64494867237dfc01bd11)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit a55557afc0f410da4b106e71362801036774c4c4)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years ago Bug 15238: Better translatability for Installer Step 1
Marc Véron [Sat, 21 Nov 2015 02:25:56 +0000 (03:25 +0100)]
 Bug 15238: Better translatability for Installer Step 1

This Bug streamlines html in installer/step1.tt for better translatibility.

To test:
Reviwe code and verify that changes in text make sense.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
To reproduce in Debian environment, remove a required module with
dpkg -r. Rewording Ok for translation purposes

Bug 15238: (followup) Remove word 'Note:'

'Note: ' removed as requested in comment #3

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Word 'Note' removed

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 29a4300c0727b779e1a0e83a35cd772828debde2)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 8a7bd3aa361ce707fd5e9fd478c7d7bbd0647312)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years ago Bug 15237: Quote of the day: Better translatibility for editor and help
Marc Véron [Sat, 21 Nov 2015 02:09:55 +0000 (03:09 +0100)]
 Bug 15237: Quote of the day: Better translatibility for editor and help

This patch moves  html markup out of explanatory text in Quote of the day editor and help
for better translatibility (Home > Tools > Quote Editor).

To test:
- Apply patch
- Go to Home > Tools > Quote Editor and related Help
- Verify that text changes make sense.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Rewording Ok for translation purposes

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Amended patch: Make consistent space after "Note:" (inside the br tag)

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit b0e833f9f5bffeb0940dd75eae150a247b5b520c)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 53f4b7241c27b36b52571f14d3b1186e6b401c01)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years ago Bug 15236: Better translatibility in "Connect biblio.biblionumber to a MARC subfield"
Marc Véron [Sat, 21 Nov 2015 01:32:30 +0000 (02:32 +0100)]
 Bug 15236: Better translatibility in "Connect biblio.biblionumber to a MARC subfield"

This patch moves html markup out of explanatory sentence in koha2marclinks.tt ("Connect
biblio.biblionumber to a MARC subfield") for better translatability.

To test:

- Apply patch
- Go to Home > Administration < Koha to MARC mapping
  and edit a tag
- Verify that text change makes sense

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Rewording Ok for translation purposes

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit f9586b01998071ddfdfc130ead2f48b079ae7e68)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit ae929c528367c135317d3058794028067b97ac90)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years ago Bug 15233: (followup) Remove 2 sentences.
Marc Véron [Wed, 2 Dec 2015 23:10:28 +0000 (00:10 +0100)]
 Bug 15233: (followup) Remove 2 sentences.

This patch removes 2 sentences (see comment #8)

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 8f77dc86cec51f0f4eea1d627d82fd6b17499060)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 722b953d0c8a8d907333e1cda43e6ed45c02b91e)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years ago Bug 15233: Cataloging subfield editors: Clean up html and streamline text for better...
Marc Véron [Sat, 21 Nov 2015 01:10:24 +0000 (02:10 +0100)]
 Bug 15233: Cataloging subfield editors: Clean up html and streamline text for better translatability

This patch removes bold markup from explanatory text in auth_subfields_structure.tt
and makes it the same as in marc_subfields_structure.tt for better translatibility.

To test:
- Apply patch
- Verify that string changes make sense and that the explanatory text is the same in both files.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Rewording Ok for translation purposes

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 9b0d9a186a7bffc16af2e5b2f67de31eb468a7a5)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit e10046a351ed9681a18b5eaf21ba320f833b057e)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 15231: (followup) Remove stray </b> tag
Marc Véron [Wed, 2 Dec 2015 05:33:32 +0000 (06:33 +0100)]
Bug 15231: (followup) Remove stray </b> tag

This patch removes a stray </b> tag (see comment #4) and a superfluous blank.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit ea0d5aa6bf7b0ff96fc75f04d6cb83dc37d4136a)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 78f47f5dc89699aa388b915a3cad81cf375f2fbc)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 15231 - Import patrons: Remove string splitting by html tags to avoid weird trans...
Marc Véron [Fri, 20 Nov 2015 21:58:40 +0000 (22:58 +0100)]
Bug 15231 - Import patrons: Remove string splitting by html tags to avoid weird translations

Some of the strings in Home > Tools > Import patrons contain html tags and therefore are
splitted in the translation tool. This makes it nearly impossible to create correct translations
from the partial strings.
Additinally, the notes for Extended patron attributes never displayed (due to a bug).

To test:
- Apply patch
- Enable Syspref 'ExtendedPAtronAttributes'
- Go to Home > Tools > Import patrons and verify, that the Notes at the right of the
  screen make sense

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Split html tags removed, notes at right side it displayed correctly

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 5843c76546d5769493099faed2fbce39fbe3b6f3)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit d1e8b93f66b8aa800b5d552f7039effaa9dc9e53)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years ago Bug 15300: Translatability: Replace ambiguous 'From' and 'To' in members-update.tt
Marc Véron [Wed, 2 Dec 2015 11:39:59 +0000 (12:39 +0100)]
 Bug 15300: Translatability: Replace ambiguous 'From' and 'To' in members-update.tt

This patch replaces semantically ambigous words "From" and "To" in
koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt
for better translatability.

To test:
- Apply patch
- Make sure that patrons can request detail changes in OPAC
  (sysprefs opacuserlogin, OPACPatronDetails)
- Log in to OPAC, request a change of personal details
  (cgi-bin/koha/opac-memberentry.pl)
- Log in to staff client
- Click link 'Patrons requesting modifications' or go to
  Home > Patrons > Update patron records
- Verify that table headers make sense

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Rewording Ok for translation purpose

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit b07513526965720c7d558bd9c6176088304a2ee9)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit d8aa61c574022e842a9921beaa2fe723891b895d)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years ago Bug 15366 - Fix breadcrumbs and html page title in guided reports
Marc Véron [Sun, 13 Dec 2015 21:39:53 +0000 (22:39 +0100)]
 Bug 15366 - Fix breadcrumbs and html page title in guided reports

This patch fixes following issues with breadcrumbs and html page title
in Home > Reports > Guided reports wizard:

- Sometimes, breadcrumbs display a stray > at the end

- While creating a report, steps are not displayed in breadcrumbs and
  do not appear in html page title
- html page title is divided by newlines

To test:
- Apply patch
- Go to Home > Reports > Guided reports wizard
- Go to all pages including the steps for creating a new report and
  verify
  - that the breadcrumbs display properly and make sense
  - in html source, the page title makes sense and displays on one line.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as descrived

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 639ccd469f4e00e1737e0dec6ee914d845907938)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit c7028a02b5158591665a35421b4a80f54f5324f3)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years ago Bug 15365: Translatability: Fix issue on Administration > Circulation and fine rules
Marc Véron [Sun, 13 Dec 2015 19:34:46 +0000 (20:34 +0100)]
 Bug 15365: Translatability: Fix issue on Administration > Circulation and fine rules

Fix translatability issue on smart-rules.tt to prevent odd translations (Sentences
splitted by tags and newlines).

To test:
- Apply patch
- Go to Administration > Circulation and fine rules
- Verify that the lines "Note: " and "Important: " below "Default holds policy by
  item type" make sense and are not splitted by tags and (in html) by newlines.

(Amended to fix commit message)

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
strong Note and Important displayed Ok for translation purpose

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit bc2e4ba86208e26d9890868d6deb5c65c263e907)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 0eff941b1b28ae1db1a2e11345a6d7cfb9616c3f)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years ago Bug 15363: Translatability: Fix issue with ambiguous 'all' on Administration > Set...
Marc Véron [Sun, 13 Dec 2015 10:58:52 +0000 (11:58 +0100)]
 Bug 15363: Translatability: Fix issue with ambiguous 'all' on Administration > Set library checkin and transfer policy

In branch_transfer_limits.tt, set ambiguous word 'all' (separated by tags) into a
translatable context.

To test:
Apply patch
- Go to Home > Administration > Set library checkin and transfer policy
- Verify that the word 'all' is no longer separated by tags
  in "For all collection codes: " rsp. "For all item types: "
  (Switch with syspref 'BranchTransfersLimitsType')

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works well for translation purpose

Bug 15363: (followup) Move tags inside if statements

Followup for comment #3

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 27363271be4b4cc308572dcf04049edf33fa1a7c)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 88d1dfcfffcb66ffde3b4ecdebc9b9e5876bc076)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 15362: Translatability: Fix issue on Administration 'Did you mean?'
Marc Véron [Sun, 13 Dec 2015 09:47:53 +0000 (10:47 +0100)]
Bug 15362: Translatability: Fix issue on Administration 'Did you mean?'

Fix sentence splitting by tags on didyoumean.tt leading to odd translations.

To test:
- Apply patch
- Go to Home > Administration > Did you mean?
- Verify that the information below the title displays properly and makes sense.
- Disable Javascript, reload page
- Verify that the warning about missing Javascript displays properly and makes sense.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as descrived. Removed em tags for translation purpose

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 984f641417e20ab561b2670b5ed921dc4aa6a907)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 40724deeb8ebd36e9be5253f47d16396230191e4)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years ago Bug 15346: Translatability: fix sentence splitting issue in memberentrygen.tt
Marc Véron [Wed, 9 Dec 2015 20:31:29 +0000 (21:31 +0100)]
 Bug 15346: Translatability: fix sentence splitting issue in memberentrygen.tt

Fix sentences in memberentrygen.tt that are split by <strong> tags, leading to
wrong capitalization in German (because it can not be decided if a string is part
of a sentence or a standalone sentence).
Example: Es sind Keine Bibliotheken definiert.

To test:
- Apply patch
- To trigger the messages, you have to edit a patron in a system where
  no libraries and no patron categories are defined
- Alternatively, carefully review the changes in
  koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Sentences fixed for translation purposes

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 698fb010f55c0d68789299003f4ac55326142f72)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit ec2e2f6d0b9d4b376b59d24e7895ad767d8fff97)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 15345: Translatability: fix issue in facets (Availability')
Marc Véron [Wed, 9 Dec 2015 17:36:21 +0000 (18:36 +0100)]
Bug 15345: Translatability: fix issue in facets (Availability')

This patch fixes an issue with a splitted sentence in facets (Avalability)
that leads to weird translations e.g.:
German: 'Zeige nur Verfügbar Exemplare'
French: 'Montrer seulement disponible exemplaires'

Additionally, the link "Show all items" gets it's own li tags to display
nicely like the other links in the facets column and it removes superfluous
dots.

To test in OPAC and Staff client:
- Apply patch
- Do a search that results in more than one available items
- In column "Refine your search", click on "Limit to currently available
  items"
- Verify that the message "Showing only available items" and the link
  "Show all items" display nicely.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
use_zebra_facets set to 0 in koha-conf.xml to test. Works as described

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 5e80a64ea39140c9918335fc472a441bb3fa9c6a)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 3951a8fffd4d9b6ecb22a8382878c79225e6d2ca)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 14363: OAI-PMH: Handle records without marcxml
Julian Maurice [Tue, 1 Sep 2015 07:46:35 +0000 (09:46 +0200)]
Bug 14363: OAI-PMH: Handle records without marcxml

Test plan:

1/ git checkout 3.18.x
2/ GET http://OPAC/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml
3/ Take the first biblionumber from the results ($biblionumber)
4/ mysql> update biblioitems set marcxml=null where biblionumber=$biblionumber
5/ Repeat step 2 => XML error
6/ Apply patch
7/ Repeat step 2 => no errors

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
  Works on 3.20.x

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Fix works for 3.18.x and 3.20.x
3.22 is not impacted

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoTrack down last 3 failing tests on Jenkins
Frédéric Demians [Tue, 29 Dec 2015 14:46:17 +0000 (15:46 +0100)]
Track down last 3 failing tests on Jenkins

- Fix t/DateUtils.t

- t/db_dependent/TestBuilder.t

  Upgrade this test verbosity in order to find out on which data source
  it fails on Jenkins.

8 years agoFix various failing tests on 3.20.x branch
Frédéric Demians [Tue, 29 Dec 2015 10:28:20 +0000 (11:28 +0100)]
Fix various failing tests on 3.20.x branch

- t/db_dependant/Contract.t
- t/db_dependent/Circulation_issue.t
- t/db_dependent/Holds.t
- t/Auth_with_shibboleth.t

8 years agoRevert "Bug 15171: Display subscriptions which will expire in the future"
Frédéric Demians [Tue, 29 Dec 2015 09:44:44 +0000 (10:44 +0100)]
Revert "Bug 15171: Display subscriptions which will expire in the future"

This reverts commit 7368075d1e3640396ed64a5ed342147a5d31fa22.

Fix test

8 years agoBug 15431: svc/checkouts dies due to undefined variable (13024 merge problem)
Tomas Cohen Arazi [Mon, 28 Dec 2015 13:57:41 +0000 (10:57 -0300)]
Bug 15431: svc/checkouts dies due to undefined variable (13024 merge problem)

When bug 13024 was merged into 3.20.x, a bug was introduced by replacing the
old way to fetch itemtype descriptions with the newer (3.22+).

To test:
- Perform a checkout on a patron
- Check so all checkouts are shown immediately
=> FAIL: It keeps loading forever. The logs show the svc/checkouts script died
- Apply the patch
- Reload page
=> SUCCESS: It loads the circ information correctly
- Sign off :-D

Regards

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
8 years agoFix Koha.pm 3.20.7 version number v3.20.07.1
Frédéric Demians [Sat, 26 Dec 2015 18:49:14 +0000 (19:49 +0100)]
Fix Koha.pm 3.20.7 version number

8 years agoTranslation updates for Koha 3.20 release v3.20.07
Bernardo Gonzalez Kriegel [Thu, 24 Dec 2015 14:51:53 +0000 (11:51 -0300)]
Translation updates for Koha 3.20 release

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoVersion 3.20.7
Frédéric Demians [Thu, 24 Dec 2015 15:19:47 +0000 (16:19 +0100)]
Version 3.20.7

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 13838 - Redirect to 'expired holds' tab after cancelling a hold
Kyle M Hall [Mon, 20 Apr 2015 19:31:11 +0000 (12:31 -0700)]
Bug 13838 - Redirect to 'expired holds' tab after cancelling a hold

When canceling a hold from the holds over tab, you are redirected back to the holds waiting tab. Instead, we should the librarian should continue to see the list of holds past the waiting length.

Test Plan:
1) Apply this patch
2) Cancel a hold from the "Holds over" tab on circ/waitingreserves.pl
3) Note you are redirected back to the holds over tab

Signed-off-by: Tom Misilo <misilot@fit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 353e30d73e261a96077917004036c2c01e32c623)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit fddc423c09f2ad1243731e94ee30e9885c9a1e44)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 15193 - Perl scripts missing exec permission
Fridolin Somers [Mon, 16 Nov 2015 12:07:07 +0000 (13:07 +0100)]
Bug 15193 - Perl scripts missing exec permission

Some perl scripts have 644 permissions instead of 755.

I think some are special like install-CPAN.pl.

This patch corrects some common perl scripts.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 3410608b66fe0dd6e4c94fdcc185c7fb89b619c1)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit bff51cb38c19678533ec11eddf68f5b9e0d74c30)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 14971: fix RIS export
Bernardo Gonzalez Kriegel [Thu, 3 Dec 2015 12:19:17 +0000 (09:19 -0300)]
Bug 14971: fix RIS export

This patch removes a limit in RIS.pm print_isbn sub.

To test:
1) Find in opac a book with an isbn with length(isbn) > 10
(with dashes or isbn13)
2) Export record to RIS format, check truncated SN field
in exported file
3) Apply the patch
4) Export again, no more truncation

Signed-off-by: jvr <jvr@fct.unl.pt>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 906d2108b9054a68168219136d69e6d783f156fb)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit f6d9e04b886c3d7d9378732f9cdc3eedffed8659)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 15202: Fix date display when transferring an order
Katrin Fischer [Sun, 22 Nov 2015 01:31:10 +0000 (02:31 +0100)]
Bug 15202: Fix date display when transferring an order

The date a basket was created was not displayed
according to the dateformat system preference.

Also fixes wording of the message shown when there
are no baskets for a chosen vendor.

To test:
- Create an order with an order line
- Click on the "Transfer" link on the basket
  summary page
- Search for a vendor without open baskets
- Verify change of message shown:
  "There are no open baskets for this vendor."
- Choose another vendor with open baskets
- Verify the creation date of the basket is
  displayed correctly formatted.

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit f4b8c4ede9c83b1b78eb87c7fb31214299cbf2f2)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit ccdc2288a6279aa3745ffa2040cc489c0b71f196)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 14846 - Items with no holdingbranch causes svc/holds to crash
Blou [Thu, 17 Sep 2015 15:33:38 +0000 (11:33 -0400)]
Bug 14846 - Items with no holdingbranch causes svc/holds to crash

When trying to display the holds for a user, if an item has no
holdingbranch, it causes the svc/holds service to crash and the display
to freeze.

Tentative steps to reproduce on any DB:
1) put 1 or more items on hold for a given user.
2) go into the database and set the item.holdingbranch to NULL
3) In the user's page, in checkouts (circulation.pl), click the tab that
   should be written 1 Hold(s)
4) It will be "Processing" indefinitely.

The cause is the svc/holds code that crashes.  The fix will validate
that there's an holdingbranch before proceding with the code.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit c6f7496422a593fdfe4dd2633aed4b190703d03d)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 6012bc8b9988bd4cc2b6fbeecb5de32171f193b6)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 15244: t/db_dependent/Reserves.t depends on external data/configuration
Marc Véron [Tue, 1 Dec 2015 19:22:27 +0000 (20:22 +0100)]
Bug 15244: t/db_dependent/Reserves.t depends on external data/configuration

Test 14 in t/db_dependent/Reserves.t fails if syspref LocalHoldsPriority is
set to "[Give] priority for filling holds to patrons whose...

To verify:
- Set syspref as above and run test. Test 14 fails.
- Set syspref to [Don't give] and run test agein, it passes OK.

To test:
- Apply patch
- Run test again with syspref set / not set
Expected result: In both cases test should pass

(AMended to change bug title)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit ae5962cab435fe5119cf743a2ea0b9e501985ff9)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit dfa650949d50c1c90a3950db9a7d2b6a265e3b76)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 15216: Returns - Show collection description
Katrin Fischer [Wed, 25 Nov 2015 23:29:34 +0000 (00:29 +0100)]
Bug 15216: Returns - Show collection description

The table of returns displays the collection code
instead of the description. This patch fixes that.

Same as first patch:

To test:
- Check out some items
- Return the items
- Verify the changes in the table of returned items

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit a102ccd48f72327d8d84d3782259b1417b75336b)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 552a9d066e722711b7049bf3b1864c7771a69719)

8 years agoBug 15216: Returns - Show branch names and item type description
Katrin Fischer [Sun, 22 Nov 2015 01:23:11 +0000 (02:23 +0100)]
Bug 15216: Returns - Show branch names and item type description

Changes the table with returned items to display the branch
names for home and holding branch and the itemtype description
instead of the codes.

To test:
- Check out some items
- Return the items
- Verify the changes in the table of returned items

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 84a0f1acf6ef052cc83eb4c0f6c07127b4cfaae2)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit efeeffb0645ffd7c2b84629618ad0c60882e8517)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 11038: Enable use of IntranetUserCSS on staff client login page
Bernardo Gonzalez Kriegel [Sat, 28 Nov 2015 14:33:37 +0000 (11:33 -0300)]
Bug 11038: Enable use of IntranetUserCSS on staff client login page

This patch enable use of IntranetUserCss on staff client
login page.

To test:
1) Add something to IntranetUserCSS to modify login page,
for example

 #login h1 a {
   height:30px;
 }

2) Logout from staff client, no changes on login page.
3) Apply the patch
4) Reload, now logo is cut in half :)
Bonus) Login again an try changing image, add

 #login h1 {
  background: url(http://example.com/img/other-logo.png) no-repeat top center;
 }

and fix height. Logout and check

This also affects 3.20 and perhaps earlier versions.
Re-upload to fix examples

Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 11e4c42e05090a25bf9fa03275f708d1f1c4fde7)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 14dc51472a88796f7bf5579e50174d691e74a28a)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
  Merging issue due to intranetusejs syspref renaming. Fixed.

8 years agoBug 9184: Acq - Don't show authority batches when ordering from staged file
Katrin Fischer [Sun, 22 Nov 2015 00:18:04 +0000 (01:18 +0100)]
Bug 9184: Acq - Don't show authority batches when ordering from staged file

When ordering from a staged file, the list of files
should only include imports of bilbiographic and
no authority data.

To test - start without the patch:
1) Stage an authority file
2) Stage a bilbiographic file
3) Create a new basked in acquisitions
4) Create a new order line selecting "From a staged file"
5) Verify that both files are shown
6) Apply patch
7) Verify that only the bibliographc file shows
   in the list now

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 169015af947e52895e784375c4c654c110c7f1a9)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 0fba468262928dddb08d8e49e3e1cff8cb1ff557)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 14599 - Saved auth login and password are used in patron creation from
Fridolin Somers [Mon, 23 Nov 2015 08:19:06 +0000 (09:19 +0100)]
Bug 14599 - Saved auth login and password are used in patron creation from

If one save the login and password used to authenticate in staff interface,
when creating a new patron, those login and password are filled in the
corresponding inputs in the form.  This behaviour is awkward from web browser.

A trick is provided by
http://stackoverflow.com/questions/10738090/why-firefox-autocomplete-even-with-different-input-name

I found that the best way is to use an hidden disabled input between userid and
password.

Test plan :

- Log into Koha
- Allow the browser to save the userid/password
- Be sure that you have only one userid/password for this Koha
- Loggout
- Re log to check the browser autocomplets the authentication form
- Create a new patron
=> Without patch your saved userid/password have been added to the form
=> With patch your saved userid/password have not been added to the form

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This is not elegant but it works.
Note that the problem does not exist with Chromium

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit f4870f6666127f0f0b2c49cc4f89cadd0241a8b9)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 3f9d68e599f7e5915f8982fd199030c32c3d8cf3)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 14349: Checkouts and Fines tab missing category description on the left
Katrin Fischer [Sun, 22 Nov 2015 02:25:58 +0000 (03:25 +0100)]
Bug 14349: Checkouts and Fines tab missing category description on the left

When navigating the tabs in the patron account, for 2 tabs the
patron category description is missing above the tabs.

To test:
- Go to a patron account in staff
- Click through the tabs
- Verify that for Checkouts and Fines the category description
  is missing above the tabs
- Apply patch
- Verify the description is now shown

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 9e518de90f3baafc5d44eefd423e3ee2a491c60d)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit df1a9a98fd6f3186a05f9eeead63de1e2b3c39ff)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 15290: (follow-up)SQL reports headers encoding problem
Hector Castro [Thu, 3 Dec 2015 19:20:40 +0000 (13:20 -0600)]
Bug 15290: (follow-up)SQL reports headers encoding problem

Fix SQL row data and headers enconding problem

To test:
-Apply patches
-Follow previous test plan
-Notice the headers and row data is displayed in UTF-8
 without double encoding
-Save in Comma separated text, Tab seprated text, and Open Document.
-Verify in the three options the file exported is Ok

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 4f6bcc5cc9c3fff9e009277f20790b6005be005c)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 8cc6e1170a167ac11530f0376d616969f412de57)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 15290: SQL reports headers encoding problem
Tomas Cohen Arazi [Thu, 3 Dec 2015 14:23:54 +0000 (11:23 -0300)]
Bug 15290: SQL reports headers encoding problem

To test:

- Create an SQL report with column names containing UTF characters
- Run the report
=> FAIL: The column names are double encoded
- Export the report
=> FAIL: The column names are double encoded in the exported file
- Apply the patch
- Re-run the report (reload works)
=> SUCCESS: Encoding correct
- Export the report
=> SUCCESS: Encoding correct
- Sign off :-D

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 879b1386ff3a274d0884dc0b48afa6064c35eed7)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 333593c011cfe83501516ecf719808b8408b846e)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 12152: Holds to pull report - Display location descriptions
Jonathan Druart [Wed, 25 Nov 2015 16:40:37 +0000 (16:40 +0000)]
Bug 12152: Holds to pull report - Display location descriptions

...instead of their code

Test plan:
Same as before, confirm the the location codes are replaced with their
descriptions.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit a901ed155a56a2c4ab95bb7bc951e2a0a7d04277)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 0ee6451023ca0c973052bcf685e9ab329a390927)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 12152: Holds to pull report - Show branch names and item type descriptions
Katrin Fischer [Sun, 22 Nov 2015 02:38:30 +0000 (03:38 +0100)]
Bug 12152: Holds to pull report - Show branch names and item type descriptions

The 'Holds to pull' report shows branch and itemtype codes without
this patch. With the patch, names and descriptions should display.

To test:
- Make sure there are some holds for available items in your system
- Go to Circulation > Holds to pull
- Verify changes mentioned above in the list of holds shown

Signed-off-by: David Cook <dcook@prosentient.com.au>
Works as described, although as Magnus mentioned, Locations
still use codes instead of descriptions.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 0f7f6a5cb32cd2e68bc39e8464147852347be310)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 773d7e2d1faa449ea1bd6f28d2422a195388686e)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBUG 11602: [ENH] Fix localcover display
Nicholas van Oudtshoorn [Thu, 15 May 2014 05:27:48 +0000 (13:27 +0800)]
BUG 11602: [ENH] Fix localcover display

Adds a css class of thumbnail to local covers.
Don't show the 1px "No image found" image
(since we'll ususally try another image provider)

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Box with "No cover image availabe" fixed when syspref OPACLocalCoverImages
set to display

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(cherry picked from commit a06793dc584212dde20f985740691b7e49074c76)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 24ba596672f6537db8fcb5b54bf5017bd6d41a6e)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 13024 [QA Followup] - Add nonpublic note to relatives' checkouts
Kyle M Hall [Tue, 1 Dec 2015 17:49:55 +0000 (17:49 +0000)]
Bug 13024 [QA Followup] - Add nonpublic note to relatives' checkouts

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit fc050984699e6831fdb354c77d065a08567beb9f)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 13c4a8e77a0a798fb63edded881d56fdafc874f1)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 13024 - Nonpublic note not appearing in the staff client
Kyle M Hall [Fri, 24 Apr 2015 14:41:58 +0000 (10:41 -0400)]
Bug 13024 - Nonpublic note not appearing in the staff client

The nonpublic note for items is not displayed in the staff client. It
should be displayed in the following areas:
1) Checkouts (circulation.pl)
2) Checkins (returns.pl)
3) Record details ( moredetail.pl )

Test Plan:
1) Ensure your non-public note field is mapped to the
   items.itemnotes_nonpublic database column
2) Edit an item, add a test nonpublic note
3) Check out the item, verify the note is visible in the checkouts table
4) Check in the item, verify the note is visible in the checkins table
5) View the item details, verify the note is visible and editable
   if your account has the rights to edit items

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 717878982f985b9f40f9eedec5e576efd62976ff)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit a5b993672fc2b87a51d4944616e5f303992d4f3f)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 15250: Fix Perl error on acqisition stats page
Katrin Fischer [Wed, 25 Nov 2015 17:18:04 +0000 (18:18 +0100)]
Bug 15250: Fix Perl error on acqisition stats page

To test:
- Go to reports -> Acquisitions statistics
- Populate with the following values:

   Acquisitions statistics
      Received on.
         Row:    checked
         Column: checked
         From:   01/01/2015
         To:     Un-selected

    Cell value
       Count items

    Output: To screen into the browser: checked

- Running the report will trigger the following error:

   Software error:
   Can't locate object method "field" via package "aqorders.datereceived" (perhaps you forgot to load "aqorders.datereceived"?) at /usr/share/koha/intranet/cgi-bin/reports/acquisitions_stats.pl line 293.

- Apply the patch and repeat test
- Verify the report now works correctly

Note: Patch was created from notes and suggested
      fix on the bug report, written by Barton Chittenden.

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit d9cef35b75770104494c2f4a01d975f367b515bf)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit cd693a52b8306f1bdc66804fb84fe17cadcd658f)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 15256: Fix items table display on the detail page
Jonathan Druart [Wed, 25 Nov 2015 17:08:43 +0000 (17:08 +0000)]
Bug 15256: Fix items table display on the detail page

Bug 14966 fixed a bug but introduced another one: With
IndependentBranches set to 'prevent', if the librarian (without the
superlibrarian permission) can edit items but not all, the table is
broken.  DataTables raises the following warning: "DataTables warning:
table id=DataTables_Table_1 - Requested unknown parameter '8' for row0."
And does not display correctly.

Test plan:
1/ Create a biblio record with 1+ items located in different places.
2/ Create/use a patron with the permission to edit items
3/ Set the IndependentBranches pref to 'prevent'
4/ With this patron logged in, go on the record detail page.
Without this patch, the display is broken (only 1 edit link and 1 td
missing, DataTables raises a warning).
With this patch, the display is correct.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
  See the warning, and the broken table. Solved by this patch.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit d456acc7bfd2507ac7eaaf32bd6da1f023655886)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit ed13f4fe200352460b62376b01ba48d3ba51ae80)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 15270: Add regression tests for Koha::Objects->find
Jonathan Druart [Tue, 1 Dec 2015 10:17:11 +0000 (10:17 +0000)]
Bug 15270: Add regression tests for Koha::Objects->find

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 15270: Make Koha::Objects->find return undef instead of crashing
Jonathan Druart [Tue, 1 Dec 2015 10:16:43 +0000 (10:16 +0000)]
Bug 15270: Make Koha::Objects->find return undef instead of crashing

On 3.20.05, if AnonymousPatron is set to a nonexistent borrowernumber, the about.pl crashes with

  DBIC result type  isn't of the type Borrower at /home/koha/src/Koha/Objects.pm line 87.

This was fixed on master by
  commit 6882949b1b3bd1284e3d2877244a64edee3883ca
  Date:   Wed Apr 8 06:38:34 2015 -0400
      Bug 13967 - System preferences need a package

Test plan:
Set the AnonymousPatron pref to a nonexistent borrowernumber
Go on about.pl
Without this patch, you get the error.

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Set AnonymousPatron pref to a nonexistent borrowernumber. Before the
patch, about.pl shows a nasty error. After applying the patch the
error is gone. Tests in t/db_dependent/Objects.t pass.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoRevert "Bug 11190: sitemap.pl -- Generate a Catalog sitemap"
Frédéric Demians [Sat, 5 Dec 2015 07:31:59 +0000 (08:31 +0100)]
Revert "Bug 11190: sitemap.pl -- Generate a Catalog sitemap"

This reverts commit ed166abbf3e4e0510d6fd14f9843b7fad1a5b686.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoRevert "Bug 11190: sitemap.pl -- Generate a Catalog sitemap"
Frédéric Demians [Sat, 5 Dec 2015 07:29:57 +0000 (08:29 +0100)]
Revert "Bug 11190: sitemap.pl -- Generate a Catalog sitemap"

This reverts commit e0a8173d10cc0f307dd95118e294c727c285e142.

This feature introduces new dependencies, and make UT failing without them,
which prevents package building.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agonew Debian package maintainer
Galen Charlton [Sat, 5 Dec 2015 01:26:11 +0000 (01:26 +0000)]
new Debian package maintainer

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
8 years agoBug 5371: (follow-up) Force no caching for private pages at the OPAC
Jonathan Druart [Thu, 1 Oct 2015 10:58:41 +0000 (11:58 +0100)]
Bug 5371: (follow-up) Force no caching for private pages at the OPAC

Same as previous patch for opac-messaging.pl and opac-readingrecord.pl

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
(cherry picked from commit a988e9425ce1f8f4bf28b46473adac941d634973)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 5371: Force no caching for private pages at the OPAC
Jonathan Druart [Thu, 17 Sep 2015 11:45:15 +0000 (12:45 +0100)]
Bug 5371: Force no caching for private pages at the OPAC

In order no to slow too much the browsing, it is certainly not a good
idea to add this cache-control value for all pages at the OPAC.

This patch just adds where the author found it could be useful.

Test plan:
1/ Login at the OPAC
2/ Go on the account page (opac/opac-account.pl)
3/ Click log out
4/ Use the back button of your browser
Without this patch you will see the previous page.
With this patch, the previous page will be reloaded and you will be
redirected to the login form.

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
(cherry picked from commit 542ab0bce949eba3abc98ff1c433fe6099db105d)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 14978: (RM followup) DBIx update
Tomas Cohen Arazi [Wed, 4 Nov 2015 15:09:06 +0000 (12:09 -0300)]
Bug 14978: (RM followup) DBIx update

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 3cab4d1efd25268441c88ce74d5a4b568773c8aa)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 14978: DBRev 3.20.06.001
Frédéric Demians [Wed, 2 Dec 2015 07:32:45 +0000 (08:32 +0100)]
Bug 14978: DBRev 3.20.06.001

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 14978: Add unique key constraint on issues.itemnumber
Jonathan Druart [Thu, 8 Oct 2015 08:15:57 +0000 (09:15 +0100)]
Bug 14978: Add unique key constraint on issues.itemnumber

The constraint might have existed before bug 14069.
For these DB, this patch will restore it, for others, it will add it :)

Test plan:
> show create table issues;
should not return "unique key itemnumber"
Execute the updatedb entry twice
> show create table issues;
should return only one "unique key itemnumber"

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 9e1d8d8c5e357a56f88c78eca52ccbb37902d43c)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoKoha release 3.20.6 v3.20.06
Frédéric Demians [Mon, 30 Nov 2015 18:13:45 +0000 (19:13 +0100)]
Koha release 3.20.6

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoTranslation updates for Koha 3.20.6 release
Bernardo Gonzalez Kriegel [Mon, 30 Nov 2015 11:47:29 +0000 (08:47 -0300)]
Translation updates for Koha 3.20.6 release

New languages: Malayalam and Occitan

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 11190: sitemap.pl -- Generate a Catalog sitemap
Frédéric Demians [Sun, 3 Nov 2013 16:05:38 +0000 (17:05 +0100)]
Bug 11190: sitemap.pl -- Generate a Catalog sitemap

Add a script sitemap.pl to process all biblio records from a Koha
instance and generate Sitemap files complying with this protocol as
described on http://sitemaps.org. The goal of this script is to be able
to provide to search engines direct access to biblio records. It avoid
leaving search engine browsing Koha OPAC and so generating a lot of
traffic, and workload, for a bad result.

Thanks Magnus for testing, and helping to improve the script design.

[2015.04.16] Switch from Moose to Moo.

[2015.08.20] Add complete (more) UT.

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
All options to the script work as expected and the output looks
good. Nice enhancement!

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
I signed-of my own patch after fixing various QA errors.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Amended patch: replace tabs with spaces.
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit ca341f6840ad7eb9170ce49f1ed6869b3e468297)

8 years agoBug 11190: sitemap.pl -- Generate a Catalog sitemap
Frédéric Demians [Sun, 3 Nov 2013 16:05:38 +0000 (17:05 +0100)]
Bug 11190: sitemap.pl -- Generate a Catalog sitemap

Add a script sitemap.pl to process all biblio records from a Koha
instance and generate Sitemap files complying with this protocol as
described on http://sitemaps.org. The goal of this script is to be able
to provide to search engines direct access to biblio records. It avoid
leaving search engine browsing Koha OPAC and so generating a lot of
traffic, and workload, for a bad result.

Thanks Magnus for testing, and helping to improve the script design.

[2015.04.16] Switch from Moose to Moo.

[2015.08.20] Add complete (more) UT.

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
All options to the script work as expected and the output looks
good. Nice enhancement!

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
I signed-of my own patch after fixing various QA errors.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Amended patch: replace tabs with spaces.
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit ca341f6840ad7eb9170ce49f1ed6869b3e468297)

8 years agoBug 15198: Change wording of OpacSuppression system preference
David Cook [Tue, 17 Nov 2015 06:18:05 +0000 (17:18 +1100)]
Bug 15198: Change wording of OpacSuppression system preference

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Paragraph rewording successfully

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 30a0365e915cce4e9b08bde790db69ef6d8ce9bd)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 15198: Make OpacSuppression work even if there are no records suppressed
David Cook [Tue, 17 Nov 2015 02:03:59 +0000 (13:03 +1100)]
Bug 15198: Make OpacSuppression work even if there are no records suppressed

This patch adds the Zebra special attribute 14 to ccl.properties and
opac-search.pl, so that we can turn on OpacSuppression and still return
results even if there are no records in Zebra for the Suppress index.

_TEST PLAN_

Before applying:

1) Make sure that you have no suppressed records indexed in Zebra
2) Turn on OpacSuppression system preference

3) Search using a keyword which should bring up records
4) Note that no records are returned in the results
5) Change UseQueryParser system preference to "Try"
6) Repeat steps 3-4

Apply the patch.

After applying:

7) Repeat step 3 (ie search using a keyword which should bring up records)
8) Confirm that records are appearing in the results!
9) Change UseQueryParser system preference to "Do not try"
10) Repeat step 3
11) Confirm that records are appearing in the results!

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised. No more, won't need to have at least one record with the
value "1" in the field mapped with this index. All records in OPAC returned.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit dd9a4ed6c6fbc078d43880e4adf8cfe28179888d)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 14264: Fix export of late orders when translated
Jonathan Druart [Sun, 24 May 2015 15:52:25 +0000 (17:52 +0200)]
Bug 14264: Fix export of late orders when translated

Bug 7298 tried to fix this issue, but it was not correct.
We have 3 files in acqui/csv:
basketgroup.tt, basket.tt and lateorders.tt
The first 2 don't contain translatable string, and are not modified on
translating the templates (`translate install`)
On the contrary, lateorders.tt has some strings to translate ('Author:',
'Published by:', etc.). After being translated, all carriage returns
between TT tags are removed.

Test plan:
1/ choose a language and update + translate the templates
for instance:
  cd misc/translate;
  ./translate update es-ES; ./translate install es-ES
2/ Go to acqui/lateorders.pl using this language
3/ Generate a csv for 1+ late orders and confirm the first line only
contains the headers.

Signed-off-by: Laurence Lefaucheur <laurence.lefaucheur@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit b2706884a1916827229ad6f818790ec47a43cbf5)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 15215: Remove warning due to misuse of UNIVERSAL
Colin Campbell [Thu, 19 Nov 2015 12:15:34 +0000 (12:15 +0000)]
Bug 15215: Remove warning due to misuse of UNIVERSAL

Calling UNIVERSAL's internal methods will cause a depreciation
warning in perls less that 5.22 as of 5.22 the warning is a fatal
error causing compilation to abort

Replace the use UNIVERSAL with UNIVERSAL::can to work around the
buggy construct perldoc UNIVERSAL::can for more info

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
No more worning/error
No qa errors

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit d69b6c048077fc028941870d1912b325076800c1)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 4502: Changing wording again...
Jonathan Druart [Tue, 22 Sep 2015 11:11:34 +0000 (12:11 +0100)]
Bug 4502: Changing wording again...

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Just a string patch, others are signed.
No errors

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 379329861d19b178f14d360d9fee2518a462d8a7)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 4502: An attempt to make things more sensible.
Mark Tompsett [Mon, 6 Apr 2015 23:50:30 +0000 (19:50 -0400)]
Bug 4502: An attempt to make things more sensible.

The reason the budget_period_id was not defined was because in
two cases it was not passed! This patch adds those missing
parameters. And as a result, cuts out the attempt to default the
authcat to '' unless the budget_period_id is defined.

Additionally, the start and end months don't seem to be passed,
so rather than have it blow up, checking them forces the else
case logic.

budget_period_id is the budget id. If you have two budgets,
you can craft a URL to work with budget_period_id matching
those two ids. Anything else should trigger the new error which
was modified to reflect more of what the problem is.

Follow the test plan in comment #6. Feel free to also to attempt
crafting URLs and triggering errors.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Well, works and does not explode any more
No errors

To trigger the new message simply put /cgi-bin/koha/admin/aqplan.pl
on your staff page, an intriguing 'Planning for by Asort1' appears :)

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit fea7b9b4d444a6bdf3f1326c54eddd68670be7f7)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 4502: Catch software error if no active budget defined
Jonathan Druart [Tue, 24 Mar 2015 14:54:37 +0000 (15:54 +0100)]
Bug 4502: Catch software error if no active budget defined

TEST PLAN
---------
0) Back up your database.
1) In mysql client:
   > DROP DATABASE {your koha database name};
   > CREATE DATABASE {your koha database name};
   > QUIT;
2) Go to the staff client, and install all the default
   and optional things -- except patrons. :)
3) Log into staff client.
4) Create a patron -> New Patron -> Staff
5) Enter data and Save
6) More -> Set Permissions
7) Make superlibrarian
8) Log out
9) Log in as new superlibrarian
10) Acquisitions -> Budgets -> New Budget
11) Enter a non-active budget with some funds.
    -- Once saved, it should list in the inactive budgets.
12) Click on the name.
13) Click on one of the Planning submenu options.
14) Click the 'Submit' button in the Filter area.
    -- This should trigger the blow up.
15) Apply the patch
16) Repeat steps 12-15
    -- The kaboom is avoided and a nice message given.

NOTE: This does not solve all the problems in this ugly, ugly
      module area. It does solve the one thing it is meant to:
      that nasty kaboom.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 0a391237710aec779b000c3dff219e54b22fb76a)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 15047: 655 URL not clickable in opac-detail.
Winona Salesky [Thu, 22 Oct 2015 13:22:47 +0000 (09:22 -0400)]
Bug 15047: 655 URL not clickable in opac-detail.

Test Plan:

1) Apply this patch
2) Ensure you are using the default XSLT setting for the staff and opac  record details
3) Find or create a record with MARC tags 655
4) Perform an opac search and select records with 655 field, select record and review details page.
5) Check that 655 field is clickable.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised. 655 field clickable

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit bcec2166a4777aa9f3c406da9a2d133814fd7c58)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 13411: (QA followup) Add logging
Kyle M Hall [Mon, 2 Mar 2015 14:06:58 +0000 (06:06 -0800)]
Bug 13411: (QA followup) Add logging

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit feafa273e443e56021959153e91bd999a68daf29)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 13411: Koha's SIP server returns not ok for checking in items that are not checke...
Kyle M Hall [Thu, 27 Aug 2015 14:56:22 +0000 (10:56 -0400)]
Bug 13411: Koha's SIP server returns not ok for checking in items that are not checked out

If an item is not checked out when a checkin via SIP2 is attempted,
Koha's SIP server sends back an "ok" of 0, and the AF message "Item
not checked out". I am not entirely sure this is good and correct
behavior by the SIP2 protocol.

In particular, this will cause SIP2 book sorting devices to fail on
all items that are not checked out, causing them all to be put into
the "special handling" been that should be reserved for things like
items checked in at the wrong library and items on hold.

Test Plan:
1) Apply the patch for bug 13159 so you can use the new enhanced
   SIP2 command line emulator
2) Use a command similar to the following to check in an item:
   sip_cli_emulator.pl -a localhost -su <sip user> -sp <sip password> -l <instituation id> --item <barcode> -m checkin
3) Note the 3rd character is 0, and there is an AF field saying the item is not checked out
4) Apply this patch
5) Restart the SIP server
6) Repeat steps 2-3, note that nothing has changed
7) In the SIP config file, Add the parameter checked_in_ok="1" to the SIP account you are using.
8) Restart the SIP server
9) Repeat steps 2-3, note that this time the 3rd character is 1, and you do not recieve the item not checked out message.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 181d3aa56de8377c67247db26932c4e5a7cb83d9)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 15175: Respect IntranetBiblioDefaultView syspref
Frédéric Demians [Wed, 11 Nov 2015 17:59:35 +0000 (18:59 +0100)]
Bug 15175: Respect IntranetBiblioDefaultView syspref

Respect IntranetBiblioDefaultView on intra search result page, on cover image
link, when XSLTResultsDisplay is empty.

TO TEST:

1. Empty XSLTResultsDisplay
2. Activate intranet local and Amazon cover images
3. Play changing IntranetBiblioDefault, and observe the links respectively on
   biblio record title and cover image. Title's link is OK, cover image
   link goes to detail.pl page independently of IntranetBiblioDefault.
4. Apply the patch.
5. Repeat 3.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Link to right display according with IntranetBiblioDefaultView is fixed.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
http://bugs.koha-community.org/show_bug.cgi?id=14175
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 0fe08231f427bdc65b1ff1219ad7507c284f1dbd)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 15171: Display subscriptions which will expire in the future
Jonathan Druart [Wed, 11 Nov 2015 09:36:16 +0000 (09:36 +0000)]
Bug 15171: Display subscriptions which will expire in the future

Since the form on the subscription check expiration page let the user choose an
expiration date > today, there is no sense to hide subscriptions which will expire in the future.

Test plan:
0/ Make sure you have at least subscription with an expiration date > today
1/ Start a seach on the check expiration page (serials/checkexpiration.pl)
with a date < today, = today and > today
=> The subscription won't never be displayed without this patch.
With this patch, it will.

Note that you will get a "No results for your query" message only if you
have search for something.

Followed testplan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 78c1b0198841d832f8aca2c1a8e7d8baffe8a08c)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 15114: Fix typo in opac-suggestion template
Jonathan Druart [Fri, 13 Nov 2015 15:45:04 +0000 (15:45 +0000)]
Bug 15114: Fix typo in opac-suggestion template

There is a $ in front of the loggedinusername variable, which is
obviously not what is expected here.

It fixes the wrong warning message "You are not authorized to see
pending purchase suggestions." when it should be "There are no pending
purchase suggestions."

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 621f2ce9ac960d93466c9da5b4c6559e71519e3d)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 15189: Do not close STDERR when running in background mode
Jonathan Druart [Fri, 13 Nov 2015 16:22:03 +0000 (16:22 +0000)]
Bug 15189: Do not close STDERR when running in background mode

The batch records modification tool close STDERR, it's useless and hide
warnings/errors.

Like the other processes using the BackgroundJob module, this one should
let it open.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 7be97133eeb350fa65fea667a149d000bf348ecc)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 15109: Make name the default sort order for all patron searches
Jonathan Druart [Fri, 13 Nov 2015 09:18:43 +0000 (09:18 +0000)]
Bug 15109: Make name the default sort order for all patron searches

Find another place where there is a patron search (add user to a basket,
add users to a fund or edit owner of a fund, set a guarantor to a child,
etc.).
Do a search a confirm that the results are now sorted by name instead of
cardnumber.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit defcfd050ebb0a4b6734274f7710f23944abf852)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 15109 - Regression in patron search results ordering
Jonathan Druart [Fri, 13 Nov 2015 09:17:49 +0000 (09:17 +0000)]
Bug 15109 - Regression in patron search results ordering

In Koha 3.16 or earlier, before the introduction of the ajax datatable
for patron searching, the search results were ordered by name. In
master, the results are currently ordered by cardnumber, which is not
very useful.

Test Plan:
1) Do a "browse by last name" or a patron search
2) Note the results are sorted by card number
3) Apply this patch
4) Reload the page, start a new search
5) Note the results are sorted by name

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit cc65a5fed2afd27b2a45af49d6fe08d54fef7de9)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 15182: Conditionally load Koha::NorwegianPatronDB
David Cook [Tue, 17 Nov 2015 01:36:16 +0000 (12:36 +1100)]
Bug 15182: Conditionally load Koha::NorwegianPatronDB

This patch loads Koha::NorwegianPatronDB if it can, or adds a warning
to the log if it can't load it.

Since the Koha::NorwegianPatronDB functionality in C4::Members is
wrapped in system preferences, the loading of the module is
irrelevant unless one actually wants to use the module and its
associated functionality.

NOTE:

This patch fixes a problem where we were getting errors saying
Crypt::GCrypt couldn't be loaded even though it's not a required
dependency.

This patch will likely only affect people not using Debian-based
systems where libcrypt-gcrypt-perl is available. The current
version of Crypt::GCrypt doesn't build so it's not an option
for most non-Debian users to install this not required
dependency in order to work around this issue...

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised for Debian-based systems

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 1801a9462e190231f3303b01247b834f6e1d99bd)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 15133: encode correctly email generated by runreport.pl
Frédéric Demians [Thu, 5 Nov 2015 07:45:25 +0000 (08:45 +0100)]
Bug 15133: encode correctly email generated by runreport.pl

/misc/cronjobs/runreport.pl send badly encoded email in text/csv
(partially ok in HTML).

TEST:

1. Send by email a report containing a subject with accented characters
   and resultset with accented characters. For example:

   ./runreport.pl --subject="éèà" --to=me@home.org  1
   ./runreport.pl --format=html --subject="éèà" --to=me@home.org  1

   The first email contains badly encoded subject & message. The second email
   contains badly encoded subject, but correct message.

2. Apply the patch

3. Repeat 1 => No more strange characters.

Signed-off-by: Liz Rea <liz@catalyst.net.nz>
Characters are correctly encoded now, thanks for that good spot.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 9515db57bdd13cdff33d9056963455fb850ad877)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 15120: runreport.pl cronjob doesn't allow custom subjects anymore
Liz Rea [Wed, 4 Nov 2015 02:33:40 +0000 (15:33 +1300)]
Bug 15120: runreport.pl cronjob doesn't allow custom subjects anymore

To test, well do something like

misc/cronjobs/runreport.pl --subject="My fancy subject!" --to=you@youraddress.com 1
where 1 is the number of your favourite saved report.

Success is your email arrives with the subject "My fancy subject!" Failure is
(with --subject defined) you get either the description of the report, or "Koha
saved report" as the subject. This is success without --subject defined.

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
  Bug repeatable and fixed by this patch.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 4f8476e09c2de223f73692521b8f8e533ef8400f)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 14542: Transliterate rule for all single quote forms
Fridolin Somers [Thu, 16 Jul 2015 15:48:14 +0000 (17:48 +0200)]
Bug 14542: Transliterate rule for all single quote forms

Single quotes in common language (not in programming) are usually ', but
there is also the form known as &rsquo; in HTML.  See
https://fr.wikipedia.org/wiki/Apostrophe_%28typographie%29

This bug proposes to transliterate all forms into a space.

Test plan :
(I'll use the code &rsquo; instead of the unicode character)
- Without the patch
- Create a record with title : L&rsquo;avion d&rsquo;argile
- Index this record
- Search for "L&rsquo;avion d&rsquo;argile" => You find the record
- Search for "L'avion d'argile" => You do not find the record
- Apply patch
- Search for "L&rsquo;avion d&rsquo;argile" => You find the record
- Search for "L'avion d'argile" => You find the record
- Search for "L avion d argile" => You find the record

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit b11eb03a4c9674f4f4dedadaa8790257e30fb1d0)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 14078: (followup) converting from ISO5426 is not complete
Fridolin Somers [Wed, 29 Apr 2015 10:35:00 +0000 (12:35 +0200)]
Bug 14078: (followup) converting from ISO5426 is not complete

Conversion of MARC from ISO5426 is defined in C4::Charset::char_decode5426().
Each character or combined characters conversion is defined in a map.

This patch adds missing conversions.

See http://www.gymel.com/charsets/MAB2.html

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 636050f9be374fc15acad8b047c1ae227d38b225)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 14078: converting from ISO5426 is not complete
Fridolin Somers [Wed, 29 Apr 2015 10:24:23 +0000 (12:24 +0200)]
Bug 14078: converting from ISO5426 is not complete

Conversion of MARC from ISO5426 is defined in C4::Charset::char_decode5426().
Each character or combined characters conversion is defined in a map.

This patch changes some odd actual conversions.

In char_decode5426(), only characters between 0xC0 and 0xDF will be used for combining with following charater :
  ($char >= 0xC0 && $char <= 0xDF)
So conversion like "$chars{0x81d1}=0x00b0" will never be used.
Rules for "h with breve below" use combining with 0xf9 but looks like the correct caracter is 0xd5.

See http://www.gymel.com/charsets/MAB2.html

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 5e3882bcecede59f24a6b3c4aa9c4324390a29c3)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 15154: Allow correct translation for upload local cover image
Hector Castro [Sat, 7 Nov 2015 06:16:02 +0000 (00:16 -0600)]
Bug 15154: Allow correct translation for upload local cover image

To test:
-Set syspref LocalCoverImages and OPACLocalCoverImages to Allow
-A new tab 'Images' appear in bib record detail on Intranet.
-Notice about the phrase "Please upload one"
-Apply the patch and reload the page.
-New phrase appear "Select the image file to upload" with button Upload
-Update translation files : cd misc/translator; perl translate update es-ES
-You will see in es-ES-staff-prog.po the new entry
"Select the image file to upload. %sUpload%s"
-You can see the result installing the translation
cd misc/translator ; perl translate install es-ES

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
  A native English speaker could confirm that the wording is ok: Please select
  the image file to upload

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit dfa757af927aaa5b80a4dd8c90210d12531cfcd7)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 15137: Display ISBN and author info when sending list by email
Jonathan Druart [Fri, 13 Nov 2015 15:18:56 +0000 (15:18 +0000)]
Bug 15137: Display ISBN and author info when sending list by email

Disclaimer: this is not caused by bug 14544 :)
And can be backported!

Both isbn and author information are missing when a list is sent by
email.
Emails sent from OPAC and staff should be (almost) the same.

Test plan:
1/ Sent a list by email (Button "Send list")
2/ The email you will receive should contain the isbn and author info

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
On top of last patch of Bug 14544
Works ok, mail with authors and ISBN
No errors

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit eb286ebbc3c594e8e81e1e8b1848ca1d52b8bccb)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 6657: Prevent biblionumber to be duplicated
Jonathan Druart [Thu, 17 Sep 2015 13:31:55 +0000 (14:31 +0100)]
Bug 6657: Prevent biblionumber to be duplicated

If the biblionumber field is displayed in the framework, on editing a
biblio the field/subfield will be duplicated.
To prevent that this patch adds a check when building the field list.

Test plan:
1/ map biblio.biblionumber with 999$c
2/ Display 999$c in a framework
3/ Edit a biblio using this framework
4/ Save => The field should not have been duplicated

5/ map biblio.biblionumber with 001
6/ Display 001 in a framework
7/ Edit a biblio using this framework
8/ Save => The field should not have been duplicated

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Works as described, aldo removes duplicate values.
No errors

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 9ae556a21243ecae669bda2c5f42a67769ae9d78)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 14795: Prevent modifying a record without using the original framework
Jonathan Druart [Fri, 13 Nov 2015 16:30:32 +0000 (16:30 +0000)]
Bug 14795: Prevent modifying a record without using the original framework

The origin framework is not passed on modifying the records and so the
default one is used.
This can caused data lost.

Test plan:
- Create a bibliographic record and specify a framework (not the default
one).
- Use the Batch records modification tools to modify it.
=> Without this patch, the default framework (framework code "") is used
and can deteriorate the record
=> With this patch, the record is saved using the original framework

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Tested framework is lost using tool without patch
Problem gone with patch
No qa errors

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit c1aeaf62b9c08d35449aa9822504de8ce79fec62)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 15079: Batch Delete Records Error
Kyle M Hall [Thu, 29 Oct 2015 11:48:02 +0000 (07:48 -0400)]
Bug 15079: Batch Delete Records Error

When using the batch deletion tool, if the script attempts to delete an
undeletable item, the script will die with the error:

Label not found for "next BIBLIONUMBER" at
/usr/share/koha/intranet/cgi-bin/tools/batch_delete_records.pl line 172.

Test Plan:
1) Attempt to batch delete a record with an item that cannot be deleted
2) Note error
3) Apply this patch
4) Repeat step 1
5) Note the error no longer occurs

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised. Follow comment 5 to reproduce the issue

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
I have not tested this patch, but looking at the code it is obviously a mistake.
If an error occured, we rollback and skip this record.
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 706a31b50d52ef1ba48c568d7e60c376cfe87983)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 14553: Silencing warn triggered when clearing item rating on OPAC
Aleisha [Tue, 21 Jul 2015 18:38:58 +0000 (18:38 +0000)]
Bug 14553: Silencing warn triggered when clearing item rating on OPAC

To test:

1) Go to any item and clear the star rating (don't have to set a rating first)
2) Notice the warn
3) Apply patch and reload page
4) Clear star rating
5) Notice no warn
6) Click a star to add a rating
7) Make sure your rating, the average rating and amount of votes are all
   correct
8) Could be beneficial to log in as another user and try to add a rating on the
   same item from their account. Check the average rating is
   cacalculated and amount of votes increases
9) Confirm still no warns

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
  Can see the warning in logs, and its disappearance with this patch.
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 94c5f8d5f06b588da0903c9607349adbf16344be)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 14735: Save cache_expiry on modifying a report
Jonathan Druart [Tue, 10 Nov 2015 15:17:12 +0000 (15:17 +0000)]
Bug 14735: Save cache_expiry on modifying a report

The cache_expiry is not saved when updating a SQL report.

Test plan:
0/ Enable memcached
1/ Create a sql report
2/ Edit it and change the cache expiry value
3/ Edit again
=> The value should have been updated.

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
  Repeatable bug. Solved with this patch.
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 27a15d5a429620dbad0a16292d714e3389ea057e)

8 years agoBug 15011: koha-indexer should define the --pidfiles on starting the daemon
Jonathan Druart [Wed, 14 Oct 2015 13:20:38 +0000 (13:20 +0000)]
Bug 15011: koha-indexer should define the --pidfiles on starting the daemon

The --pidfiles options is not provided on starting the daemon and the is_indexer_running consider that the daemon is not running

Test plan:
koha-indexer start
koha-indexer stop

should start and stop the zebra daemon wuthout any error.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Tested on kohadevbox:ansible

sudo debian/scripts/koha-indexer --stop kohadev
sudo debian/scripts/koha-indexer --start kohadev
sudo debian/scripts/koha-indexer --restart kohadev

All work as expected on the different scenarios.

(cherry picked from commit 0ba1fb9e7739e66f57199bba2b4809e539a00237)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 14575: Fix typo in opac-basket.tt
Jonathan Druart [Tue, 10 Nov 2015 09:06:32 +0000 (09:06 +0000)]
Bug 14575: Fix typo in opac-basket.tt

No more typo in the codebase.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit a0460ecc0abbe5f69554ab3885775e55b6a25fe0)

8 years agoBug 14575: Fix typo OPACurlOpenInNewWindow vs OPACURLOpenInNewWindow
Jonathan Druart [Mon, 9 Nov 2015 11:01:02 +0000 (11:01 +0000)]
Bug 14575: Fix typo OPACurlOpenInNewWindow vs OPACURLOpenInNewWindow

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 004fa5ac4448fc1dedf9a74774b2ee0b1ec67f77)

8 years agoBug 14575: OPACURLOpenInNewWindow should apply to item-level urls too
David Cook [Tue, 21 Jul 2015 03:09:39 +0000 (13:09 +1000)]
Bug 14575: OPACURLOpenInNewWindow should apply to item-level urls too

This patch applies the OPACURLOpenInNewWindow system preference
to item-level urls (in addition to the pre-existing bib-level url
handling).

_TEST PLAN_

Before applying:

1) Set OPACURLOpenInNewWindow to "don't" and click on an item-level url
2) Note that the current tab changes to that url
3) Set OPACURLOpenInNewWindow to "do" and click on an item-level url
4) Note that the current tab changes to that url

Apply the patch.

After applying:

5) Click on an item-level url
6) Note that the url opens in a new tab (as OPACURLOpenInNewWindow
should be set to "do")
7) Set OPACURLOpenInNewWindow to "don't" and click on an item-level
url
8) Note that the url opens in the current tab

9) Repeat the above steps 5-8 alternating
"TrackClicks" between "Don't track" and either "Track" or
"Track anonymously".

Followed test plan. Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit e815d1e010a20b73327cba1eaa78d08f06ec50a8)

8 years agoBug 14743: addorder.pl redirect problems under plack behind apache 2.4.10
Kyle M Hall [Thu, 5 Nov 2015 13:24:51 +0000 (13:24 +0000)]
Bug 14743: addorder.pl redirect problems under plack behind apache 2.4.10

I can't quite figure this out. When I run CGI version of Koha, I see following response (recorded using tcpdump):

HTTP/1.1 302 Found
Date: Thu, 27 Aug 2015 13:28:41 GMT
Server: Apache/2.4.10 (Debian)
Location: /cgi-bin/koha/acqui/basket.pl?basketno=5610
Vary: User-Agent
Content-Length: 0
Keep-Alive: timeout=5, max=98
Connection: Keep-Alive
Content-Type: text/x-perl

However, when running behind apache 2.4.10 on Debian wheezy I see chunked response:

HTTP/1.1 302 Found
Date: Thu, 27 Aug 2015 13:21:28 GMT
Server: Apache/2.4.10 (Debian)
Vary: User-Agent
Keep-Alive: timeout=5, max=100
Connection: Keep-Alive
Transfer-Encoding: chunked
Content-Type: text/x-perl

60
Transfer-Encoding: chunked
Date: Thu, 27 Aug 2015 13:21:28 GMT
Connection: keep-alive

0

0

This response doesn't work in firefox (where it reports page not found) nor in chrome (where it returns lines below 60 on screen).

In the template the hidden input 'basketno' is listed twice. What the cgi script reads in the parameter, what is does is concat the values of the multiple basketno instances together createing what is likely an invalid basketno. For reasons beyond my understanding this is what triggers this error!

Test Plan:
1) Using plack, add an order to a basket from an external source
2) Note the error
3) Apply this patch
4) Add an order to a basket from an external source
5) Note you get no error!

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 237c1483ddf22babb4f1bfd4dfa3e7120c2d8cd9)

8 years agoBug 15036: Do not overwrite complete status in basket ops
Colin Campbell [Tue, 20 Oct 2015 13:19:35 +0000 (14:19 +0100)]
Bug 15036: Do not overwrite complete status in basket ops

Reopening or closing a basket should preserve the completed
status for receipted orders.

This patch excludes orderlines with the completed status
from having their status rewritten as a result of the
change in basket status

Made the subroutines involved more efficient by removing an
unnecessary loop and by not fetching a large amount of
superfluous data

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 4a4dbbf1237c93e0233eef0600015c9be3320bf0)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 14867: userid not generated when defined in BorrowerUnwantedField
Fridolin Somers [Tue, 22 Sep 2015 07:49:39 +0000 (09:49 +0200)]
Bug 14867: userid not generated when defined in BorrowerUnwantedField

When userid is not provided when creating a new patron, it is generated
using surname and firstname.  The bug is when userid is defined in
syspref BorrowerUnwantedField, the input text is missing in patron
creation form. When saving you always get an alert message :
"Username/password already exists". No patron can be created.

This patch corrects by adding this case to userid generation conditions.

Test plan :
- add 'userid' in syspref BorrowerUnwantedField
- try to create a new patron : /cgi-bin/koha/members/memberentry.pl
- there is not input text for userid
- choose non-existing surname and firstname
- click on save
  => Without patch : patron is not created, you see the alert message
     "Username/password already exists"
  => With patch : patron is created, userid is generated with surname
     and firstname
- remove 'userid' in syspref BorrowerUnwantedField and check it can be
  defined in patron creation form

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
  The issue is there, and this patch fixes it.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 0cbc65111c735e699d94d50ad09c17fb7b7b8913)

8 years agoBug 14388: Funds should be sorted by budget_code
Jonathan Druart [Thu, 2 Jul 2015 15:42:16 +0000 (16:42 +0100)]
Bug 14388: Funds should be sorted by budget_code

Before this patch, the funds were sorted by budget_id, which does not
make any sense.

This patch adds a sort by budget_code on the fund list (acqui/acqui-home.pl and
admin/aqbudgets.pl)

Test plan:
On both pages (acqui/acqui-home.pl and admin/aqbudgets.pl) confirm that
the funds are now sorted by fund code (DB column budget_code)

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit e0032c46e98b4cf31d76abb93d12041ea362d81e)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
8 years agoBug 14687: Patron's transaction history changes items' order after paying fines.
Joonas Kylmälä [Mon, 17 Aug 2015 12:40:05 +0000 (12:40 +0000)]
Bug 14687: Patron's transaction history changes items' order after paying fines.

Sorts Patron's accounting data consistently from newest to oldest.
It doesn't depend on anymore to timestamp (which can be same for multiple
entries) from database but instead uses accountline's id to sort.

Signed-off-by: Liz Rea <liz@catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 307fe0ac533c2dc8116a183d104c864717a91fc5)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>