From df93b26f170d3d91ef7dd6bcced2a4b8a47d2efd Mon Sep 17 00:00:00 2001
From: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Date: Tue, 1 Oct 2024 11:23:48 -0400
Subject: [PATCH] Bug 38053: Change description of
 DefaultLongOverduePatronCategories and DefaultLongOverdueSkipPatronCategories
 system preferences

This patch changes the description of the DefaultLongOverduePatronCategories
and DefaultLongOverdueSkipPatronCategories system preferences
to make it clearer it has to do with the **long overdues** process
and not just the overdues process. It also highlights the
warning by making it bold.

To test:
1. Apply patch
2. Go to Administration > System preferences > Circulation >
   Lost item policy
3. Read the description for DefaultLongOverduePatronCategories
   and DefaultLongOverdueSkipPatronCategories, make sure it
   makes sense, that the grammar and spelling is OK

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
---
 .../en/modules/admin/preferences/circulation.pref  | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
index 679ff89681..fce172e8d1 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
@@ -568,21 +568,23 @@ Circulation:
             - <br>(Used when the longoverdue.pl script is called without the --charge parameter)
             - "<br><strong>NOTE:</strong> This system preference requires the <code>misc/cronjobs/longoverdue.pl</code> cronjob. Ask your system administrator to schedule it."
         -
-            - Set the default patron categories to receive overdues to
+            - The long overdue process affects patrons in the
             - pref: DefaultLongOverduePatronCategories
               choices: patron-categories
               class: multiple
-            - <br>Leave this field empty if you want to process overdues for all patron categories.
+            - categories.
+            - <br>Leave this field empty if you want to process long overdues for all patron categories.
             - <br>(Used when the longoverdue.pl script is called without the --category parameter)
-            - <br>WARNING — This preference will be active only if DefaultLongOverdueSkipPatronCategories is empty.
+            - <br><strong>WARNING:</strong> This preference will be active only if DefaultLongOverdueSkipPatronCategories is empty.
             - <br>
-            - Set the default patron categories to <i>not</i> receive overdues to
+            - The long overdue process <i>does not</i> affect patrons in the
             - pref: DefaultLongOverdueSkipPatronCategories
               choices: patron-categories
               class: multiple
-            - <br>Leave this field empty if you want to process overdues for all patron categories.
+            - categories.
+            - <br>Leave this field empty if you want to process long overdues for all patron categories.
             - <br>(Used when the longoverdue.pl script is called without the --skip-category parameter)
-            - <br>WARNING - This preference overrides the DefaultLongOverduePatronCategories preference, so the DefaultLongOverduePatronCategories filter will not take effect.
+            - <br><strong>WARNING:</strong> This preference overrides the DefaultLongOverduePatronCategories preference, so the DefaultLongOverduePatronCategories filter will not take effect.
             - "<br><strong>NOTE:</strong> This system preference requires the <code>misc/cronjobs/longoverdue.pl</code> cronjob. Ask your system administrator to schedule it."
         -
             - When using the automatic item loss process, skip items with <a href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=LOST">LOST</a> values matching any of
-- 
2.39.5