From 81b21b6d118c9c1039d5c2f22153adafa3bda544 Mon Sep 17 00:00:00 2001 From: Andreas Jonsson Date: Thu, 13 Jun 2024 17:00:31 +0200 Subject: [PATCH] Bug 37016: Invalid due date in SIP renew response MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Test plan using koha-testing-docker: 1) Make sure SIP is running. You may need to edit /etc/koha/sites/SIPconfig.xml and remove the 8023 connector and restart the SIP-server (koha-sip --restart kohadev) 2) Find a patron, say 23529000197047 3) Set a password by selecting "change password", set it to "Password1234" 4) Find a book, say 39999000000856 5) Issue book to patron with sip-client: sudo koha-shell -c "/usr/share/koha/bin/sip_cli_emulator.pl \ --address localhost --port 6001 -t cr \ --su term1 --sp term1 --message checkout \ --location CPL --item 39999000000856 \ --patron 23529000197047 --password Password1234"\ kohadev 6) Note the AH-header in the response which for example: 'AH20240619 235900' 7) Make a renewal with: sudo koha-shell -c "/usr/share/koha/bin/sip_cli_emulator.pl \ --address localhost --port 6001 -t cr \ --su term1 --sp term1 --message renew \ --location CPL --item 39999000000856 \ --patron 23529000197047 --password Password1234"\ kohadev 8) Make sure the AH-header in the response is different from the response to the checkout, for example: 'AH20240624 235900' Signed-off-by: Tadeusz „tadzik” Sośnierz Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer (cherry picked from commit 3295fd52279728c222ef6504766ab9d573561e0f) Signed-off-by: Lucas Gass (cherry picked from commit 82f15de4fbdcb7a117a4c158741b927beb01f20e) Signed-off-by: Fridolin Somers --- C4/Circulation.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index 3aac4cb43d..7d97e0e7af 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -1591,7 +1591,7 @@ sub AddIssue { $issuedate, # here interpreted as the renewal date } ); - $issue = $item_object->checkout; + $issue = $item_object->checkout->get_from_storage; } else { -- 2.39.5