From 4f57d8ccea9033cc3b6d17d69f3ac6d982877b6d Mon Sep 17 00:00:00 2001 From: Nicolas Legrand Date: Wed, 22 Feb 2017 10:11:18 +0100 Subject: [PATCH] Bug 18150 - CanItemBeReserved doesn't work with (IndependentBranches AND ! canreservefromotherbranches) The variable $item used to be a hash, but at the end of the function, it's a Koha object. As $item->{homebranch} doesn't yield anything and should be $item->homebranch. It prevents people using different branches without holds between branches from placing a hold on an item they should be able to place hold on. Test plan: 1. Before patch a. with IndependantBranches off b. try to place hold on an item you should be able to place hold on c. it should work d. put IndependantBranches on and canreservefromotherbranches off e. shouldn't work 2. after patches redo steps from (1) and everything should be working fine. Signed-off-by: Christopher Brannon Signed-off-by: Jonathan Druart Note: Item is fetched twice, it's not necessary. But out of the scope of this patch. Signed-off-by: Brendan A Gallagher (cherry picked from commit f79cf7930d887ea157fa64bb89fb0eb130b74aae) Signed-off-by: Katrin Fischer --- C4/Reserves.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Reserves.pm b/C4/Reserves.pm index 8aa1e05df9..88e14c9690 100644 --- a/C4/Reserves.pm +++ b/C4/Reserves.pm @@ -583,7 +583,7 @@ sub CanItemBeReserved { if ( C4::Context->preference('IndependentBranches') and !C4::Context->preference('canreservefromotherbranches') ) { - my $itembranch = $item->{homebranch}; + my $itembranch = $item->homebranch; if ( $itembranch ne $borrower->{branchcode} ) { return 'cannotReserveFromOtherBranches'; } -- 2.39.5