]> git.koha-community.org Git - koha.git/commit
Bug 37845: Remove C4::Members::DeleteExpiredOpacRegistrations
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 5 Sep 2024 15:06:04 +0000 (17:06 +0200)
committerKatrin Fischer <katrin.fischer@bsz-bw.de>
Mon, 21 Oct 2024 13:10:31 +0000 (15:10 +0200)
commitc89e020e7d8a71b8abd636786d35434f62ab64e4
tree0cc5526bbb4d178fde1ea15a93e393e5bb562414
parent73f890ab2d3a166bd5a0b4b7166121c6fc4f04ac
Bug 37845: Remove C4::Members::DeleteExpiredOpacRegistrations

This patch remove the subroutine C4::Members::DeleteExpiredOpacRegistrations.
The code is moved and adjusted to Koha::Patrons.
We now have 2 new methods:
  Koha::Patrons->filter_by_expired_opac_registrations
  Koha::Patrons->filter_by_safe_to_delete

Test plan:
Run the misc/cronjobs/cleanup_database.pl script with the
--del-exp-selfreg (as well as --verbose and --confirm) and confirm that
it behaves as expected

Note that it improve the output of the verbose mode and now tell if the something
is wrong with the config (syspref not set)

Signed-off-by: Sukhmandeep Benipal <sukhmandeep.benipal@inLibro.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
C4/Members.pm
Koha/Patrons.pm
misc/cronjobs/cleanup_database.pl
t/db_dependent/Koha/Patrons.t
t/db_dependent/Members.t