From a7d46e6ac9d0c1234c049dde9af8c73de58f2aba Mon Sep 17 00:00:00 2001 From: Mark Tompsett Date: Tue, 21 Jan 2014 00:41:00 -0500 Subject: [PATCH] Bug 11587: get rid of warnings generated by IsSuperLibrarian with anonymous sessions This corrects line 1250 of C4/Context.pm to be: return ($userenv->{flags}//0) % 2; And thus avoids an uninitialized value used in the modulus. TEST PLAN --------- 1) Apply the first patch (to update t/Context.t) 2) prove -v t/Context.t -- This should fail tests 7 and 8 3) Apply this patch (to fix C4/Context.pm) 4) prove -v t/Context.t -- All tests should succeed Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit bf3b1aac7b7bc422bea26bb2c045be69d93ef0bf) Signed-off-by: Fridolin Somers --- C4/Context.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Context.pm b/C4/Context.pm index 41ce79e255..d91dd05f5a 100644 --- a/C4/Context.pm +++ b/C4/Context.pm @@ -1259,7 +1259,7 @@ sub IsSuperLibrarian { return 1; } - return $userenv->{flags} % 2; + return ($userenv->{flags}//0) % 2; } 1; -- 2.39.5