From bda46fb9f235e0ba7fff758ca4c243dd5e15484c Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Tue, 1 Aug 2017 17:07:33 +0000 Subject: [PATCH] Bug 18985 - SQL reports 'Last edit' and 'Last run' columns sort alphabetically, not chronologically MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit This patch alters the DataTables configuration of the SQL reports list so that date columns are identified via class rather than position. To test, apply the patch and go to Reports -> Use saved. Test the re-ordering of the creation date, last edit, and last run columns. Each should sort correctly based on the date. Signed-off-by: Marc Véron Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart (cherry picked from commit 3304c7c4ca49db1b95aa564b3550bacf260b9b4f) Signed-off-by: Fridolin Somers --- .../prog/en/modules/reports/guided_reports_start.tt | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt index 499daa3c11..65417bd1a5 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt @@ -94,10 +94,8 @@ $("#delColumn").on("click",function(){ 'aoColumnDefs': [ { 'bSortable': false, 'bSearchable':false, 'aTargets': [0, -1] }, { 'bSearchable': false, 'aTargets': [3] }, - { "aTargets": [ 1, 2 ], "sType": "natural" } - ], - "aoColumns": [ - null,null,null,null,null,null,null,null,{ "sType": "title-string" },null,null,null,[% IF (usecache) %]null,[% END %]null,null[% IF has_obsolete_reports %],null[% END %] + { "aTargets": [ 1, 2 ], "sType": "natural" }, + { "sType": "title-string", "aTargets" : [ "title-string" ] } ], 'oLanguage': { 'sZeroRecords': _("No matching reports found") @@ -374,9 +372,9 @@ canned reports and writing custom SQL reports.

Subgroup Notes Author - Creation date - Last edit - Last run + Creation date + Last edit + Last run Public [% IF (usecache) %] Cache expiry (seconds) [% END %] Saved results -- 2.39.5