]> git.koha-community.org Git - koha.git/log
koha.git
16 years agodebugify a warn
Galen Charlton [Thu, 16 Oct 2008 15:44:56 +0000 (10:44 -0500)]
debugify a warn

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agobugfix: fixed reference to sort2 column in query
Galen Charlton [Thu, 16 Oct 2008 15:24:32 +0000 (10:24 -0500)]
bugfix: fixed reference to sort2 column in query

Fixes following error when using the patron statistics report:

DBD::mysql::st execute failed: Unknown column 'sort' in 'where clause' at /home/gmc/koha/dev/reports/borrowers_stats.pl line 127

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoSome changes to improve display on Internet Explorer.
Owen Leonard [Wed, 15 Oct 2008 14:05:11 +0000 (09:05 -0500)]
Some changes to improve display on Internet Explorer.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoChanges to prevent javascript errors in Internet Explorer
Owen Leonard [Wed, 15 Oct 2008 14:05:23 +0000 (09:05 -0500)]
Changes to prevent javascript errors in Internet Explorer

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agofollowup on Owen's patron attributes patch
Galen Charlton [Thu, 16 Oct 2008 15:10:09 +0000 (10:10 -0500)]
followup on Owen's patron attributes patch

Hide the display of the patron attributes only if
no types are defined; the patron attributes section
(and more importantly, the edit link), should still
be displayed if an attribute type is defined, even
if the patron has no attributes currently set.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoAdd the feature to create reports with borrower's sex information(Men/Women) (bug...
Nahuel Angelinetti [Wed, 15 Oct 2008 07:38:47 +0000 (09:38 +0200)]
Add the feature to create reports with borrower's sex information(Men/Women) (bug #2671)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoSpelling correction (catalogue -> catalog)
Owen Leonard [Wed, 15 Oct 2008 14:24:58 +0000 (09:24 -0500)]
Spelling correction (catalogue -> catalog)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoHiding patron attributes entry if not configured.
Owen Leonard [Wed, 15 Oct 2008 14:04:10 +0000 (09:04 -0500)]
Hiding patron attributes entry if not configured.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agobug 2677: restore RandomizeHoldsQueueWeight and StaticHoldsQueueWeight
Galen Charlton [Wed, 15 Oct 2008 13:52:34 +0000 (08:52 -0500)]
bug 2677: restore RandomizeHoldsQueueWeight and StaticHoldsQueueWeight

Restoring the functionality of these sysprefs as part of the
rework of build_holds_queue.pl:

* StaticHoldsQueueWeight is an ordered list of library codes.
  The order of the libraries in this list determines the order
  of libraries in which available items will be chosen to be
  targeted to holds.  Note that if this list does not include
  a library, items from that library will never be targeted to
  holds and staff will never be asked to retrieve items for
  title-level holds from those libraries.

* RandomizeHoldsQueueWeight is a Boolean parameter, indicating
  whether to randomize the libraries in the StaticHoldsQueueWeight
  list.

If neither RandomizeHoldsQueueWeight nor StaticHoldsQueueWeight is
set, then the libraries will be used to target items to holds in
alphabetical order by library code.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoMore corrections to fix Bug 2649, "minPasswordLength Sys Pref does nothing." Previous...
Owen Leonard [Tue, 7 Oct 2008 14:21:01 +0000 (09:21 -0500)]
More corrections to fix Bug 2649, "minPasswordLength Sys Pref does nothing." Previous patch included typo copied from member-password.pl. Both are corrected now.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoRemove ambiguity from SQL statement for holds queue.
Ryan Higgins [Wed, 8 Oct 2008 05:31:24 +0000 (00:31 -0500)]
Remove ambiguity from SQL statement for holds queue.

holdingbranch table not referenced in view_holdsqueue.pl, causing irresolvable ambiguity in
sql query when limited by library (holdingbranch).  This was causing DBI errors to be thrown
in test database, and library-limited holdsqueue display was thus empty.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years ago2663 fix
Marc Chantreux [Wed, 8 Oct 2008 11:05:01 +0000 (13:05 +0200)]
2663 fix

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agofollowup - make barcode_to_borrowernumber() work as named
Galen Charlton [Tue, 14 Oct 2008 18:10:28 +0000 (13:10 -0500)]
followup - make barcode_to_borrowernumber() work as named

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoSIP Holds processing on checkout
Joe Atzberger (siptest [Thu, 9 Oct 2008 22:53:37 +0000 (17:53 -0500)]
SIP Holds processing on checkout

Allow valid comparison of hold_queue to current user barcode and
permit checkout if the current user is at the front of the queue.
Effectively, this allows a user to checkout a book he has held.
Here are the example checkout (11) and checkout response (12)
statements in a SIP telnet session, showing failure (120) previously
and success (121) after patch application.
Before:
11YN20060329    203000                  AOCPL|AA1|AB502326000820|ACterm1
120NUN20081009    140222AOCPL|AA1|AB502326000820|AJKidnapped :|AH|AF2008-10-09 : Koha Admin (1)|BLY|
After:
11YN20060329    203000                  AOCPL|AA1|AB502326000820|ACterm1
121NNY20081009    150204AOCPL|AA1|AB502326000820|AJKidnapped :|AH2008-10-10|AFItem was reserved for you.|

This patch also resolves security/privacy issues related to the display
of "needsconfirmation" values that identify, for example, the user
currently issued an item, or with a hold on the item.  These messages
should not be passed to an end-user interface.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoFully qualify function call.
Joe Atzberger (siptest [Thu, 9 Oct 2008 22:53:36 +0000 (17:53 -0500)]
Fully qualify function call.

This is a pre-requisite to continued SIP processing, dealing with some
arcana related to recursive dependencies and UNIVERSAL.  The reason this
is separate from other SIP patches is that it is expected patched in other
submissions already.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoAnother correction to eliminate left column from print view.
Owen Leonard [Fri, 3 Oct 2008 16:16:10 +0000 (11:16 -0500)]
Another correction to eliminate left column from print view.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoBug 2555 : label batch_id not properly incremented after batch num 10.
Ryan Higgins [Sat, 27 Sep 2008 17:57:08 +0000 (12:57 -0500)]
Bug 2555 : label batch_id not properly incremented after batch num 10.

This is a stop-gap fix intended for 3.0 maintenance release.
3.2 should include a label_batches table which will allow named
batches to be associated with a template & layout, and fix the
column definition of batch_id here to be an auto_incr int.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoMore Consistant terminoligy in stage-marc-import.tmpl
Michael Hafen [Wed, 1 Oct 2008 19:29:50 +0000 (13:29 -0600)]
More Consistant terminoligy in stage-marc-import.tmpl

Changes 'Notes about this file' to 'Comments about this file'.  It's
'Comments' in the manage-marc-import.tmpl file.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoHiding minimum password hint if there is no minimum password length set.
Owen Leonard [Thu, 2 Oct 2008 16:24:04 +0000 (11:24 -0500)]
Hiding minimum password hint if there is no minimum password length set.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoFix for Bug 2649, "minPasswordLength Sys Pref does nothing." Adds note specifying...
Owen Leonard [Wed, 1 Oct 2008 17:39:17 +0000 (12:39 -0500)]
Fix for Bug 2649, "minPasswordLength Sys Pref does nothing." Adds note specifying minimum password length to patron entry form, and generates warning if submitted password is not long enough.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoCorrections to manage marc import interface, including fix for inaccurate progress...
Owen Leonard [Thu, 2 Oct 2008 16:23:49 +0000 (11:23 -0500)]
Corrections to manage marc import interface, including fix for inaccurate progress bar.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoAdding javascript to prevent premature submission of forms when using a barcode scann...
Owen Leonard [Mon, 15 Sep 2008 16:33:32 +0000 (11:33 -0500)]
Adding javascript to prevent premature submission of forms when using a barcode scanner (or by hitting the enter key). Addresses Bug 2591

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agobug: query squashes issues.timestamp which circulation.pl needs to sort todaysissues
Michael Hafen [Wed, 10 Sep 2008 19:12:56 +0000 (13:12 -0600)]
bug: query squashes issues.timestamp which circulation.pl needs to sort todaysissues

Little change to the query so we get the right timestamp to sort on.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agobug: chargelostitem() didn't unset onloan on the item record.
Michael Hafen [Tue, 2 Sep 2008 19:57:09 +0000 (13:57 -0600)]
bug: chargelostitem() didn't unset onloan on the item record.

I don't think this is left set intentionally.

If an item is set lost and it's on loan it's marked returned, but it
wasn't set as not on loan.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agobug: sticky due date isn't stick if there is a question about an issue
Michael Hafen [Tue, 2 Sep 2008 22:13:16 +0000 (16:13 -0600)]
bug: sticky due date isn't stick if there is a question about an issue

the stickyduedate input isn't sent on from the question dialogs.  This
causes it to un-stick if there is a question.

Also removed month, day, and year as there seems to be no use for them.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoReduce logging from rebuild_zebra.pl with a command line option
Michael Hafen [Wed, 1 Oct 2008 18:04:16 +0000 (12:04 -0600)]
Reduce logging from rebuild_zebra.pl with a command line option

This reduces the output of the script and zebraidx, and creates a -v
command line switch which will increase the logging to their former
states.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoEliminate left-column margin on print view
Owen Leonard [Wed, 24 Sep 2008 16:26:33 +0000 (11:26 -0500)]
Eliminate left-column margin on print view

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoBUGFIX missing div
paul [Mon, 22 Sep 2008 16:31:54 +0000 (18:31 +0200)]
BUGFIX missing div

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agofix date formatting in overdue_notices.pl
Pianohacker [Fri, 26 Sep 2008 19:57:25 +0000 (14:57 -0500)]
fix date formatting in overdue_notices.pl

This makes overdue_notices.pl format dates in fields that both start and end with 'date'.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agobugfix: Add a message to circulation.pl if item is restricted
Michael Hafen [Wed, 1 Oct 2008 15:48:18 +0000 (09:48 -0600)]
bugfix: Add a message to circulation.pl if item is restricted

Don't know how this was missed.  If an item is restricted it isn't
allowed to be issued, but there is no message about why it can't be
issued, just the yellow box.

This adds a message saying "item is restricted".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoBugfix #2630 2nd attempt
Frederic Demians [Fri, 26 Sep 2008 17:25:58 +0000 (19:25 +0200)]
Bugfix #2630 2nd attempt

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoRemove hardcoded "Freelist" line from Auth.
Joe Atzberger [Tue, 30 Sep 2008 22:00:40 +0000 (17:00 -0500)]
Remove hardcoded "Freelist" line from Auth.

Apparently a leftover debugging snippet.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoMarkup and formatting improvements to Manage Staged Records interface.
Owen Leonard [Tue, 30 Sep 2008 00:00:29 +0000 (19:00 -0500)]
Markup and formatting improvements to Manage Staged Records interface.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoAdding progress bar and some other visual enhancements to file upload interactions.
Owen Leonard [Tue, 30 Sep 2008 00:00:20 +0000 (19:00 -0500)]
Adding progress bar and some other visual enhancements to file upload interactions.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoBugfix #2633
Frederic Demians [Tue, 23 Sep 2008 15:47:11 +0000 (17:47 +0200)]
Bugfix #2633

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoBug 2587 followup, updated test.
Joe Atzberger [Tue, 23 Sep 2008 17:15:11 +0000 (12:15 -0500)]
Bug 2587 followup, updated test.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoConvert to C4::Debug, comment out unused Data::Dumper.
Joe Atzberger [Tue, 23 Sep 2008 17:01:48 +0000 (12:01 -0500)]
Convert to C4::Debug, comment out unused Data::Dumper.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agobug 2628: fixing test script to deal with DESTDIR in Makefile.PL
Andrew Moore [Fri, 19 Sep 2008 15:42:54 +0000 (10:42 -0500)]
bug 2628: fixing test script to deal with DESTDIR in Makefile.PL

Recently, there were changes to the Makefile.PL to make it install in a
DESTDIR that the OS (debian) may choose. This broke the test suite.
Since we're not installing the stuff in the t/ directory, we need to
ignore the DESTDIR specifiation before we write the test-config.txt.
So, this patch adds a call to the _strip_destdir function for all
directories written to the t/test-config.txt file.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoRevising the stub for ILS/Transaction/FeePayment.pm
Joe Atzberger [Fri, 19 Sep 2008 00:02:49 +0000 (19:02 -0500)]
Revising the stub for ILS/Transaction/FeePayment.pm

Obviously more implementation is needed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoMore fixes for Bug 2600, enabling the appearance of HTML tags in item titles. Resubmi...
Owen Leonard [Wed, 17 Sep 2008 15:03:34 +0000 (10:03 -0500)]
More fixes for Bug 2600, enabling the appearance of HTML tags in item titles. Resubmission.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agobug 2615: remove unneeded 'require Exporter'
Galen Charlton [Wed, 17 Sep 2008 12:07:51 +0000 (07:07 -0500)]
bug 2615: remove unneeded 'require Exporter'

Most Perl scripts (as opposed to modules) do
not need to require Exporter.

No user-visible or documentation changes.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agobug 2625: finish fix by converting another array to hash
Galen Charlton [Fri, 19 Sep 2008 00:09:02 +0000 (19:09 -0500)]
bug 2625: finish fix by converting another array to hash

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agobug 2625
Clay Fouts [Thu, 18 Sep 2008 19:40:05 +0000 (14:40 -0500)]
bug 2625

Using the barcode as an index for assigning values to an array creates problems if
the numeric value of the barcode is sufficiently large to consume enough memory to
starve other processes. This patch changes return_failed from an indexed array into
an associative one, using the barcode as the key.

Signed-off-by: Ryan Higgins <rch@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agobug 2609: display correct requested title
Galen Charlton [Tue, 16 Sep 2008 02:00:42 +0000 (22:00 -0400)]
bug 2609: display correct requested title

In databases where biblionumber is not necessarily
the same as biblioitemnumber, the title of
certain hold requests displayed by moremember.pl
could be drawn from the wrong record.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agobug 2608: let offline circ processing work in background
Galen Charlton [Tue, 16 Sep 2008 01:38:22 +0000 (20:38 -0500)]
bug 2608: let offline circ processing work in background

If an offline circulation file is large, process_koc.pl
could time out before processing all of the transactions.

To prevent this, the processing can now be run in the
background, with an AJAX loop to check the job's
status.

As a consequence of the patch, the UI for uploading offline circ files has
changed slightly.  One must select a file, click the "upload file" button, then
click the "process offline circulation file" button.

Also removed the now-superfluous upload_koc.pl, added the warnings pragma,
and fixed a typo in the template.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoBug 2365 : Inner counter not properly set for serials subscriptions not starting...
Ryan Higgins [Tue, 16 Sep 2008 11:05:33 +0000 (06:05 -0500)]
Bug 2365 : Inner counter not properly set for serials subscriptions not starting on first issue.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agofix for bug 2556: Overlaying records sometimes creates new record
Jesse Weaver [Sun, 14 Sep 2008 03:59:10 +0000 (22:59 -0500)]
fix for bug 2556: Overlaying records sometimes creates new record

This makes "Try another search" in the Z39.50 search tool pass the biblionumber along, so that records are overlaid correctly.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoCorrections to fix javascript error in Internet Explorer.
Owen Leonard [Sat, 13 Sep 2008 15:50:19 +0000 (10:50 -0500)]
Corrections to fix javascript error in Internet Explorer.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoAltering system log search form to conform with other similar forms; escaping output...
Owen Leonard [Sat, 13 Sep 2008 15:50:11 +0000 (10:50 -0500)]
Altering system log search form to conform with other similar forms; escaping output of "info" variable.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoDHTMLcalendar should not be imported.
Joe Atzberger [Fri, 12 Sep 2008 16:25:01 +0000 (11:25 -0500)]
DHTMLcalendar should not be imported.

Changing these scripts as precursor to removing it from C4::Dates @EXPORT_OK

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agomoredetail.pl is not an Exporter.
Joe Atzberger [Fri, 12 Sep 2008 16:25:02 +0000 (11:25 -0500)]
moredetail.pl is not an Exporter.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoRemove acquisitions permission requirement on catalogue/showmarc.pl
Ryan Higgins [Thu, 11 Sep 2008 19:31:05 +0000 (14:31 -0500)]
Remove acquisitions permission requirement on catalogue/showmarc.pl

This script is linked to from z39.50 search as well as acquisitions.
cataloguing/z3950_search.pl requires only the 'catalogue' flag, so
requiring only that permission here.  A user without acquisitions permissions
would get a login instead of the record display without this change.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoSort libraries by name in holds queue's select input.
Ryan Higgins [Thu, 11 Sep 2008 18:17:24 +0000 (13:17 -0500)]
Sort libraries by name in holds queue's select input.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoChange missing from previous commit re:Bug 2600.
Owen Leonard [Thu, 11 Sep 2008 14:55:52 +0000 (09:55 -0500)]
Change missing from previous commit re:Bug 2600.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoMarkup correction; Fix for Bug 2600, "HTML tags in titles not escaped in list of...
Owen Leonard [Thu, 11 Sep 2008 14:54:04 +0000 (09:54 -0500)]
Markup correction; Fix for Bug 2600, "HTML tags in titles not escaped in list of returned items."

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoRefining keyboard shortcuts javascript.
Owen Leonard [Thu, 11 Sep 2008 14:53:48 +0000 (09:53 -0500)]
Refining keyboard shortcuts javascript.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoSome formatting fixes for bookcount.tmpl and issuehistory.tmpl. Linking to moredetail...
Owen Leonard [Wed, 10 Sep 2008 19:02:20 +0000 (14:02 -0500)]
Some formatting fixes for bookcount.tmpl and issuehistory.tmpl. Linking to moredetail.pl from issuehistory.pl (just as barcode on detail.pl links to moredetail.pl).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agobug 2596: remove URL escaping added by previous patch
Galen Charlton [Wed, 17 Sep 2008 02:58:13 +0000 (21:58 -0500)]
bug 2596: remove URL escaping added by previous patch

If URL in an href comes from a MARC record, it should not
be URL-escaped - otherwise, link is interpreted as relative
to MARCdetail.pl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoFix for Bug 2596, "restore ability to hyperlink URL fields in MARC detail display"
Owen Leonard [Wed, 10 Sep 2008 13:11:07 +0000 (08:11 -0500)]
Fix for Bug 2596, "restore ability to hyperlink URL fields in MARC detail display"

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoFix for Bug 2592, "hyphens being added to marc view isbn." Also removing truncation...
Owen Leonard [Tue, 9 Sep 2008 20:21:07 +0000 (15:21 -0500)]
Fix for Bug 2592, "hyphens being added to marc view isbn." Also removing truncation of subfield descriptions.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agobug 2588: fixed several links to open in new window when OPACURLOpenInNewWindow is ON
Danny Bouman [Tue, 9 Sep 2008 20:05:35 +0000 (16:05 -0400)]
bug 2588: fixed several links to open in new window when OPACURLOpenInNewWindow is ON

Fixed several links on the OPAC Detail page to open in a new window when the OPACURLOpenInNewWindow system preference is ON.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoCan't escape title variable as HTML because of search term highlighting.
Owen Leonard [Tue, 9 Sep 2008 19:54:04 +0000 (14:54 -0500)]
Can't escape title variable as HTML because of search term highlighting.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoTrying again: Standardizing styling of error messages; other markup corrections.
Owen Leonard [Tue, 9 Sep 2008 19:53:49 +0000 (14:53 -0500)]
Trying again: Standardizing styling of error messages; other markup corrections.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoBug Fixing : 2581 Problem With HomeBranchOrHoldingBranch (count items management)
Henri-Damien LAURENT [Thu, 4 Sep 2008 14:34:41 +0000 (16:34 +0200)]
Bug Fixing : 2581 Problem With HomeBranchOrHoldingBranch (count items management)

Using $item->{$hbranch} rather than $item->{homebranch}

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoBugs 2541 and 2587 - AddIssue must return date object as intended.
Joe Atzberger (siptest [Thu, 11 Sep 2008 03:30:04 +0000 (22:30 -0500)]
Bugs 2541 and 2587 - AddIssue must return date object as intended.

SIP actually relied on the AddIssue return that was not reliable.
AddRenew also updated to return C4::Dates object for datedue.

Please note, any running SIPServer will have to be restarted
*immediately* after applying this patch, because although Koha
C4 behaves as normal, the SIP server runs as a Net::Server with
components cached.  Changes will not be applied until SIPServer
restarts, and so checkout actions may fail until then.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agobug 2594: fixing SQL statement to populate patron information in offline circulation db
Andrew Moore [Tue, 9 Sep 2008 17:51:35 +0000 (12:51 -0500)]
bug 2594: fixing SQL statement to populate patron information in offline circulation db

The offline circulation tool can use all of the patron information, not just their ID
numbers. This patch populates the offline circulation database with patron information.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agofix extra <td> introduced in previous patch
Galen Charlton [Tue, 9 Sep 2008 16:16:59 +0000 (11:16 -0500)]
fix extra <td> introduced in previous patch

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agocommenting out debug warns
Galen Charlton [Tue, 9 Sep 2008 16:08:07 +0000 (11:08 -0500)]
commenting out debug warns

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoCorrection to previous commit, removing debugging.
Owen Leonard [Tue, 9 Sep 2008 15:54:23 +0000 (10:54 -0500)]
Correction to previous commit, removing debugging.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoFormatting itemtype icon section with tabs to match authorized value interface.
Owen Leonard [Tue, 9 Sep 2008 15:26:48 +0000 (10:26 -0500)]
Formatting itemtype icon section with tabs to match authorized value interface.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoRemove double conditional, fix one FIXME.
Joe Atzberger [Mon, 8 Sep 2008 17:49:40 +0000 (12:49 -0500)]
Remove double conditional, fix one FIXME.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoMinor cleanup, updated POD.
Joe Atzberger [Mon, 8 Sep 2008 17:49:39 +0000 (12:49 -0500)]
Minor cleanup, updated POD.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoA few more en-US spelling corrections; Markup corrections; Standardizing on "email...
Owen Leonard [Tue, 9 Sep 2008 15:26:40 +0000 (10:26 -0500)]
A few more en-US spelling corrections; Markup corrections; Standardizing on "email" instead of "e-mail"; Copying isbn-formatting from opac-detail.pl to detail.pl;

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agobug 2585: fix search links for names (XSLT OPAC display)
Galen Charlton [Fri, 5 Sep 2008 15:52:20 +0000 (10:52 -0500)]
bug 2585: fix search links for names (XSLT OPAC display)

Fix malformed OPAC search syntax that caused this bug:

When using the default stylesheet for MARC21 XSLT OPAC details display, the
search links for name headings (from 100, 700, 710, 710, 111, and 711) that are
linked to authority records don't work.  When the user clicks on such a link,
they are directed to the advanced search form instead of the search results.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoCorrect application of noissues flag in SIP.
Joe Atzberger (siptest [Fri, 5 Sep 2008 22:50:15 +0000 (17:50 -0500)]
Correct application of noissues flag in SIP.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agobug2580: category name and home library will now correctly display on all patron...
Danny Bouman [Thu, 4 Sep 2008 15:50:58 +0000 (11:50 -0400)]
bug2580: category name and home library will now correctly display on all patron tabs

This patch fixes several improperly named variables and includes the home library variable on the pages that were missing it. The category
description was added to the GetMemberDetails function since a couple of the pages using that function required the variable.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agobug fix 2590 :
Henri-Damien LAURENT [Mon, 8 Sep 2008 15:45:07 +0000 (17:45 +0200)]
bug fix 2590 :

seems that when itemtypeimagelocation returns undef, the hash is messed up.
put it at the end of the hash and everything is fine.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agobugfix: need to return something if an itemtype doesn't have an image
Michael Hafen [Thu, 28 Aug 2008 20:58:21 +0000 (14:58 -0600)]
bugfix: need to return something if an itemtype doesn't have an image

I noticed that on the search pages if an itemtype doesn't have an image it's information doesn't make it out the the template.  I don't understand why, but this fixes it.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agofix for bug 2577: Cannot delete patron in IE
Jesse Weaver [Tue, 2 Sep 2008 22:53:27 +0000 (17:53 -0500)]
fix for bug 2577: Cannot delete patron in IE

Internet Explorer seems to have a problem with JS array and object constructors that have a comma at the end. There may be other JavaScript files that have this problem.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoRemove unnecessary EXPR.
Joe Atzberger [Tue, 2 Sep 2008 23:48:15 +0000 (18:48 -0500)]
Remove unnecessary EXPR.

There are two problems with this EXPR:
 (1) It's unnecessary, and
 (2) It's an EXPR.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoHTML fixes for matching-rules.tmpl
Galen Charlton [Wed, 3 Sep 2008 01:20:28 +0000 (20:20 -0500)]
HTML fixes for matching-rules.tmpl

* maxnorms, maxoffset => maxlength
* no escape attribute in <input> elements

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoHTML validation adjustments to about.pl
Joe Atzberger [Wed, 3 Sep 2008 20:49:54 +0000 (15:49 -0500)]
HTML validation adjustments to about.pl

Corrects the Tidy errors:
line 428 column 19 - Error: "tr" not finished but containing element ended
line 428 column 19 - Error: end tag for "tr" omitted, but OMITTAG NO was specified
line 426 column 25 - Info: start tag was here
line 452 column 31 - Error: end tag for "strong" omitted, but OMITTAG NO was specified
line 452 column 12 - Info: start tag was here
line 518 column 17 - Error: document type does not allow element "ul" here; missing one of "object", "applet", "map", "iframe", "button", "ins", "del" start-tag
line 525 column 17 - Error: document type does not allow element "ul" here; missing one of "object", "applet", "map", "iframe", "button", "ins", "del" start-tag

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agobug 2582 [2/2]: fix NULL issues.issuedate
Galen Charlton [Thu, 4 Sep 2008 17:23:47 +0000 (12:23 -0500)]
bug 2582 [2/2]: fix NULL issues.issuedate

Corrects loans whose issuedate was set to NULL
during a renewal as follows:

* First, tries to extract the loan date from
  the statistics table.
* For any remaining rows,  sets the issue date
  to the date of the last renewal.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agobug 2582 [1/2]: don't set issuedate during renewal
Galen Charlton [Thu, 4 Sep 2008 17:23:46 +0000 (12:23 -0500)]
bug 2582 [1/2]: don't set issuedate during renewal

Changed so that issues.issuedate is never modified
during a renewal, since that column records the original
date of the loan.  Changed the name and interpretation
of the $issuedate parameter of AddRenewal() to
$lastreneweddate, allowing (e.g.) offline circulation
to set the date of the renewal without changing the
issue date.

As a result of the original bug, issues.issuedate can be
set to NULL for loans that were renewed via the OPAC,
self checkout, or the staff interface when explicitly
renewing a loan.  Loans that were renewed by checking
the item out to the same patron will have the issue date
changed to the date of the last renewal.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoremove debug warn
Galen Charlton [Tue, 2 Sep 2008 21:52:06 +0000 (16:52 -0500)]
remove debug warn

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoValidation fix, include required "type" in link tag.
Joe Atzberger [Tue, 2 Sep 2008 22:39:12 +0000 (17:39 -0500)]
Validation fix, include required "type" in link tag.

This removes validation warnings like:
  Warning: <link> inserting "type" attribute

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoDocumentation update (test-single not single-test)
Joe Atzberger [Tue, 2 Sep 2008 23:08:34 +0000 (18:08 -0500)]
Documentation update (test-single not single-test)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoBug fixing : 2516
Henri-Damien LAURENT [Fri, 29 Aug 2008 16:15:20 +0000 (18:15 +0200)]
Bug fixing : 2516

There was a problem with names ordering in circ/circulation.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoFixing markup errors, tweaking show/hide javascript.
Owen Leonard [Fri, 29 Aug 2008 14:06:03 +0000 (09:06 -0500)]
Fixing markup errors, tweaking show/hide javascript.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoMore markup corrections for better validation.
Owen Leonard [Fri, 29 Aug 2008 14:06:11 +0000 (09:06 -0500)]
More markup corrections for better validation.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoPutting icon sets into tabs. Makes the interface more compact, and much better when...
Owen Leonard [Fri, 29 Aug 2008 14:05:52 +0000 (09:05 -0500)]
Putting icon sets into tabs. Makes the interface more compact, and much better when editing authorized values for which icons are inappropriate.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agobug 2569: added the zipcode to display along with the patron address
Danny Bouman [Thu, 28 Aug 2008 19:22:39 +0000 (15:22 -0400)]
bug 2569: added the zipcode to display along with the patron address

Added the zipcode to display along with the patron address when you are viewing a Patron from the intranet.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agofixing permission
Galen Charlton [Tue, 2 Sep 2008 21:34:41 +0000 (16:34 -0500)]
fixing permission

16 years agochange link to moredetail.pl. In other places it's called with itemnumber=
Michael Hafen [Fri, 22 Aug 2008 23:26:17 +0000 (17:26 -0600)]
change link to moredetail.pl. In other places it's called with itemnumber=

Change the link to moredetail.pl from item= to itemnumber=
I saw the link on boraccount.pl as itemnumber= and thought it should be that way here too.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoAdd/Change link to item details (catalogue/moredetail.pl) for circulation and patron...
Michael Hafen [Fri, 22 Aug 2008 23:24:43 +0000 (17:24 -0600)]
Add/Change link to item details (catalogue/moredetail.pl) for circulation and patron details

This adds the link to item details to circulation.pl
and changes the link on member details to include the itemnumber and #item... in the link.

Forgot the returns.pl.  Will do that in the next patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoAdded link to catalogue/moredetail.pl on the returns page for each returned item
Michael Hafen [Fri, 22 Aug 2008 23:24:44 +0000 (17:24 -0600)]
Added link to catalogue/moredetail.pl on the returns page for each returned item

Had to add itemnumber to the hash of returned item information.

Links to moredetail.pl with itemnumber and #item in the url.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agomodification to show the library and not the username of the person at OPAC.
Henri-Damien LAURENT [Thu, 28 Aug 2008 15:48:13 +0000 (17:48 +0200)]
modification to show the library and not the username of the person at OPAC.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agobug 2568: set default value of intranetuserjs to blank
Galen Charlton [Thu, 28 Aug 2008 13:46:04 +0000 (08:46 -0500)]
bug 2568: set default value of intranetuserjs to blank

The intranetuserjs syspref allows a Koha administrator
to insert arbitrary JavaScript into the staff page header.
Now that this syspref is functional again, this patch
changes the installation scripts so that the default
value is blank - any JavaScript we ship with Koha should
be in the templates, not in a syspref.

Documentation changes: none per se.  However, I do want to
point out that the intranetuserjs syspref is a bit of a
dangerous one - enter a value with incorrect syntax, and
you could make it difficult to access the staff interface -
and should probably be marked as an advanced option.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoFix for Bug 2557, "Guarantor information - error messaee when clicking borrower#...
Owen Leonard [Tue, 26 Aug 2008 19:06:02 +0000 (14:06 -0500)]
Fix for Bug 2557, "Guarantor information - error messaee when clicking borrower# link." Also correcting a couple of minor markup errors.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoFixing tablesorter, display of renew links
Owen Leonard [Mon, 25 Aug 2008 16:14:36 +0000 (11:14 -0500)]
Fixing tablesorter, display of renew links

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>