]> git.koha-community.org Git - koha.git/commit
Bug 37728: (follow-up) Tell the test that opac-illrequests.tt has an op
authorPhil Ringnalda <phil@chetcolibrary.org>
Tue, 24 Sep 2024 02:40:32 +0000 (19:40 -0700)
committerKatrin Fischer <katrin.fischer@bsz-bw.de>
Fri, 18 Oct 2024 12:25:55 +0000 (14:25 +0200)
commitadbbbb1d8c8e239d8bfa7e9cac90db9326ab1feb
tree0ae8bdd5d5314cad03675d370e601b6a1be114e1
parent1f8b6d5daad407ed289a5b1f097e3ae57d6f452d
Bug 37728: (follow-up) Tell the test that opac-illrequests.tt has an op

xt/find-missing-op-in-forms.t wants to see name="op" value="cud-..." in any
form with method="post", but opac-illrequests.tt inserts its op input by
passing around whole and unpack and repacking whole.keys which includes
the op. We just need to tell the test that it really exists.

At first, I thought of this approach as a joke, faking out the test, but
when I tried to be more responsible and put a whole <input type="hidden" etc.
in the comment, I realized that would be more likely to confuse someone
who thought that was uncommented and that they were making real changes than
it would be to future-proof against changes in the test's approach.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt