]> git.koha-community.org Git - koha.git/log
koha.git
2 years agoBug 31714: Add Generic way to print patron slips
Martin Renvoize [Fri, 7 Oct 2022 15:24:20 +0000 (16:24 +0100)]
Bug 31714: Add Generic way to print patron slips

This patch adds a very simple controller and template to allow patron
slip printing without all the boilerplate.

See bug 31713 for an example use.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31684: Plugin versions starting with a "v" cause unnecessary warnings
Kyle M Hall [Wed, 17 Mar 2021 14:44:31 +0000 (10:44 -0400)]
Bug 31684: Plugin versions starting with a "v" cause unnecessary warnings

Our code assumes that plugin version will be purely numeric ( e.g. 1.2.3 ) but many plugin authors ( including myself ) use the format "v1.2.3".
This causes warnings as we use a numeric comparison on the version numbers.
It could make sense to check for and strip any v's from the beginning of the version.

Test Plan:
1) Apply the first patch to set the test plugin's version to v1.01
2) prove t/db_dependent/Koha/Plugins/Plugins.t
3) Note the warnings and test failures
4) Apply this patch
5) prove t/db_dependent/Koha/Plugins/Plugins.t
6) All tests pass!

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31684: Set Koha::Plugin::Test version to 'v1.01'
Kyle M Hall [Wed, 5 Oct 2022 12:47:16 +0000 (12:47 +0000)]
Bug 31684: Set Koha::Plugin::Test version to 'v1.01'

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31803: Compiled CSS
Tomas Cohen Arazi [Fri, 21 Oct 2022 12:56:21 +0000 (09:56 -0300)]
Bug 31803: Compiled CSS

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31803: "remove from cart" button displayed even if not in cart
Owen Leonard [Thu, 20 Oct 2022 10:55:06 +0000 (10:55 +0000)]
Bug 31803: "remove from cart" button displayed even if not in cart

This patch modifies CSS related to the "Remove from cart" button
associated with bibligraphic record views. A change in specificity of
buttons made by Bug 30952 made it so that the button was no longer
hidden correctly.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Locate a bibliographic record in the staff interface and view the
  detail page.
- In the toolbar you should see an "Add to cart" button but not a
  "Remove from cart" button.
- The buttons should correctly toggle on and off as you add and remove
  the title from the cart.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31829: Fix change password form alignment
Lucas Gass [Wed, 19 Oct 2022 22:44:45 +0000 (22:44 +0000)]
Bug 31829: Fix change password form alignment

This patch gives the fieldset on member-password.tt the class row. It also moves the hints below the list.

To test:
1. Apply patch
2. Pull up a patron record and go to 'Change password'.
3. Make sure the form now looks good.
4. Also check and make sure the form is still functional.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31885: Define submit button as primary in renew page
Fridolin Somers [Thu, 20 Oct 2022 06:29:06 +0000 (20:29 -1000)]
Bug 31885: Define submit button as primary in renew page

Submit button in renew page is the most important action on this form, it should be yellow

Test plan :
1) Go to renew page /cgi-bin/koha/circ/renew.pl
2) Check submit button 'Submit' as class 'btn-primary' and is yellow

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31750: (follow-up) Stylelint fixes
Owen Leonard [Tue, 18 Oct 2022 17:34:16 +0000 (17:34 +0000)]
Bug 31750: (follow-up) Stylelint fixes

This patch makes no changes which affect the style of the page.
All changes are corrections to formatting.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31750: Need more padding in cataloguing
Owen Leonard [Tue, 18 Oct 2022 17:21:40 +0000 (17:21 +0000)]
Bug 31750: Need more padding in cataloguing

This patch makes some minor tweaks to the CSS controlling the appearance
of the toolbar shown in the basic cataloging editor.

To test, apply the patch and go to Cataloging -> New record.

- Confirm that the page looks correct, with the toolbar the same width
  as the main content of the page.
- Confirm that the toolbar looks correct when you scroll and the toolbar
  "floats"

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31811: Add 'page-section' to MARC modification templates pages
Owen Leonard [Thu, 20 Oct 2022 17:59:19 +0000 (17:59 +0000)]
Bug 31811: Add 'page-section' to MARC modification templates pages

This patch adds "page-section" divs to the MARC modification templates
template so that sections are properly defined and content has adequate
contrast.

Note: The patch includes indentation changes, so please ignore
whitespace when checking the diff.

To test, apply the patch and go to Cataloging -> MARC modification
templates.

The main content should be surrounded by a white box whether you're
looking at the list of templates, the the action add/edit form.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31738: Fix untranslatable string for recalls
Katrin Fischer [Sat, 15 Oct 2022 22:04:11 +0000 (00:04 +0200)]
Bug 31738: Fix untranslatable string for recalls

To test translation:
1. Apply patch and update your po files using:
   https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation
2. Verify the string appears in po files now and translate it
3. Install the language

To test functionality:
1. Turn on recalls
   1.1. In Administration > Global system preferences, enable UseRecalls
   1.2. Add recalls permissions in your circulation rules
2. In the OPAC, log in as a patron
3. Find a record with checked out items and place a recall
4. In the intranet, go to the patron file of the patron who currently has that item checked out
--> In the Checkouts table at the bottom of the page, there is a red message next to the recalled title

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31810: Define 'Place hold' button as primary
Fridolin Somers [Thu, 20 Oct 2022 01:42:50 +0000 (15:42 -1000)]
Bug 31810: Define 'Place hold' button as primary

When placing a hold in staff, the 'Place hold' button should be yellow for the most important action on this form.

Patch changes this button from btn-default to btn-primary.

Test plan :
Play with placing hold, one and several, with cases :
- normal
- override required
- none available

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31884: Define 'check in' button as primary
Fridolin Somers [Thu, 20 Oct 2022 06:20:35 +0000 (20:20 -1000)]
Bug 31884: Define 'check in' button as primary

Check in button in check in page is the most important action on this form, it should be yellow

Test plan :
1) Go to check in page /cgi-bin/koha/circ/returns.pl
2) Check submit button 'Check in' as class 'btn-primary' and is yellow

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 28375: (QA follow-up) Remove two remaining interface params
Marcel de Rooy [Mon, 17 Oct 2022 11:45:40 +0000 (11:45 +0000)]
Bug 28375: (QA follow-up) Remove two remaining interface params

No test plan: parameter is already obsolete.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 28375: (follow-up) Use C4::Context->interface
Nick Clemens [Fri, 7 Oct 2022 12:00:21 +0000 (12:00 +0000)]
Bug 28375: (follow-up) Use C4::Context->interface

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 28375: (follow-up) Remove guessed interface parameter - always pass
Nick Clemens [Fri, 30 Sep 2022 12:06:25 +0000 (12:06 +0000)]
Bug 28375: (follow-up) Remove guessed interface parameter - always pass

Previous patch added interface parameter passed on each call. There was an
existing one that 'guessed' - this patch removes that

Fixes missing comma

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 28375: Inefficiencies in fetching COinS
Nick Clemens [Tue, 18 May 2021 15:59:53 +0000 (15:59 +0000)]
Bug 28375: Inefficiencies in fetching COinS

This patchset adds an 'interface' parameter to XSLTParseForDisplay to avoid fetching
coins when not needed

Additionally we move some logic from the scripts to searchResults to avoid an extra fetch fo the biblio object

To test:
1 - Enable  COinSinOPACResults syspref
2 - Also enable  OPACShowOpenURL  and  OPACOpenURLItemTypes  - adding an itemtype that you can find
3 - Perform a search on the OPAC and confirm coins are included and openurl shown
4 - Perform a search on staff client and confirm openurls do not show
5 - Apply patch
6 - Results should be the same

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31728: Remove duplicate claims modal template markup
Owen Leonard [Mon, 10 Oct 2022 16:22:05 +0000 (16:22 +0000)]
Bug 31728: Remove duplicate claims modal template markup

This patch removes some markup which duplicates markup now in a
separate include file. modal-claims.inc contains the same
markup for #claims-returned-modal as checkouts.table.inc.

To test, apply the patch and make sure a LOST authorized value code
is defined in the  ClaimReturnedLostValue system preference.

- Check an item out to a patron, e.g. item 39999000001334 to patron
  23529000179433.
- In the table showing the patron's checkouts, click the "Claim
  returned" button.
- A "Claim returned" modal should appear.
- Click "Make claim."
- Switch to the "Claims" tab. You should see the item listed there.
- Check out another item, e.g. 39999000013313, to the patron and test
  the return claim process again from the patron detail page.
- Check out another item, e.g. 39999000018691, to the patron with a due
  date specified which is in the past.
- Go to Circulation -> Overdues. You should see the item in the list of
  overdues. Test that the "Claim returned" button works correctly on
  this page too.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31842: Fix DT search error on col.data.split
Marcel de Rooy [Mon, 17 Oct 2022 10:32:47 +0000 (10:32 +0000)]
Bug 31842: Fix DT search error on col.data.split

Set searchable to false for opac_info.

Test plan:
Check if DT search for libraries works again.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
[EDIT] Reverted the data/render function change as requested
by Jonathan. Considering the fact that dataTables or custom
extensions do not check col.data.split as a clear bug btw.
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31883: Filter trim causes false warnings
Mason James [Thu, 20 Oct 2022 00:26:17 +0000 (13:26 +1300)]
Bug 31883: Filter trim causes false warnings

Test plan:
Run xt/find-missing-filters.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 29012: Fix undef warnings around unseen_renewals_allowed in smart-rules.pl
Slava Shishkin [Tue, 11 Oct 2022 15:18:23 +0000 (18:18 +0300)]
Bug 29012: Fix undef warnings around unseen_renewals_allowed in smart-rules.pl

Trivial fix.

To reproduce:
1. Create or edit a rule on /cgi-bin/koha/admin/smart-rules.pl - i.e. submit the form (make POST request)
2. Notice the mentioned above warning in plack-intranet-error.log
3. Apply the patch.
4. Repeat step 1.
5. That warning in log file should be no more.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 29012: Fix existing update to prevent inserting incorrect data
Nick Clemens [Tue, 11 Oct 2022 12:40:51 +0000 (12:40 +0000)]
Bug 29012: Fix existing update to prevent inserting incorrect data

Both updates now rely on 'suspension_chargeperiod' as the source of truth
for existence of a rule. Spot checking some existing production databases this
seems to be acceptable.

This alters the update to only add rules where a 'suspension_chargeperiod' rule exists
and a value for the rule is not already set.

NOTE: While the table has a unique key:
UNIQUE KEY `branchcode` (`branchcode`,`categorycode`,`itemtype`,`rule_name`),

This key doesn't prevent duplicates on NULLs, i.e.:

branchcode  | categorycode  | itemtype  | rule_name                 | rule_value
NULL        | NULL          | BK        | unseen_renewals_allowed   | 1
NULL        | NULL          | BK        | unseen_renewals_allowed   | 2
NULL        | NULL          | BK        | unseen_renewals_allowed   | 3

So we need to both check that any rule is present and that the specific rule is not.
The 'INSERT IGNORE' won't IGNORE existing values except for the most specific rules

Test plan:
 0 - Edit and save existing default rule in DB (sample data does not include suspension_chargeperiod)
 1 - Set some rules for "Default checkout, hold and return policy" for "Standard rule" and some specific libraries
 2 - cp installer/data/mysql/db_revs/220600024.pl installer/data/mysql/atomicupdate/
 3 - SELECT * FROM circulation rules, note the number of rules that exist
 4 - updatedatabase
 5 - Check the DB again, you should now have rules as described in the bug
     i.e. You will have 5 new rules per 'Default checkout, hold and return policy'
 6 - apply 1st patch on bug
 7 - rm installer/data/mysql/atomicupdate/220600024.pl (so we don't add again)
 8 - updatedatabase
 9 - Check DB, the extra rules have been deleted
10 - Apply 2nd patch
11 - cp installer/data/mysql/db_revs/220600024.pl installer/data/mysql/atomicupdate/
12 - rm installer/data/mysql/atomicupdate/bug_31727.pl (so we can confirm update isn't adding rules)
13 - updatedatabase
14 - Confirm no change in rules since step 9
15 - git reset --hard (get deleted update back)
16 - rm installer/data/mysql/atomicupdate/220600024.pl

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31417: Update and reference cat-menu.inc
Martin Renvoize [Fri, 19 Aug 2022 11:18:46 +0000 (12:18 +0100)]
Bug 31417: Update and reference cat-menu.inc

This patch reinstates the cat-menu.inc include and references it from
the various 'tools' that are closely tied to cataloging.

We use the new cataloging home page submission as a reference for which
options should appear in the menu.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31162: (QA follow-up) Use new WRAPPPERs and fix help link
Katrin Fischer [Mon, 17 Oct 2022 20:18:16 +0000 (20:18 +0000)]
Bug 31162: (QA follow-up) Use new WRAPPPERs and fix help link

This migrates the start page to the new page structure using
WRAPPERs instead of includes. One visible problem before
was the missing help link.

Also makes sure the help link leads to the correct page :)

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31162: Add a cataloging module home page
Martin Renvoize [Fri, 15 Jul 2022 11:37:03 +0000 (12:37 +0100)]
Bug 31162: Add a cataloging module home page

This patch adds a new cataloging-home template and controller and
replaces most cases of links to addbooks.  This serves to provide a new
cataloging home page for the cataloging module and keeps it distinct
from the current addbooks page it partially replaces as a starting point
for cataloging.

We migrate most cataloging related tools from the 'Tools' module whilst
opting to move 'Rotating collections' to the 'Circulation' section of
the 'Tools' homepage. We also add links to the cataloging tab of system
preferences and a the adminstration pages if the user has the correct
permissions to have access to these areas.

Signed-off-by: KIT <michaela.sieber@kit.edu>
Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31626: DBRev 22.06.00.066
Tomas Cohen Arazi [Tue, 18 Oct 2022 12:54:08 +0000 (09:54 -0300)]
Bug 31626: DBRev 22.06.00.066

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31626: DBIC schema
Tomas Cohen Arazi [Tue, 18 Oct 2022 12:50:41 +0000 (09:50 -0300)]
Bug 31626: DBIC schema

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31626: (QA follow-up) Make db_rev robust
Tomas Cohen Arazi [Tue, 18 Oct 2022 12:48:59 +0000 (09:48 -0300)]
Bug 31626: (QA follow-up) Make db_rev robust

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31626: Add letter id to the message queue table
Kyle Hall [Mon, 26 Sep 2022 16:05:10 +0000 (12:05 -0400)]
Bug 31626: Add letter id to the message queue table

It can be useful to know exactly what template was used to generate a notice. To this end, it would be useful to store the letter id as a foreign key in the message queue table.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Restart all the things!
4) Run an action that will send a notice to a patron
5) Note the letter id is now in the message_queue table for that notice!

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 25426: DBRev 22.06.00.065
Tomas Cohen Arazi [Tue, 18 Oct 2022 12:38:05 +0000 (09:38 -0300)]
Bug 25426: DBRev 22.06.00.065

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 25426: (QA follow-up) Make subtest stand on its own
Tomas Cohen Arazi [Tue, 18 Oct 2022 12:35:17 +0000 (09:35 -0300)]
Bug 25426: (QA follow-up) Make subtest stand on its own

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 25426: (QA follow-up) Update notes on circulation rules page for new pref
Katrin Fischer [Mon, 3 Oct 2022 10:14:20 +0000 (12:14 +0200)]
Bug 25426: (QA follow-up) Update notes on circulation rules page for new pref

This adds a note to the circulation rules page that already
explained about ReservesControlBranch to also include information
about the new CircControlReturnsBranch system preference.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 25426: (QA follow-up) Rephrase CircControlReturnsBranch system preference description
Katrin Fischer [Mon, 3 Oct 2022 09:32:55 +0000 (11:32 +0200)]
Bug 25426: (QA follow-up) Rephrase CircControlReturnsBranch system preference description

Rephrased in hope to make its use a little clearer:
* 'logged in at' replaced with 'checked in at' keeping self checks in mind
* 'At checkin' rephrased a bit to explain possible options

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 25426: (QA follow-up) Small fixes to POD and INSERT IGNORE or datatabase update
Katrin Fischer [Mon, 3 Oct 2022 09:31:06 +0000 (11:31 +0200)]
Bug 25426: (QA follow-up) Small fixes to POD and INSERT IGNORE or datatabase update

* Makes sure the system preference is added with INSERT IGNORE
* Some smaller fixes/additions to the POD of get_return_branch_policy

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 25426: Allow return policy to be selected via syspref and not just home library
Kyle M Hall [Thu, 25 Aug 2022 13:05:32 +0000 (13:05 +0000)]
Bug 25426: Allow return policy to be selected via syspref and not just home library

1) Apply this patch
2) Run updatedatabase.pl
3) Verify CircControlReturnsBranch is set to home library by default
4) Set a Return policy for Branch A to "Item returns home" ( homebranch )
5) Set a Return polity for Branch B to "Item returns to issuing library" ( holdingbranch )
6) Set a Return polity for Branch C to "Item floats" ( noreturn )
7) Create an item with homebranch of Branch A, holding branch of branch B
8) Log in as Branch C
9) Set CircControlReturnsBranch to "the library the item is currently held by"
10) Check the item in, note it should be returned to the holding library
11) Set CircControlReturnsBranch to "the library the item is owned by"
12) Check the item in, note it should be returned to the home library
13) Set CircControlReturnsBranch to "the library you are logged in at"
14) Check the item in, note it should float

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 14783: (follow-up) Fix problematic db_rev
Tomas Cohen Arazi [Tue, 18 Oct 2022 12:02:44 +0000 (09:02 -0300)]
Bug 14783: (follow-up) Fix problematic db_rev

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 27265: (QA follow-up) Typo on L99 cron script
Marcel de Rooy [Mon, 17 Oct 2022 13:08:33 +0000 (13:08 +0000)]
Bug 27265: (QA follow-up) Typo on L99 cron script

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 27265: (follow-up) Use existing parameter
Nick Clemens [Fri, 30 Sep 2022 12:32:25 +0000 (12:32 +0000)]
Bug 27265: (follow-up) Use existing parameter

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 27265: Enable message queue cron to accept multiple codes and types
Kyle M Hall [Fri, 18 Dec 2020 13:45:06 +0000 (08:45 -0500)]
Bug 27265: Enable message queue cron to accept multiple codes and types

It would be nice to be able to combine several types in a single run,
but exclude others, without having to have multiple cron lines

Test Plan:
1) Apply this patch
2) Run process_message_queue.pl with a single -c parameter
3) Note behavior is unchanged
4) Run process_message_queue.pl with multiple -c parameters
5) Note all the codes specified are processed
6) Repeat 2-5 with -t for type limits

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 27315: use the namespace-aware docbook stylesheet
Andreas Roussos [Tue, 11 Oct 2022 06:41:15 +0000 (08:41 +0200)]
Bug 27315: use the namespace-aware docbook stylesheet

When viewing the man page for the `koha-list` command, the output does
not appear correctly: there appears to be a "staircase"-like effect on
the text. The same is true for all other man pages.

The source XML files for our man pages have the following namespace
declaration at the top: xmlns='http://docbook.org/ns/docbook', which
means they are DocBook V5.0 documents and should be processed by
namespace-aware DocBook XSL stylesheets.

This patch fixes that by using the DocBook-to-man-page transformation
stylesheet from the docbook-xsl-ns package (note the "-ns" suffix).

Test plan:
1) Apply the patch
2) Build and install new package
3) Confirm the man pages display correctly

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 28555: (follow-up) Add to script documenation
Nick Clemens [Mon, 17 Oct 2022 17:17:25 +0000 (17:17 +0000)]
Bug 28555: (follow-up) Add to script documenation

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 28555: (follow-up) Make verbose count flags passed
Nick Clemens [Wed, 12 Oct 2022 13:11:46 +0000 (13:11 +0000)]
Bug 28555: (follow-up) Make verbose count flags passed

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 28555: Improve logging for overdue_notices.pl
Nick Clemens [Fri, 11 Jun 2021 15:12:32 +0000 (15:12 +0000)]
Bug 28555: Improve logging for overdue_notices.pl

Currenlty the output with -v from overdue_notices is a bit overwhelming and hard to parse

I do a few things here:
1 - Only show SQL if verbose > 1
2 - Add some separators to make it more readab;e
3 - Remove some redundant messages with branchcode and borrowernumber

To test:
1: perl misc/cronjobs/overdue_notices.pl -v
2: Notice you get a LOT of information all smushed together
3: Apply patch
4: perl misc/cronjobs/overdue_notices.pl -v
5: Less info, and easier to read
6: perl misc/cronjobs/overdue_notices.pl -v -v
7: All the info, but nicer to read

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31835: Add page-section to holds queue
Lucas Gass [Mon, 17 Oct 2022 17:24:10 +0000 (17:24 +0000)]
Bug 31835: Add page-section to holds queue

To test:
1. Apply patch
2. Make some holds and then run build_holds_queue.pl
3. Look at the holds queue and make sure everything looks right with the new page-section.

Note:
I made some indentation and whitespace changes.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31569: (QA follow-up) Add missing entries in schema
Tomas Cohen Arazi [Mon, 17 Oct 2022 21:00:41 +0000 (18:00 -0300)]
Bug 31569: (QA follow-up) Add missing entries in schema

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 14783: DBRev 22.06.00.064
Tomas Cohen Arazi [Mon, 17 Oct 2022 20:33:34 +0000 (17:33 -0300)]
Bug 14783: DBRev 22.06.00.064

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 14783: Update atomicupdate syntax
Tomas Cohen Arazi [Mon, 17 Oct 2022 18:59:07 +0000 (15:59 -0300)]
Bug 14783: Update atomicupdate syntax

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 14783: Compiled CSS
Tomas Cohen Arazi [Mon, 17 Oct 2022 18:45:10 +0000 (15:45 -0300)]
Bug 14783: Compiled CSS

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 14783: (QA follow-up) Rename method and move tests
Tomas Cohen Arazi [Mon, 17 Oct 2022 18:43:22 +0000 (15:43 -0300)]
Bug 14783: (QA follow-up) Rename method and move tests

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 14783: (QA follow-up) Add unit tests.
Björn Nylén [Tue, 9 Nov 2021 14:40:22 +0000 (15:40 +0100)]
Bug 14783: (QA follow-up) Add unit tests.

This commit adds unit tests for Bug 14783.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 14783: (QA follow-up) Change "Pick up location" to "Pickup location" in table.
Björn Nylén [Tue, 9 Nov 2021 15:42:04 +0000 (16:42 +0100)]
Bug 14783: (QA follow-up) Change "Pick up location" to "Pickup location" in table.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 14783: (follow-up) Move pickup library form into modal
Owen Leonard [Wed, 28 Jul 2021 19:27:34 +0000 (19:27 +0000)]
Bug 14783: (follow-up) Move pickup library form into modal

This patch attemps to simplify the list of holds by moving the form for
changing a hold's pickup library into a modal dialog.

This patch also makes minor tweaks to the CSS for the "X" close button
shown in modal in windows. Instances where modal markup used "x" have
been updated to use the Bootstrap 4 standard "&times;"

To test, apply the patch and rebuild the OPAC
SCSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)

- Turn on the OPACAllowUserToChangeBranch system preference.
- Log in to the OPAC as a user with holds.
- In the view of your holds, confirm that each hold which can be
  modified shows a "Change" link.
- Clicking the link should show a modal window with the title of the
  item on hold shown in the header.
- Confirm that changing the pickup location works correctly.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 14783: Change pickup location from opac.
Björn Nylén [Fri, 7 Oct 2022 11:22:19 +0000 (11:22 +0000)]
Bug 14783: Change pickup location from opac.

This patch allows users to change the  pickup location for their holds
from the opac. A syspref (OPACAllowUserToChangeBranch) controls at what
stage a hold can be changed.

To test:
1. Set up holds with diffrent statuses for a patron (pending, waiting,
   in transit, suspended)
2. No pickup locations for any hold should be able to be changed.
3. Turn on and off the different options under
   OPACAllowUserToChangeBranch. Make sure that only the corresponding
   holds can be changed from the opac. Check eg in the staff client that
   pickup location has changed.
4. The available pickup locations should respect any transfer
   restrictions. (Same as the
   holds list for a biblio in staff client)
5. For an in-transit hold: Check in the item at the original pickup
   location.
6. Note that it will be redirected to the new location.

Sponsored-by: Lunds Universitetsbibliotek
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 21705: Map copyrightdate to both 260/264c by default for new MARC21 installations
Caroline Cyr La Rose [Thu, 2 Dec 2021 22:58:56 +0000 (17:58 -0500)]
Bug 21705: Map copyrightdate to both 260/264c by default for new MARC21 installations

This patch adds a mapping from 264 to biblio.copyrightdate.

To test:
1) Apply patch
2) Delete existing frameworks
   -  In the database
      delete from marc_tag_structure;
      delete from marc_subfield_structure;
      delete from biblio_framework;
3) Load default framework
   - In a terminal, run
     ./misc/load_yaml.pl -f installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml --load
4) In the staff interface, go to Administration > MARC bibliographic framework
   - Make sure the default framework is there
5) In Administration > Koha to MARC mapping, check the mappings for biblio.copyrightdate
   - biblioitems.publishercode should be mapped to 260 as well as 264
6) Create a bibliographic record with a value in 264
   - In the database, check the biblio entry for this record, the value from 264 should be in copyrightdate
7) Create a bibliographic record with a value un 260
   - In the database, check the biblio entry for this record, the value from 264 should be in copyrightdate

I hope I didn't forget anything! :)

Caroline

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31781: Add page-section to branchtransfers page
Lucas Gass [Thu, 13 Oct 2022 22:18:32 +0000 (22:18 +0000)]
Bug 31781: Add page-section to branchtransfers page

This patch adds the page-section div to 2 tables on the branch transfer page.

To test:
1. Apply patch
2. Place an item level hold on a few items.
3. Now go to the branch transfer page and try transferring your items that have holds on them.
4. This should bring up a 'Reserve found' page. Look at the table and make sure it looks good with the page-section div added.
5. Now try some transfers that do not have holds. Make sure the table that populates also goods good with the page-section div added.

Note: There are some indentation changes.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31252: Advanced search in staff interface should call barcodedecode if the search...
Kyle Hall [Thu, 28 Jul 2022 12:35:33 +0000 (08:35 -0400)]
Bug 31252: Advanced search in staff interface should call barcodedecode if the search index is a barcode

We should run any inputted barcode through barcodedecode before passing it to any subroutines.
This was missed during the initial development of bug 26351.

Test Plan:
1) Set itemBarcodeInputFilter to "Remove spaces from"
2) Browse to the staff side advanced search
3) Run a barcode search for "MY TEST"
4) Note the message returned is:
   No results match your search for 'bc,wrdl: "MY TEST"'.
5) Apply this patch
6) Restart all the things!
7) Repeat your search
8) Note the message returned is:
   No results match your search for 'bc,wrdl: "MYTEST"'.
9) Note the lack of the space between MY and TEST!

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31808: Compiled CSS
Tomas Cohen Arazi [Mon, 17 Oct 2022 11:27:56 +0000 (08:27 -0300)]
Bug 31808: Compiled CSS

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31775: Template cleanup
Marcel de Rooy [Thu, 13 Oct 2022 14:12:07 +0000 (14:12 +0000)]
Bug 31775: Template cleanup

Removing unused parts.

Test plan:
See first test plan. Confirm that it still works.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31775: Show single library
Marcel de Rooy [Thu, 13 Oct 2022 12:49:31 +0000 (14:49 +0200)]
Bug 31775: Show single library

Test plan:
Check both cases: one library (public accessible) and more
libraries (public accessible). In the latter case click on
one of these libraries too.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31808: Set fieldset.rows li width to 100%
Lucas Gass [Fri, 14 Oct 2022 23:21:44 +0000 (23:21 +0000)]
Bug 31808: Set fieldset.rows li width to 100%

To test:
1. Find an item and try placing a hold.
2. Under 'Hold details' the first list element is the patron name, it displays far to the right in an unusual location.
3. Apply patch and regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface )
4. Try steps 1 & 2 again.
5. The name should display correctly.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31569: DBRev 22.06.00.063
Tomas Cohen Arazi [Mon, 17 Oct 2022 11:23:36 +0000 (08:23 -0300)]
Bug 31569: DBRev 22.06.00.063

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31569: DBIC schema
Tomas Cohen Arazi [Mon, 17 Oct 2022 11:18:44 +0000 (08:18 -0300)]
Bug 31569: DBIC schema

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31569: (QA follow-up) Remove additional spaces from ISBN/ISSN
Katrin Fischer [Fri, 7 Oct 2022 14:26:09 +0000 (14:26 +0000)]
Bug 31569: (QA follow-up) Remove additional spaces from ISBN/ISSN

Before this change, the ISBN woudl display like: ( isbn )
This patch removes the additional spaces so the display is
the same as without this patch set on current master: (isbn)

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31569: Add filters
Nick Clemens [Thu, 15 Sep 2022 13:54:08 +0000 (13:54 +0000)]
Bug 31569: Add filters

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31569: Remove unecessary imports
Nick Clemens [Thu, 15 Sep 2022 13:50:35 +0000 (13:50 +0000)]
Bug 31569: Remove unecessary imports

By using objects a number of other routines are not needed:
GetImportRecordMarc SetImportRecordStatus SetMatchedBiblionumber

To test:
Grep for routines above in addorderiso2709 and confirm they are not used

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31569: Remove GetImportRecordsRange from list step
Nick Clemens [Thu, 15 Sep 2022 13:47:07 +0000 (13:47 +0000)]
Bug 31569: Remove GetImportRecordsRange from list step

This patch removes the use of GetImportRecordsRange from the step
of listing import batches to choose. It was only used for a count so is a simple
replacement

To test:
1 - Stage a number of files for import
2 - Import one of the files from tools
3 - Add to basket form a staged file
4 - Confirm staged baskets are listed, and imported basket is not

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31569: Remove GetImportRecordsRange from import stage
Nick Clemens [Thu, 15 Sep 2022 13:35:37 +0000 (13:35 +0000)]
Bug 31569: Remove GetImportRecordsRange from import stage

This patch removes the use of GetimportRecordsRange from the importing
step

To test:
 0 - Apply patch
 1 - Stage a marc file for import
 2 - Add to basket from a staged file
 3 - Select titles to import (don't select all)
 4 - Fill out necessary fields, be sure to select itemtype on items tab
 5 - Import
 6 - Confirm titles successfully added to basket
 7 - Confirm staged import not marked as imported
 8 - Add to basket from same file
 9 - Select rest of titles
10 - Import
11 - Confirm staged file now marked imported

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31569: Remove GetImportRecordsRange from import_biblios_list
Nick Clemens [Thu, 15 Sep 2022 12:47:37 +0000 (12:47 +0000)]
Bug 31569: Remove GetImportRecordsRange from import_biblios_list

This patch changes the way records are loaded for display when adding to
a basket from a staged file

To test:
1 - Stage a file of records for import
2 - Go to Acquisitions, find a vendor, create or find a basket
3 - Add to basket from staged file
4 - Choose the file
5 - Note the display of records
6 - Cancel
7 - Apply patch
8 - Stage from same file
9 - Note the display is unchanged

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31569: DB update and objects
Nick Clemens [Thu, 15 Sep 2022 12:42:56 +0000 (12:42 +0000)]
Bug 31569: DB update and objects

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31776: Fix a typo in cleanup_database.pl cronjob's help/usage
Petro Vashchuk [Thu, 13 Oct 2022 14:37:24 +0000 (17:37 +0300)]
Bug 31776: Fix a typo in cleanup_database.pl cronjob's help/usage

cleanup_database.pl cronjob has a typo in it's usage/help:
"preserve-logs" option should be "preserve-log" as it is everywhere
in the code.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31780: Add page-section class to audio alerts
Lucas Gass [Thu, 13 Oct 2022 19:56:50 +0000 (19:56 +0000)]
Bug 31780: Add page-section class to audio alerts

To test:

1. Apply the patch and go to Administration -> Audio alerts
2. Confirm that the screen/table look correct with the page-section class added.

Note: There are some indentation changes.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 28967: Patrons with no checkouts report shows patrons from other libraries with...
The Minh Luong [Wed, 26 Jan 2022 21:22:19 +0000 (16:22 -0500)]
Bug 28967: Patrons with no checkouts report shows patrons from other libraries with IndependentBranches

When IndependentBranches is activated and a non-superlibrarian user looks at the "Patrons with no checkouts" report, it shows patrons from other libraries.

To recreate:
1) Activate IndependentBranches, IndependentBranchesPatronModifications and IndependentBranchesTransfers
2) Create a staff user with limited permissions (NOT a superlibrarian), including reports permissions. Here are mine as an example
  - circulate (all)
  - catalogue
  - borrowers
    - delete_borrowers
    - edit_borrowers
  - reserveforothers (all)
  - reports (all)
3) Create (or make sure you already have) a patron in another branch (if using an existing patron, make sure they have no checkouts or checkout history)
4) Log in as your limited staff patron
5) Go to Reports > Inactive > Patrons who haven't checked out
6) Don't put in any limitations and click Submit
-- The patron from the other library appears in the list
7) Try to search for that other patron in the patron module
-- The patron from the other library is inaccessible
8) Apply the patch
9) Notice that the limited patron can only see patrons from his own
library

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31807: Context for translation: Filter (verb) vs. Filter (noun)
Caroline Cyr La Rose [Fri, 14 Oct 2022 20:34:33 +0000 (16:34 -0400)]
Bug 31807: Context for translation: Filter (verb) vs. Filter (noun)

This patch add the context 'noun' to the 'Filter' string in
marc-overlay-rules.tt. This will separate that instance of 'Filter' from
the other ones, where it is meant as a verb.

To test:
1. Apply patch
2. Visit Administration > MARC overlay rules, make sure the page works
(no errors) and that there is a column called 'Filter'
3. Update the po files

gulp po:update --lang xx-XX

for example, gulp po:update --lang fr-CA

4. Check the xx-XX-messages.po file (e.g.
misc/translator/po/fr-CA-messages.po), there should be an entry for
'Filter', with a line msgctxt that gives the 'noun' context
5. Update the file with a random word for the 'Filter' translation
for example, I translated 'Filter' by 'Filter as a noun', just to see
the difference

\#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt:83
msgctxt "noun"
msgid "Filter"
msgstr "Filter as a noun"

6. Install a new language
6.1. Run the following commands in the terminal, replacing xx-XX with
the language code (e.g. fr-CA)

cd misc/translator
./translate install xx-XX

6.2. In the Koha staff interface, go to Administration > Global system
preferences
6.3. Search for language
6.4. Check the box next to the new language
6.5. Save

7. View the MARC overlay rules page in the new language, the 'Filter'
column heading should be whatever you put in step 5

Optional test
8. In the staff interface in English, view one or more of these pages,
the 'Filter' should be unchanged
- Acquisitions > Late orders (Filter button)
- Aquisitions > Search for vendor > Receive shipments (Filter heading on
the left and Filter button)
- Acquisitions > Search for vendor > Click vendor's name > Uncertain
prices (Filter button)
- Administration > Budgets > Click budget's name > Planning > Plan by
... (any option) (Filter heading on the left)
- Reports > Use saved (Filter heading on the left)
- Reports > Acquisitions statistics wizard (Filter column heading)
- Reports > Patrons statistics wizard (Filter column heading)
- Reports > Catalog statistics wizard (Filter column heading)
- Reports > Circulation statistics wizard (Filter column heading)
- Reports > Holds statistics wizard (Filter column heading)
- Reports > Average loan time (Filter column heading)
- Tools > News (Filter heading on the left)

9. View these same pages in the other language, the Filter should NOT be
changed to whatever you put in step 5

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 30487: Compiled CSS
Tomas Cohen Arazi [Mon, 17 Oct 2022 11:07:12 +0000 (08:07 -0300)]
Bug 30487: Compiled CSS

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 30487: Convert checkout and patron details page tabs to Bootstrap
Owen Leonard [Thu, 7 Apr 2022 10:54:38 +0000 (10:54 +0000)]
Bug 30487: Convert checkout and patron details page tabs to Bootstrap

This patch updates the checkout and patron details pages, updating
jQueryUI tabs to Bootstrap tabs.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Go to Circulation -> Check out and load a patron record for checkout.
Ideally the patron record should have a variet of data associated with
it:

 - Checkouts
 - Relative's checkouts (if patron is a guarantor or guarantee to
   another patron with checkouts)
 - Holds
 - Article requests
 - Claims
 - Restrictions
 - Clubs

On the patron's checkout page, test the various tabs corresponding to
the features listed above. Having data to display in those tabs helps
confirm that any table functionality triggered by the tab activation is
working correctly.

The checkouts tab should work correctly whether you have "Always show
checkouts immediately" checked or not.

Test that you can pre-select any tab by appending its anchor to the URL,
e.g.:

/cgi-bin/koha/circ/circulation.pl?borrowernumber=123#reserves

Perform the same checks on the patron details page.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31762: Flatten page-section
Martin Renvoize [Thu, 13 Oct 2022 11:38:09 +0000 (12:38 +0100)]
Bug 31762: Flatten page-section

This patch removes the box-shadow from our 'card' mixin and thus makes
page-section and other similar content area blocks look flat

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31747: Compiled CSS
Tomas Cohen Arazi [Mon, 17 Oct 2022 11:03:59 +0000 (08:03 -0300)]
Bug 31747: Compiled CSS

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31773: Add page-section class to Manage staged MARC records page
Lucas Gass [Thu, 13 Oct 2022 20:23:59 +0000 (20:23 +0000)]
Bug 31773: Add page-section class to Manage staged MARC records page

To test:
1. Apply patch
2. Have some MARC records and stage them for import. It will be nessesary to add more than 1
3. Go to the Manage staged MARC records page and make sure the table looks right with the page-section added.

Note: I am also adding the Bootstrap table class to this table becuase I think it makes the table look much nicer.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31766: Add page-section wrapper to notice table
Lucas Gass [Thu, 13 Oct 2022 15:52:46 +0000 (15:52 +0000)]
Bug 31766: Add page-section wrapper to notice table

To test:
1. Apply patch
2. Look at the noitce page and notice how the table, and it's tools, now are wrapped with the page-section element.
3. Is it better than it was before?

Feel free to osboslete these patch and replace it with your own.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31764: Add 'page-section' to patron clubs page
Owen Leonard [Thu, 13 Oct 2022 18:09:21 +0000 (18:09 +0000)]
Bug 31764: Add 'page-section' to patron clubs page

This patch updates patron clubs template so that the main content of
the page is wrapped with a "page-section" div. This ensures that content
has sufficient contrast. See Bug 31757.

Note: This patch contains indentation changes, so use diff accordingly.

To test, apply the patch and go to Tools -> Patron clubs.

- If necessary, add at least one club template and at least one club
  based on that template.
- Confirm that the display of club templates and clubs looks correct.
- Locate some patrons and add them to a club.
- On the patron clubs page, locate a club with enrollments and click
  Actions -> Enrollments. Confirm that the page looks correct.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31767: Add 'page-section' to tags page
Owen Leonard [Thu, 13 Oct 2022 18:07:07 +0000 (18:07 +0000)]
Bug 31767: Add 'page-section' to tags page

This patch updates tags templates so that the main content of
the page is wrapped with a "page-section" div. This ensures that content
has sufficient contrast. See Bug 31757.

Note: This patch contains indentation changes, so use diff accordingly.

To test, apply the patch and go to Tools -> Tags.

- Confirm that the content area of the page looks correct.
- Click one of the tag terms to view the list of titles tagged with that
  term. Confirm that this page looks correct too.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31758: (follow-up) Add padding between adjacent sections
Owen Leonard [Thu, 13 Oct 2022 10:51:45 +0000 (10:51 +0000)]
Bug 31758: (follow-up) Add padding between adjacent sections

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Edit: changed the subject

2 years agoBug 31758: Add page-section div around subsections
Martin Renvoize [Thu, 13 Oct 2022 08:51:16 +0000 (09:51 +0100)]
Bug 31758: Add page-section div around subsections

An alternative that puts adds a new page-section div around each
preference subsection rather than around the whole tab section.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Edit: changed the title

2 years agoBug 31747: Use page-section class, reduce CSS
Martin Renvoize [Thu, 13 Oct 2022 09:50:15 +0000 (10:50 +0100)]
Bug 31747: Use page-section class, reduce CSS

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31747: Give area-news box new staff design look
Lucas Gass [Wed, 12 Oct 2022 22:09:22 +0000 (22:09 +0000)]
Bug 31747: Give area-news box new staff design look

To test:
1. Apply patch
2. Regenerate staff CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface )
3. Look at the #area-news element of the mainpage.
4. There should be no rounded corners and the box-shadow should be the same as seen elsewhere ( i.e. patron details page )

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31595: Don't process extended attributes if none are inlcuded in the file
Nick Clemens [Wed, 21 Sep 2022 16:10:34 +0000 (16:10 +0000)]
Bug 31595: Don't process extended attributes if none are inlcuded in the file

This patch simply adds a check to the import process to only process attrbutes if
they have been found in the data

To test:
1 - Import some patrons without extended attributes
2 - Import patrons including extended attributes
3 - Confirm both work unchanged

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31785: (follow-up) Fix modify operation too
Marcel de Rooy [Fri, 14 Oct 2022 09:07:14 +0000 (09:07 +0000)]
Bug 31785: (follow-up) Fix modify operation too

Test plan:
Enable SQL strict mode (koha-conf).
Modify branch, set Public to No.
Check.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31785: Fix for adding non-public library
Marcel de Rooy [Fri, 14 Oct 2022 07:42:26 +0000 (07:42 +0000)]
Bug 31785: Fix for adding non-public library

The code in admin/branches.pl changed a 0 to undef which is not
desirable for booleans.
A similar fix was already present for pickup_location.
This may need a bit more thought (somewhere else!).

Test plan:
Add a new branch with pickup location No, public No.
Check.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31724: Remove 'i' from breadcrumb when deleting a MARC framework subfield
David Nind [Sun, 9 Oct 2022 21:44:37 +0000 (21:44 +0000)]
Bug 31724: Remove 'i' from breadcrumb when deleting a MARC framework subfield

Remove 'i' added to the end of the breadcrumb on the confirmation page
when deleteing a MARC framework subfield.

Test plan:
1. Go to Administration > MARC bibliographic frameworks.
2. View the subfields for a tag for a framework, for example:
   . BKS framework > Actions > MARC structure
   . Search for tag 245
   . Select Actions > View subfields.
3. Select any subfield to delete and select the Delete button.
4. Note that there is an 'i' at the end of the breadcrumb, for example:
   . ... > Confirm deletion of subfield bi
5. Apply the patch.
6. Refresh the page and note that that 'i' is removed.
7. Sign off.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31763: Add 'page-section' to patron lists page
Owen Leonard [Thu, 13 Oct 2022 17:47:35 +0000 (17:47 +0000)]
Bug 31763: Add 'page-section' to patron lists page

This patch updates patron lists templates so that the main content of
the page is wrapped with a "page-section" div. This ensures that content
has sufficient contrast. See Bug 31757.

Unrelated change: I wrapped some form controls in a <fieldset> to make
it consistent with other pages and to work better with the updated
markup.

Note: This patch contains indentation changes, so use diff accordingly.

To test, apply the patch and go to Tools -> Patron lists.

- If necessary, create one or more patron lists so that the table
  appears. Confirm that the content area looks correct.
- Click Actions -> Add patrons to confirm that the screen
  looks correct.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31437: (bug 30718 follow-up) Prevent useless indexation call from ModDateLastSeen
Jonathan Druart [Fri, 14 Oct 2022 09:04:40 +0000 (11:04 +0200)]
Bug 31437: (bug 30718 follow-up) Prevent useless indexation call from ModDateLastSeen

Koha::Object->store is triggering an UPDATE because the datelastseen is
different than the value in DB (comparing a datetime with a date)

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoRevert "Bug 30718: (follow-up) index_records is called more times than we thought"
Jonathan Druart [Fri, 14 Oct 2022 08:57:30 +0000 (10:57 +0200)]
Revert "Bug 30718: (follow-up) index_records is called more times than we thought"

This reverts commit 35165e5f13ec11a62dea7f6b129f7f07c7ecb7f4.

https://bugs.koha-community.org/show_bug.cgi?id=31437
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 29554: Do not hide display of itemtypes on neworderempty
Marcel de Rooy [Mon, 22 Nov 2021 13:00:57 +0000 (13:00 +0000)]
Bug 29554: Do not hide display of itemtypes on neworderempty

Hiding the list may lead to biblioitems.itemtype being NULL.
We do not want that, since 942$c is mandatory.

Test plan:
Create basket and set 'create items when' to receiving or
cataloging.
Create order from new empty record.
Check biblioitems.itemtype of created biblio.
Without this patch, it would have been NULL like this:
    select biblionumber,title from biblio;
    |            7 | Test 3                |
    select biblionumber,itemtype from biblioitems;
    |            7 | NULL     |

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 31749: Fix detail display when not display cover images
Lucas Gass [Wed, 12 Oct 2022 21:56:49 +0000 (21:56 +0000)]
Bug 31749: Fix detail display when not display cover images

To test:
1. Apply patch
2. Have none of the image services turned on:
AmazonCoverImages
LocalCoverImages
IntranetCoce
SyndeticsCovers
3. Look at the detail page, things should look right.
4. Turn on some of these image services, things should still look right.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 30952: Compiled CSS
Tomas Cohen Arazi [Wed, 12 Oct 2022 19:16:33 +0000 (16:16 -0300)]
Bug 30952: Compiled CSS

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 30952: (follow-up) Restore DataTable sorting icons
Owen Leonard [Wed, 28 Sep 2022 16:43:53 +0000 (16:43 +0000)]
Bug 30952: (follow-up) Restore DataTable sorting icons

Some CSS was removed which controlled the appearance of DataTables
column sort icons. Without it, DataTables tries to use some default
images which do not exist.

This patch restores the icons. With it, sorting icons should look like
they do in master and there should be no related 404 errors in the
console.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 30952: (follow-up) Avoid nav menu jump between bold and normal
Owen Leonard [Wed, 28 Sep 2022 15:37:36 +0000 (15:37 +0000)]
Bug 30952: (follow-up) Avoid nav menu jump between bold and normal

I think styling links with a bold hover state results in a "jumpy" look,
and I seem to recall making changes in the past to issues like in
response to bug reports.

I'd like to propose an alternative style for the nav menu which uses
color changes to indicate the hover state. This menu can be seen in the
sidebar of patron details, bibliographic details, etc.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 30952: Fix style of datatables buttons when not inside a .pager
Julian Maurice [Wed, 28 Sep 2022 14:38:25 +0000 (16:38 +0200)]
Bug 30952: Fix style of datatables buttons when not inside a .pager

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 30952: Make the top left logo clickable area wider
Julian Maurice [Wed, 28 Sep 2022 14:16:28 +0000 (16:16 +0200)]
Bug 30952: Make the top left logo clickable area wider

Issue #35

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2 years agoBug 30952: Fix patroninfo-section alignment
Julian Maurice [Wed, 28 Sep 2022 13:48:20 +0000 (15:48 +0200)]
Bug 30952: Fix patroninfo-section alignment

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>