From 1476c17cda5b973f1e07e7963d03023e61865890 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Wed, 26 Jan 2022 15:54:28 +0000 Subject: [PATCH] Bug 29915: (QA follow-up) Add a comment in checkauth on $flags This is quite a misleading call. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall --- C4/Auth.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/C4/Auth.pm b/C4/Auth.pm index 3bd6689031..94a8d750fc 100644 --- a/C4/Auth.pm +++ b/C4/Auth.pm @@ -879,6 +879,7 @@ sub checkauth { } elsif ( $sessionID = $query->cookie("CGISESSID") ) { # assignment, not comparison my ( $return, $more_info ); + # NOTE: $flags in the following call is still undefined ! ( $return, $session, $more_info ) = check_cookie_auth( $sessionID, $flags, { remote_addr => $ENV{REMOTE_ADDR}, skip_version_check => 1 } ); -- 2.39.5