From 205a1db4a4cfdb6af4f88eb2393ddf26a0a29d2a Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Tue, 11 Nov 2014 20:01:59 -0500
Subject: [PATCH] Bug 13236 - Regression: Table of checkouts no longer
 preselects overdue items for rewewal

Before Bug 11703, overdue items in the list of a patrons checkouts had
the renewal checkbox preselected so that librarians could quickly renew
only those items which required it. This is not longer the case.

This patch corrects it. To test, apply the patch and clear your browser
cache. Check out to a patron who has overdues and confirm that the
overdue items have the "renew" checkbox preselected. Check that items
which are not overdue are not preselected.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, no problems found.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>

Conflicts:
	koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js
---
 .../intranet-tmpl/prog/en/js/checkouts.js     | 23 ++++++++++++-------
 1 file changed, 15 insertions(+), 8 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js
index 8ffb04b5e9..c9d99ea24e 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js
+++ b/koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js
@@ -279,17 +279,24 @@ $(document).ready(function() {
                             +  "<input type='checkbox' class='renew' id='renew_" + oObj.itemnumber + "' name='renew' value='" + oObj.itemnumber +"'/>"
                             +  "</span>";
 
-                    if ( oObj.renewals_remaining ) {
-                        content += "<span class='renewals'>("
-                                + RENEWALS_REMAINING.format( oObj.renewals_remaining, oObj.renewals_allowed )
-                                + ")</span>";
-                    }
+                    if ( oObj.renewals_remaining && oObj.onsite_checkout == 0 ) {
+                            content += "<span class='" + span_class + "' style='" + span_style + "'>"
+                                    +  "<input type='checkbox' ";
+                            if ( oObj.date_due_overdue ) {
+                                content += "checked='checked' ";
+                            }
+                            content += "class='renew' id='renew_" + oObj.itemnumber + "' name='renew' value='" + oObj.itemnumber +"'/>"
+                                    +  "</span>";
 
-                    content += "</span>";
+                            content += "<span class='renewals'>("
+                                    + RENEWALS_REMAINING.format( oObj.renewals_remaining, oObj.renewals_allowed )
+                                    + ")</span>";
+                        }
 
+                        content += "</span>";
 
-                    return content;
-                }
+                        return content;
+                    }
             },
             {
                 "bSortable": false,
-- 
2.39.5