]> git.koha-community.org Git - koha.git/log
koha.git
5 years agoBug 17140: Atomic update file
Nick [Fri, 4 Oct 2019 08:15:43 +0000 (08:15 +0000)]
Bug 17140: Atomic update file

Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 17140: Make rounding syspref controlled
Nick [Thu, 3 Oct 2019 11:06:47 +0000 (11:06 +0000)]
Bug 17140: Make rounding syspref controlled

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 17140: fix rounding errors when paying fines
Blou [Fri, 21 Dec 2018 15:33:29 +0000 (10:33 -0500)]
Bug 17140: fix rounding errors when paying fines

Whenever a fine (accountlines in DB) has a precision longer than two floating points, it becomes very hard for a user to clear it.
Ex: 1.035 will be displayed as 1.04 or 1.03 depending on the screen.  But entering any of those value in Pay Fine will not clear it.
The user has no way to know the exact value to enter.

This fix makes sure that the intent of the user is met, by matching the EXACT needed sum when the difference is less than 0.01.

TEST
1) Create a 1.035 fine
  - Go to a Patron screen
  - Fines tab on the left
  - Create manual invoice
2) go to Pay fines, click Pay amount on bottom left.
3) It will show 1.03 as Total, and as Collect from patron.  Click confirm.
4) An error message will appear.
5) Apply patch, do again.

Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 23626: (follow-up) Fix JS when not viewing results
Nick [Thu, 10 Oct 2019 16:40:55 +0000 (16:40 +0000)]
Bug 23626: (follow-up) Fix JS when not viewing results

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 20780: (follow-up) Use Koha::Object
Martin Renvoize [Wed, 31 Oct 2018 14:41:12 +0000 (14:41 +0000)]
Bug 20780: (follow-up) Use Koha::Object

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 20780: Add handling for AcqItemSetSubfieldsWhenRecieved in EDI
Martin Renvoize [Fri, 18 May 2018 15:56:26 +0000 (16:56 +0100)]
Bug 20780: Add handling for AcqItemSetSubfieldsWhenRecieved in EDI

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 21580: Pass buyer_ean to create_edi_order
Colin Campbell [Tue, 16 Oct 2018 15:27:17 +0000 (16:27 +0100)]
Bug 21580: Pass buyer_ean to create_edi_order

create_edi_order requires two parameters to be passed
but if vendor was set to auto_order the subroutine
was called with basketno only resulting in the error
'no basket or ean passed' - pass the buyer_ean as
passed in the quotes message

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 21580: Add test for message buyer_ean method
Colin Campbell [Tue, 16 Oct 2018 15:21:49 +0000 (16:21 +0100)]
Bug 21580: Add test for message buyer_ean method

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 20334: (RM follow-up) Fix test for case insensative filesystems 2
Martin Renvoize [Wed, 9 Oct 2019 14:03:06 +0000 (15:03 +0100)]
Bug 20334: (RM follow-up) Fix test for case insensative filesystems 2

This patch moves the Elasticsearch/Indexer.t to ElasticSearch/Indexer.t
and thus removes the case directory name collision introduced.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 20334: (RM follow-up) Fix test for case insensative filesystems
Martin Renvoize [Wed, 9 Oct 2019 14:03:06 +0000 (15:03 +0100)]
Bug 20334: (RM follow-up) Fix test for case insensative filesystems

This patch moved the tests created in Elasticsearch/QueryBuilder.t into
ElasticSearch/QueryBuilder.t and thus removes the case directory name
collision introduced.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 17179: DBRev 19.06.00.039
Martin Renvoize [Wed, 9 Oct 2019 13:37:39 +0000 (14:37 +0100)]
Bug 17179: DBRev 19.06.00.039

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 17179: (follow-up) Add to keyboard_shortcuts.sql
Nick [Mon, 7 Oct 2019 23:25:38 +0000 (23:25 +0000)]
Bug 17179: (follow-up) Add to keyboard_shortcuts.sql

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 17179: (follow-up) Correct typos, add default select.
Alex Sassmannshausen [Thu, 3 Oct 2019 13:36:26 +0000 (15:36 +0200)]
Bug 17179: (follow-up) Correct typos, add default select.

Correct error whereby object curCursor was invoked as a function.

Added action whereby the most recent entry in the clipboard is
selected after all copy and cut operations.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 17179: Add keyboard shortcuts to repeat (duplicate) a field, and cut text
Nick Clemens [Wed, 20 Feb 2019 17:30:36 +0000 (17:30 +0000)]
Bug 17179: Add keyboard shortcuts to repeat (duplicate) a field, and cut text

This patchset introduces an internal clipboard to the advanced editor
and provides some new functionality to make use of this, default shortcuts are provided
but can be edited per bug 21411

The default shortcuts for new/changed functions are:

Changed:
Ctrl-X:       Now cuts a line into the clipboard area
Shift-Ctrl-X: Now cuts current subfield into clipboard area

Added:
Ctrl-C:       Copies a line into the clipboard area
Shift-Ctrl-C: Copies current subfield into clipboard area
Ctrl-P:       Pastes the selected item from the clipboard at cursor
Ctrl-I:       Copies the current line and inserts onto a new line below

To test:
Verify all functionality above and confirm it behaves as expected

Note:
Ctrl-v pastes from the system clipboard - codemirror does not have
access and this is why we use our "Clipboard"

For browser cut/paste please use mouse right click or context menus

Ctrl-P can be accessed as print by focusing outside the editor window

Signed-off-by: Alex Sassmannshausen <alex@komputilo.eu>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 23626: Add missing TT failure
Kyle M Hall [Wed, 9 Oct 2019 12:28:32 +0000 (08:28 -0400)]
Bug 23626: Add missing TT failure

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 23626: [alternate] Default to including all rows
Kyle M Hall [Mon, 7 Oct 2019 16:34:07 +0000 (12:34 -0400)]
Bug 23626: [alternate] Default to including all rows

If a person is fetching all data, it seems most likely that that person wants
to see all the data in the chart. We should default to that behavior.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 23626: Only fetch full chart data if requested
Nick [Wed, 2 Oct 2019 09:58:59 +0000 (09:58 +0000)]
Bug 23626: Only fetch full chart data if requested

This patchset prevents the full return of report data unless explicitly requested by the user for charting purposes
Additionally the user is warned if requesting more than 1000 rows of data

To test:
 1 - Create a report that returns over 1000 rows of data
 2 - Run the report
 3 - Note you have two buttons now 'Chart data' and 'Fetch all data for chart'
 4 - Click chart data
 5 - Note the note that you are only charting visible data
 6 - Create the chart and confirm it works
 7 - Close the chart
 8 - Click 'Fetch all data'
 9 - Note the confirm window
10 - Click 'cancel', note there is no change
11 - Repeat and click ok
12 - Fetch all data button is gone
13 - Page to next data, note fetch all does not return
14 - Click 'Chart data'
15 - Note you now have checkbox option to use all data in report
16 - Click it
17 - Create chart
18 - Confirm it works as expected

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 23778: Regression: Guarantor entry section no longer has a unique id
Owen Leonard [Tue, 8 Oct 2019 14:18:01 +0000 (14:18 +0000)]
Bug 23778: Regression: Guarantor entry section no longer has a unique id

This patch adds back a fieldset ID which was accidentally removed by Bug
14570:

<fieldset id="memberentry_guarantor" class="rows">

This ID is important if libraries want to customize the patron entry
page to hide the guarantor section.

To test, apply the patch and go to Patrons -> New patron.

Inspect the markup and look at the fieldset labeled "Guarantor
information." It should have the correct ID attribute.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 22927: Do not check an already lost item when marked as withdrawn or damaged
Jonathan Druart [Sat, 8 Jun 2019 20:34:24 +0000 (15:34 -0500)]
Bug 22927: Do not check an already lost item when marked as withdrawn or damaged

Due to how moredetail.pl was written it was hard to know which action
was triggered.

Test plan:
- Set MarkLostItemsAsReturned to "from the items tab of the catalog
module."
- Check an item out to a patron
- Use additem.pl to set that item to a lost status without returning it
- go to moredetail.pl for that item
- mark item as either damaged or withdrawn without interacting with the
lost dropdown
- note that item has not been returned

Note for QA: Maybe we could have just tested if exists $item_changes->{'itemlost'}
to call LostItem

Signed-off-by: Claudie Trégouët <claudie.tregouet@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 22997: Unit test
Fridolin Somers [Fri, 9 Aug 2019 11:51:46 +0000 (13:51 +0200)]
Bug 22997: Unit test

Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 22997: Searching gives no results in auth_finder.pl
Fridolin Somers [Tue, 28 May 2019 13:48:54 +0000 (15:48 +0200)]
Bug 22997: Searching gives no results in auth_finder.pl

During cataloguing of an existing biblio, on an heading field,
the use of tag editor fills authorities finder with existing value :
  Search main heading ($a only)
  Search main heading
Default operator beeing 'contains'.

Actually with Elasticsearch those search give no results.

Example with heading :
200
  $a Casaubon
  $b Isaac
  $f 1559-1614

Call to Elasticsearch :
    "query" : {
        "bool" : {
           "must" : [
              {
             "query_string" : {
                  "query" : "Casaubon*",
                  "default_field" : "heading-main",
                   }
              },
              {
             "query_string" : {
                  "query" : "(Isaac*) AND (1559-1614*)",
                  "default_field" : "heading"
                   }
              }
            ]
         }
      },
    "sort" : [
       {
      "heading__sort.phrase" : "asc"
       }
     ]
  }

Patch adds to "query_string" :
  analyze_wildcard : true.

Test plan :
1) Use Elasticsearch
2) Edit an existing biblio record
3) Use tag editor on a heading
4) Click search => You get correct results
5) Check also search in authorities-home.pl

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 14669: (RM follow-up) Ensure updated include compiles
Martin Renvoize [Wed, 9 Oct 2019 06:28:50 +0000 (07:28 +0100)]
Bug 14669: (RM follow-up) Ensure updated include compiles

The introduction of `options_for_libraries` in the filter-orders include
template requires that we process 'html_helpers' within the file to
ensure it always compiles.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 23720: Add div wrapper to search results to make moving cover images easier
Lucas Gass [Wed, 2 Oct 2019 23:54:21 +0000 (23:54 +0000)]
Bug 23720: Add div wrapper to search results to make moving cover images easier

TEST PLAN:

1. Apply this patch and turn on some cover images.
2. Add this CSS: '.bibliocol {display: flex;}.coverimages
   {padding-right:20px;}' to the OPACUserCSS.
3. Notice covers on left.
4. Remove CSS and notice covers should look normal on the right side.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 23731: Give staff detail/OPAC detail option to display LOC classification
Lucas Gass [Thu, 3 Oct 2019 06:27:27 +0000 (06:27 +0000)]
Bug 23731: Give staff detail/OPAC detail option to display LOC classification

Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 23694: (QA follow-up) Add new class for 'by' to intranet XSLT
Katrin Fischer [Mon, 7 Oct 2019 19:27:03 +0000 (21:27 +0200)]
Bug 23694: (QA follow-up) Add new class for 'by' to intranet XSLT

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 23694: Author "By" should have its own class
Lucas Gass [Mon, 30 Sep 2019 15:29:05 +0000 (15:29 +0000)]
Bug 23694: Author "By" should have its own class

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 23697: DBRev 19.06.00.038
Martin Renvoize [Tue, 8 Oct 2019 13:52:33 +0000 (14:52 +0100)]
Bug 23697: DBRev 19.06.00.038

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 23697: (QA follow-up) Fix quotes in database update statement
Katrin Fischer [Mon, 7 Oct 2019 18:59:57 +0000 (18:59 +0000)]
Bug 23697: (QA follow-up) Fix quotes in database update statement

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 23697: (QA follow-up) Rename PatronAutocompletion to PatronAutoComplete
Katrin Fischer [Mon, 7 Oct 2019 18:54:29 +0000 (20:54 +0200)]
Bug 23697: (QA follow-up) Rename PatronAutocompletion to PatronAutoComplete

Just a find and replace on the changed system preference name.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 23697: (follow-up) Add autocompletion search in patron module
Matthias Meusburger [Fri, 4 Oct 2019 09:16:08 +0000 (11:16 +0200)]
Bug 23697: (follow-up) Add autocompletion search in patron module

 - Rename CircAutocompl system preference to PatronAutocompletion
 - Take this system preference into consideration for patron search

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 23697: Add autocompletion search in patron module
Matthias Meusburger [Wed, 2 Oct 2019 12:21:00 +0000 (14:21 +0200)]
Bug 23697: Add autocompletion search in patron module

 Test plan:

  - Apply the patch
  - Go to "Patrons" (members/members-home.pl)
  - Check that autocomplete is enabled for patron search

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 23507: Add ability to show change given on auto-popup fee receipt from FinePaymen...
Kyle M Hall [Mon, 26 Aug 2019 18:33:29 +0000 (14:33 -0400)]
Bug 23507: Add ability to show change given on auto-popup fee receipt from FinePaymentAutoPopup

Some libraries would like to show the amount of change given on print reciepts triggered by FinePaymentAutoPopup
so the patron can verify he or she has recieved the correct amount of change.

1) Apply this patch
2) Edit ACCOUNT_CREDIT slip and add "[% IF change_given %]<h1>CHANGE: [% change_given %]</h1>[% END %]" at the top
3) Enable FinePaymentAutoPopup
4) Make a payment
5) Note the change given is shown on the popup receipt
6) Note the change given is *not* shown on subsequent prints of the same receipt using the "print" button for the payment

Signed-off-by: Kyle Hall <kyle@bywatersolutions.com>
Signed-off-by: Hasina Akhte <hasinaa@pascolibraries.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 21701: DBRev 19.06.00.037
Martin Renvoize [Tue, 8 Oct 2019 13:45:03 +0000 (14:45 +0100)]
Bug 21701: DBRev 19.06.00.037

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 21701: Fix up db update
Kyle M Hall [Mon, 7 Oct 2019 13:22:03 +0000 (09:22 -0400)]
Bug 21701: Fix up db update

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 21701: Have PayPal optionally return to originating OPAC url rather than OPACBaseURL
David Kuhn [Thu, 8 Nov 2018 16:58:37 +0000 (08:58 -0800)]
Bug 21701: Have PayPal optionally return to originating OPAC url rather than OPACBaseURL

This enhancement will allow a library to choose whether to use the alias of the
current OPAC or the value of OPACBaseURL as the return url when making payments
via PayPal.

To test:
Note: you need to have PayPal enabled on your system (either Sandbox mode or
Live) and be using an alias URL for your OPAC.

1. Apply the patch.
2. With the option "PayPalReturnURL" set to "OPACBaseURL", log into a card via
the OPAC and start the process to pay in PayPal (you can either complete the
payment or cancel from the PayPal page). When you are returned to the OPAC, the
domain will be the value of OPACBaseURL.
3. With the option "PayPalReturnURL" set to "OPAC's alias", repeat the above
sequence to make a payment in PayPal. When you are returned to the OPAC, the
domain will be your current alias.

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 13937: Add SRU tests
Ere Maijala [Tue, 23 Jul 2019 12:14:51 +0000 (15:14 +0300)]
Bug 13937: Add SRU tests

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 13937: Switch from GetItem() to Koha::Items->find()
Ere Maijala [Fri, 8 Mar 2019 09:40:54 +0000 (11:40 +0200)]
Bug 13937: Switch from GetItem() to Koha::Items->find()

Signed-off-by: Stefan Berndtsson <stefan.berndtsson@ub.gu.se>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 13937: Fix the daemon log path.
Olli-Antti Kivilahti [Thu, 14 Feb 2019 13:08:54 +0000 (15:08 +0200)]
Bug 13937: Fix the daemon log path.

directory _LOG_DIR_/logs does't exists.

All other log4perl -logs are out to _LOG_DIR_

Thank you for the good work Ere!

Signed-off-by: Stefan Berndtsson <stefan.berndtsson@ub.gu.se>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 13937: Add support for Z39.50 responder to the Debian scripts
Ere Maijala [Fri, 11 Jan 2019 09:27:56 +0000 (11:27 +0200)]
Bug 13937: Add support for Z39.50 responder to the Debian scripts

Signed-off-by: Stefan Berndtsson <stefan.berndtsson@ub.gu.se>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 13937: Fix RPN conversion
Ere Maijala [Tue, 15 Jan 2019 11:54:17 +0000 (13:54 +0200)]
Bug 13937: Fix RPN conversion

Fixes handling of parenthesis and removes unused quote handling.

Signed-off-by: Stefan Berndtsson <stefan.berndtsson@ub.gu.se>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 13937: Add tests for search and retrieval
Ere Maijala [Tue, 27 Nov 2018 11:40:44 +0000 (13:40 +0200)]
Bug 13937: Add tests for search and retrieval

Sponsored-by: National Library of Finland
Signed-off-by: Stefan Berndtsson <stefan.berndtsson@ub.gu.se>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 13937: Add support for SRU and Elasticsearch
Ere Maijala [Thu, 22 Nov 2018 09:20:01 +0000 (11:20 +0200)]
Bug 13937: Add support for SRU and Elasticsearch

Splits Session to GenericSession and ZebraSession where Generic supports any
search backend via the SearchEngine classes and Zebra maintains the direct
channel to the Zebra server.

Adds config files required for mapping BIB-1 attributes to Koha search fields
and SRU indexes to BIB-1 attributes.

Adds PODs.

Sponsored-by: National Library of Finland
Signed-off-by: Stefan Berndtsson <stefan.berndtsson@ub.gu.se>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 13937: Fix issues found in QA
Ere Maijala [Wed, 21 Nov 2018 14:20:33 +0000 (16:20 +0200)]
Bug 13937: Fix issues found in QA

Signed-off-by: Stefan Berndtsson <stefan.berndtsson@ub.gu.se>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 13937: (follow-up) Pass through yaz switches and don't ignore case
Nick Clemens [Tue, 14 Nov 2017 12:29:52 +0000 (12:29 +0000)]
Bug 13937: (follow-up) Pass through yaz switches and don't ignore case

Signed-off-by: Stefan Berndtsson <stefan.berndtsson@ub.gu.se>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 13937: Add unit tests
Nick Clemens [Thu, 7 Sep 2017 15:50:42 +0000 (11:50 -0400)]
Bug 13937: Add unit tests

Signed-off-by: Stefan Berndtsson <stefan.berndtsson@ub.gu.se>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 13937: (follow-up) Correct error call to use self
Nick Clemens [Thu, 7 Sep 2017 15:49:34 +0000 (11:49 -0400)]
Bug 13937: (follow-up) Correct error call to use self

Signed-off-by: Stefan Berndtsson <stefan.berndtsson@ub.gu.se>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 13937: (follow-up) Remove reference to sub _prefetch_records
Nick Clemens [Mon, 12 Dec 2016 14:20:25 +0000 (14:20 +0000)]
Bug 13937: (follow-up) Remove reference to sub _prefetch_records

Remove reference to sub _prefetch_records

It appears this sub is built into fetch and this call is a duplicate

Signed-off-by: George Williams <george@nekls.org>
Signed-off-by: Stefan Berndtsson <stefan.berndtsson@ub.gu.se>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 13937: Add a Z39.50 daemon that can inject item status MARC subfields
Jesse Weaver [Fri, 11 Dec 2015 21:26:20 +0000 (14:26 -0700)]
Bug 13937: Add a Z39.50 daemon that can inject item status MARC subfields

This creates a new daemon, misc/z3950_responder.pl, which can respond to
Z39.50 requests. By default, it just proxies searches to Zebra.

If desired, however, it can also add a subfield to the item tags on
outgoing records with a textual description of the item's status
(checked out, lost, etc.). This is useful for certain ILL systems. These
strings can be translated using the 'Z3950_STATUS' authorized value.

Test plan:
  1) Start the Z39.50 server using `perl misc/z3950_responder.pl`.
  2) Connect to the server using `yaz-client 127.0.0.1:9999/biblios`.
  3) Run a search, such as `find @attr 1=1016 book`.
  4) Fetch the results both one at a time with `show 1` and in a batch
     using `show 1+5`.
  5) Turn on MARCXML using `format xml` and `elements marcxml`, and
     verify that the records are still correctly fetched.
  6) Enable the item status subfield by restarting the server with the
     option `--add-item-status=k`.
  7) Search for and fetch records, and verify that a $k subfield is
     added to the item tags as appropriate. It should show some
     combination of "Checked Out", "Lost", "Not For Loan", "Damaged",
     "Withdrawn", "In Transit", or "On Hold" as appropriate, or
     "Available".
  8) Add an authorized value named "Z3950_STATUS" with any of the keys
     "AVAILABLE", "CHECKED_OUT", "LOST", "NOT_FOR_LOAN", "DAMAGED",
     "WITHDRAWN", "IN_TRANSIT" or "ON_HOLD", and verify that their
     descriptions are used instead of the default values above.

Signed-off-by: George Williams <george@nekls.org>
Signed-off-by: Stefan Berndtsson <stefan.berndtsson@ub.gu.se>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 17005: Fix bad rebase
Josef Moravec [Wed, 3 Jul 2019 19:58:20 +0000 (19:58 +0000)]
Bug 17005: Fix bad rebase

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 17005: Add plugin parameters to /checkouts endpoint
Josef Moravec [Thu, 4 Apr 2019 07:42:14 +0000 (07:42 +0000)]
Bug 17005: Add plugin parameters to /checkouts endpoint

Signed-off-by: Michal Denar <black23@gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 17005: Test for checked_in parameter
Josef Moravec [Mon, 1 Apr 2019 08:24:23 +0000 (08:24 +0000)]
Bug 17005: Test for checked_in parameter

Test plan:
prove t/db_dependent/api/v1/checkouts.t

Signed-off-by: Michal Denar <black23@gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 17005: Add checked_in checkouts to REST API response
Josef Moravec [Mon, 1 Apr 2019 07:56:39 +0000 (07:56 +0000)]
Bug 17005: Add checked_in checkouts to REST API response

This patch implements parameter 'checked_in' on checkouts endpoint to
enable getting circulation history.

Test plan:
1) Apply the patch and restart plack
2) Use your favorite REST API tester and play with /checkouts endpoint:
    - use it without checked_in parameter
    - use checked_in=1 for getting returned checkouts

Signed-off-by: Michal Denar <black23@gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 18309: Add missing fields in biblio framework
Julian Maurice [Thu, 3 Oct 2019 13:04:35 +0000 (15:04 +0200)]
Bug 18309: Add missing fields in biblio framework

018 - [Reserved for other International Standard Numbers]
033 - Other System Persistent Record Identifier
183 - Coded Data Field: Type of Carrier
203 - Content Form and Media Type
231 - Digital File Characteristics
283 - Carrier Type
338 - Funding Information Note

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 18309: Fix INSERT sql query in unimarc_framework_DEFAULT.sql
Julian Maurice [Wed, 2 Oct 2019 12:58:24 +0000 (14:58 +0200)]
Bug 18309: Fix INSERT sql query in unimarc_framework_DEFAULT.sql

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 18309: Add UNIMARC field 214 and its subfields
Julian Maurice [Wed, 2 Oct 2019 12:17:23 +0000 (14:17 +0200)]
Bug 18309: Add UNIMARC field 214 and its subfields

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 18309: UNIMARC update from IFLA - biblio UNIMARC complet (en)
Julian Maurice [Thu, 23 Mar 2017 10:24:30 +0000 (11:24 +0100)]
Bug 18309: UNIMARC update from IFLA - biblio UNIMARC complet (en)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 18309: UNIMARC update from IFLA - authority (fr) (STU)
Julian Maurice [Mon, 30 Sep 2019 14:21:44 +0000 (16:21 +0200)]
Bug 18309: UNIMARC update from IFLA - authority (fr) (STU)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 18309: UNIMARC update from IFLA - authority (fr) (SCO)
Julian Maurice [Mon, 30 Sep 2019 14:20:17 +0000 (16:20 +0200)]
Bug 18309: UNIMARC update from IFLA - authority (fr) (SCO)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 18309: UNIMARC update from IFLA - authority (fr) (SAUT)
Julian Maurice [Mon, 30 Sep 2019 14:19:56 +0000 (16:19 +0200)]
Bug 18309: UNIMARC update from IFLA - authority (fr) (SAUT)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 18309: UNIMARC update from IFLA - authority (fr) (FA)
Julian Maurice [Mon, 30 Sep 2019 14:19:29 +0000 (16:19 +0200)]
Bug 18309: UNIMARC update from IFLA - authority (fr) (FA)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 18309: UNIMARC update from IFLA - authority (fr) (CO_UNI_TI)
Julian Maurice [Mon, 30 Sep 2019 14:19:03 +0000 (16:19 +0200)]
Bug 18309: UNIMARC update from IFLA - authority (fr) (CO_UNI_TI)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 18309: UNIMARC update from IFLA - authority (fr) (AUTTIT)
Julian Maurice [Mon, 30 Sep 2019 14:18:14 +0000 (16:18 +0200)]
Bug 18309: UNIMARC update from IFLA - authority (fr) (AUTTIT)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 18309: UNIMARC update from IFLA - authority (fr) (TM)
Julian Maurice [Mon, 30 Sep 2019 14:17:01 +0000 (16:17 +0200)]
Bug 18309: UNIMARC update from IFLA - authority (fr) (TM)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 18309: UNIMARC update from IFLA - authority (fr) (SNG)
Julian Maurice [Mon, 30 Sep 2019 14:15:51 +0000 (16:15 +0200)]
Bug 18309: UNIMARC update from IFLA - authority (fr) (SNG)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 18309: UNIMARC update from IFLA - authority (fr) (SNC)
Julian Maurice [Mon, 30 Sep 2019 14:14:30 +0000 (16:14 +0200)]
Bug 18309: UNIMARC update from IFLA - authority (fr) (SNC)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 18309: UNIMARC update from IFLA - authority (fr) (SAUTTIT)
Julian Maurice [Mon, 30 Sep 2019 13:51:55 +0000 (15:51 +0200)]
Bug 18309: UNIMARC update from IFLA - authority (fr) (SAUTTIT)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 18309: UNIMARC update from IFLA - authority (fr) (PA)
Julian Maurice [Mon, 30 Sep 2019 13:49:19 +0000 (15:49 +0200)]
Bug 18309: UNIMARC update from IFLA - authority (fr) (PA)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 18309: UNIMARC update from IFLA - authority (fr) (NP)
Julian Maurice [Mon, 30 Sep 2019 13:47:57 +0000 (15:47 +0200)]
Bug 18309: UNIMARC update from IFLA - authority (fr) (NP)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 18309: UNIMARC update from IFLA - authority (fr) (FAM)
Julian Maurice [Mon, 30 Sep 2019 13:46:25 +0000 (15:46 +0200)]
Bug 18309: UNIMARC update from IFLA - authority (fr) (FAM)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 18309: UNIMARC update from IFLA - authority (fr) (GENRE/FORM)
Julian Maurice [Mon, 30 Sep 2019 13:43:36 +0000 (15:43 +0200)]
Bug 18309: UNIMARC update from IFLA - authority (fr) (GENRE/FORM)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 18309: UNIMARC update from IFLA - authority (fr) (FAM)
Julian Maurice [Mon, 30 Sep 2019 13:37:16 +0000 (15:37 +0200)]
Bug 18309: UNIMARC update from IFLA - authority (fr) (FAM)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 18309: UNIMARC update from IFLA - authority (fr) (WORK)
Julian Maurice [Mon, 30 Sep 2019 13:29:46 +0000 (15:29 +0200)]
Bug 18309: UNIMARC update from IFLA - authority (fr) (WORK)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 18309: UNIMARC update from IFLA - authority (fr) (TU)
Julian Maurice [Mon, 30 Sep 2019 13:28:13 +0000 (15:28 +0200)]
Bug 18309: UNIMARC update from IFLA - authority (fr) (TU)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 18309: UNIMARC update from IFLA - authority (fr) (PUB)
Julian Maurice [Mon, 30 Sep 2019 13:16:58 +0000 (15:16 +0200)]
Bug 18309: UNIMARC update from IFLA - authority (fr) (PUB)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 18309: UNIMARC update from IFLA - authority (fr) (PERS)
Julian Maurice [Mon, 30 Sep 2019 13:14:29 +0000 (15:14 +0200)]
Bug 18309: UNIMARC update from IFLA - authority (fr) (PERS)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 18309: UNIMARC update from IFLA - authority (fr) (NTWORK)
Julian Maurice [Mon, 30 Sep 2019 13:00:59 +0000 (15:00 +0200)]
Bug 18309: UNIMARC update from IFLA - authority (fr) (NTWORK)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 18309: UNIMARC update from IFLA - authority (fr) (NTEXP)
Julian Maurice [Mon, 30 Sep 2019 12:55:34 +0000 (14:55 +0200)]
Bug 18309: UNIMARC update from IFLA - authority (fr) (NTEXP)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 18309: UNIMARC update from IFLA - authority (fr) (EXP)
Julian Maurice [Mon, 30 Sep 2019 12:45:55 +0000 (14:45 +0200)]
Bug 18309: UNIMARC update from IFLA - authority (fr) (EXP)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 18309: UNIMARC update from IFLA - authority (fr) (CO)
Julian Maurice [Mon, 30 Sep 2019 12:35:49 +0000 (14:35 +0200)]
Bug 18309: UNIMARC update from IFLA - authority (fr) (CO)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 18309: UNIMARC update from IFLA - authority (fr) (CLASS)
Julian Maurice [Mon, 30 Sep 2019 12:33:33 +0000 (14:33 +0200)]
Bug 18309: UNIMARC update from IFLA - authority (fr) (CLASS)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 18309: UNIMARC update from IFLA - authority (fr) (default framework)
Julian Maurice [Mon, 30 Sep 2019 12:30:19 +0000 (14:30 +0200)]
Bug 18309: UNIMARC update from IFLA - authority (fr) (default framework)

Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 23677: Unit tests
Tomas Cohen Arazi [Thu, 26 Sep 2019 19:23:49 +0000 (16:23 -0300)]
Bug 23677: Unit tests

This patch introduces tests for the GET /biblios/{biblio_id} endpoint.
It tries to cover all the use cases.

To test:
- Apply this patchset
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/biblios.t
=> SUCCESS: Tests pass!
- Use Postman (or your favourite tool) to test the API
=> SUCCESS: Works as expected!
- Sign off :-D

Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 23677: Controller method and dependencies tweak
Tomas Cohen Arazi [Thu, 26 Sep 2019 19:23:41 +0000 (16:23 -0300)]
Bug 23677: Controller method and dependencies tweak

Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 23677: Schema fix
Tomas Cohen Arazi [Thu, 26 Sep 2019 19:22:54 +0000 (16:22 -0300)]
Bug 23677: Schema fix

Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 23677: OpenAPI spec for GET /biblios/{biblio_id}
Tomas Cohen Arazi [Thu, 26 Sep 2019 19:22:34 +0000 (16:22 -0300)]
Bug 23677: OpenAPI spec for GET /biblios/{biblio_id}

Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 22294: Check return of as_isbn10 before calling methods on it
Martin Renvoize [Fri, 8 Feb 2019 10:37:50 +0000 (10:37 +0000)]
Bug 22294: Check return of as_isbn10 before calling methods on it

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 22540: (QA follow-up) fixes
Kyle Hall [Wed, 20 Mar 2019 17:37:56 +0000 (17:37 +0000)]
Bug 22540: (QA follow-up) fixes

borrowernumber is not an accessor for C4::SIP::ILS::Patron, access is
via hashref

Add ability to specify the pickup location using a command line
parameter

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Signed-off-by: frederik chenier <frederik.chenier@inlibro.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 22540: Add ability to place holds using SIP CLI emulator
Kyle M Hall [Tue, 19 Mar 2019 15:22:03 +0000 (11:22 -0400)]
Bug 22540: Add ability to place holds using SIP CLI emulator

Test Plan:
1) Place a hold using the following arguments:
   sip_cli_emulator.pl -a <address> -p <port> -su <sip_user> -sp <sip_password> -l <location_code> --patron <cardnumber> --item <barcode> -m hold
2) Note the hold was placed in Koha

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Signed-off-by: frederik chenier <frederik.chenier@inlibro.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 23400: Add --status to koha-indexer
Magnus Enger [Mon, 30 Sep 2019 08:03:13 +0000 (10:03 +0200)]
Bug 23400: Add --status to koha-indexer

koha-zebra has a nice, informative --status switch, koha-indexer
does not. This patch adds it.

To test:
- Run "sudo koha-indexer --status kohadev" - you get an error:
  "Error: invalid option switch (--status)"
- Apply this patch
- If you are on e.g. kohadevbox you need to copy koha-indexer to
  where it is actually run from:
  sudo cp debian/scripts/koha-indexer /usr/sbin/koha-indexer
- Run "sudo koha-indexer --status kohadev" again and you should
  get a nice status telling if the indexer is running or not
- Toggle the indexer on and off with koha-indexer --start/--stop
  and verify the status is telling the truth about the state of
  the indexer
- Run "sudo koha-indexer --help" and check there is a description
  of the --status option
- Have a look at debian/docs/koha-indexer.xml and verify there is
  an adequate description of the --status option.
- Run "prove -v xt/verify-debian-docbook.t" to check the structure
  of the man page in DocBook format.

PS: I tried to generate a manpage from the DocBook as described at
https://wiki.koha-community.org/wiki/Testing_man_pages
but the output did not look good for any of our DocBook files.
Not sure why.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 21245: Compiled CSS
Martin Renvoize [Tue, 8 Oct 2019 13:18:54 +0000 (14:18 +0100)]
Bug 21245: Compiled CSS

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 21245: Move 'Last patron' button into 'breadcrumb' bar
Martin Renvoize [Tue, 7 May 2019 10:59:32 +0000 (11:59 +0100)]
Bug 21245: Move 'Last patron' button into 'breadcrumb' bar

This patch moved the 'Last patron' button introduced in bug 20312 inline
with the breadcrumb bar from floating above it.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 23101: (follow-up) use NoSort class in datatable
Fridolin Somers [Tue, 8 Oct 2019 12:05:49 +0000 (14:05 +0200)]
Bug 23101: (follow-up) use NoSort class in datatable

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 20334: DBRev 19.06.00.036
Martin Renvoize [Tue, 8 Oct 2019 13:13:59 +0000 (14:13 +0100)]
Bug 20334: DBRev 19.06.00.036

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 20334: Move new system preference into right spot in alphabet
Katrin Fischer [Sun, 28 Oct 2018 23:57:46 +0000 (23:57 +0000)]
Bug 20334: Move new system preference into right spot in alphabet

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 20334: Improve syspref description and set more sensible defaults
David Gustafsson [Mon, 22 Oct 2018 13:50:07 +0000 (15:50 +0200)]
Bug 20334: Improve syspref description and set more sensible defaults

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 20334: Option for escaping slashes in search queries
David Gustafsson [Fri, 2 Mar 2018 17:16:39 +0000 (18:16 +0100)]
Bug 20334: Option for escaping slashes in search queries

Add "QueryRegexEscapeOption" system preference to provide option to escape
Elasticsearch regexp delimiters (/) within queries, or alternativly to
unescape escaped slashes (\/) while escaping unescaped slashes, in
effect making "\/" the new regexp delimiter.

How to test:
1) Run tests in ./t/Koha/SearchEngine/ElasticSearch/QueryBuilder.t
2) All tests should succeed

Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr>
Signed-off-by: Maksim Sen <maksim.sen@inlibro.com>
Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 15422: Consider partial copies needed as whole numbers
Nick Clemens [Tue, 4 Dec 2018 14:58:35 +0000 (14:58 +0000)]
Bug 15422: Consider partial copies needed as whole numbers

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 15422: Correct calculation of holds ratio report
Nick Clemens [Thu, 29 Nov 2018 02:07:18 +0000 (02:07 +0000)]
Bug 15422: Correct calculation of holds ratio report

See comment 1 for a detailed explanation of current calculations and
needed calculations

Also removes an unnecessary variable

To test:
 1 - Place 4 holds on a biblio with one item
 2 - go to /cgi-bin/koha/circ/reserveratios.pl (Circulation->Holds
        ratios)
 3 - Run with 'Hold ratio'=3, it says order 1, ok
 4 - Run with HR=4, it says order 1, wrong
 5 - Run with HR=2, it syas order 2, wrong
 6 - Run with HR=.5, it syas order 4, wrong
 7 - Apply patch
 8 - Run with HR=3, order 1, OK
 9 - Run with HR=4, item does not appear (0 to order), OK
10 - Run with HR=2, order 1, OK
11 - Run with HR=.5, order 7, OK

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 14669: Add search option for managing library to orders search
Katrin Fischer [Sat, 11 May 2019 21:08:11 +0000 (21:08 +0000)]
Bug 14669: Add search option for managing library to orders search

Currently the order search can't be limited by managing library.
The patch adds the search option to the order history search form
and a column for the managing library to the search results table.

To test:
- Create some baskets with orders
  - Set managing library for some, but also have some without
- Apply patch
- prove t/db_dependent/Acquisition.t
- Go to Aquisition > Orders search tab on top > Advanced search link
- Search for orders without limiting
  Orders with and without managing library set should show up
- Limit search to a specific managing library
- Verify results match expectations

Signed-off-by: Alex Sassmannshausen <alex@komputilo.eu>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
5 years agoBug 22667: Pick default value from framework for cn_source
Jonathan Druart [Tue, 30 Apr 2019 17:54:37 +0000 (13:54 -0400)]
Bug 22667: Pick default value from framework for cn_source

If the cn_source has a default value defined in the framework it will
not be used when ordering or receiving serials.

Test plan:
Set the pref DefaultClassificationSource to Library of congress
Define a default value=ddc (for Dewey) for the ACQ and default framework
Receive an order (AcqCreateItem=on ordering) and confirm that Dewey is
selected by default (the default value from the ACQ framework is used)
Receive a serial and confirm that Dewey is selected by default

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>