]> git.koha-community.org Git - koha.git/log
koha.git
12 years agoBug 8176 [SIGNED-OFF] Assign an intial value to $sqlwhere
Colin Campbell [Fri, 1 Jun 2012 07:10:21 +0000 (08:10 +0100)]
Bug 8176 [SIGNED-OFF] Assign an intial value to $sqlwhere

warnings in log because of undefined value in
string concatenation
variable should be initialized to empty string rather
than left undefined

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Removes a warning in logs

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 3638 : Captured Holds may need to generate a transfer
Colin Campbell [Thu, 18 Aug 2011 15:48:44 +0000 (16:48 +0100)]
Bug 3638 : Captured Holds may need to generate a transfer

If a discharged item is captured for a hold at another branch
the selfcheck should generate a branchtransfer for it.
This was complicated as the checkin routine was setting its own
location from a field not set in many scm machines (e.g. 3M)
also in ILS::Transaction the test for location was incorrect
assuming that an empty string or undefined was a valid location

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 3638 Self Check Should Capture Hold Items
Colin Campbell [Mon, 4 Jul 2011 15:44:16 +0000 (16:44 +0100)]
Bug 3638 Self Check Should Capture Hold Items

Shelf Check was receiving messages saying item was wanted
for a hold but the item was discharged to the shelf
not associated with the hold or transited to
the pickup location. The message was also being sent
on discharge of items when a suitable item had already
been captured.
Checkin now associates the item with the hold and sets
the appropriate data for a correct checkin response

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 5327 : Fix for XISBN test, thingisbn is now handing back different results
Chris Cormack [Fri, 1 Jun 2012 22:29:52 +0000 (10:29 +1200)]
Bug 5327 : Fix for XISBN test, thingisbn is now handing back different results

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 8082: Fixing circulation.pref to match reality for IssuingInProcess
Chris Cormack [Mon, 14 May 2012 01:48:53 +0000 (13:48 +1200)]
Bug 8082: Fixing circulation.pref to match reality for IssuingInProcess

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
passes tests, changes are as advertised.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoWelcome to Piotr Kowalski, that is 183th
Paul Poulain [Tue, 5 Jun 2012 13:54:50 +0000 (15:54 +0200)]
Welcome to Piotr Kowalski, that is 183th

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 8116 : Fixing warn in error log
Piotr Kowalski [Mon, 28 May 2012 09:50:49 +0000 (21:50 +1200)]
Bug 8116 : Fixing warn in error log

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 8111 - Language chooser display problem in self-checkout
Owen Leonard [Wed, 16 May 2012 16:44:56 +0000 (12:44 -0400)]
Bug 8111 - Language chooser display problem in self-checkout

- Adds required JavaScript and JavaScript linked files
- Updates CSS with changes relevant to this feature which had
  been made to the main CSS file.
- Removes an image file which has been made obsolete now that
  sco.css uses the main image sprite like opac.css does.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7847: OPAC search dies with Plack
Jared Camins-Esakov [Mon, 28 May 2012 23:27:45 +0000 (19:27 -0400)]
Bug 7847: OPAC search dies with Plack

Due to a dependency cycle between C4::Search and C4::Items, searches
in the OPAC die spectacularly under Plack. This counter-patch extends
dpavlin's solution and replaces use with require for C4::Search in
C4::Items and for C4::Items in C4::Search.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7599 - [SIGNED-OFF] Cart JavaScript contains untranslatable English strings
Owen Leonard [Tue, 22 May 2012 18:42:42 +0000 (14:42 -0400)]
Bug 7599 - [SIGNED-OFF] Cart JavaScript contains untranslatable English strings

To simplify the sentence structure for better translation flexibility
the message now reads:

"Item in your cart: " + number

Fixed in both OPAC and staff client, although I'm not sure
the message is actually triggered in the staff client.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Strings become translatable

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 8140 - [SIGNED-OFF] Error when exporting label xml
Kyle M Hall [Wed, 23 May 2012 11:43:59 +0000 (07:43 -0400)]
Bug 8140 - [SIGNED-OFF] Error when exporting label xml

It appears that the name of a variable was changed,
but the declaration of said variable was not.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 4330 : Adding copyright headers and fixing FSF addresses
Chris Cormack [Mon, 21 May 2012 08:06:36 +0000 (20:06 +1200)]
Bug 4330 : Adding copyright headers and fixing FSF addresses

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 4330 : Fixing FSF address and copyright headers for acqui/
Chris Cormack [Sun, 20 May 2012 23:03:21 +0000 (11:03 +1200)]
Bug 4330 : Fixing FSF address and copyright headers for acqui/

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 4330 : Adding missing license statement
Chris Cormack [Sun, 20 May 2012 10:30:41 +0000 (22:30 +1200)]
Bug 4330 : Adding missing license statement

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 4330 Fixing FSF statements
Chris Cormack [Sun, 20 May 2012 10:27:29 +0000 (22:27 +1200)]
Bug 4330 Fixing FSF statements

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 4330 : Fixing FSF address and copyright statements
Chris Cormack [Sun, 20 May 2012 10:14:04 +0000 (22:14 +1200)]
Bug 4330 : Fixing FSF address and copyright statements

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 4330 : Fixing FSF address and copyright headers
Chris Cormack [Sun, 20 May 2012 09:55:55 +0000 (21:55 +1200)]
Bug 4330 : Fixing FSF address and copyright headers

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 8144 - 775 tag in the MARC record causes display issue
Paul Poulain [Mon, 28 May 2012 15:36:32 +0000 (17:36 +0200)]
Bug 8144 - 775 tag in the MARC record causes display issue

Fixing XSL template in the OPAC and staff client following
recommendations by Jared.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Fixes the markup and correctly displays 775 notes.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoWelcome to the 182th commiter !
Paul Poulain [Mon, 28 May 2012 09:29:28 +0000 (11:29 +0200)]
Welcome to the 182th commiter !

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 6684: Fixes to koha-remove
Simon Story [Fri, 18 Nov 2011 14:52:09 +0000 (14:52 +0000)]
Bug 6684: Fixes to koha-remove

Fixes bugs 6684 6997 4880:
6684 koha-remove should check the number of arguments it gets
6997 koha-remove leaves system in inconsistent state if there is an error
4880 koha-remove sometimes fails because user is logged in

Amended by chrisc@catalyst.net.nz
Trying to resolve conflicts.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Rebased on top of bug 7924.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 8080 - login and password is pre-filled by the browser when creating a new patron
Kyle M Hall [Mon, 14 May 2012 12:22:14 +0000 (08:22 -0400)]
Bug 8080 - login and password is pre-filled by the browser when creating a new patron

When creating a new patron, if you have chosen to let your browser remember your
login and password for you, the login and password fields will be pre-filled with
them, leading to a systematic error "the passwords entered do not match" since
the second password field was not filled. These fields should be blank.

Add the directive autocomplete="off" to the memberentry form tags.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
passes t xt
enhances usability of password forms, gets my signoff.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 5795 Update the database as follow-up If sys pref
Amit Gupta [Tue, 22 May 2012 10:32:31 +0000 (16:02 +0530)]
Bug 5795 Update the database as follow-up If sys pref

ReservesControlBranch has null then update the table to
insert a PatronLibrary as value

To Test:
1) Go to mysql use koha database
2) select * from systempreferences where variable = 'ReservesControlBranch'; Check if value set to ItemHomeLibrary.
+-----------------------+-----------------+-------------------------------+-------------------------------------------------+--------+
| variable              | value           | options                       | explanation                                     | type   |
+-----------------------+-----------------+-------------------------------+-------------------------------------------------+--------+
| ReservesControlBranch | PatronLibrary   | ItemHomeLibrary|PatronLibrary | Branch checked for members reservations rights. | Choice |
+-----------------------+-----------------+-------------------------------+-------------------------------------------------+--------+

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Conflicts:

installer/data/mysql/updatedatabase.pl

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Fixed for 3.8.x

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 5795 [SIGNED-OFF] - Missing ReservesControlBranch system pref in database installer
Katrin Fischer [Sat, 14 Apr 2012 11:12:54 +0000 (13:12 +0200)]
Bug 5795 [SIGNED-OFF] - Missing ReservesControlBranch system pref in database installer

sysprefs.sql file was missing ReservesControlBranch.

To test:
1) Create a new installation and check sysprefs.sql loads correctly.
2) Check ReservesControlBranch shows up correctly in the sys pref editor.
3) Check sys pref can be edited and new value saves correctly.

Signed-off-by: Marc Veron <veron@veron.ch>
- Line is added at the end of installer/data/mysql/sysprefs.sql
- Tested Line diretly in MySQL with a systempreferences table where variable 'ReservesControlBranch' was missing. Data inserted correctly.
- Syspref shows up in Staff client

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
- Fixed merge conflict

Conflicts:

installer/data/mysql/sysprefs.sql

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
- Tidied for 3.8.x

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 3521 - Items table in catalogue/detail.pl and cataloguing/additem.pl is sorted...
Kyle M Hall [Thu, 29 Mar 2012 13:54:38 +0000 (09:54 -0400)]
Bug 3521 - Items table in catalogue/detail.pl and cataloguing/additem.pl is sorted nonsensically

Based on patch submitted by Ian Walls

Items were sorted by branch, then date accessioned, in GetItemsInfo.  While this can be
helpful in some circumstances, more often it is useful for items to be sorted first by
their enumchron (volume/issue, if applicable) then by their copy number.  This patch changes the
sort on GetItemsInfo to branch, enumcrhon, copynumber then date accessioned.

As sorting on copynumber will be incorrect based on standard sorting ( e.g. 1, 10, 2, 20 ),
the copynumber is now padded with leading zeros to correct the sorting ( e.g. 01, 02, 10 20 ).
This function appears to be a standard SQL function and not a mysql-ism. I have verfified
that is available in MySQL, Postgres, and Oracle.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Passed t xt

Item sorts appear to be correct to me based on the rubric of branch, enumchron, copynumber, then date accessioned.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7948 - Printing transfer slip loses barcode field focus
Kyle M Hall [Thu, 12 Apr 2012 15:16:20 +0000 (11:16 -0400)]
Bug 7948 - Printing transfer slip loses barcode field focus

  * Refocus on barcode field after running Dopop()
  * Cleaned up javascript, removed tabs

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
passes t xt
works as advertised.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7604 - Link on basket group name for closed basket groups is broken
Katrin Fischer [Sat, 14 Apr 2012 12:43:32 +0000 (14:43 +0200)]
Bug 7604 - Link on basket group name for closed basket groups is broken

Fixes the intended behaviour of the link on the basket group name
for closed basket groups by adding a missing '='.

Clicking the link will reopen the basket group.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 8001: [SIGNED-OFF] improve styling potential of the tag list
Robin Sheat [Tue, 24 Apr 2012 04:43:56 +0000 (16:43 +1200)]
Bug 8001: [SIGNED-OFF] improve styling potential of the tag list

This adds the class name "tagterm" to the terms in the list of a user's
tags in the OPAC, allowing them to be seperately styled.

signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7722 - Insidious problem with searching
Kyle M Hall [Thu, 15 Mar 2012 20:27:07 +0000 (16:27 -0400)]
Bug 7722 - Insidious problem with searching

I cannot find the root cause of this issue, but multiple libraries that I am aware of have problems searching on particular search terms ( and never the same terms at the same library ). The error they get when they trigger this problem is:

Tag "" is not a valid tag. at /home/koha/kohaclone/C4/Biblio.pm line 1849

Something somewhere is adding empty keys to C4::Context->marcfromkohafield, I think it may have something to do with the analytics feature that was added.

In the while loop for TransformKohaToMarc, there is a line

next unless my $dtm = $db_to_marc->{''}->{$name};

I don't think it's working.
If I dump $dtm, for each search, I see the dump twice.
It looks like this:
$VAR1 = [
           '952',
           'w'
         ];
 $VAR1 = [];
I think the second time, when it is empty is what's breaking this.
The next never fails because even though it is empty, it is still a valid arrayref.

The solution I have some up with is to skip over the elements where the arrayref is empty.

Signed-off-by: Ian Walls <koha.sekjal@gmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7213 : Follow up fixing license information
Chris Cormack [Mon, 14 May 2012 21:15:43 +0000 (09:15 +1200)]
Bug 7213 : Follow up fixing license information

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7213 - simple /svc/ HTTP example
Dobrica Pavlinusic [Thu, 10 Nov 2011 20:39:55 +0000 (21:39 +0100)]
Bug 7213 - simple /svc/ HTTP example

Simple command-line client which can authorize itself to Koha,
get MARC XML record based on biblio number and update record

This script can also be used as module using require "koha-svc.pl"
from other scripts which can implement MARC XML creation or parsing.

This is follow up version which now uses Content-type: text/xml
header when using POST method to be in sync with documentation at
http://wiki.koha-community.org/wiki/Koha_/svc/_HTTP_API

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 8022: Permissions test doesn't check all languages
Jared Camins-Esakov [Sat, 28 Apr 2012 14:04:51 +0000 (10:04 -0400)]
Bug 8022: Permissions test doesn't check all languages

Add the permissions files for es-ES and nb-NO to the permissions test.

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Running xt/permissions.t before the patch leaves out nb-NO and es-ES.
After the patch they are picked up and the test fails correctly
because of the missing permissions described in Bug 7984.
As far as I can tall, all permission files are now picked up by
this test.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoWelcoming Lyon 3 team as a committer, and adding 3.8.0 release
Paul Poulain [Fri, 11 May 2012 09:28:25 +0000 (11:28 +0200)]
Welcoming Lyon 3 team as a committer, and adding 3.8.0 release

Also fixing 3 space/tab mistakes

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7820: Followup: Add missing Debian packages
Jonathan Druart [Wed, 28 Mar 2012 13:27:50 +0000 (15:27 +0200)]
Bug 7820: Followup: Add missing Debian packages

Adds DateTime::Set used in Koha/Calendar.pm

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7820: Add missing Debian packages
Ian Walls [Sat, 24 Mar 2012 13:50:29 +0000 (09:50 -0400)]
Bug 7820: Add missing Debian packages

Adds DateTime::Format::DateParse, Readonly, Readonly::XS and Modern::Perl
Debian packages to install_misc/debian.packages

Signed-off-by: Marc Balmer <marc@msys.ch>
Signed-off-by: Ian Walls <koha.sekjal@gmail.com>
Sign off for Marc Balmer added manually by Ian Walls on Mar 24, 2012 by
permission (see IRC chat log)

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agobug 7990 - styl= in aqplan.tt
Stéphane Delaune [Fri, 20 Apr 2012 13:32:10 +0000 (15:32 +0200)]
bug 7990 - styl= in aqplan.tt

Signed-off-by: Mason James <mtj@kohaaloha.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 8008 - Fix typo in man page for koha-create
Magnus Enger [Wed, 25 Apr 2012 12:28:32 +0000 (14:28 +0200)]
Bug 8008 - Fix typo in man page for koha-create

Line 121 had "/etc/koha/koha-site.conf" instead of "/etc/koha/koha-sites.conf"

To test:
I don't think this needs any actual testing, just read the patch and check
that it looks sensible...

Signed-off-by: Marc Veron <veron@veron.ch>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7929 - Duplicate id "availability" on XSLT result page
Katrin Fischer [Wed, 11 Apr 2012 06:06:00 +0000 (08:06 +0200)]
Bug 7929 - Duplicate id "availability" on XSLT result page

Changes id="availability" to class="availability" for XHTML valididy
(ids have to be unique on a page).

Signed-off-by: mveron <veron@veron.ch>
Signed-off-by: Mason James <mtj@kohaaloha.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7987 [SIGNED-OFF] Fix typo in circulation template
Colin Campbell [Fri, 20 Apr 2012 11:16:13 +0000 (12:16 +0100)]
Bug 7987 [SIGNED-OFF] Fix typo in circulation template

li was not properly closed after loss of a character

Signed-off-by: Marc Veron <veron@veron.ch>
- Checked koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt before / after applying patch
- Line is changed as expected, ends now with </li>

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 2399: Follow up removing MySQLisms from ru-RU and uk-UA sample files
Katrin Fischer [Tue, 3 Apr 2012 18:23:47 +0000 (20:23 +0200)]
Bug 2399: Follow up removing MySQLisms from ru-RU and uk-UA sample files

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 2399: All status fields in the item edit interface offer two blank/null entries...
Katrin Fischer [Mon, 2 Apr 2012 17:28:37 +0000 (19:28 +0200)]
Bug 2399: All status fields in the item edit interface offer two blank/null entries per dropdown instead of one

Removes the '0' values without description from the sample date for
authorised values.

To test:
1) Verify that SQL files load correctly
- truncate authorised_values; /* empty authorised values table */
- load sample data using one of the SQL files
2) Check cataloging interface - all status fields should only show 1 empty line

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 3413: Checkboxes for new subfields not saving correctly
Katrin Fischer [Mon, 9 Apr 2012 09:44:06 +0000 (11:44 +0200)]
Bug 3413: Checkboxes for new subfields not saving correctly

The bug was in the numbering of the fields and subfields in the form.
The form elements for the 'new subfield' got the same numbered names and ids as
the form elements for the second subfield. (example: repeatable1)
The patch fixes the numbering to continue to the new subfield.

To test:
- Create some new subfields and check all checkbox fields save correctly
  (mandatory, repeatable, is url)
- Check that other subfields' checkboxes are not changed
- Check existing subfields and newly created subfields can be edited

Signed-off-by: mveron <veron@veron.ch>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 8025: corrects the return of a zero value for authorised values
Adrien Saurat [Mon, 30 Apr 2012 08:05:07 +0000 (10:05 +0200)]
Bug 8025: corrects the return of a zero value for authorised values

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 3969: Budget search in acquisition doesn't work (string changes)
Katrin Fischer [Sat, 14 Apr 2012 16:12:42 +0000 (18:12 +0200)]
Bug 3969: Budget search in acquisition doesn't work (string changes)

String changes:
- Correcting tab name from "Search budgets" to "Seach funds"
- Changing search option from "Name" to "Fund code"

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Strings look a-ok.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoUpdate version for 3.6.5
Jared Camins-Esakov [Fri, 25 May 2012 12:52:02 +0000 (08:52 -0400)]
Update version for 3.6.5

12 years agoRelease Notes for 3.06.05.000 24 May 2012 12:55:26 Z
Jared Camins-Esakov [Thu, 24 May 2012 12:55:29 +0000 (08:55 -0400)]
Release Notes for 3.06.05.000 24 May 2012 12:55:26 Z

12 years agoBug 7371: Add 'cardnumber' as option for AutoEmailPrimaryAddress
Katrin Fischer [Thu, 12 Apr 2012 05:53:32 +0000 (07:53 +0200)]
Bug 7371: Add 'cardnumber' as option for AutoEmailPrimaryAddress

The systempref.sql file had one more option 'cardnumber' that was not
visible from the system preference editor. This patch adds the setting.

To test:
- Check new setting cardnumber is available for AutoEmailPrimaryAddress
- Use setting with a patron that has an email address as cardnumber and
verify email is sent out correctly.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7886 follow-up DBRev number
Paul Poulain [Tue, 10 Apr 2012 09:53:15 +0000 (11:53 +0200)]
Bug 7886 follow-up DBRev number

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7886 - C4/ShelfBrowser slow SQL performance
Dobrica Pavlinusic [Wed, 4 Apr 2012 23:03:30 +0000 (01:03 +0200)]
Bug 7886 - C4/ShelfBrowser slow SQL performance

ShelfBrowser uses two SQL queries with syntax

WHERE ((cn_sort = ? AND itemnumber < ?) OR cn_sort < ?)
AND homebranch = ? AND location = ? AND ccode = ?

homebranch already has index, and adding indexes on ccode and location
improves performance by 30% for each query since MySQL is able to use
index_merge intersect(items_ccode,homebranch,items_location)

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoStop unnecessary warnings in get_language
Colin Campbell [Mon, 2 Apr 2012 14:06:28 +0000 (15:06 +0100)]
Stop unnecessary warnings in get_language

Refactor code to be more idiomatic and clarify its intention was testing
undef against languages causing log warn was creating and assigning to
unnecessary variables calling accept_language with an undef is an
expensive way to get undef returned to the caller test we are asking it
a meabingful question use any rather than first ( we dont care about
firstness it should be unique anyway but it obscures the meaning of the
test ) split takes a pattern not a string

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Having put my hands recently in this part of Koha code, I can confirm
that this patch fix log warnings, and add clarity and conciseness.

http://bugs.koha-community.org/show_bug.cgi?id=7874
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7766 - C4/Auth.pm: emit DEBUG output to STDERR
Dobrica Pavlinusic [Wed, 21 Mar 2012 08:26:22 +0000 (09:26 +0100)]
Bug 7766 - C4/Auth.pm: emit DEBUG output to STDERR

writing to STDOUT breaks plack when running with DEBUG=1

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7885 - Change filename of TransferLog suggested by packages to fit with logrotate
Magnus Enger [Wed, 4 Apr 2012 06:49:56 +0000 (08:49 +0200)]
Bug 7885 - Change filename of TransferLog suggested by packages to fit with logrotate

The apache accesslogs suggested by the default config files are called
*_log, which results in them not getting picked up by logrotate, which
looks for *.log. This patch changes the suggested filenames to *.log.

To test:
Not much to test here, just apply the patch and check that all
occurences of TransferLog and CustomLog are now on the form *.log

All the lines where these occur are commented out, so this will
not actually change any behaviour.

Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7823: [SIGNED-OFF] Ergonomy improvements: Rename button to "New patron"
Katrin Fischer [Sat, 24 Mar 2012 10:40:16 +0000 (11:40 +0100)]
Bug 7823: [SIGNED-OFF] Ergonomy improvements: Rename button to "New patron"

"New" for adding new patrons is hard to translate and is not consistent
with the naming of similar buttons in other parts of Koha.

Patch changes "New" to "New patron".

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Patch does what it says and ii makes sense to change the wording.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7771: "Notices" changed to "Notices & Slips"
Adrien Saurat [Wed, 21 Mar 2012 10:15:18 +0000 (11:15 +0100)]
Bug 7771: "Notices" changed to "Notices & Slips"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7585 - Correct MARC 008 Value Builder Char 06 Default
Chris Nighswonger [Thu, 23 Feb 2012 15:25:13 +0000 (10:25 -0500)]
Bug 7585 - Correct MARC 008 Value Builder Char 06 Default

This patch changes the default value of the 06 char in 008
from 't' to 'b.' This change allows for a valid 008 field
if no dates are entered in 07-14.

To test:

1. Create a new MARC record (prior to patch application).
2. Click on the 008 field to auto-populate.
3. Note that the 06 char is 't'.
4. Apply patch.
5. Create a new MARC record.
6. Click on the 008 field to auto-populate.
7. Note that the 06 char is now 'b'.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Confirm fix works per test plan.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7575 Opac search results print alignment
Chris Hall [Wed, 22 Feb 2012 03:47:47 +0000 (16:47 +1300)]
Bug 7575 Opac search results print alignment

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7579 - Icons for authorized values/item types not showing in OPAC
Kyle M Hall [Wed, 22 Feb 2012 15:08:24 +0000 (10:08 -0500)]
Bug 7579 - Icons for authorized values/item types not showing in OPAC

The functions getitemtypeimagedir and getitemtypeimagesrc
in Koha.pm were using the system preference 'template'
when they should be using 'opacthemes' instead.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years ago7453 Followup for borrower without expiry date
Marcel de Rooy [Thu, 23 Feb 2012 08:46:32 +0000 (09:46 +0100)]
7453 Followup for borrower without expiry date

While it should be impossible now to have a patron without expiry date, I still had one. It does not hurt to add a simple check on expiry date defined before calling delta days on null values and breaking the opac login.
Trivial change.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested by deleting the expirydate from my own patron record.
Missing expiry date now no longer breaks the summary page
in the patron account on OPAC.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7558: Serial issue note doubled up in full history
Katrin Fischer [Sun, 19 Feb 2012 17:01:04 +0000 (18:01 +0100)]
Bug 7558: Serial issue note doubled up in full history

Removes the note behind the status, because there is a separate column.

To test:
- Add a subscription
- Receive an issue, add a note for it
- Search record in OPAC and check the full history tab for the note

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 3916 [follow-up] : Adding a default choice in every dropdown list, not only branc...
Sophie Meynieux [Tue, 14 Feb 2012 13:38:25 +0000 (14:38 +0100)]
Bug 3916 [follow-up] : Adding a default choice in every dropdown list, not only branches, to let the corresponding value unchanged

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Patch works as advertised

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7460: followup : Add template toolkit's FILTER html_line_break on staff details...
Stéphane Delaune [Thu, 9 Feb 2012 10:01:33 +0000 (11:01 +0100)]
Bug 7460: followup : Add template toolkit's FILTER html_line_break on staff details description's tab

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7454 Initialize return arrays in ILS/Transaction/RenewAll
Colin Campbell [Tue, 17 Jan 2012 14:46:09 +0000 (14:46 +0000)]
Bug 7454 Initialize return arrays in ILS/Transaction/RenewAll

Explicitly clear these arrays and update them directly.
In practice item numbers were already in them when called
so that more items were being returned than were actually
renewed (or failed)

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Functionally sound patch, and tested in production

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 5373 - allow 'cardnumber' to appear on the patron import field list
Robin Sheat [Thu, 24 Nov 2011 00:35:27 +0000 (13:35 +1300)]
Bug 5373 - allow 'cardnumber' to appear on the patron import field list

For some reason, it was explicitly removed, however you need it if you
want to match up on cardnumber.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Easy to test and works nicely.
Before patch cardnumber is not shown in the list of fields on the
patron import page. After applying the patch it is.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7513 Marc Import Hangs
BibLibre [Thu, 9 Feb 2012 09:11:36 +0000 (10:11 +0100)]
Bug 7513 Marc Import Hangs

On some record, the commit_biblio_file is creating wide
character
because as_xml is not used with correct parameter.
This patch fixes that.
To test on a UNIMARC Koha, stage attachment 7510 and
then import.
It hangs before the patch, it passes after.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7496 - Personally identifying information sent in opac user TITLE
Owen Leonard [Fri, 17 Feb 2012 15:52:31 +0000 (10:52 -0500)]
Bug 7496 - Personally identifying information sent in opac user TITLE

Removing patron name from OPAC page <title> tags. Making
some other minor changes to improve <title> clarity and consistency.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
titles appear to be consistent
passes prove xt

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agobug_7231: Call GetMarcPrice() in acqui/neworderempty.pl for staged imports
Srdjan Jankovic [Fri, 27 Jan 2012 02:19:25 +0000 (15:19 +1300)]
bug_7231: Call GetMarcPrice() in acqui/neworderempty.pl for staged imports

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry-picked from commit 39def35275c3f2fa8eb4468e97b4c445e1f605fb)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 6496 - correct the order of the author display in the OPAC
Robin Sheat [Thu, 2 Feb 2012 05:21:44 +0000 (18:21 +1300)]
Bug 6496 - correct the order of the author display in the OPAC

This sets the order the fields are displayed in to be as it is in the
MARC (typically numerical order), rather than 100,700,110,710,... like
it was.

Basically, it's a port of the way it's done in the staff client. As
such, it should be able to handle a lot more than it could previously,
including relator codes.

(replaces the previous commit, just removing an erronious comment and
making the commit message more accurate)

Conflicts:

koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 6496 - tidy the display of 710 fields on XSLT
Robin Sheat [Wed, 31 Aug 2011 07:59:44 +0000 (19:59 +1200)]
Bug 6496 - tidy the display of 710 fields on XSLT

This puts '--' between 710$b fields, and replaces the '.' with a '; ' if
there are additional authors.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7540 [3.6.x] - add id values to the legends in the patron entry form
Robin Sheat [Tue, 14 Feb 2012 23:34:30 +0000 (12:34 +1300)]
Bug 7540 [3.6.x] - add id values to the legends in the patron entry form

This adds the following IDs to the legends in the patron entry form:
 main_address_lgd contact_lgd alt_address_lgd alt_contact_lgd
 library_management_lgd library_setup_lgd opac_staff_login_lgd
 patron_messaging_prefs_lgd

With these in place, then jquery like:
$(document).ready(function(){
        $('#main_address_lgd').text('Postal Address');
        $('#alt_address_lgd').text('Residential Address');
});
in intranetuserjs can be used to rename things to taste.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 5543 - Date ISO format wrong separator
Owen Leonard [Wed, 7 Dec 2011 17:18:53 +0000 (12:18 -0500)]
Bug 5543 - Date ISO format wrong separator

This patch converts the changes in Fridolyn SOMERS patch
to T:T and adds an update to the database to correct
the description there.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7272 setting NULL to debarred field, to avoid having 0000-00-00
Paul Poulain [Wed, 30 Nov 2011 13:53:48 +0000 (14:53 +0100)]
Bug 7272 setting NULL to debarred field, to avoid having 0000-00-00

0000-00-00 can come only from a problem in the 3.06.00.001 update

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoRevert "Bug 7699: Restricted until datepicker broken"
Jared Camins-Esakov [Thu, 10 May 2012 13:17:31 +0000 (09:17 -0400)]
Revert "Bug 7699: Restricted until datepicker broken"

This reverts commit fc6a6da31df374ba61b81e42941aaf1a7d27125a.

Thanks to Katrin Fischer to pointing out that this patch should not have been
cherry-picked to 3.6.x.

12 years agoRevert "Bug 7837 - nb-NO z3950servers.sql misses column names"
Jared Camins-Esakov [Thu, 10 May 2012 13:01:06 +0000 (09:01 -0400)]
Revert "Bug 7837 - nb-NO z3950servers.sql misses column names"

This reverts commit f1d92920e102d1a6d1a77613f3adeae01d0dff48.

Thanks to Katrin Fischer to pointing out that this patch should not have been
cherry-picked to 3.6.x.

12 years agoBug 7824 - [3.6.x] show the first name correctly in the OPAC user update screen
Robin Sheat [Mon, 26 Mar 2012 06:37:56 +0000 (19:37 +1300)]
Bug 7824 - [3.6.x] show the first name correctly in the OPAC user update screen

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Paron's name on 'my personal details' tab shows correctly after
applying the patch.

12 years agoUpdate 3.6.x release notes template
Jared Camins-Esakov [Wed, 9 May 2012 00:01:34 +0000 (20:01 -0400)]
Update 3.6.x release notes template

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7924 - Fix handling of command line arguments in koha-remove
Magnus Enger [Mon, 30 Apr 2012 11:49:38 +0000 (13:49 +0200)]
Bug 7924 - Fix handling of command line arguments in koha-remove

koha-remove would fail with a message like this:
Removing Koha instance --
ERROR 1396 (HY000) at line 1: Operation DROP USER failed for 'koha_--'@'%'

After fixing this, the --keep-mysql option made the script exit without doing
anything.

To test:

Alt 1
- Build package with build-git-snapshot
- Install package

Alt 2
- Replicate the changes in the patch in an existing installation

Then:
- Add instance1 and instance2
- koha-remove instance1
-- Check that script completes and the databse is gone
- koha-remove --keep-mysql instance2
-- Check that the script completes but the database is not removed

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Cherry-picked to 3.6.x prior to inclusion in Master because this is required for
the release build.

12 years agoBug 8020 [3.8.x/MASTER] - update changelogs to get to 3.8
Robin Sheat [Wed, 26 Oct 2011 03:02:32 +0000 (16:02 +1300)]
Bug 8020 [3.8.x/MASTER] - update changelogs to get to 3.8

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 3969 follow-up = budget name field is budget_name, not name
Paul Poulain [Fri, 20 Apr 2012 14:59:35 +0000 (16:59 +0200)]
Bug 3969 follow-up = budget name field is budget_name, not name

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 3969: Budget search in acquisition does't work (search)
Katrin Fischer [Sat, 14 Apr 2012 17:39:30 +0000 (19:39 +0200)]
Bug 3969: Budget search in acquisition does't work (search)

Search term was never evaluated.
Patch makes sure input param is correctly stored in the variable
and changes comparison to be case insensitive.

To test:
- Check search for fund codes (case insensitive) works
- Check search for fund code in combination with library works

The budgets to be shown can depend on your permissions.
Testing with with a superlibrarian should bring up all funds.

Also fixes warns in the logs that appeared when viewing the funds
for a budget without funds.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Funds are now searchable.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 6931 : Only update frameworks for the correct marcflavour
Chris Cormack [Thu, 19 Apr 2012 21:52:04 +0000 (09:52 +1200)]
Bug 6931 : Only update frameworks for the correct marcflavour

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 1577 - update INSTALL to mention need to translate templates
MJ Ray [Wed, 18 Apr 2012 15:34:02 +0000 (16:34 +0100)]
Bug 1577 - update INSTALL to mention need to translate templates

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 6267 custom http user-agent in check-url.pl (fix for books.google.com 401 error)
MJ Ray [Thu, 5 Apr 2012 12:18:07 +0000 (13:18 +0100)]
Bug 6267 custom http user-agent in check-url.pl (fix for books.google.com 401 error)

Patch by Judit with a small change to the help wording.
Sponsored by CALYX information essentials.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7726: explanation and options that were in the wrong order
Paul Poulain [Tue, 27 Mar 2012 07:56:33 +0000 (09:56 +0200)]
Bug 7726: explanation and options that were in the wrong order

I also removed the ` mysql-ism

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7693 - clear screen button misaligned
Gaetan Boisson [Thu, 12 Apr 2012 15:59:32 +0000 (17:59 +0200)]
Bug 7693 - clear screen button misaligned

This patch removes firefox specific lines in the css which were breaking the display

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
This fixes the layout problem in current versions of Firefox. I think
the CSS which is removed by this patch might be necessary for older
versions of Firefox, but if this turns out to be a problem we can
follow up.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7950 - Typo for preference intranetuserjs
Kyle M Hall [Thu, 12 Apr 2012 16:25:09 +0000 (12:25 -0400)]
Bug 7950 - Typo for preference intranetuserjs

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 3337 - RSS link is not correct for searches without results
Katrin Fischer [Sat, 14 Apr 2012 22:09:34 +0000 (00:09 +0200)]
Bug 3337 - RSS link is not correct for searches without results

RSS links for searches without results didn't have the search terms.

To test:
- Search for something with results and check RSS link
- Search for something with no results and check RSS link

In both cases your search should show up in the link.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
RSS Link works in both cases listed in test plan.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7833 - unique holiday link broken
Katrin Fischer [Sat, 14 Apr 2012 15:50:51 +0000 (17:50 +0200)]
Bug 7833 - unique holiday link broken

As Nicole stated on the bug the branchcode was missing from the links.

To test:
- add unique holidays to calendar for different branches
- click on link and check that the date is opened in the right calendar

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Clicked links for unique holidays and exceptions for
multiple branches and everything works perfectly.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7845: Multiple 260s don't display properly in search results
Katrin Fischer [Mon, 9 Apr 2012 15:44:38 +0000 (17:44 +0200)]
Bug 7845: Multiple 260s don't display properly in search results

Corrects display for multiple 260 fields in intranet and OPAC.
In intranet the order of fields was wrong on the detail page.
In OPAC and intranet punctuation for multiple 260 fields in the
result list was not displaying properly.

Example after correction:
Publisher: Jena : Elsevier, 1907 ; Stuttgart : Franckh, 1907-1992 ; Jena : Urban & Fischer, 1993-2003

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7922: Fixing typo in German sample news
Katrin Fischer [Sun, 8 Apr 2012 11:30:10 +0000 (13:30 +0200)]
Bug 7922: Fixing typo in German sample news

Fehlerkorrektoren > Fehlerkorrekturen

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7354: Can't edit local use system preferences
Katrin Fischer [Thu, 12 Apr 2012 06:59:32 +0000 (08:59 +0200)]
Bug 7354: Can't edit local use system preferences

Fixes adding and editing of local use system preferences and redirects to correct
page after saving.

To test:
- Create a new local use system preference
- Edit an existing local use system preference from summary page
- Edit an existing local use system preference using 'Edit'
- Delete a local use system preference

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7528 - amount subtracting 1 cent
mveron [Sun, 15 Apr 2012 15:20:16 +0000 (17:20 +0200)]
Bug 7528 - amount subtracting 1 cent

Rounding issue with JavaScript and float numbers, JavaScript changed to do no calculation if discount is 0

Signed-off-by: Ian Walls <koha.sekjal@gmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7927 - library not showing on subscription full history anymore
Katrin Fischer [Wed, 11 Apr 2012 06:41:57 +0000 (08:41 +0200)]
Bug 7927 - library not showing on subscription full history anymore

Restores former functionality:
Shows the branchcode in the branch column for the full history
view of subscriptions in OPAC.

http://bugs.koha-community.org/show_bug.cgi?id=7929
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Branch codes are visible again.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agobug 7016 further followup: clarify return of GetItemnumbersForBiblio
Galen Charlton [Wed, 11 Apr 2012 20:13:22 +0000 (16:13 -0400)]
bug 7016 further followup: clarify return of GetItemnumbersForBiblio

New function was actually returning an arrayref, so made
perldoc and function usage consistent.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7016 Followup: Add new GetItemnumberForBiblio subroutine
Ian Walls [Fri, 6 Jan 2012 14:53:49 +0000 (09:53 -0500)]
Bug 7016 Followup: Add new GetItemnumberForBiblio subroutine

Adds a new subroutine in C4::Items, GetItemnumbersForBiblio, which takes a
single biblionumber, and returns an array of all the corresponding itemnumbers.

This patch also replaces the usage of get_itemnumbers_of in C4::Reserves::CanBookBeReserved
with this new subroutine, as the output is more consistent with what we were
lookng for (this is what fixes the bug issue).

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7831 : Sort budgets for selection in new order
Colin Campbell [Tue, 27 Mar 2012 15:04:12 +0000 (16:04 +0100)]
Bug 7831 : Sort budgets for selection in new order

The select budget dropdown list should be presented in
an ordered fashion. To achieve this sort the budget array
by the visible text.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7940 - Placing a hold on a single item from the staff cart causes errors
Kyle M Hall [Tue, 10 Apr 2012 15:36:36 +0000 (11:36 -0400)]
Bug 7940 - Placing a hold on a single item from the staff cart causes errors

This is caused by the javascript function placeHold() in basket.pl
The cause of this error is thus: when a staff member uses the cart
to place holds on multiple items at once, the cart redirects to
reserver/request.pl with the params 'biblionumbers' ( a string of
biblionumbers separated by slashes ( e.g. '5/4/3/' ) and the param
multi_hold with a value of 1.

When multi_hold is enabled, request.pl splits the string 'biblionumbers'
on those slashes and works on that list.

In placeHold(), when only one item is checked, the system passes
the param biblionumbers with a single biblionumber ( e.g. '5/' )
and does *not* pass the multi_hold param. This causes request.pl
to not parse the biblionumbers param, and thus reserve.pl has
no biblionumber to work on ( hence our error here ).

There are two options to resolve this:
A) Add the multi_hold param even for a single hold from the cart.
B) In the event of a single hold being placed from the cart,
   switch to the standard single hold url ( i.e. request.pl?biblionumber=234 )

This commit resolves the situation using option B, as it seems more
logical than using the multi-holds system for a single hold.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
passes tests, works as advertised. Good catch!

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7838 - Add sort-string-utf.chr for Ukrainian and Russian
Serhij Dubyk {Сергій Дубик} [Tue, 27 Mar 2012 23:46:09 +0000 (02:46 +0300)]
Bug 7838 - Add sort-string-utf.chr for Ukrainian and Russian

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoUpdating euskara and french translation teams
Paul Poulain [Tue, 10 Apr 2012 14:13:37 +0000 (16:13 +0200)]
Updating euskara and french translation teams

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7935 follow-up: Update DBRev
Jared Camins-Esakov [Fri, 4 May 2012 00:09:18 +0000 (20:09 -0400)]
Bug 7935 follow-up: Update DBRev

Version 3.06.04.004

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7935: Introduce sys pref to control 'browse results' in OPAC
Katrin Fischer [Mon, 9 Apr 2012 19:27:16 +0000 (21:27 +0200)]
Bug 7935: Introduce sys pref to control 'browse results' in OPAC

Patch introduces a new system preference "OpacBrowseResults" to control
the feature for browsing and paging through results shown on top of the
left menu on detail pages in OPAC.

Preference is activated by default and can be deactivated using the
system preference.

To test:
 - Check database update works correctly
 - Check that browsing and paging still works with after database update
 - Deactivate the feature by setting 'OpacBrowseResults' to 'Disable'
 - Check the feature does no longer show up in OPAC
 - Check that a new installation also has the system preference with correct default

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7893 - add package dependencies
Robin Sheat [Wed, 4 Apr 2012 11:10:59 +0000 (23:10 +1200)]
Bug 7893 - add package dependencies

This adds some dependencies to the control file that are required.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>