From 5a9f79c1bd3b1e35bbe80d98eef6d1e51354479f Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Fri, 23 Dec 2016 09:18:03 +0000 Subject: [PATCH] Bug 17808: Fix behavior when editing a circ rule The original behavior is broken, see https://stackoverflow.com/questions/21410484/jquery-selector-to-find-out-count-of-non-empty-inputs Test plan: Edit a circ rule => Without this patch you get a useless message => With this patch, no message Edit a circ rule with content in inputs => With or without this patch you get a useful message Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall (cherry picked from commit 5a9ffa92cecf69ec44450da9676cfbdb0f7d9fa1) Signed-off-by: Katrin Fischer --- koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt index fea01f3dd2..d5bdec273c 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt @@ -40,7 +40,7 @@ $(document).ready(function() { $('#selectlibrary').submit(); }); $(".editrule").click(function(){ - if ( $(edit_row).find("input[type='text'][value!='']").length > 0 ) { + if ( $("#edit_row").find("input[type='text']").filter(function(){return this.value.length > 0 }).length > 0 ) { var edit = confirm(_("Are you sure you want to edit another rule?")); if (!edit) return false; } -- 2.39.5