From a198cba41aff6fd4181b42592ba5afb5f7ef51eb Mon Sep 17 00:00:00 2001 From: Fridolyn SOMERS Date: Fri, 16 Aug 2013 13:36:10 +0200 Subject: [PATCH] Bug 10741: restore holdability of in-transit items on OPAC search results In search results, one could not place a hold on an item in transit and for loan (items.notforloan=0). This appears when AllowOnShelfHolds is allowed. This patch repairs a regression introduced by the patch for bug 8975. Test plan : - Set AllowOnShelfHolds to on - Create a record with a normal item : not lost, not withdrawn, not damaged, notforloan=0 - Index this record - Perform a search on OPAC that returns this record (and others) => You see in actions "Place hold" - Add this item in transit : /cgi-bin/koha/circ/branchtransfers.pl - Re-perform the search on OPAC => You see in actions "Place hold" and item "in transit" Signed-off-by: Owen Leonard Signed-off-by: Chris Cormack Signed-off-by: Galen Charlton (cherry picked from commit 239513dc7a13a1a31356b59ab8e36b120c0fa281) Signed-off-by: Tomas Cohen Arazi (cherry picked from commit e143ff307286698575a41e943202c902f1493071) Signed-off-by: Bernardo Gonzalez Kriegel (cherry picked from commit e143ff307286698575a41e943202c902f1493071) --- C4/Search.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/C4/Search.pm b/C4/Search.pm index 7541a7b36c..8b85f4f817 100644 --- a/C4/Search.pm +++ b/C4/Search.pm @@ -1903,8 +1903,8 @@ sub searchResults { $can_place_holds = 1; } } - } elsif ( $item->{notforloan} < 0 ) { - # item is not damaged and notforloan is < 0 + } elsif ( !$item->{notforloan} || $item->{notforloan} < 0 ) { + # item is not damaged and item is either for loan or has notforloan < 0 $can_place_holds = 1; } } -- 2.39.5