From 9fad5e032163cbd08c7dbcb708ee694838cc42a0 Mon Sep 17 00:00:00 2001
From: Nick Clemens <nick@bywatersolutions.com>
Date: Thu, 26 Sep 2024 19:53:28 +0000
Subject: [PATCH] Bug 37526: (QA follow-up) Tidy

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
---
 .../Koha/BackgroundJob/ErmSushiHarvester.t    | 94 +++++++++++++------
 1 file changed, 63 insertions(+), 31 deletions(-)

diff --git a/t/db_dependent/Koha/BackgroundJob/ErmSushiHarvester.t b/t/db_dependent/Koha/BackgroundJob/ErmSushiHarvester.t
index 214cbc4186..9621f5a488 100755
--- a/t/db_dependent/Koha/BackgroundJob/ErmSushiHarvester.t
+++ b/t/db_dependent/Koha/BackgroundJob/ErmSushiHarvester.t
@@ -232,31 +232,48 @@ subtest 'is_redirect() tests' => sub {
     $schema->storage->txn_begin;
 
     my $ua = Test::MockModule->new('LWP::UserAgent');
-    $ua->mock('simple_request', sub {
+    $ua->mock(
+        'simple_request',
+        sub {
             return mock_HTTP_redirect();
-    });
-    $ua->mock('get', sub {
-        return mock_sushi_response({'error'=>'invalid_api_key'});
-    });
+        }
+    );
+    $ua->mock(
+        'get',
+        sub {
+            return mock_sushi_response( { 'error' => 'invalid_api_key' } );
+        }
+    );
 
     my $usage_data_provider = $builder->build_object(
         { class => 'Koha::ERM::EUsage::UsageDataProviders', value => { name => 'TestProvider' } } );
 
     my $job_args = {
-            ud_provider_id   => $usage_data_provider->erm_usage_data_provider_id,
-            report_type      => 'TR_J1',
-            begin_date       => '2023-08-01',
-            end_date         => '2023-09-30',
-            ud_provider_name => $usage_data_provider->name,
-        };
+        ud_provider_id   => $usage_data_provider->erm_usage_data_provider_id,
+        report_type      => 'TR_J1',
+        begin_date       => '2023-08-01',
+        end_date         => '2023-09-30',
+        ud_provider_name => $usage_data_provider->name,
+    };
 
     my $job_id = Koha::BackgroundJob::ErmSushiHarvester->new->enqueue($job_args);
-    my $job = Koha::BackgroundJobs->find($job_id)->_derived_class;
-    $job->process( $job_args );
+    my $job    = Koha::BackgroundJobs->find($job_id)->_derived_class;
+    $job->process($job_args);
 
-    is( $job->{messages}[0]->{message}, decode_json($sushi_response_errors->{invalid_api_key})->{Severity} . ' - ' . decode_json($sushi_response_errors->{invalid_api_key})->{Message},'SUSHI error invalid_date_arguments is stored on job messages correctly' );
-    is( $job->{messages}[0]->{type},'error','SUSHI error invalid_date_arguments is stored on job messages correctly' );
-    is( $job->{messages}[0]->{code},decode_json($sushi_response_errors->{invalid_api_key})->{Code},'SUSHI error invalid_date_arguments is stored on job messages correctly' );
+    is(
+        $job->{messages}[0]->{message},
+        decode_json( $sushi_response_errors->{invalid_api_key} )->{Severity} . ' - '
+            . decode_json( $sushi_response_errors->{invalid_api_key} )->{Message},
+        'SUSHI error invalid_date_arguments is stored on job messages correctly'
+    );
+    is(
+        $job->{messages}[0]->{type}, 'error',
+        'SUSHI error invalid_date_arguments is stored on job messages correctly'
+    );
+    is(
+        $job->{messages}[0]->{code}, decode_json( $sushi_response_errors->{invalid_api_key} )->{Code},
+        'SUSHI error invalid_date_arguments is stored on job messages correctly'
+    );
 
     $schema->storage->txn_rollback;
 };
@@ -296,19 +313,34 @@ sub mock_sushi_response {
 sub mock_HTTP_redirect {
     my $response = Test::MockObject->new();
 
-    $response->mock('code', sub {
-        return 301;
-    });
-    $response->mock('is_error', sub {
-        return 0;
-    });
-    $response->mock('is_redirect', sub {
-        return 1;
-    });
-    $response->mock('header', sub {
-        return 'www.whatever.com';
-    });
-    $response->mock('decoded_content', sub {
-        return 'Moved permanently';
-    });
+    $response->mock(
+        'code',
+        sub {
+            return 301;
+        }
+    );
+    $response->mock(
+        'is_error',
+        sub {
+            return 0;
+        }
+    );
+    $response->mock(
+        'is_redirect',
+        sub {
+            return 1;
+        }
+    );
+    $response->mock(
+        'header',
+        sub {
+            return 'www.whatever.com';
+        }
+    );
+    $response->mock(
+        'decoded_content',
+        sub {
+            return 'Moved permanently';
+        }
+    );
 }
-- 
2.39.5