From cc86857dd642e9c5a53012f005dd59899bc2cb0d Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Thu, 5 Dec 2013 09:13:35 -0500 Subject: [PATCH] Bug 11342: fix error in OPAC self registration form if BorrowersTitles is empty If BorrowersTitles is empty, it causes the library pulldown on the self registration page to be empty, and to have the "Saluation" field have the option "branches". This patch also fixes a minor string capitalization issue. Test Plan: 1) Enable OPAC self registration 2) Set the system preference BorrowersTitles to be empty 3) View the self registration page 4) Note the lack of branches in the home library pulldown 5) Apply this patch 6) Note the branches now display in the pulldown Signed-off-by: Christopher Brannon Signed-off-by: Katrin Fischer Tested in bootstrap and prog OPAC, with BorrowersTitle configured and emptied. Passes all tests and QA script. Note: The titles pull down has 2 empty entries in master with and without the patch. Signed-off-by: Galen Charlton (cherry picked from commit 9a5f737dcbb1c695130a3acafd46a63a44f2e4cf) Signed-off-by: Fridolin Somers --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 4 ++-- koha-tmpl/opac-tmpl/prog/en/modules/opac-memberentry.tt | 4 ++-- opac/opac-memberentry.pl | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt index a82380a177..0d48e8dd29 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt @@ -68,7 +68,7 @@ [% ELSE %] + Home library: [% FOREACH b IN branches %] @@ -107,7 +107,7 @@ Identity
    - [% UNLESS hidden.defined('title') %] + [% UNLESS hidden.defined('title') || !member_titles %]
  1. [% IF mandatory.defined('title') %]