]> git.koha-community.org Git - koha.git/log
koha.git
12 years agoBug 8680 Z39.50 ISBN Search is problematic and there is a missing ISSN field.
Joseph Alway [Thu, 20 Sep 2012 17:39:28 +0000 (12:39 -0500)]
Bug 8680 Z39.50 ISBN Search is problematic and there is a missing ISSN field.

The changes here are duplicate fixes.
The cataloguing directory had the same bugs as the acqui directory.
The bugs in the cataloguing files of the same name were fixed in Bug 8550.
The bugs in the acqui files had not been fixed.
This will fix Bug 8680 which is in the Acquisitions Module.

Changes to the z3950_search.pl file:
Rather than treating ISBN and ISSN as the same, this patch breaks
them out into separate parts of the query, as well as changing
the truncation attribute to enable right truncation (the correct
behavior for the ISBN field in MARC21, and valid behavior in
UNIMARC).

Changes to the z3950_search.tt file:
Sometime in 2009 or so, the ISSN field was removed from the Z39.50 search
page, and the ISBN field replaced with a combined ISBN/ISSN field. Since
this breaks ISBN search for most Z39.50 targets (due to the
differing treatment of ISBN vs. ISSN), this is a bug not a feature.

Signed-off-by: Marc Veron <veron@veron.ch>
Works as expected.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 6037 [Follow-up] Invalid markup, missing breadcrumbs on Keyword to MARC Mapping...
Owen Leonard [Fri, 14 Sep 2012 16:33:42 +0000 (12:33 -0400)]
Bug 6037 [Follow-up] Invalid markup, missing breadcrumbs on Keyword to MARC Mapping page

Extra </div> returned. Killing it again.

After applying the patch the validator should only warn of
invalid "autocomplete" attribute.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8850: Export CanItemBeReserved in C4::ILSDI::Services
Julian Maurice [Tue, 2 Oct 2012 09:26:39 +0000 (11:26 +0200)]
Bug 8850: Export CanItemBeReserved in C4::ILSDI::Services

Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8850: Export CanBookBeReserved in C4::ILSDI::Services
Julian Maurice [Mon, 1 Oct 2012 09:56:22 +0000 (11:56 +0200)]
Bug 8850: Export CanBookBeReserved in C4::ILSDI::Services

Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8796 - patron cards not starting on designated card
Marc Veron [Mon, 24 Sep 2012 20:19:56 +0000 (22:19 +0200)]
Bug 8796 - patron cards not starting on designated card

Better wording for the meaning of 'Position' to prevent mistakes on behaviour.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8497: Strange behavior when modifying the timeout system preference
Fridolyn SOMERS [Tue, 2 Oct 2012 11:49:32 +0000 (13:49 +0200)]
Bug 8497: Strange behavior when modifying the timeout system preference

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Tested standard login, patron auto-complete, and system preferences.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8810 - Opac: Cart should display branchname instead of branchcode
Marc Veron [Mon, 24 Sep 2012 13:05:12 +0000 (15:05 +0200)]
Bug 8810 - Opac: Cart should display branchname instead of branchcode

In Opac, the cart should display the branchname instead of the branchcode.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8379 don't close dbh
Paul Poulain [Mon, 24 Sep 2012 20:48:30 +0000 (22:48 +0200)]
Bug 8379 don't close dbh

don't close the DBH handler, because under plack this cause a lot of problem
and in CGI mode, closing the dbh handler is useless

Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8379 removing another useless ->disconnect line
Paul Poulain [Mon, 24 Sep 2012 20:55:45 +0000 (22:55 +0200)]
Bug 8379 removing another useless ->disconnect line

and s/tab/spaces/

Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7589 - tinymce editor broken in .deb packages - in 'en' templates
Mason James [Tue, 8 May 2012 04:59:20 +0000 (16:59 +1200)]
Bug 7589 - tinymce editor broken in .deb packages - in 'en' templates

this patch fixes a glitchy symlink to tiny_mce

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Note that you have to *remove* koha-common then install fresh in order
to recreate the symlink.

VERY IMPORTANT!!! debian/rules MUST USE TABS. USE -n WHEN COMMITING
THIS PATCH, AND DO NOT REPLACE TABS WITH SPACES.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8739 follow-up fixing perlcritic error
Paul Poulain [Wed, 3 Oct 2012 16:02:38 +0000 (18:02 +0200)]
Bug 8739 follow-up fixing perlcritic error

This patch is not related nor introduced by bug 8739, but while qa-ing it, I found those 2 perlcritic violation

this patch fixes it !

I also fixed a tiny indentation problem

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8739 - Partial Fine Payments Saving Amount Paid Incorrectly
Kyle M Hall [Fri, 7 Sep 2012 15:44:22 +0000 (11:44 -0400)]
Bug 8739 - Partial Fine Payments Saving Amount Paid Incorrectly

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Confirmed using test plan that the display is corrected.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8744: Thesaurus in authorities should not lock fields
Jared Camins-Esakov [Sun, 9 Sep 2012 12:55:12 +0000 (08:55 -0400)]
Bug 8744: Thesaurus in authorities should not lock fields

Although fields in the authority editor should support thesaurus
control, they should never be locked, as authority records commonly
refer to other records that may not be in use locally (and therefore
might not be in the authority file).

Test plan:
1) Make sure a 5xx field in one of your authority frameworks is
   thesaurus-controlled.
2) Note that you cannot edit the field directly.
3) Apply patch.
4) Note that you can now edit the field irectly.

Signed-off-by: wajasu <matted-34813@mypacks.net>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8711 - alternating colors messed up on reports
Owen Leonard [Thu, 6 Sep 2012 19:21:03 +0000 (15:21 -0400)]
Bug 8711 - alternating colors messed up on reports

Patch adds the "zebra-striping" option to the
table sorter initialization and changes the row
color CSS to match the tablesorter's to prevent
conflicts.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8583 : Add a warning if a Z39.50 search is started from biblio edition page.
Frédérick Capovilla [Fri, 30 Sep 2011 19:11:01 +0000 (15:11 -0400)]
Bug 8583 : Add a warning if a Z39.50 search is started from biblio edition page.

Warn the user that the current biblio record might be overwritten by
this action.

Signed-off-by: Marc Veron <veron@veron.ch>
Woks as expected. I prefer this solution with an explicit warning,
since several times I acidentally changed a record  :-)

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8350: warning in logs when searching for nonexistent ISBN
Mark Tompsett [Thu, 30 Aug 2012 07:06:07 +0000 (15:06 +0800)]
Bug 8350: warning in logs when searching for nonexistent ISBN

Searching for a 10 or 13 digit numeric string that does not exist in
one's catalog will fail to affect SQL statement correctly
in C4::Breeding. Moved string substitution, which was triggering error
when search was undefined, and fixed if statements accordingly.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8581: don't display parentheses when we don't have a type
Jared Camins-Esakov [Mon, 6 Aug 2012 18:04:32 +0000 (14:04 -0400)]
Bug 8581: don't display parentheses when we don't have a type

Prior to this patch, see also references in certain authority records
(most notably GND records) were being followed by empty parentheses in
the search results display. This patch resolves that problem.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7642: Fixing typo
Chris Cormack [Mon, 1 Oct 2012 22:26:19 +0000 (11:26 +1300)]
Bug 7642: Fixing typo

12 years agoBug 7642 follow-up fix POD
Paul Poulain [Mon, 1 Oct 2012 15:42:23 +0000 (17:42 +0200)]
Bug 7642 follow-up fix POD

The patch for bug 7642 did not introduce this error, but the QA tools detected it, so I fixed it

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7642 - [3.8.x] fix the lost display of tag sizes
Robin Sheat [Fri, 28 Sep 2012 23:34:32 +0000 (11:34 +1200)]
Bug 7642 - [3.8.x] fix the lost display of tag sizes

This fixes the display of different sized words for differently popular
tags. It is a bit of a refactor of that part of the system, moving
logic to more sensible places (and removing an unused method on the
way.)

Note that it isn't an attempt to reproduce what was there previously,
just to do something similar, and in an easier to change fashion.

Sponsored-By: New Zealand Educational Institute
Signed-off-by: Marc Veron <veron@veron.ch>
Works as expected.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8659 Remove and readd the inactive funds in javascript to make it work in all...
Maxime Pelletier [Tue, 21 Aug 2012 22:02:31 +0000 (18:02 -0400)]
Bug 8659 Remove and readd the inactive funds in javascript to make it work in all browsers

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8702: System preferences search does not allow accented letters
Fridolyn SOMERS [Tue, 18 Sep 2012 13:59:37 +0000 (15:59 +0200)]
Bug 8702: System preferences search does not allow accented letters

This bug enables accented/diacritic system preference text to be matched
when searching for sysprefs.

Signed-off-by: wajasu <matted-34813@mypacks.net>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8617 - Problem with display of comments waiting for moderation in OPAC
Owen Leonard [Thu, 16 Aug 2012 19:19:04 +0000 (15:19 -0400)]
Bug 8617 - Problem with display of comments waiting for moderation in OPAC

This patch addresses on aspect of Bug 8617: The behavior where
live previews of edited comments are displaying on opac-detail
as a duplicate comment. We must pass the review id back to the
script when submitting so that the check for it will evaluate
as true when it should.

This patch also corrects some JavaScript for translatability.

To test, submit a comment on a title and approve it. Return to
the title and edit the comment. When you submit your revised
comment the comment pop-up window should close and your revised
comment should appear on opac-detail as "pending approval."

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8764 - Template change "Authors" to "Additional authors" in OPAC
David Cook [Wed, 12 Sep 2012 20:31:41 +0000 (06:31 +1000)]
Bug 8764 - Template change "Authors" to "Additional authors" in OPAC

This patch simply changes "Authors" to "Additional authors" in the OPAC. This label describes authors that are added via the MARC 700 fields, which are added or additional authors.

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Works as advertised, and seems to make sense. Only affects the display
when XSLT is not enabled.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8629: update of statistics fields on fund selection in order creation/edition
Fridolyn SOMERS [Mon, 13 Aug 2012 11:55:11 +0000 (13:55 +0200)]
Bug 8629: update of statistics fields on fund selection in order creation/edition

Signed-off-by: Marc Veron <veron@veron.ch>
Followed test plan in comment #1
Behaves as described in the test plan.
Useful feature!

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 4173: Followup: Document KohaAuthorisedValues plugin
Kyle M Hall [Thu, 6 Sep 2012 13:23:08 +0000 (09:23 -0400)]
Bug 4173: Followup: Document KohaAuthorisedValues plugin

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 4173: Followup: put the lib into a variable
Jonathan Druart [Wed, 25 Jul 2012 14:20:30 +0000 (16:20 +0200)]
Bug 4173: Followup: put the lib into a variable

Prevent 2 calls instead of 1

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 4173 - Statuses not appearing in the OPAC
Kyle M Hall [Thu, 12 Jul 2012 14:48:12 +0000 (10:48 -0400)]
Bug 4173 - Statuses not appearing in the OPAC

For the authorised values LOST and DAMAGED, if an OPAC description
is defined for the given value, display that description in the OPAC
rather than the generic description.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8721: Fixes minor typo in AllowItemsOnHoldCheckout
Nicole C. Engard [Tue, 4 Sep 2012 15:22:48 +0000 (11:22 -0400)]
Bug 8721: Fixes minor typo in AllowItemsOnHoldCheckout

Small string fix to remove repeated word.

Signed-off-by: Marc Veron <veron@veron.ch>
Tiny typo fix

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoMerge remote-tracking branch 'tamil/3.8.5-translate' into 3.8.x v3.08.05
Chris Cormack [Sat, 22 Sep 2012 18:40:25 +0000 (06:40 +1200)]
Merge remote-tracking branch 'tamil/3.8.5-translate' into 3.8.x

12 years agoBumping version number for release
Chris Cormack [Sat, 22 Sep 2012 18:36:19 +0000 (06:36 +1200)]
Bumping version number for release

12 years ago3.8.5 Translation Update
Frédéric Demians [Sat, 22 Sep 2012 06:03:45 +0000 (08:03 +0200)]
3.8.5 Translation Update

12 years agoUpdated the release notes
Chris Cormack [Sat, 22 Sep 2012 00:23:21 +0000 (12:23 +1200)]
Updated the release notes

12 years agoBug 6617 - Wrong first indicator value in test
Tomas Cohen Arazi [Thu, 23 Aug 2012 15:58:52 +0000 (12:58 -0300)]
Bug 6617 - Wrong first indicator value in test

Testing the first indicator value=2 should be used for labeling 'Partial content'.

Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoRelease notes for 3.8.5
Chris Cormack [Fri, 21 Sep 2012 21:30:51 +0000 (09:30 +1200)]
Release notes for 3.8.5

12 years agoBug 8717 - Wrong subscription notes are showing in catalogue detail view of serials...
David Cook [Tue, 4 Sep 2012 02:19:41 +0000 (12:19 +1000)]
Bug 8717 - Wrong subscription notes are showing in catalogue detail view of serials in staff client

Changes the subscription note from the opac "notes" to the proper staff client "internalnotes" field.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 3782: Remove broken z39.50 targets from sample files
Katrin Fischer [Wed, 22 Aug 2012 20:33:26 +0000 (22:33 +0200)]
Bug 3782: Remove broken z39.50 targets from sample files

Removes NYPL and NYU from the list of sample z39.50 servers, because
they don't work or only work inconsistently.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8275: xml parsing error when the webservice GetPatronInfo/show_loans is called
Fridolyn SOMERS [Thu, 19 Jul 2012 09:37:16 +0000 (11:37 +0200)]
Bug 8275: xml parsing error when the webservice GetPatronInfo/show_loans is called

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8336 follow-up, tabs to space
Paul Poulain [Tue, 18 Sep 2012 09:23:42 +0000 (11:23 +0200)]
Bug 8336 follow-up, tabs to space

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8336 Support Sip Renewal Transaction
Colin Campbell [Fri, 29 Jun 2012 17:43:28 +0000 (18:43 +0100)]
Bug 8336 Support Sip Renewal Transaction

Renewals were being rejected for incorrect reasons
Checking was being done against the wrong object
Add more informative messages on failure
Correctly set due_date for renewal response
Avoid crashing the SIPServer because it handles RenewAll
incorrectly

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8765 follow-up replace tabs by spaces
Paul Poulain [Mon, 17 Sep 2012 17:00:05 +0000 (19:00 +0200)]
Bug 8765 follow-up replace tabs by spaces

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8765 - Add series title to intranet search results
David Cook [Wed, 12 Sep 2012 21:00:13 +0000 (07:00 +1000)]
Bug 8765 - Add series title to intranet search results

Patch adds series title to intranet search results, so that the
series volume is no longer displayed on its own.

It also removes the comma that comes before the series volume as
this is unnecessary punctuation that creates duplicate punctuation
in search results.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8713 - Warning message triggered by clicking Keywords to MARC mapping
Mark Tompsett [Mon, 3 Sep 2012 03:00:32 +0000 (11:00 +0800)]
Bug 8713 - Warning message triggered by clicking Keywords to MARC mapping

In the Koha Administration screen, clicking
Keywords to MARC mapping triggered an uninitialized $op warning
in the koha error logs. Added a "|| q{}" to ensure it is set.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8727 Minor stylistic change to help text
Colin Campbell [Wed, 5 Sep 2012 13:03:13 +0000 (14:03 +0100)]
Bug 8727 Minor stylistic change to help text

indexing not indexation
some minor grammatical changes

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7690: hidelostitems not working in Normal Display
Fridolyn SOMERS [Thu, 9 Aug 2012 10:43:20 +0000 (12:43 +0200)]
Bug 7690: hidelostitems not working in Normal Display

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Tested by toggling both the hidelostitems preference and the
OpacHiddenItems preference. Both work as expected in the normal
search results display.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8714 - Poorly ordered and triggers warning in marctagstructure.pl
Mark Tompsett [Mon, 3 Sep 2012 04:27:58 +0000 (12:27 +0800)]
Bug 8714 - Poorly ordered and triggers warning in marctagstructure.pl

An array boundary check was after a comparison using the array.
By changing the logic which had " and ( $j < $cnt)" to be at the
beginning "( $j < $cnt ) and ", the warning is no longer shown
in the error log.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8705: Software error on help of main page
Fridolyn SOMERS [Thu, 30 Aug 2012 16:42:26 +0000 (18:42 +0200)]
Bug 8705: Software error on help of main page

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8420: tool statisticfines.pl(bz 6858) and hourly loan(bz5549)
Fridolyn SOMERS [Mon, 17 Sep 2012 11:03:17 +0000 (13:03 +0200)]
Bug 8420: tool statisticfines.pl(bz 6858) and hourly loan(bz5549)

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7409 : Missing dependency on DBD::Mock
Chris Cormack [Mon, 17 Sep 2012 07:34:08 +0000 (19:34 +1200)]
Bug 7409 : Missing dependency on DBD::Mock

12 years agoBug 7409 : Fixing typo
Chris Cormack [Sun, 16 Sep 2012 09:50:33 +0000 (21:50 +1200)]
Bug 7409 : Fixing typo

12 years agoBug 8520 - Authorities summary incorrect on posible duplicate notice
Tomas Cohen Arazi [Mon, 3 Sep 2012 18:01:38 +0000 (15:01 -0300)]
Bug 8520 - Authorities summary incorrect on posible duplicate notice

We didn't notice this one with jcamins when we fixed this bug.

Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8653 remove erroneous whitespace blocking indexing
Colin Campbell [Thu, 16 Aug 2012 17:19:20 +0000 (18:19 +0100)]
Bug 8653 remove erroneous whitespace blocking indexing

The superfluous whitespace after the definition of subject
tag $9s is causing an error when carried over into dom config
files so that the authority links fail to index

Also removed the (harmless) trailing space in the equivalent
Unimarc files

A good editor and git can help in not creating excess whitespace

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8743 follow-up, throw a more explanatory error message
Paul Poulain [Fri, 14 Sep 2012 13:59:50 +0000 (15:59 +0200)]
Bug 8743 follow-up, throw a more explanatory error message

When testing bug 8743, I discovered a missing index in my authority file.
The error message was
"CCL parsing error (10014) Unknown qualifier ZOOM"

which is not very helpfull because it does not show the query that was made.
This patch add the query itself after the zebra error

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8743: ZOOM error when merging authority change to biblios
Jared Camins-Esakov [Sun, 9 Sep 2012 12:18:05 +0000 (08:18 -0400)]
Bug 8743: ZOOM error when merging authority change to biblios

The merge fails and the following errors appear in the log:
[Sun Sep 02 23:38:10 2012] [error] [client 75.149.175.233] ZOOM error 25
"Specified element set name not valid for specified database" (addinfo:
"F") from diag-set 'Bib-1', referer:
http://****/cgi-bin/koha/authorities/authorities.pl?authid=3010
[Sun Sep 02 23:38:11 2012] [error] [client 75.149.175.233] Premature end of
script headers: authorities.pl, referer:
http://****/cgi-bin/koha/authorities/authorities.pl?authid=3010

Test plan:
1) Set dontmerge to "Do"
2) Find an authority that is linked to a bib record.
3) Edit the main entry of the authority.
4) Save the authority record.
5) Notice that you got a nasty error and the bib record was not updated.
6) Apply patch.
7) Edit the main entry of the authority again (you can just set it back
   to what it was to start with).
8) Save authority record.
9) Notice that there was no error, and the bib record was updated.
10) Sign off.

Signed-off-by: Doug Kingston <dpk@randomnotes.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8002 : Database bump
Chris Cormack [Sun, 16 Sep 2012 08:12:58 +0000 (20:12 +1200)]
Bug 8002 : Database bump

12 years agoBug 8002: FIX Change datatype from varchar 1 to 10 for borrower_attribute_types.categ...
Jonathan Druart [Thu, 6 Sep 2012 14:03:42 +0000 (16:03 +0200)]
Bug 8002: FIX Change datatype from varchar 1 to 10 for borrower_attribute_types.category_code

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Conflicts:

installer/data/mysql/updatedatabase.pl

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 6976 Close loophole allowing borrowers extra holds via opac
Colin Campbell [Tue, 28 Aug 2012 13:34:55 +0000 (14:34 +0100)]
Bug 6976 Close loophole allowing borrowers extra holds via opac

The check that the max number of reserves has
not been reached needs to take account of the fact
that we may have added enouch reserves to
reach the limit while this script is running.
Add a check against the incrementing count

The variable canreserve was only used when looping
through multiple holds but was not being
reinitialized on every iteration
make variable local to loop it is used in and
initialize to zero

Have used perltidy to correct the indention of
the while loop as it was misleading to the reader

Some numeric comparisons were using a string operator
fix them before strange bugs manifest themselves

The loophole manifests thus:
borrowers are only allowed Y holds.
If holds are done individually, it is
obeying that law i.e. X has held Y separate books –
 when I tried to do a 6th
book it told me that I could not place a hold.
However, if a borrower checks the catalogue,
gets the intial list up and clicks items on the “results”
box and then clicks “place hold” they can hold more than Y
items Please enter the commit message for your changes. Lines starting

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7409 : Missing dependency on libtest-mockmodule-perl
Chris Cormack [Sun, 16 Sep 2012 07:48:43 +0000 (19:48 +1200)]
Bug 7409 : Missing dependency on libtest-mockmodule-perl

12 years agoBug 8447: Make sure we have enough subfields for broader_headings
Jared Camins-Esakov [Fri, 7 Sep 2012 14:58:53 +0000 (10:58 -0400)]
Bug 8447: Make sure we have enough subfields for broader_headings

Thanks to wajasu for providing the debugging information, as I cannot
seem to duplicate the problem, even seeing where it could come from.

Fix corrects cases where upon save, a software error complaing about
indicators being wrong as a side effect of a poorly autogenerated
biblio/authority record.

Behvior with this fix causes existing bilio data to to be preserved
while linking to the authority via subtag 9.

Signed-off-by: wajasu <matted-34813@mypacks.net>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8418: load repeating holidays hash correctly
Colin Campbell [Tue, 14 Aug 2012 14:38:05 +0000 (15:38 +0100)]
Bug 8418: load repeating holidays hash correctly

The repeating holidays structure was being loaded in
a different order to how it was tested

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8656 Calendar needs to load both exception and nonexception dates
Colin Campbell [Mon, 20 Aug 2012 14:24:58 +0000 (15:24 +0100)]
Bug 8656 Calendar needs to load both exception and nonexception dates

single_holidays and exception_holidays were both being selected
with the same parameter with the result that single holidays were not
being loaded.

Have removed the retrieval of the unused parameters title and
description.

In effect the distinction is not meaningful for these routines and
the two structures could become one. This patch just fixes the
current bug

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8071: link between bib and authorities with the authid
Fridolyn SOMERS [Wed, 25 Jul 2012 15:59:54 +0000 (17:59 +0200)]
Bug 8071: link between bib and authorities with the authid

Do not automatically populate $9 in bibliographic headings when the
$9 is set in the authorized heading field of the authority record.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8719: Private lists always sorted by title
Adrien Saurat [Tue, 4 Sep 2012 11:59:35 +0000 (13:59 +0200)]
Bug 8719: Private lists always sorted by title

Virtualshelves:
The private lists were sorted by title, even when author or date was selected.
This patch corrects this behaviour.

Signed-off-by: Marc Veron <veron@veron.ch>
With this patch lists sort as expected.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8730 - browse overlaying powered by
Owen Leonard [Thu, 6 Sep 2012 19:02:29 +0000 (15:02 -0400)]
Bug 8730 - browse overlaying powered by

This patch adds a "z-index" property to the CSS for
the browse results menu so that it will appear
on top of the "Powered by Koha" link.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8017 reduce manipulation of GetAllIssues return
Colin Campbell [Fri, 27 Apr 2012 17:20:08 +0000 (18:20 +0100)]
Bug 8017 reduce manipulation of GetAllIssues return

GetAllIssues can produce large lists
For performance purposes:
Dont loop over the list without cause
Dont do expensive processing in the loop
Dont needlessly copy the array
Do display formatting in the template
Dont extract the barcode list unless we are producing it
Reduce db calls by using the data to hand

Make the table in the template a bit more readable
where everything was stuffed into one line

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8339 - div id="login" should be id="login_controls" in header.inc
Mark Tompsett [Tue, 11 Sep 2012 16:57:43 +0000 (00:57 +0800)]
Bug 8339 - div id="login" should be id="login_controls" in header.inc

After experiencing what I believe was stale CSS, I have
implemented oleonard's suggested fix which does work. That is:
header.inc change login to login_controls, and in
staff-global.css change the #login to #login_controls.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8677 - table overlapping to the right on holds waiting
Owen Leonard [Fri, 7 Sep 2012 15:23:08 +0000 (11:23 -0400)]
Bug 8677 - table overlapping to the right on holds waiting

Converting layout to 100% flexible width to allow
table to expand as needed.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8716 - make the routing list reordering function work
Robin Sheat [Tue, 4 Sep 2012 14:53:36 +0000 (16:53 +0200)]
Bug 8716 - make the routing list reordering function work

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 3456: Show internalnotes when receiving serials
Julian Maurice [Wed, 22 Aug 2012 10:29:13 +0000 (12:29 +0200)]
Bug 3456: Show internalnotes when receiving serials

Shows nonpublic note on serials receipt page.

Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7068 - autobarcode not working when duplicating patrons
MJ Ray [Fri, 7 Sep 2012 16:40:26 +0000 (17:40 +0100)]
Bug 7068 - autobarcode not working when duplicating patrons

Fixed by blanking cardnumber in the code and showing it in the template,
instead of just not showing it in the template

Autobarcode now correctly fills in on a duplicated patron.

Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7143 tiny follow-up, removing tabs
Paul Poulain [Thu, 13 Sep 2012 15:55:37 +0000 (17:55 +0200)]
Bug 7143 tiny follow-up, removing tabs

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7143: Adding Kathryn Tyree to the history and About page.
Melia Meggs [Tue, 11 Sep 2012 21:38:28 +0000 (16:38 -0500)]
Bug 7143: Adding Kathryn Tyree to the history and About page.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8524 follow-up: fix Javascript syntax error
Jared Camins-Esakov [Thu, 9 Aug 2012 12:39:10 +0000 (08:39 -0400)]
Bug 8524 follow-up: fix Javascript syntax error

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8524: Followup FIX an undeclared variable $query
Jonathan Druart [Thu, 9 Aug 2012 12:07:35 +0000 (14:07 +0200)]
Bug 8524: Followup FIX an undeclared variable $query

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Conflicts:

cataloguing/value_builder/barcode.pl

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8524 follow-up: fix broken test
Jared Camins-Esakov [Thu, 9 Aug 2012 11:45:05 +0000 (07:45 -0400)]
Bug 8524 follow-up: fix broken test

The t/Barcodes_ValueBuilder.t test had the wrong number of tests
declared, and rather than checking that a variable was undefined I was
checking that it had a length of zero. Fixed both issues.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8524: Add a non-automatic barcode plugin
Jared Camins-Esakov [Wed, 1 Aug 2012 15:54:55 +0000 (11:54 -0400)]
Bug 8524: Add a non-automatic barcode plugin

In addition to adding a new barcode plugin, this commit begins
refactoring the barcode generation code using a new module,
C4::Barcodes::ValueBuilder. From the POD:
    This module is intended as a shim to ease the eventual transition
    from having all barcode-related code in the value builder plugin
    barcode.pl file to using C4::Barcodes. Since the shift will require
    a rather significant amount of refactoring, this module will return
    value builder-formatted results, at first by merely running the
    code that was formerly in the barcodes.pl value builder, but later
    by using C4::Barcodes.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8251 Do not try to debar patrons if returns are not overdue
Colin Campbell [Wed, 5 Sep 2012 10:58:54 +0000 (11:58 +0100)]
Bug 8251 Do not try to debar patrons if returns are not overdue

If a period of suspension is configured in the issuing rules
a calculation to debar the patron was called on all returns
It should be limited to overdue returns

Renamed _FixFineDaysOnReturn subroutine to _debar_user_on_return
which is more descriptive of its purpose
Removed some unnecessary or duplicated processing
Changed visibility of $today so it didnt need
calculating twice
Removed declaration of a datedue variable that is
never used

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8708 [Revised] RSS feed for new comments is broken
Owen Leonard [Fri, 31 Aug 2012 13:04:13 +0000 (09:04 -0400)]
Bug 8708 [Revised] RSS feed for new comments is broken

Removing white space from the beginning of the file
so that XML processing will work correctly.

Before the patch, viewing the page
(/cgi-bin/koha/opac-showreviews.pl?format=rss) in a browser
which supports RSS handling (ex: Firefox)  will show you
unformatted and broken-looking text. After the patch the
page will trigger the browser's built-in RSS-handling format.

Revision: Template now includes comment pointing out that the <xml>
declaration must not have any white space before it.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8678: XSLT stylesheets output XML, but HTML is needed
Jared Camins-Esakov [Thu, 23 Aug 2012 16:27:49 +0000 (12:27 -0400)]
Bug 8678: XSLT stylesheets output XML, but HTML is needed

Because we are embedding the results of XSLT stylesheets in HTML, we
need to output HTML instead of XML. Outputting XML results in
non-standard-compliant (or at least non-Firefox-compliant) markup.

To test:
View a variety of XSLT-rendered pages on the OPAC and intranet, and
confirm that all look as expected.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8204 follow-up: don't display OpacNav on auth details
Jared Camins-Esakov [Mon, 27 Aug 2012 13:03:30 +0000 (09:03 -0400)]
Bug 8204 follow-up: don't display OpacNav on auth details

Based on the way we handle the bib details page, it seems we should
not be displaying OpacNav on the authority details pages on the OPAC.
This patch removes them.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8550: restore ISSN field to Z39.50 search
Jared Camins-Esakov [Wed, 1 Aug 2012 17:40:50 +0000 (13:40 -0400)]
Bug 8550: restore ISSN field to Z39.50 search

Sometime in 2009 or so, the ISSN field was removed from the Z39.50 search
page, and the ISBN field replaced with a combined ISBN/ISSN field. Since
this breaks ISBN search for most Z39.50 targets (due to the
differing treatment of ISBN vs. ISSN), this is a bug not a feature.

A future enhancement would be to use Business::ISBN to search for both
ISBN10 and ISBN13.

To test:
1) Apply patch.
2) Do a search for an ISBN using the ISBN field.
3) Do a search for an ISSN using the ISSN field.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8696: Update Export bibs on Tool Menu
Nicole C. Engard [Tue, 28 Aug 2012 15:00:04 +0000 (11:00 -0400)]
Bug 8696: Update Export bibs on Tool Menu

The tool for exporting bibs is now 'Export data'
this patch changes the label on the menu to reflect
that.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8261: Cannot search system preferences from Local Use tab
Fridolyn SOMERS [Wed, 29 Aug 2012 14:59:49 +0000 (16:59 +0200)]
Bug 8261: Cannot search system preferences from Local Use tab

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Conflicts:

koha-tmpl/intranet-tmpl/prog/en/includes/sysprefs-admin-search.inc

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8706 - Private lists can be accessed by anyone
Marcel de Rooy [Fri, 31 Aug 2012 09:48:51 +0000 (11:48 +0200)]
Bug 8706 - Private lists can be accessed by anyone

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Confirmed private lists can be accessed directly before patch is
applied. After applying patch, I can no longer access the list
via the same url.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8704 - Typo in etc/koha-conf.xml
Marcel de Rooy [Thu, 30 Aug 2012 12:59:32 +0000 (14:59 +0200)]
Bug 8704 - Typo in etc/koha-conf.xml

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7613: OCLC Connexion web service and desktop client, followup patch
D Ruth Bavousett [Mon, 11 Jun 2012 19:13:01 +0000 (12:13 -0700)]
Bug 7613: OCLC Connexion web service and desktop client, followup patch

Prior patches to this bug had lots of comments like "I don't have a way to test this, so..."

In the OCLC Connexion web, when you choose the option to export to MARC, it'll *send* it, and
say, "Record Exported," but the web client does nothing whatever to confirm that the record
actually landed in Koha.  That's a flaw in their software, but can be easily checked by
looking in Koha to see if an import batch got created.  The desktop client is a little
smarter about this, but needed much more testing, also.

With this patch, both the client and web will actually work.  With a config file and set up as
previously described, The record will be staged and/or imported, and the desktop client returns
a useful message about what happened, *and* the staff client URL to the record.

Oodles of gobs of bunches of thanks to Virginia Military Institute, for loaning me their OCLC
authorization credentials so this could be tested, as well as for great suggestions of cosmetic
improvements to the mechanism and output.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 5327 : Fixing a typo in the test that was causing a false fail
Chris Cormack [Wed, 5 Sep 2012 18:29:15 +0000 (06:29 +1200)]
Bug 5327 : Fixing a typo in the test that was causing a false fail

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
t/db_dependent/Items.t was failing despite valid data before patch,
works fine after

12 years agoBug 8478 - Update Ubuntu related files (3.8.x)
Mark Tompsett [Mon, 30 Jul 2012 16:09:43 +0000 (00:09 +0800)]
Bug 8478 - Update Ubuntu related files (3.8.x)

Updated allation instructions, cleaned up ubuntu-pkg-check.sh,
renamed ubuntu*.packages files more consistently, updated files
to include missing libraries, corrected incorrect libraries
 (yaz3->yaz4, mysqlclient v16 to v18, dropped the dev version of the client).

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 6886 Follow up for NORMARC
Chris Cormack [Sun, 5 Aug 2012 21:59:54 +0000 (09:59 +1200)]
Bug 6886 Follow up for NORMARC

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 6886 - Follow up for UNIMARC
Chris Cormack [Sun, 5 Aug 2012 21:44:36 +0000 (09:44 +1200)]
Bug 6886 - Follow up for UNIMARC

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 6886 - OPAC XSLT respecting single branch mode
Chris Cormack [Tue, 20 Sep 2011 03:27:08 +0000 (15:27 +1200)]
Bug 6886 - OPAC XSLT respecting single branch mode

This is only for the MARC21 XSLT at this stage, follow up patch for
UNIMARC will come

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8594 - prevent the report system from breaking some subqueries
Robin Sheat [Wed, 8 Aug 2012 16:02:13 +0000 (18:02 +0200)]
Bug 8594 - prevent the report system from breaking some subqueries

If you had a report query that had a subquery in the fields list, and
that subquery had a LIMIT specifier, then it would be removed which
could break your query. This patch prevents this case from breaking by
ensuring that only a LIMIT that follows the last WHERE in the query is
removed.

If you don't have a WHERE, then it will behave like it always
did, removing all the cases of LIMIT (which would still break a subquery
but this is a) more rare, and b) would require more intelligent parsing
to deal with.

Also adds test cases and function documentation.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Tested with this report:

select biblionumber, (select itemnumber from items where items.biblionumber=biblio.biblionumber LIMIT 1) from biblio where biblionumber<1000;

and it worked like a charm

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 2553 [Serials report] alphabetize dropdown menus
Owen Leonard [Thu, 23 Aug 2012 14:08:27 +0000 (10:08 -0400)]
Bug 2553 [Serials report] alphabetize dropdown menus

Rebase of a patch originally submitted by gcollum@gmail.com
Original commit message:

Improvement on the previous patch through the use of GetBranchesLoop.
Added code so that the logged in location will be the location that
is selected by default.

Fixed a couple of minor xhtml errors.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8675 Add hours and mins to renewal due date
Colin Campbell [Thu, 23 Aug 2012 13:04:31 +0000 (14:04 +0100)]
Bug 8675 Add hours and mins to renewal due date

If user supplies renewal with a new due date it should add
a time using the same logic as dateduespec in circulation.pl
rather than defaulting to 00:00

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Conflicts:

reserve/renewscript.pl

12 years agoBug 8666: Hide 'New basket' link if supplier is inactive
Julian Maurice [Wed, 22 Aug 2012 13:26:58 +0000 (15:26 +0200)]
Bug 8666: Hide 'New basket' link if supplier is inactive

Signed-off-by: Koha Team Lyon 3 <koha@univ-lyon3.fr>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 4064 - Uninitialized variable errors in opac-search.pl
Mark Tompsett [Tue, 4 Sep 2012 00:15:19 +0000 (08:15 +0800)]
Bug 4064 - Uninitialized variable errors in opac-search.pl

In 3.6.3 the error was triggered. It was already fixed with some
particularly ugly logic: if (($params->{'offset'}||'') eq '') {
Having read through the code, $offset is a better choice and
produces prettier, clearer code: if (!$offset) {

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7368: fixed subsribe typo
Kathryn Tyree [Thu, 23 Aug 2012 04:23:58 +0000 (16:23 +1200)]
Bug 7368: fixed subsribe typo

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Corrects typo.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8569: Paying for lost item overwrites nonpublic notes.
D Ruth Bavousett [Fri, 3 Aug 2012 14:53:23 +0000 (07:53 -0700)]
Bug 8569: Paying for lost item overwrites nonpublic notes.

This patch modifies C4::Circulation::ReturnLostItem to append the Paid-for note
to existing data, rather than overwriting it.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8012: default values for defaultSortField/defaultSortOrder NULL on install
D Ruth Bavousett [Fri, 17 Aug 2012 12:42:12 +0000 (08:42 -0400)]
Bug 8012: default values for defaultSortField/defaultSortOrder NULL on install

...which *looks* like "relevance/ascending" in the staff client, which doesn't make sense.
This patch initializes the values at "relevance/descending", which is a functional
combination.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8593 - Follow-up - Add unique IDs to pending approval markup on staff client...
Owen Leonard [Wed, 8 Aug 2012 12:39:10 +0000 (08:39 -0400)]
Bug 8593 - Follow-up - Add unique IDs to pending approval markup on staff client home page

This patch adds similar IDs to the tags and comments <div>

Signed-off-by: jorgia <jorgia_m_kelsey@hotmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>