]> git.koha-community.org Git - koha.git/log
koha.git
13 years agoBug 5509 - use an XML parser to get values from config
Robin Sheat [Thu, 16 Dec 2010 05:05:43 +0000 (18:05 +1300)]
Bug 5509 - use an XML parser to get values from config

Using sed and regex was causing issues when LDAP connection details were
added.

See
http://stackoverflow.com/questions/1732348/regex-match-open-tags-except-xhtml-self-contained-tags/1732454#1732454
for more information.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit dfc1038931618a820942f8cb9456be72648ce0f4)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 3543: split NLM call numbers in label creator
Jared Camins-Esakov [Wed, 13 Apr 2011 14:03:03 +0000 (10:03 -0400)]
Bug 3543: split NLM call numbers in label creator

Split NLM call numbers using the same rules as those used for Library of
Congress call numbers.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 139f7343f42c32e4bc1981bc072cf6ba05b20c0b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agohistory.txt updates for April 2011 releases
Galen Charlton [Fri, 22 Apr 2011 14:23:05 +0000 (10:23 -0400)]
history.txt updates for April 2011 releases

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d04ca42111a39da4774582c16f8fec03ed27f724)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoRevert "3.0.x: ce353e7 bug #3674 allow users creation with disabled password"
Chris Nighswonger [Thu, 21 Apr 2011 19:09:41 +0000 (15:09 -0400)]
Revert "3.0.x: ce353e7 bug #3674 allow users creation with disabled password"

This reverts commit 87b792b2b61c8232c2facecf6feb2ce5f3fa2b9e.

13 years agoBug 6211: Set default correctly for SubscriptionHistory syspref
Colin Campbell [Wed, 20 Apr 2011 02:16:13 +0000 (22:16 -0400)]
Bug 6211: Set default correctly for SubscriptionHistory syspref

Was being set to an invalid value ';'
resulting in weird behaviour where it looked set but was not
in practice

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d9be1d6ba9d5dc7cff65e0037ec8ecbe63c2a333)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoReverting pieces of enh bug 4506 which crept in
Chris Nighswonger [Wed, 20 Apr 2011 19:27:11 +0000 (15:27 -0400)]
Reverting pieces of enh bug 4506 which crept in

13 years agoUpdating package lists
Chris Cormack [Tue, 19 Apr 2011 05:01:27 +0000 (17:01 +1200)]
Updating package lists
(cherry picked from commit 139d3a81f732b380a5f569470d8c1c0b5cc84d64)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6126 - [3.2.x] Slip print doesn't work on Webkit based browsers
Tomas Cohen Arazi [Mon, 18 Apr 2011 14:25:07 +0000 (11:25 -0300)]
Bug 6126 - [3.2.x] Slip print doesn't work on Webkit based browsers

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoLower dependency on Storable to 2.20 in PerlDependencies.pm
Ricardo Dias Marques [Thu, 14 Apr 2011 15:15:55 +0000 (16:15 +0100)]
Lower dependency on Storable to 2.20 in PerlDependencies.pm

This patch lowers the dependency on the "Storable" Perl package
(also known as module/distribution) from version 2.21 to 2.20

This patch created today (14-Apr-2011) does, in PerlDependencies.pm,
the same as a previous patch dated 30-Mar-2010 from Lars Wirzenius
did, in Makefile.PL :

[Koha-patches] [PATCH] Lower dependency on Storable to 2.20.
http://lists.koha-community.org/pipermail/koha-patches/2010-March/011560.html

The reason for this patch is the same that Lars gave for his:

" The Debian squeeze system has only 2.20, and the 2.21 does not seem
 to be required for all tests to pass. Also, checked with
Galen Charlton and Henri-Damien LAURENT (who added the 2.21 dependency)
on IRC that 2.21 did not have anything that was required, compared
to 2.20. "

I believe this patch should be applied to the "master" branch
and should also be "cherry-picked" for the "3.2.x" branch.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 7457243d4d54a76588d51d1833df3517ee40988b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6104: Modify item looses branch
Paul Poulain [Thu, 7 Apr 2011 09:42:59 +0000 (11:42 +0200)]
Bug 6104: Modify item looses branch

If the $value is provided by the item, use it, don't use the librarian branch !

Signed-off-by: Sophie Meynieux <sophie.meynieux@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit b0374db5ffe1ef15a331eea3fd24b50fe8396b3b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix for Reserves.t allow the tests to run without a logged in user
Chris Cormack [Thu, 14 Apr 2011 03:03:37 +0000 (15:03 +1200)]
Fix for Reserves.t allow the tests to run without a logged in user
(cherry picked from commit 67e3b861819f62d125f40564fe6a7370ee47e219)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6154: Default sorting by title doesn't work
Jared Camins-Esakov [Sun, 10 Apr 2011 21:28:05 +0000 (17:28 -0400)]
Bug 6154: Default sorting by title doesn't work

If you have the default sorting set to title ascending or title descending,
your search results will not automatically be sorted because the syspref uses
title_asc and title_dsc, whereas Search.pm wants title_az and title_za. The same
issue is present when the default sort is on author.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 499c694daf408571cc8370b4c20568336ba35cde)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6170: Do not prematurely group results
Colin Campbell [Tue, 12 Apr 2011 20:43:41 +0000 (22:43 +0200)]
Bug 6170: Do not prematurely group results

If OPACGroupResults preference was set it was
shortcircuiting the template selection logic and
we didn't go to the advanced options field

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 8b309c66242dcc460191360c9523e0bcb8d2a829)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6169: Inventory tool fails when ignoreissued set
Jared Camins-Esakov [Tue, 12 Apr 2011 10:06:36 +0000 (11:06 +0100)]
Bug 6169: Inventory tool fails when ignoreissued set

Due to incorrect parameters passed to C4::Items::GetItemsForInventory, checking
the "Skip copies on loan" box resulted in the inventory failing to run.

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit f08f67d3f1fb1b7ca9406fbb395c0c68312d0d49)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5917 : Fix for xgettext.pl
Chris Cormack [Tue, 12 Apr 2011 08:16:57 +0000 (20:16 +1200)]
Bug 5917 : Fix for xgettext.pl
(cherry picked from commit 8df93d61bc4160f2d7618ca86319a6cda62b4e94)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 2505: quiet warnings in tools/inventory.pl
Jared Camins-Esakov [Mon, 11 Apr 2011 18:26:24 +0000 (14:26 -0400)]
Bug 2505: quiet warnings in tools/inventory.pl

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 9475752f3ad2d16b6097b47437cf7c33b1f882f3)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6164 Send Borrower Data to template consistently
Colin Campbell [Mon, 11 Apr 2011 17:12:08 +0000 (18:12 +0100)]
Bug 6164 Send Borrower Data to template consistently

messaging and notices patron tabs were not passing borrower
info in a manner consistent with other tabs

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit b993d2d2317720370d64f7fcca2230f9164ebeef)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoAdding 2 more developers to the history, 141 now
Chris Cormack [Mon, 11 Apr 2011 11:34:37 +0000 (23:34 +1200)]
Adding 2 more developers to the history, 141 now
(cherry picked from commit 79ec08b47908787a4ec1cb87b8dcf6242d18083a)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years ago Bug 6155 : Fixing bug with lists not showing
Chris Cormack [Mon, 11 Apr 2011 11:36:17 +0000 (11:36 +0000)]
 Bug 6155 : Fixing bug with lists not showing

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 88f0c4cb45dde91f1e140294f18aa94112482ae8)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug 6031: play with options passed on to rebuild-zebra.pl
Srdjan Jankovic [Thu, 31 Mar 2011 22:31:31 +0000 (11:31 +1300)]
bug 6031: play with options passed on to rebuild-zebra.pl

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 78829117999e8d8884a56454a37eb514baf2f3ea)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug #6053 Improvement of letter HOLD_PRINT
Sophie Meynieux [Tue, 5 Apr 2011 09:31:00 +0000 (11:31 +0200)]
bug #6053 Improvement of letter HOLD_PRINT

Modify title template for letter HOLD_PRINT in installer sample data

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit ac9e9cf809fd486cd98e826f0d3e92f1ab5d659e)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBZ6087: remove duplicate budget link
Paul Poulain [Fri, 8 Apr 2011 08:04:44 +0000 (10:04 +0200)]
BZ6087: remove duplicate budget link

this feature doesn't exist yet, so the link is useless

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 5b16634c0c692a40899d67c7946e68f3fa303910)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix for Bug 5950 - changing frameworks doesn't change anymore
Owen Leonard [Fri, 8 Apr 2011 10:16:08 +0000 (12:16 +0200)]
Fix for Bug 5950 - changing frameworks doesn't change anymore

Selecting a framework from the dropdown menu has never (AFAICT)
auto-submitted the form to change the framework. This patch
reformats the form in order to make it clearer that this menu
 is part of the search function.

Signed-off-by: fdurand <frederic.durand@univ-lyon2.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit b29e6e860957393e05888fb01c3dd53cc67b3e6f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6108 - Quicksearch in member.pl does not display paging correctly
Stéphane Delaune [Fri, 8 Apr 2011 13:07:08 +0000 (15:07 +0200)]
Bug 6108 - Quicksearch in member.pl does not display paging correctly

Signed-off-by: Stéphane Delaune <stephane.delaune@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit bda0be46b2b35b6879f3dc0fd3ab1834755733a0)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug #6052 - BranchTransfer Limit :Adds a default value
Alex Arnaud [Fri, 8 Apr 2011 08:10:16 +0000 (10:10 +0200)]
Bug #6052 - BranchTransfer Limit :Adds a default value

Signed-off-by: Christophe Croullebois <christophe.croullebois@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 18b89e9a67470eabb6878dd2e00edbe0e6fa396b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug #6130 - Letters: Fixing Subject encoding
Alex Arnaud [Fri, 8 Apr 2011 09:49:20 +0000 (11:49 +0200)]
Bug #6130 - Letters: Fixing Subject encoding

Signed-off-by: Stéphane Delaune <stephane.delaune@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 7c08d7c81edf6b25d74c71d57414dc9da78810d8)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6118 - Title-host missing in Search.pm
Paul Poulain [Fri, 8 Apr 2011 07:25:16 +0000 (09:25 +0200)]
Bug 6118 - Title-host missing in Search.pm

in Search.pm, in the list of available indexes, Title-host is missing

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 074bcc1970f0417d2e39ed59cb99501c32ef21e5)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix for Bug 5234 - Remove unused CSS files
Owen Leonard [Thu, 7 Apr 2011 13:34:07 +0000 (15:34 +0200)]
Fix for Bug 5234 - Remove unused CSS files

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 8464104fb299d1b1d707c0a083a04dce7c108953)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6017 : MT3157 : editing an attribute lead to Error500
Henri-Damien LAURENT [Wed, 6 Apr 2011 14:51:00 +0000 (16:51 +0200)]
Bug 6017 : MT3157 : editing an attribute lead to Error500

Editing an extended attribute in the extended attribute tab would lead to an Error500
This patch adds some checks for values before UPDATE in SQLHelper.pm
And Adds some checks also befaore calling ModMember in members/memberentry

Signed-off-by: Stéphane Delaune <stephane.delaune@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit e2fd348f7f53d4a9a69bc26062c466aa6b79c370)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6024 : add "Run report" link on the new report creation success page
Srdjan Jankovic [Thu, 7 Apr 2011 14:45:41 +0000 (10:45 -0400)]
Bug 6024 : add "Run report" link on the new report creation success page

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit b390c657b83961f999baa2be66fb1766056ac8a4)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5895: Translation error in German fast add framework
Katrin Fischer [Fri, 18 Mar 2011 20:21:54 +0000 (21:21 +0100)]
Bug 5895: Translation error in German fast add framework

Fixes description of 952$1.

Signed-off-by: Mark Gavillet <mark.gavillet@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 44fe3559bbe462c3f29c2ef6cdfe73bcc26017bc)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6095: Add UTF8 encoding in template
Alex Arnaud [Thu, 7 Apr 2011 09:12:40 +0000 (11:12 +0200)]
Bug 6095: Add UTF8 encoding in template

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 0b96414ce36e4c6baf7bac89f454ae04067a8d7b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5949: Hide 'Edit record' link when creating new order
Katrin Fischer [Thu, 7 Apr 2011 10:56:12 +0000 (10:56 +0000)]
Bug 5949: Hide 'Edit record' link when creating new order

The 'Edit record' link only makes sense, when you want to modify
an order after creating it. Before there is no biblionumber the link
can link to. Patch adds check for existing biblionumber so link is
only shown when there is an existing record to be edited.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 760babcf4c7573620cf3e03c0e0899282b6634b1)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 4189 : Searching z39.50 without selecting any servers results in error message
Tomas Cohen Arazi [Wed, 30 Mar 2011 20:08:57 +0000 (17:08 -0300)]
Bug 4189 : Searching z39.50 without selecting any servers results in error message

This patch makes z3950_search.pl handle the situation properly, and z3950_search.tmpl
show a proper message instead of a program error. All this, in case the javascript
checks that alert the user (that at least one target has to be chosen)  are by-passed.

Regards
To+

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fixed small translation problem in javascript alert message.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 4747f5adb25dce337fe295e3442e19bcacadeffa)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6088: remove Perl warning
Paul Poulain [Thu, 7 Apr 2011 11:09:27 +0000 (11:09 +0000)]
Bug 6088: remove Perl warning

caused by use warnings;

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 65c21fa52f9a44920e341f39b23bd877f5c87c84)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6072: fixing permission inconsistencies MT5306
Paul Poulain [Wed, 6 Apr 2011 08:54:38 +0000 (10:54 +0200)]
Bug 6072: fixing permission inconsistencies MT5306

In large libraries, some librarian may have permission only
to recieve shipments This patch fixes some permission :
* booksellers page = accessible to anyone that has at least 1 acq permission
* parcels = accessible to anyone with order_recieve
* supplier detail = accessible to anyone that has at least 1 acq permission,
  but modifying accessible only if vendor_manage

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit c0ecd7df4fdfa9e2520b1acc498a820f6abebaf1)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix for Bug 6109, Hey!
Owen Leonard [Thu, 7 Apr 2011 13:44:28 +0000 (15:44 +0200)]
Fix for Bug 6109, Hey!

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit bd4bf5485c88314e3d0e9794f520e88dced6d790)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 4912: Follow-up fix for Bug 4912, redirect user to correct lists
Owen Leonard [Thu, 7 Apr 2011 08:04:23 +0000 (10:04 +0200)]
Bug 4912: Follow-up fix for Bug 4912, redirect user to correct lists

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d269389839415ce4d14f7bc01635978807374631)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug #6112 - Missing fields in overdues csv file
Alex Arnaud [Thu, 7 Apr 2011 14:30:13 +0000 (16:30 +0200)]
Bug #6112 - Missing fields in overdues csv file

Signed-off-by: Christophe Croullebois <christophe.croullebois@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 913d520be7fddb8664753fa202f4f0362634c833)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug #6107 - Problems when duplicate a patron on memberentry.pl
Alex Arnaud [Thu, 7 Apr 2011 10:05:27 +0000 (12:05 +0200)]
Bug #6107 - Problems when duplicate a patron on memberentry.pl

Signed-off-by: Stéphane Delaune <stephane.delaune@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 52ff3ca6ec6dbb801f27f6de84747032828ad004)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6099: error in report pagination when GROUP BY
Jonathan Druart [Thu, 7 Apr 2011 14:14:29 +0000 (16:14 +0200)]
Bug 6099: error in report pagination when GROUP BY

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: fdurand <frederic.durand@univ-lyon2.fr>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 6de105084e8ed08846545848e0d5cd3e3ba9d178)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5903 : French authorised values fixed
Paul Poulain [Thu, 7 Apr 2011 09:53:37 +0000 (11:53 +0200)]
Bug 5903 : French authorised values fixed

country codes must be in capital letters

Signed-off-by: Stéphane Delaune <stephane.delaune@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit b67375b3d24f40026b1f21cacb1dab1a2150d341)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5275: enable switching back to default biblio framework
Paul Poulain [Thu, 7 Apr 2011 14:15:54 +0000 (16:15 +0200)]
Bug 5275: enable switching back to default biblio framework

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit f0de62e4cc26b21f18005e25d32431c70ef78b61)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix for Bug 6037, Invalid markup, missing breadcrumbs on Keyword to MARC Mapping...
Stéphane Delaune [Thu, 7 Apr 2011 13:35:13 +0000 (15:35 +0200)]
Fix for Bug 6037, Invalid markup, missing breadcrumbs on Keyword to MARC Mapping page

Signed-off-by: Stéphane Delaune <stephane.delaune@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit a59b1d23bb807b3946320365127b82fbcc144914)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 3072: Search for Heading-Main in authorities
Marcel de Rooy [Thu, 7 Apr 2011 09:42:30 +0000 (11:42 +0200)]
Bug 3072: Search for Heading-Main in authorities

Includes Heading-Main in authorities bib1 attribute set.
Also includes Any in authorities bib1 (was still missing).
Also removes temporary fix in AuthoritiesMarc.pm.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Rebased after pushed fix for #5924.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 6e58529bdd78f0593c9ad8b767715ff2d32e8ba8)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6096 Correctly return arrayref from GetAllShelves
Colin Campbell [Thu, 7 Apr 2011 15:30:17 +0000 (17:30 +0200)]
Bug 6096 Correctly return arrayref from GetAllShelves

Follow on from bug 5529 GetAllShelves was also vaguely stuffing
an arrayref into an array
Some signs of cut and paste (unnecessary @params variable)
Calling code now does not have to shuffle the return about
to get the reference. Also removed a debug warn

Signed-off-by: fdurand <frederic.durand@univ-lyon2.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit c0655aabe47cfe21e7846b7a8956db92c1e5b5d2)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5529 Absence or Presence of lists not being reliably returned
Colin Campbell [Thu, 7 Apr 2011 14:25:27 +0000 (16:25 +0200)]
Bug 5529 Absence or Presence of lists not being reliably returned

C4::VirtualShelves::GetRecentShelves contained some rather confused
code The contents of the requested list are returned in an arrayref
which was in its turn being wrapped needlessly in an array
As a result the returned array always consisted of a single element
irrespective of the number of lists.
Made the routine return the arrayref, which can now be tested directly
Unfortunately rather than fixing this we had previously coded around it
assuming it to be a "design" decision. Have amended other calls of
the subroutine resulting in some hopefully less obscure code

Fixed logic error in the results template which displayed new list
within a test for the presence of lists

Removed the offset parameter from the sql in the routine as it was hardcoded
to 0 i.e. the default value

Signed-off-by: fdurand <frederic.durand@univ-lyon2.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 0cf2eccfe926f77753a2b948e2babf077e2975d3)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug #6082 - On aqbudgets.pl bug on the Statistic's combobox
Alex Arnaud [Thu, 7 Apr 2011 09:59:22 +0000 (11:59 +0200)]
Bug #6082 - On aqbudgets.pl bug on the Statistic's combobox

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 22dc04e24c9af810672ee8f6e313316f3bcc9a59)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6106: add item not respecting framework in acq The PrepareItemrecordDisplay sub...
Paul Poulain [Thu, 7 Apr 2011 15:15:53 +0000 (17:15 +0200)]
Bug 6106: add item not respecting framework in acq The PrepareItemrecordDisplay sub builds an item framework for later use in ACQ Some cases were missing : item subfield connected to a plugin, hidden subfield, long size subfield.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit e5ff05857e5b99ab19210bc272086f253ea9404b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug #6110 - fix Callnumber index mistake
Alex Arnaud [Thu, 7 Apr 2011 12:59:53 +0000 (14:59 +0200)]
Bug #6110 - fix Callnumber index mistake

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 2950fc5596542ff181f05f766f32855089f96528)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoNew developer to the history
Chris Cormack [Thu, 7 Apr 2011 20:43:06 +0000 (08:43 +1200)]
New developer to the history
(cherry picked from commit 2a489184c088f0b023285069706f8ff614e4704e)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug 4903: enable OAI-DC output when install done in standard mode
Galen Charlton [Thu, 7 Apr 2011 07:57:45 +0000 (09:57 +0200)]
bug 4903: enable OAI-DC output when install done in standard mode

Based on patch by Tomás Cohen Arazi <tomascohen@gmail.com>,
revised to work regardless of the installation mode.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 46041a8fdc51c9c1173cd8cc343e6ac1f7bd46f6)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoUpdating Version Number to 3.02.07.003
Chris Nighswonger [Sat, 16 Apr 2011 17:47:05 +0000 (13:47 -0400)]
Updating Version Number to 3.02.07.003

13 years agoBug #6064 Improvement of default value usage in overdue
Sophie Meynieux [Thu, 7 Apr 2011 08:21:16 +0000 (10:21 +0200)]
Bug #6064 Improvement of default value usage in overdue

Change default value in overduerules table for delayn (NULL instead of 0) and fix GetBranchcodesWithOverdueRules function

Signed-off-by: Stéphane Delaune <stephane.delaune@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 141a52ac30c94b0f5e8dde0d29552bc8d5f44553)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6062: ordering basketgroups
Paul Poulain [Tue, 5 Apr 2011 12:43:23 +0000 (14:43 +0200)]
Bug 6062: ordering basketgroups

When you have many basketgroups, you get the oldest one on top. Usually, you
have something to do on recent ones, so it's better to have basket groups
ordered DESC

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 311e81810ab894b2b7f2dc186cbf3a8c6a337a1f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5951 : consistency change: s/planning/statistic/
Paul POULAIN [Tue, 5 Apr 2011 14:26:16 +0000 (16:26 +0200)]
Bug 5951 : consistency change: s/planning/statistic/

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit aaa6ecf2b6bad86b51ec21299407c92840d2417c)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFixing typo in kohaversion.pl
Chris Nighswonger [Sat, 16 Apr 2011 17:32:39 +0000 (13:32 -0400)]
Fixing typo in kohaversion.pl

13 years agoBug 5915 : C4::AuthoritiesMarc AddAuthority
Paul Poulain [Tue, 5 Apr 2011 09:04:42 +0000 (11:04 +0200)]
Bug 5915 : C4::AuthoritiesMarc AddAuthority

Fixing 100$a simple error: Sometimes, language is encoded fre50 and not
frey50.
This patch adds check for that problem

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit c9def9328613401f751f038653273b35b3e9d84e)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoUpdating Version Number to 3.02.07.002
Chris Nighswonger [Sat, 16 Apr 2011 17:23:52 +0000 (13:23 -0400)]
Updating Version Number to 3.02.07.002

13 years ago5936: Remove some obsolete db columns from aqbooksellers and aqbudgets if needed
Marcel de Rooy [Wed, 6 Apr 2011 11:35:37 +0000 (11:35 +0000)]
5936: Remove some obsolete db columns from aqbooksellers and aqbudgets if needed

Removes obsolete columns from aqbooksellers and aqbudgets if needed.
aqbooksellers: deliverydays followupdays followupscancel invoicedisc nocalc
specialty
aqbudgets: budget_description

These columns should not exist in a fresh install from kohastructure.sql, but
originate from older 3.0 versions.
One line in acqui/updatesupplier.pl referring to one of these columns is
removed too.

This patch therefore does not change functionality, but only keeps your db in
shape.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Rebased April 6.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5923 : Authorities list :removing link on Summary
Henri-Damien LAURENT [Tue, 5 Apr 2011 08:40:14 +0000 (10:40 +0200)]
Bug 5923 : Authorities list :removing link on Summary

removing the link to authority details on authority List directly from summary
And adding a generic link to details

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 21404359d498865ea55beb745327763a819f81fe)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoRemoving conflict markers
Chris Cormack [Thu, 7 Apr 2011 03:55:33 +0000 (15:55 +1200)]
Removing conflict markers
(cherry picked from commit c649ed9257d3c7f4d71f484d8ea6e2d5af2e48d7)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years ago(Bug 4049) Searching itemtypes returning noise
Henri-Damien LAURENT [Tue, 5 Apr 2011 12:13:51 +0000 (14:13 +0200)]
(Bug 4049) Searching itemtypes returning noise

Fix the problem of searching on partial itemtypes strings
for instance, itemtype="ARTICLE DE PERIODIQUE", itemtype="PERIODIQUE"
searching on itemtype="PERIODIQUE" would also get "ARTICLE DE PERIODIQUE"

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 700de9664d0e9016845d12916905e458cab9dbd4)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5213 - Suffix number sequence not resetting properly in hmyymmincr barcode autoge...
Chris Nighswonger [Tue, 5 Apr 2011 09:50:48 +0000 (11:50 +0200)]
Bug 5213 - Suffix number sequence not resetting properly in hmyymmincr barcode autogen pattern

Two things are happening.

First, the SELECT does not account for a branchcode greater than 2 chars.

This is fixed by just selecting the final four digits representing the
incremental suffix from the barcode field.

Second, the incremental suffix (4 digits) is not rolling back over to zero when
reaching 9999.

This pattern probably needs help. It should allow for cataloging of 10000 items
per month as is. I would not recommend doing barcode numbering this way, but
need to support it since it is in use in at least one library.

This patch also impliments strict and warnings per Bug 2505

Signed-off-by: Stéphane Delaune <stephane.delaune@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 8ca5d5ff85c429ee972b3f80f91f5b27a58cf5d5)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6077: qty not incremented for AcqCreateItem=recieve
Paul Poulain [Wed, 6 Apr 2011 08:02:31 +0000 (10:02 +0200)]
Bug 6077: qty not incremented for AcqCreateItem=recieve

When you want to create items on order recieve, the qty was not incremented
when the librarian adds an item with the +

This was because the js was expecting the qty field to be id=quantity

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d58092dd96383378f8abdce92d07c1795c617f97)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix for Bug 5156, JavaScript error when adding list
Owen Leonard [Wed, 6 Apr 2011 09:27:11 +0000 (11:27 +0200)]
Fix for Bug 5156, JavaScript error when adding list

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 9bb36148fddd4cb249c83033c5d6c27bef0513a6)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6028 : MT3815: Quickfix for CSV export (9999 rows limitation)
Matthias Meusburger [Wed, 6 Apr 2011 14:39:36 +0000 (16:39 +0200)]
Bug 6028 : MT3815: Quickfix for CSV export (9999 rows limitation)

Signed-off-by: Stéphane Delaune <stephane.delaune@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 3a8be8d8e0619e248ee02a851a0f21497d3490a7)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoThis patch fixes the broken pagination in members-search.pl
Koustubha Kale [Sat, 2 Apr 2011 16:53:06 +0000 (22:23 +0530)]
This patch fixes the broken pagination in members-search.pl

Small patch to fix Error 404 which comes up when we click on pagination links after searching in Patron Card creator.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 332e701c258a126cbc90862c12249de7aaada710)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6100: request.pl should check maxreserves exists
Jared Camins-Esakov [Wed, 6 Apr 2011 18:00:47 +0000 (14:00 -0400)]
Bug 6100: request.pl should check maxreserves exists

Adds a check to confirm that the maxreserves syspref actually has a value before
using it. Also fixes an off-by-one error in the maxreserves calculation that
would allow librarians to place maxreserves + 1 holds for patrons.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 8b582d863debf1a60c69560b1cb797a9931bdcf8)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6032: Increase zebra biblio register stores
Robin Sheat [Wed, 6 Apr 2011 23:18:32 +0000 (11:18 +1200)]
Bug 6032: Increase zebra biblio register stores

This keeps the package versions of the zebra configuration in sync with
the makefile-installed ones.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 0645f83c225c6b95e3b0c7b091b493481a35d3f2)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6032: Give biblio register and shadow sane default max sizes
Jared Camins-Esakov [Wed, 6 Apr 2011 18:28:49 +0000 (14:28 -0400)]
Bug 6032: Give biblio register and shadow sane default max sizes

The out-of-the-box maximum size for the biblio register and shadow stores is
4GB, which is much too small for even medium sized libraries. This makes the
default maximum 20GB, which should be enough for even most large libraries.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 2b71959a88029d9b948e13ad2f1f863fad8c44d6)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 4374 Improve biblio data entry form regarding hidden/mandatory fields
Frédéric Demians [Wed, 6 Apr 2011 08:14:29 +0000 (10:14 +0200)]
Bug 4374 Improve biblio data entry form regarding hidden/mandatory fields

Biblio framework has 3 entry points controlling if input box are
displayed by default in data entry form:

  - 'mandatory' flag at field level
  - 'mandatory' flag at subfield level
  - 'hidden' flag at subfield level

It doesn't work as it should (?):

  - All subfields are expanded (shown) if their field is mandatory
  - A subfield containing anything is always expanded whatever it contains
  - A mandatory subfield is always expanded
  - An hidden subfield isn't expanded.

Default framework having 0 in all marc_subfield_structure.hidden, by default
all subfields will be expanded.

TO BE INTEGRATED IN RELEASE NOTES:

  Koha sysadmin should have to edit its frameworks to add hidden=1 in
  appropriate subfields.

Signed-off-by: Stéphane Delaune <stephane.delaune@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit cecdc193696c6c91560128da5954681aa7ce610f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6014 : Removing a leftover warn
Chris Cormack [Thu, 7 Apr 2011 01:16:26 +0000 (13:16 +1200)]
Bug 6014 : Removing a leftover warn
(cherry picked from commit 13ad14a7540dab8b27a21fb6cb00a6edc875040d)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6014 : MT3138 Adding some permission management to viewlog
Henri-Damien LAURENT [Wed, 6 Apr 2011 15:28:45 +0000 (17:28 +0200)]
Bug 6014 : MT3138 Adding some permission management to viewlog

If user can not access reports, then form to search the logs is not displayed.
It also improves the presentation.

C4/Log.pm
- adds the fact that we can enter multiple actions
- fixes the fact that user information was truncated

circ-menu.inc:
Fixing information passed to the viewlog from circ-menu

Signed-off-by: fdurand <frederic.durand@univ-lyon2.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 99b49e2b1aa2e5d2629f1167e2b63c3b3158ffe8)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug 4837 make circ print page show item type description
Nicole Engard [Tue, 5 Apr 2011 13:30:07 +0000 (15:30 +0200)]
bug 4837 make circ print page show item type description

Signed-off-by: Guillaume Hatt <guillaume.hatt@€nc.sorbonne.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit fcbcdcf4cebdb32544a545d8ef91de1bbe67f457)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 4196 -Followup : Defintion of popularity index into Unimarc setup
fdurand [Tue, 5 Apr 2011 15:07:31 +0000 (17:07 +0200)]
Bug 4196 -Followup : Defintion of popularity index into Unimarc setup

Signed-off-by: Stéphane Delaune <stephane.delaune@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit ecbeafff07fa32918d552bbf4ba9cd8410207633)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5941 : (MT4425) Replace search 'an' by 'an, phr' in searchresultlist.tmpl
Alex Arnaud [Tue, 5 Apr 2011 07:54:11 +0000 (09:54 +0200)]
Bug 5941 : (MT4425) Replace search 'an' by 'an, phr' in searchresultlist.tmpl

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 99f49c1108dad5ef7548929b23d4a3815ae1a166)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBZ6065: confirmation when deleting an order
Paul Poulain [Tue, 5 Apr 2011 12:54:48 +0000 (14:54 +0200)]
BZ6065: confirmation when deleting an order

when clicking on "delete order", there is no confirmation box, the order line is
deleted without any question !

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 2a28b30a3c5a02475d59d4beab9c3b67cfc666e3)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5942, sql for UNIMARC Authorities
Stéphane Delaune [Mon, 4 Apr 2011 13:22:37 +0000 (15:22 +0200)]
Bug 5942, sql for UNIMARC Authorities

(MT #4339) init default UNIMARC sql structure

Signed-off-by: Stéphane Delaune <stephane.delaune@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 132743f66bc07f6b8799835aac6cf440430bd44e)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6056: Notes were not shown when modifying order line
Katrin Fischer [Tue, 5 Apr 2011 11:42:57 +0000 (13:42 +0200)]
Bug 6056: Notes were not shown when modifying order line

To test:
- add a new order in acquisitions with some content in the notes field
- save order
- modify order - Notes field will be shown as empty

The template variable for notes is missing from the template.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 9cab9be3d6114898e0b8354d784fb8d56ad51fbc)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5949 : Popup alert when deleting items from basket, also change planning value...
Christophe Croullebois [Mon, 4 Apr 2011 10:29:36 +0000 (12:29 +0200)]
Bug 5949 : Popup alert when deleting items from basket, also change planning value to statistics

(MT #2391) : acqui/neworderempty.pl

Multiple fixes in neworderempty.pl, mainly about Modify order line page, link to edit catalog, user can delete items with popup information and can't add items also with popup explanation.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
- changed the the link from 'Edit Catalog' to 'Edit record' (like on result list)
- changed position of 'Edit record' to be shown behind the label 'Catalog details' instead of showing behind the Title.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 1f323c00a14673ae83ae24b2502aa172d7949781)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5947 Suggestions : add date to the search query
Alex Arnaud [Mon, 4 Apr 2011 15:17:35 +0000 (17:17 +0200)]
Bug 5947 Suggestions : add date to the search query

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fixes searching by dates, like 'Suggested on:'
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 3603ae6274da149370fd38ce642848738b11fcdc)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 3628: opacSerialDefaultTab
Marcel de Rooy [Mon, 4 Apr 2011 10:04:30 +0000 (12:04 +0200)]
Bug 3628: opacSerialDefaultTab

This partial fix makes this existing pref visible in the interface.
It should work for UNIMARC. Some work still needs to be done at the MARC side.

Signed-off-by: Claire Hernandez <claire.hernandez@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 0dba0e0d3c687ffa0c8ba64ddf5c5f217c68aa0a)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoUpdating Version Number to 3.02.07.001
Chris Nighswonger [Sat, 16 Apr 2011 15:52:21 +0000 (11:52 -0400)]
Updating Version Number to 3.02.07.001

13 years agoBug 5860: Adding duplicate stocknumber fails silently
Katrin Fischer [Mon, 4 Apr 2011 11:20:20 +0000 (11:20 +0000)]
Bug 5860: Adding duplicate stocknumber fails silently

When adding a duplicate stocknumber the duplicate was not saved to the database.
This happened, because the field stocknumber in table items was declared to be unique.
Discussion on bug suggests to lift this restriction.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tested. Corrected typo in updatedatabase script. Version 3.01.00.095 introduced the index with double s, although structure had only one s in index name.
Unaware of this bug, I entered the more general bug 6041 for similar problems with modifying items.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit a8ffb2273b63c398492a7cbd08394adedb2aeadb)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoAdding a javascript function to check the validation of a record with a budget.
koha-preprod [Mon, 7 Feb 2011 16:12:49 +0000 (11:12 -0500)]
Adding a javascript function to check the validation of a record with a budget.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 9dc69cf47fb374b64dcc2ee3716cffa3b15cfb7c)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5948 : Creation of a quantity column in receipt summary
Christophe Croullebois [Mon, 4 Apr 2011 09:21:18 +0000 (11:21 +0200)]
Bug 5948 : Creation of a quantity column in receipt summary

In receipt summary the quantity did'nt appear in already received table, this patch fixes the omission

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patch tested on current master. Works like advertised.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit b9d434c18f3ff5a4d168cf24454d51ede1523fde)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoSmall patch to make myself feel important
Robin Sheat [Tue, 29 Mar 2011 04:01:38 +0000 (17:01 +1300)]
Small patch to make myself feel important

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit dc37fe9730f00d8dcc1c97029da816f66a0f9a02)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoEscape the double quotes in authority search queries to prevent errors.
Frédérick Capovilla [Fri, 1 Apr 2011 07:16:51 +0000 (09:16 +0200)]
Escape the double quotes in authority search queries to prevent errors.

Before this fix, any search with double-quotes would return an error
500.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 21993ab00a853d2cf7afb314bd2b6bacb0439ecc)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5990: Lists and Cart show LOC code not Location Authorized value
Ian Walls [Wed, 30 Mar 2011 17:39:53 +0000 (13:39 -0400)]
Bug 5990: Lists and Cart show LOC code not Location Authorized value

Lists in the OPAC, and Cart on both sides, show the LOC code for items, rather
than the appropriate Description from Authorised Values.  This is because the
code uses GetItemInfo, which is a very heavy-weight call to only retrieve some
of the desired information.

This patch introduces a new subroutine in C4::Items, GetItemsLocationInfo, which
returns the branch names for both home- and holdingbranches, the location code,
both opac and intranet location descriptions, itemcallnumber and cn_sort. This
should be used instead of GetItemsInfo in any case where the locational
information is all that's required, as it's much more streamlined and efficient.

In the OPAC Lists, this only applies if OPACXSLTResultsDisplay is 'off' (set to
'normal').

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 90392c19cc343ada611c1f06e4b5c20f3dd6dc93)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 6005: Fixes Transit slips cause FF4 to display "prevent this page from opening...
root [Wed, 30 Mar 2011 14:44:59 +0000 (10:44 -0400)]
Bug 6005: Fixes Transit slips cause FF4 to display "prevent this page from opening additional dialogs"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 5d707b5e9b7f18351d9b996f5f73a1ae53066080)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix for Bug 3523 - Menu of existing lists limited to 10
Owen Leonard [Wed, 30 Mar 2011 13:34:25 +0000 (15:34 +0200)]
Fix for Bug 3523 - Menu of existing lists limited to 10

- adding "more" option to the search results dropdown
- offering a scrolling list on the add-to-list popup
- lists add popup shows the full list of all
  the patron's lists, divided into groups of private and
  public lists.

Can be improved by a fix for Bug 5529

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 731b933d51367489422b90fa7021cfc42c747584)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoMT3289 : check_sysprefs.pl case sensitive variable names
Henri-Damien LAURENT [Sun, 11 Apr 2010 18:40:57 +0000 (20:40 +0200)]
MT3289 : check_sysprefs.pl case sensitive variable names

Variable names for systempreferences are now case sensitive.
Changing check_sysprefs in relation with this change

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 641616ef7fd43600864d46f39b938ef3cd8cd4f3)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 3644 Add support for NORMARC
Magnus Enger [Fri, 5 Mar 2010 10:58:14 +0000 (11:58 +0100)]
Bug 3644 Add support for NORMARC

- XSLT for the OPAC
- Value_builders for lesder, 007 and 008
- Default NORMARC framework
- Reverse MARC logic of some subs, so MARC21 is default (and works for NORMARC)
- Add NORMARC as an option to the syspref marcflavour
- Add record.abs for NORMARC
- Add NORMARC and nb as options to Makefile.PL
- Add etc/zebradb/lang_defs/nb/sort-string-utf.chr
- Copy MARC21slim2OAIDC.xsl to NORMARCslim2OAIDC.xsl

Some things are still missing, e.g.:

- XSLT for Intranet
- More MARC21slim2*.xsl transformations
(cherry picked from commit edf8ad5d5da9c11e0dc61c1df40ce977e9e6a125)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoAnother wrong encoding in installer/data/mysql/nb-NO/2-Valgfritt/
Magnus Enger [Tue, 29 Mar 2011 19:15:08 +0000 (21:15 +0200)]
Another wrong encoding in installer/data/mysql/nb-NO/2-Valgfritt/

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
(cherry picked from commit 759499d6e829fad122c7a98668603598e9cea768)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix wrong encodings in installer/data/mysql/nb-NO/2-Valgfritt/
Magnus Enger [Tue, 29 Mar 2011 19:13:41 +0000 (21:13 +0200)]
Fix wrong encodings in installer/data/mysql/nb-NO/2-Valgfritt/

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
(cherry picked from commit d5608708c179b5377794129f76fb0e6e6115448f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoA couple of missing translations in installer/data/mysql/nb-NO/2-Valgfritt/
Magnus Enger [Tue, 29 Mar 2011 19:11:28 +0000 (21:11 +0200)]
A couple of missing translations in installer/data/mysql/nb-NO/2-Valgfritt/

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
(cherry picked from commit a299f54a9f4dce47530f90176a96bc6abaeb0cd8)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix typo in installer/data/mysql/nb-NO/2-Valgfritt/sample_patrons.txt
Magnus Enger [Tue, 29 Mar 2011 19:06:47 +0000 (21:06 +0200)]
Fix typo in installer/data/mysql/nb-NO/2-Valgfritt/sample_patrons.txt

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
(cherry picked from commit 93d968cb30d26dbc3aa2933eb49f74f25611b2d4)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoAdd files to installer/data/mysql/nb-NO/2-Valgfritt/
Magnus Enger [Tue, 29 Mar 2011 14:26:47 +0000 (16:26 +0200)]
Add files to installer/data/mysql/nb-NO/2-Valgfritt/

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
(cherry picked from commit 4a5f1ec49a081319fdc1f00311900119df90eeae)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoTranslate OPACSearchForTitleIn in installer/data/mysql/nb-NO/1-Obligatorisk/sysprefs.sql
Magnus Enger [Tue, 29 Mar 2011 11:32:25 +0000 (13:32 +0200)]
Translate OPACSearchForTitleIn in installer/data/mysql/nb-NO/1-Obligatorisk/sysprefs.sql

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
(cherry picked from commit 1564cd0d004aef5b0494fd4eb9a4b4ebc78fa082)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>