From b4099974f078bb7ed034d4e24d53af6da33aa5c6 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Thu, 24 Oct 2024 10:26:52 +0200
Subject: [PATCH] Bug 33484: Pass external filters only if exists

The external_filter_nodes object should only be passed if the filters
block on the left actually exists. So only for the main patron search,
not the other ones.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
---
 .../prog/en/includes/patron-search.inc        | 20 +++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc
index 708a82b45e..f3a9af0f9c 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc
@@ -31,6 +31,7 @@
 [%# - search_type: select 'contains' or 'starts with' %]
 [%- searchtype = searchtype || Koha.Preference('DefaultPatronSearchMethod') -%]
 [% BLOCK patron_search_filters %]
+    [% SET has_patron_search_filters_block = 1 %]
     <aside>
         <form method="get" class="patron_search_form">
             <fieldset class="brief">
@@ -406,14 +407,17 @@
                     return filters;
                 }
             };
-            let external_filter_nodes = {
-                search_patron_filter: '.search_patron_filter',
-                firstletter_filter: '.firstletter_filter',
-                searchtype_filter: '.searchtype_filter',
-                searchfieldstype_filter: '.searchfieldstype_filter',
-                categorycode_filter: '.categorycode_filter',
-                branchcode_filter: '.branchcode_filter'
-            };
+            let external_filter_nodes = {};
+            [% IF has_patron_search_filters_block %]
+                external_filter_nodes = {
+                    search_patron_filter: '.search_patron_filter',
+                    firstletter_filter: '.firstletter_filter',
+                    searchtype_filter: '.searchtype_filter',
+                    searchfieldstype_filter: '.searchfieldstype_filter',
+                    categorycode_filter: '.categorycode_filter',
+                    branchcode_filter: '.branchcode_filter'
+                };
+            [% END %]
 
             [% UNLESS default_sort_column %]
                 [% default_sort_column = "name" %]
-- 
2.39.5