From 33fb560cf10272bf557c3fd0b0f2b6fcebc3923f Mon Sep 17 00:00:00 2001
From: Phil Ringnalda <phil@chetcolibrary.org>
Date: Tue, 1 Oct 2024 19:01:39 -0700
Subject: [PATCH] Bug 38056: Search term after deleting an authority shouldn't
 be URI encoded

Now that deleting an authority record uses a form, rather than building up a
URL in JavaScript, using the filter | uri on the value (confusingly named
value) which passes along the search terms to reload after deleting results
in a bad search. It should instead use the filter | html.

Test plan:
 1. Without the patch, top menu - Authorities
 2. The default search, Main heading ($a only), Authority type Default,
    Operator contains, Order by Heading A-Z will work fine. You need to a
    search which will return more than one of the same thing (not hard in
    ktd) - for MARC21 search for a professional
 3. You should get five results. For one of them, Actions - Delete - Confirm
    that you meant to click it
 4. You now have a%20professional in the search box, and search results for
    whatever ElasticSearch thinks a% means. It's certainly not professional -
    you can change that term to any random string and get the same results
 5. Apply patch, top menu - Authorities
 6. Repeat steps 2 and 3, but this time after deleting another result,
    you will get a professional without the %20 in the search box, and
    your results will be the remaining Addison-Wesley professional computing
    series authorities

Sponsored-by: Chetco Community Public Library
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 6eb4d5804b006f16f6876dcfd9b4b6b036bba10d)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
---
 .../prog/en/modules/authorities/searchresultlist.tt             | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt
index 07fdd6559c..1819ac2750 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt
@@ -121,7 +121,7 @@
                       <input type="hidden" name="excluding" value="[% excluding | html %]" />
                       <input type="hidden" name="operator" value="[% operator | html %]" />
                       <input type="hidden" name="orderby" value="[% orderby | html %]" />
-                      <input type="hidden" name="value" value="[% value | uri %]" />
+                      <input type="hidden" name="value" value="[% value | html %]" />
                       <input type="hidden" name="startfrom" value="[% startfrom | html %]" />
                       <input type="hidden" name="resultsperpage" value="[% resultsperpage | html %]" />
                       <button type="submit" class="btn btn-default"><i class="fa fa-trash"></i> Delete</button>
-- 
2.39.5