]> git.koha-community.org Git - koha.git/commit
Bug 25669: Use include_type_name parameter in ES calls
authorNick Clemens <nick@bywatersolutions.com>
Mon, 28 Mar 2022 12:00:25 +0000 (12:00 +0000)
committerLucas Gass <lucas@bywatersolutions.com>
Fri, 29 Jul 2022 15:27:43 +0000 (15:27 +0000)
commit99757c2d975d224ea191622116e6eb839fff70c1
treeb12a1b9272df962d1ef322114df4d9b7abe71479
parent584c49961c71d91e2698025d216752a40fe0eb08
Bug 25669: Use include_type_name parameter in ES calls

This patch includes the parameter:
include_type_name
on our ES calls

It removes the deprecation warning we are seeing, and should allow using ES7 with no other chnages.

For ES8 we will need to remove the hardcoded type,

I would suggest a second patch, with a new syspref "ElasticsearchLegacyType" set to 'True' by default.
Description can explain that this must be set to false, and data reindexed after upgrading to ES7 and before
upgrading to ES8 - then we can drop this pref when we drop ES7 support

When we drop ES6 support the pref can be set default true for upgrades, default 'false' for new installs

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 150a4b03f337f6a58869c67d3681caa64441d53a)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Koha/SearchEngine/Elasticsearch.pm
Koha/SearchEngine/Elasticsearch/Indexer.pm
Koha/SearchEngine/Elasticsearch/QueryBuilder.pm