]> git.koha-community.org Git - koha.git/commit
Bug 35935: Ensure login branch will be used after incorrect login
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 30 Jan 2024 08:02:19 +0000 (09:02 +0100)
committerFridolin Somers <fridolin.somers@biblibre.com>
Mon, 11 Mar 2024 09:00:51 +0000 (10:00 +0100)
commitb94bb009dca187cba85c072f1d7e00af484bdcea
treee658c8d67e93484b9cab039b9a08b665b0bd5270
parenta2bfc13866a6d1b3b9c877682d594af4157b3bbf
Bug 35935: Ensure login branch will be used after incorrect login

If a different branch is selected after an incorrect login, the previous
branch will be used.

To recreate:
* login with foo/bar, select CPL => FAIL
* login with koha/koha, select another branch => OK but CPL is picked!

It was caused by a dup of "branch" in CGI param list (and first was
picked).

This patch patch also removes "koha_login_context" to not have it twice.
You can also open the source of the page to confirm that form#loginform
contains "branch" and "koha_login_context" in hidden inputs.

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Tested in KTD. Works as advertised.
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 7c54394383234f33dcf5b6acb8ceabb72d0deca4)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt