]> git.koha-community.org Git - koha.git/commit
Bug 37323: Escape characters in patron image picture upload
authorAmit Gupta <amit.gupta@informaticsglobal.com>
Thu, 11 Jul 2024 17:43:06 +0000 (23:13 +0530)
committerTomas Cohen Arazi <tomascohen@theke.io>
Tue, 13 Aug 2024 14:53:56 +0000 (11:53 -0300)
commitbbb74562c0b170a5c7892b722253c0ba7a71aed8
tree2631e2ca02ba0fa69a5cc483c8989385d0e9d4da
parent3f75367a31e128137eaddf289760711f181007b8
Bug 37323: Escape characters in patron image picture upload

To Test
1. Create a file name for example: test.zip`curl xxxxtesting.informaticsglobal.com`.zip
   where the domain is one you can watch the logs from.
2. Go to Tools and click on Upload patron images choose option zip file and upload the file.
3. Check /var/log/apache2/access.log and see the curl with the IP
   "xx.xxx.xx.xxx - - [11/Jul/2024:23:10:33 +0530] "GET / HTTP/1.1" 200 267 "-" "curl/7.68.0"
4. Apply the patch
5. Repeat 2 and 3 step and check no error is coming for the Remote execution error.
6. Test uploading actual zip file and images still works.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
tools/picture-upload.pl