]> git.koha-community.org Git - koha.git/commit
Bug 31497: Prevent ID clash on quick add fields
authorNick Clemens <nick@bywatersolutions.com>
Tue, 13 Sep 2022 12:19:57 +0000 (12:19 +0000)
committerLucas Gass <lucas@bywatersolutions.com>
Mon, 31 Oct 2022 22:31:32 +0000 (22:31 +0000)
commitc8793b1cd3eacece7ccadc9fc6a0c8248a73bba2
treebde6a5cd1ae752b23c3b6769c2f8eadc259b8ab2
parent79bc7a8de5ef9dd1c139ae9770d22e93acbc95c4
Bug 31497: Prevent ID clash on quick add fields

The quick add clones the original fields, including ids. This can cause some clash when
other JS is running on the page.

This patch updates the ids of the fields before adding to the form, which prevents bad
copying/clearing of fields

To test:
* Go to patrons module
* Click on Quick add new patron (I chose Patron as category)
* On sample database these fields are marked as mandatory:
  * Surname
  * Cardnumber
  * Library
  * Category
* Fill in Surname, leave cardnumber empty
* Save - mandatory message is shown
* Fill in cardnumber - save
* The patron is saved
* BUT: cardnumber is empty!
APPLY PATCH
* Repeat plan above
* Cardnumber is correctly saved

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 0f599e2a2a8c9f6caed4fe4ae6060b106d2a1004)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt