From d07bf802d7d68f0951377373829b7c82e5abd81a Mon Sep 17 00:00:00 2001 From: David Nind Date: Tue, 7 May 2024 05:41:54 +0000 Subject: [PATCH] Bug 36796: (follow-up) Fix column descriptions for the statistics table This follow-up to bug 32312 fixes the descriptions for the statistics database columns, used in guided reports. It removes the duplicate statistics section in Koha/Database/Columns.pm so that descriptions are displayed for all columns, as originally intended. It also adds a description for the interface column (a new column added after the original patch was pushed). Test plan: 1. Go to Reports > Guided reports > Create guided report. 2. Choose 'Circulation' for the module to report on and select 'Next'. 3. Choose 'Tabular' for the type of report and select 'Next'. 4. Scroll down to the statistics table section and note that some columns have descriptions and some don't: Statistics date and time / statistics.datetime Library / statistics.branch Value / statistics.value Type / statistics.type Item number / statistics.itemnumber Item type / statistics.itemtype statistics.other statistics.location Borrower number / statistics.borrowernumber statistics.ccode statistics.categorycode statistics.interface 5. Apply the patch. 6. Restart all the things (restart_all). 7. Repeat steps 1 to 4. 8. Scroll down to the statistics table section again and note that all columns now have descriptions: Statistics date and time / statistics.datetime Library / statistics.branch Value / statistics.value Transaction type / statistics.type SIP mode / statistics.other Item number / statistics.itemnumber Koha item type / statistics.itemtype Shelving location / statistics.location Borrower number / statistics.borrowernumber Collection / statistics.ccode Patron category / statistics.categorycode Interface / statistics.interface 9. Sign off :D Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer (cherry picked from commit 7cc445e95cc7ba5130fc0efbca863f858d4269ee) Signed-off-by: Fridolin Somers --- Koha/Database/Columns.pm | 29 ++++++++++------------------- 1 file changed, 10 insertions(+), 19 deletions(-) diff --git a/Koha/Database/Columns.pm b/Koha/Database/Columns.pm index 4637d0cab3..0e83e21bbe 100644 --- a/Koha/Database/Columns.pm +++ b/Koha/Database/Columns.pm @@ -243,19 +243,6 @@ sub columns { "new_status" => __("New status"), "exclude_from_local_holds_priority" => __("Exclude from local holds priority"), }, - statistics => { - "datetime" => __("Statistics date and time"), - "branch" => __("Library"), - "value" => __("Value"), - "type" => __("Transaction type"), - "other" => __("SIP mode"), - "itemnumber" => __("Item number"), - "itemtype" => __("Koha item type"), - "location" => __("Shelving location"), - "borrowernumber" => __("Borrower number"), - "ccode" => __("Collection"), - "categorycode" => __("Patron category"), - }, biblio => { "abstract" => __("Abstract"), "author" => __("Author"), @@ -301,14 +288,18 @@ sub columns { "volumedesc" => __("Volume information"), }, statistics => { - "borrowernumber" => __("Borrower number"), - "branch" => __("Library"), "datetime" => __("Statistics date and time"), - "itemnumber" => __("Item number"), - "itemtype" => __("Itemtype"), - "other" => __(""), - "type" => __("Type"), + "branch" => __("Library"), "value" => __("Value"), + "type" => __("Transaction type"), + "other" => __("SIP mode"), + "itemnumber" => __("Item number"), + "itemtype" => __("Koha item type"), + "location" => __("Shelving location"), + "borrowernumber" => __("Borrower number"), + "ccode" => __("Collection"), + "categorycode" => __("Patron category"), + "interface" => __("Interface"), }, subscription => { "branchcode" => __("Library"), -- 2.39.5