From d1e3956eff6198219e5f9a5b10d64f3cc6e3aa74 Mon Sep 17 00:00:00 2001
From: Lucas Gass <lucas@bywatersolutions.com>
Date: Tue, 9 Jan 2024 21:57:49 +0000
Subject: [PATCH] Bug 35753: Remove Checkbox() function

To test:
1. APPLY PATCH and clear browser cache.
2. Have multiple additional content items ( news/HTML customization/Pages )
3. From one of the pages ( news/HTML customization/Pages ) click the 'Delete selected' button. Since no items are checked you should see the 'Please select content to delete' alert.
4. Check some items and click 'Delete selected' they should be correctly deleted.

Note: There is no change in behavior from this patch.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 898da9e4eb08f74cff250c44ae6f1252d0fe02f6)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
---
 .../prog/en/modules/tools/additional-contents.tt    | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt
index 0092df3bf8..28a19b8114 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt
@@ -566,17 +566,6 @@
                 modalNumber = $(this).attr('data-number');
                 $('.modal[data-number="'+modalNumber+'"]').modal('show');
             })
-            function Checkbox(){
-                var form = document.getElementById('del_form');
-                var inputs = form.getElementsByTagName('input');
-                var checked = false;
-                for (var i=0; i<inputs.length; i++) {
-                    if (inputs[i].type == 'checkbox' && inputs[i].name == 'ids') {
-                        checked = inputs[i].checked;
-                        if (checked) return true;
-                    }
-                }
-            }
 
             function filterDataTable( table, column, term ){
                 if( column ){
@@ -629,7 +618,7 @@
                 });
 
                 $("#del_form").on("submit",function(){
-                    if ( Checkbox() ) {
+                    if ( $('#del_form input[type="checkbox"][name="ids"]:checked').length ) {
                         return confirmDelete( _("Are you sure you want to delete the selected content?") );
                     } else {
                         alert(_("Please select content to delete."));
-- 
2.39.5