From e8405efbec4a7c186abbaa1f9b88cbc8dceda183 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Tue, 26 Jul 2022 09:55:38 -0300 Subject: [PATCH] Bug 31223: Do not explode if plugins disabled MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit This patch makes the code skip calculating the plugin-related task codes => class mapping if plugins are entirely disbaled. To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/Koha/Plugins/BackgroundJob.t => FAIL: Tests explode with: Can't call method "GetPlugins" on an undefined value at... Koha/BackgroundJob.pm line 424. 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Joonas Kylmälä Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 7867106d430dd9ab3f673185945467931a10082e) Signed-off-by: Lucas Gass --- Koha/BackgroundJob.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Koha/BackgroundJob.pm b/Koha/BackgroundJob.pm index 76bed24426..dcfba14659 100644 --- a/Koha/BackgroundJob.pm +++ b/Koha/BackgroundJob.pm @@ -380,7 +380,7 @@ Returns the available types to class mappings. sub type_to_class_mapping { my ($self) = @_; - my $plugins_mapping = $self->plugin_types_to_classes; + my $plugins_mapping = ( C4::Context->config("enable_plugins") ) ? $self->plugin_types_to_classes : {}; return ($plugins_mapping) ? { %{ $self->core_types_to_classes }, %$plugins_mapping } -- 2.39.5