From ec0ebda77db48e0fbe190df9a3d1969604bc229c Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Wed, 10 May 2023 12:19:13 +0200
Subject: [PATCH] Bug 33421: Fix filtering suggestions by status

If the display is by status and a specific status is selected in the
filter, the filter won't have any effects.

Test plan:
Create several suggestions, with different status, for different
libraries.
Use the "display by status" view and filter on a given status
=> Result must be relevant

Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 suggestion/suggestion.pl | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl
index f85b4366ea..44fc5527d2 100755
--- a/suggestion/suggestion.pl
+++ b/suggestion/suggestion.pl
@@ -376,6 +376,12 @@ if ($op=~/else/) {
     my @allsuggestions;
     foreach my $criteriumvalue ( @criteria_dv ) {
         my $search_params = {%$suggestion_ref};
+
+        next
+          if $search_params->{STATUS}
+          && $displayby eq 'STATUS'
+          && $criteriumvalue ne $search_params->{STATUS};
+
         # By default, display suggestions from current working branch
         my $definedvalue = defined $$suggestion_ref{$displayby} && $$suggestion_ref{$displayby} ne "";
 
-- 
2.39.5