From f5144061ef6812ec285309546627ba4ba52fec4b Mon Sep 17 00:00:00 2001
From: Michal Urban <michalurban177@gmail.com>
Date: Wed, 8 Jun 2022 11:40:42 -0400
Subject: [PATCH] Bug 30768: Capitalizing "pin" in 2FA setup

Change of text from "pin" to "PIN" in the 2FA setup interface.
This slight changes clarifies that "PIN" is an acronym,
 and increases user comprehension

To test:
1) Log in as an Administrator
2) Enable TwoFactorAuthentication
3) Log in to a user with superlibrarian permissions.
4) On the user profile page, click the "More" dropdown button,
click "Manage Two-Factor
5) Check that "pin" is displayed in lowercase, in both instances.
6) Apply patch.
7) Refresh the page and observe that "pin" has changed to "PIN"
8) Sign off.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit ed4250e7a9c8a83f8a538b5088f8867c630c72a1)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
---
 .../intranet-tmpl/prog/en/modules/members/two_factor_auth.tt  | 4 ++--
 t/db_dependent/selenium/authentication_2fa.t                  | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/two_factor_auth.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/two_factor_auth.tt
index bc0e7c095d..a0ae7afafc 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/two_factor_auth.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/two_factor_auth.tt
@@ -54,7 +54,7 @@
                         </div>
 
                         [% IF invalid_pin %]
-                            <div class="dialog error">Invalid pin code</div>
+                            <div class="dialog error">Invalid PIN code</div>
                         [% END %]
                         <form id="two-factor-auth" action="/cgi-bin/koha/members/two_factor_auth.pl" method="post">
                             <fieldset class="rows">
@@ -67,7 +67,7 @@
                                         <img id="qr_code" src="[% qr_code | $raw %]" />
                                     </li>
                                     <li>
-                                        <label for="pin_code">Pin code: </label>
+                                        <label for="pin_code">PIN code: </label>
                                         <input type="text" id="pin_code" name="pin_code" value="" />
                                     </li>
                                 </ol>
diff --git a/t/db_dependent/selenium/authentication_2fa.t b/t/db_dependent/selenium/authentication_2fa.t
index 1c5bb0d76d..2b8f888219 100755
--- a/t/db_dependent/selenium/authentication_2fa.t
+++ b/t/db_dependent/selenium/authentication_2fa.t
@@ -70,7 +70,7 @@ SKIP: {
 
         $s->fill_form({pin_code => 'wrong_code'});
         $s->submit_form;
-        ok($driver->find_element('//div[@class="dialog error"][contains(text(), "Invalid pin code")]'));
+        ok($driver->find_element('//div[@class="dialog error"][contains(text(), "Invalid PIN code")]'));
         is( $patron->get_from_storage->secret, undef, 'secret is not set in DB yet' );
 
         my $secret32 = $driver->find_element('//form[@id="two-factor-auth"]//input[@name="secret32"]')->get_value();
-- 
2.39.5