]> git.koha-community.org Git - koha.git/commit
Bug 11912: (refactoring followup) make GetMarcISBN implement its advertised API
authorTomas Cohen Arazi <tomascohen@gmail.com>
Mon, 10 Mar 2014 14:52:19 +0000 (11:52 -0300)
committerGalen Charlton <gmc@esilibrary.com>
Sat, 19 Apr 2014 18:23:15 +0000 (18:23 +0000)
commit774483772b2a7ff8ebdb8a9aeac82881e7c858cf
treeb4420ac9462dfad8253baf66a8fd536ebf3e516f
parentc4900dc448aa029749ab27f98b59d1be6eb8bb14
Bug 11912: (refactoring followup) make GetMarcISBN implement its advertised API

The current implementation of GetMarcISBN contradicts the documented API.
It currently returns an array of hashes with only one key (marcisbn)
which doesn't add any value to it.

I chose to fix GetMarcISBN to honour the API instead of changing thex
 docs, because it seems a really silly change.

To test:
- Run:
  prove t/db_dependent/Biblio.t
=> SUCCESS
- catalogue/detail.pl should correctly show ISBNs.
- opac/opac-detail.pl should correctly show ISBNs in both prog and bootstrap.
- opac-opac-sendshelf.pl should correctly show ISBNs in the email.

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
C4/Biblio.pm
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelf.tt
koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
koha-tmpl/opac-tmpl/prog/en/modules/opac-sendshelf.tt
t/db_dependent/Biblio.t