Merge branch 'serials_mods' of git://github.com/colinsc/koha into to-push
Description by Colin Campbell:
A number of commits, subsequent to enabling warnings in C4::Serials and
eradicating errors and removing dead code.
These are extracted from an install branch running at UN FAO in Rome.
Commits have been rebased on current 3.2 HEAD.
These are not major new functionality, but a series of fixes to
eradicate some randomness caused by undefined values. Includes a commit
to fix Licenses in the serials directory.
* 'serials_mods' of git://github.com/colinsc/koha:
Check value is defined before splitting it
Fix FSF Address in directory serials/
Bug 4380 Use syspref to resolve which bib display is used
Remove bottleneck making claims page unuseable
Clean up Pod Documentation
add warnings to Serials.pm
Add Text to claim date column's header
Basic refactoring of serials-edit.pm
Remove unused or unnecessary variables in claims processing
Owen Leonard [Tue, 2 Mar 2010 19:22:43 +0000 (14:22 -0500)]
Fix for Bug 4262, changing matching rule add big message box
Fix includes a change to the format of the page to consolidate
matching rule settings with matching rule controls. This
reduces potential confusion from the placement of the message
box. Assuming that matching rule settings and controls were
displayed separately for clarity and control, I've added
JavaScript which allows the user to change their mind after
changing a selection (but before submitting). It's a new
interaction which I hope is useful.
Owen Leonard [Wed, 24 Feb 2010 16:38:36 +0000 (11:38 -0500)]
Fix for Bug 4250, cart missing print button
- Print button was hidden by CSS for some reason (git blame me)
- Print formatting was off because of column mismatch
- Table style modified in print view for clarity
- Redirect from print view corrected by adding missing bib_list
and verbose parameters
Colin Campbell [Thu, 8 Apr 2010 16:58:20 +0000 (17:58 +0100)]
Remove bottleneck making claims page unuseable
While the idea of showing the number of late serials against the
vendor name was nice it does not scale and on large sites selecting claims
was just timing out. Improved the speed of the initial query but have removed
the big query for each user just to get a count.
Check for 0000-00-00 dates so that C4::Dates does not log error
Removed a variable that was never set and the bit of template used
if the impossible happened
Colin Campbell [Thu, 8 Apr 2010 13:44:39 +0000 (14:44 +0100)]
Clean up Pod Documentation
Ensured returns were documented
Fixed some language issues
Removed the host of podchecker warnings about missing lists
added a couple of explicit returns when subroutines
'fell off the end' to remove any ambiguity
Colin Campbell [Thu, 8 Apr 2010 12:28:40 +0000 (13:28 +0100)]
add warnings to Serials.pm
Change obvious warning generators:
( use of string comparisons in numeric comparison)
( declaration of variable in comnditional )
also some errors caused by undefined values:
abouttoexpire was not checking for undef values
Pass a valid planneddate in generation of next expected
(undef here causes odd results)
Add a basic test script
test is minimal but I fell over a bug this would have caught
Colin Campbell [Thu, 8 Apr 2010 12:16:31 +0000 (13:16 +0100)]
Basic refactoring of serials-edit.pm
Removed some useless counts from serials-edit / Serials interfaces
Removed old commented out code. Unrequired variables
Reformatted some code so that improving logic can be done
more easily
Colin Campbell [Thu, 8 Apr 2010 11:46:06 +0000 (12:46 +0100)]
Remove unused or unnecessary variables in claims processing
Also cleaned the interface to the claims related functions
in C4::Serials so they do not return an extra count variable
moved generation of dropdown to template instead of inline code
Kyle M Hall [Thu, 22 Oct 2009 12:19:16 +0000 (12:19 +0000)]
Added plugin to automatically add brackets around the value in marc21 field 245h
This plugin will automatically add brackets around the value typed in at the time the field's focus is removed ( onblur ).
If the text in the field is already enclosed in brackets, it will do nothing.
Owen Leonard [Tue, 23 Feb 2010 14:26:04 +0000 (09:26 -0500)]
Fix for Bug 4167, Tag link styled incorrectly on Cart popup
- Removing DOM creation of tag and hold links: if the Cart is working,
the user must have JavaScript enabled. Therefore we can assume
tagging and holds will work
- Conditionally displaying some JavaScript based on whether tagging
or placing holds is allowed
Colin Campbell [Fri, 19 Mar 2010 16:09:30 +0000 (16:09 +0000)]
Refactor for Human Readability
Fixes generation of empty index page when total_parcels is a multiple of pagesize
Remove some calculations whose results were not used
Make variable names meaningful (results and count arnt)
Fix errors in pod syntax
Make what code does clearer to readers who are not computers
Use a subroutine
Colin Campbell [Tue, 23 Mar 2010 09:59:21 +0000 (09:59 +0000)]
Bug 4331 Remove cruft from acqui-home script
Remove unnecessary db calls and processing from acqui-home.pl
Do not duplicate processing of fields
Declare variables closer to use
Remove unnecessary holding vars
Replace some anonymous var names by something more meaningful
Do not generate a toggle variable use Template's LOOP vars
This bug blocks entirely serials module. It isn't possible
to create/edit a subscription. Brocken JavaScript prevents
Search for a vendor and Search for Biblio dialog box
to pop-up.
Problem with new strings and new html tags inside the strings
this patch removes them
tweak display of issuing library on staff reading history
Following idea in patch submitted by Kyle Hall on 1 April 2010,
use issues.branchcode instead of issues.issuingbranch to set
displayed issuing library. Also tweaked wording.
bug 4358: remove disused ReadingHistory syspref and related code
The ReadingHistory sytem preference is no longer used, and possibly
was used by only one library anyway. Removed references to it; note
that had it been turned on, a patron viewing checkout history would have
seen old loans showing up twice.
Lars Wirzenius [Tue, 30 Mar 2010 21:16:08 +0000 (10:16 +1300)]
Lower dependency on Storable to 2.20.
The Debian squeeze system has only 2.20, and the 2.21 does not
seem to be required for all tests to pass. Also, checked with
Galen Charlton and Henri-Damien LAURENT (who added the 2.21
dependency) on IRC that 2.21 did not have anything that was
required, compared to 2.20.
Nicolas Morin [Wed, 10 Mar 2010 21:26:27 +0000 (22:26 +0100)]
text for SCO Finish button
Simplifying finish button on SCO screen: it was a long sentence with a button saying "click here if you're done". Changed to "Finish". Changed the help accordingly.
Owen Leonard [Thu, 11 Mar 2010 13:54:16 +0000 (08:54 -0500)]
Improve display of information on Transfers to your library report
- Use GetRecordValue() to show subtitle
- Show author
- Separate branch and call number display for better sorting
- Correct teriminology (reserve -> hold)
Owen Leonard [Tue, 9 Mar 2010 19:59:51 +0000 (14:59 -0500)]
Fix for Bug 4296, label search printing titles between buttons
- Reformating display for readability
- Converting select/clear all buttons to links to match existing patterns
- Fixing "Results x of x" display which was broken for single-page sets
projects / koha.git / log