From 6c264b24d12bafb8d0bc6eecdc7e188a622d7389 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Wed, 5 Feb 2014 10:35:47 -0500 Subject: [PATCH] Bug 11686: make "please note your reason here..." translatable Through some quirk of the translation script a predefined value on a text input is not properly translated even though the string appears in the po file. On the suggestions form the problem can be solved by using the HTML5 placeholder attribute. To test you must have existing suggestions to manage. Apply the patch and: - Update a translation by running tranlsate update [language code] - Install/reinstall the translation by running translate install [language code] - In the English templates: - Navigate to Acquisitions -> Suggestions and find the "Mark selected as:" section below the table of existing suggestions. - Select "Other" from the "choose a reason" field. A text input field should appear with the placeholder text "please note your reason here." - In the templates you updated and installed, follow the same procedure above. The placeholder text should now appear with the correct translation. - In both English and translated templates using this bulk-status option should save your chosen status correctly with the correct reason, whether that reason be predefined or manually entered. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Passes tests and QA script. Tested successfully with German - nice to see this fixed! Signed-off-by: Galen Charlton --- .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt index c4a15c4cd5..15c56c1be9 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt @@ -72,7 +72,6 @@ $(document).ready(function() { e.preventDefault(); }); $("#other_reason[% suggestion.suggestiontype %]").hide(); - $("input[name*=other_reason[% suggestion.suggestiontype %]]").focus(function(){ $(this).val(""); }); $("#reason[% suggestion.suggestiontype %]").change(function(){ if($(this).val() == "other"){ $(this).hide(); @@ -578,7 +577,7 @@ h4.local_collapse a { font-size : 80%; text-decoration: none; } fieldset.brief o - + Cancel -- 2.39.5