]> git.koha-community.org Git - koha.git/commit
Bug 32627: Calculate expirationdate relative to waitingdate
authoremlam <emily.lamancusa@montgomerycountymd.gov>
Wed, 5 Apr 2023 13:30:30 +0000 (09:30 -0400)
committerTomas Cohen Arazi <tomascohen@theke.io>
Fri, 12 May 2023 14:22:24 +0000 (11:22 -0300)
commit21bcb6e85520b2963dde71c21ccb5e169c4c5e28
treed4a078bab2230bf7ba78bf34267211a65a55d61b
parentc1fe7406b9f4a3d253ed282f2cb510258dac732e
Bug 32627: Calculate expirationdate relative to waitingdate

Hold::set_waiting should calculate the MaxPickupDelay expiration date
based on waitingdate rather than the current date, to avoid resetting
the expirationdate on a hold that was already waiting.

To test:
1. Place a hold and check in the item so the hold will be set to Waiting
2. Confirm that the expiration date is correct based on the
   ReservesMaxPickupDelay setting
3. Adjust your system clock to one day later
4. Check in the item again and confirm the hold
5. Note that the expiration date has changed
7. Apply patch and restart_all
8. Repeat steps 1-4. Confirm that the expiration date is calculated
   correctly, and does not change when the item is checked in again
9. Reset your system clock to the current date
10. Set ExcludeHolidaysFromMaxPickupDelay to Use the Calendar
11. Add an upcoming holiday to the calendar
12. Repeat steps 1-4. Confirm the expiration date correctly accounts for
    the holiday, and does not change when the item is checked in again

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Koha/Hold.pm