Galen Charlton [Fri, 19 Feb 2010 03:42:53 +0000 (22:42 -0500)]
bug 1532: various code cleanup
* export C4::Reserves::CancelExpiredReserves
* rename misc/cronjobs/cancel_expired_reserves.pl
to misc/cronjobs/holds/cancel_expired_holds.pl
* added cancel_expired_holds.pl to example crontab
* fix staff crash if AllowHoldDateInFuture is on
* expirationdate is now nullable instead of relying
on 0000-00-00
Galen Charlton [Fri, 19 Feb 2010 02:45:56 +0000 (21:45 -0500)]
bug 1532: tweak new reserves columns and add to init SQL (DB rev 121)
Changed type of lowestpriority from BOOL to tinyint(1) - BOOL was likely
OK, but made it tinyint(1) to match the rest of the flag columns. We
should look into converting those to BOOL en masse in 3.4.
Kyle M Hall [Wed, 23 Sep 2009 16:10:23 +0000 (16:10 +0000)]
(bug 1532) Reserves Updates Ported From Dev_Week
This is a much improved re-implementation of the reserves updates from dev_week.
Less new code has been added, and more existing functions are used instead of adding new ones.
The 'Lock Hold' function has been removed due to it not working as intended.
[RM note for documentation: this adds the following features:
* ability to specify an expiration date for a hold request
when placing it via the staff interface or OPAC
* daily batch job to cancel expired holds
* nice interface to change the priority of hold
requests for a bib in the staff interface]
Michael Hafen [Wed, 4 Nov 2009 21:31:48 +0000 (14:31 -0700)]
bugfix Guided Reports - allow user specified limit in sql
Tweak the regular expression in strip_limit to work.
Tweak execute_query to use the user limit if it's lower than the hard coded one.
Also total is calculated somewhere else now.
This helps most with the csv export of a report so the user can set their own
limit instead of having the hard coded limit of 9999.
Michael Hafen [Wed, 18 Nov 2009 15:37:40 +0000 (08:37 -0700)]
add memcached questions to koha-install-log
Add the use_memcached question to rewrite-config.pl and all three questions
to koha-install-log. So that we don't have to keep answering these questions
when we upgrade/install with the --prev-install-log option.
Galen Charlton [Thu, 18 Feb 2010 18:22:46 +0000 (13:22 -0500)]
Revert "Add basic restrictive robots.txt file to opac"
Per discussion on 12/9/2009, reverting. I agree with Nicole Engard
that a restrictive robots.txt for the OPAC should *not* be the
default. A patch for a README on how to do it would be nice, though.
In one of my setups, "install-code.pl pt-PT" complained
about a missing "Locale::PO". So, I'm adding it to
Makefile.PL. I'm using the version 0.17 as minimum
required because it's the one that's available in
Debian 5.0.2. ("lenny").
this patch restrict the send of baskets and shelves to authenticated users only, and show their surname/firstname in the e-mail, so the receiver will know who sent the list.
(cherry picked from commit f87b75522801ee6d08291bb0eeb6bc38a5b785d5)
Jane Wagner [Thu, 18 Feb 2010 16:45:50 +0000 (11:45 -0500)]
Bug 4215 OPAC "Search for title in" can fail with trailing slashes in title
While configuring Search for Title In links, I found that some target sites
can't process an incoming title search if the title being sent has a trailing
slash. If the same search is sent without the trailing slash, it works fine. I
modified opac-detail.pl to strip off the trailing slash (and space) for titles
being sent to other sites.
Frédéric Demians [Wed, 17 Feb 2010 14:05:47 +0000 (15:05 +0100)]
OAI server fixes
- Add preference OAI-PMH:ConfFile. I just add it in web-services.pref
and not in DB. It's enough. It's not an end-user preference. Without
this pref, OAI server operates as previously. And preferences editor
allow to add a new value to the DB if necessary.
- Fix response to ListMetadataFormats which was empty in extended mode.
Galen Charlton [Thu, 18 Feb 2010 14:23:26 +0000 (09:23 -0500)]
bug 1080: finish work for soundon syspref (DBrev 120)
Tweaked wording of the soundon syspref, added it to the non-English
SQL scripts, and created a DBrev. Thanks to Nahuel and Eric
for the French translation.
root [Wed, 17 Feb 2010 18:24:46 +0000 (13:24 -0500)]
Bugzilla 1080 to add enhancement for sound. Only changed circulation.tmpl/pl and returns.tmpl/pl and added a single syspref (set to off) along with very compressed OGG files for sound which are on the open source "artistic" licence.
Works for HTML5 because it loads smoothly and no plugins required but *at
this time* this update will only work with staff clients which are Firefox
version >=3.5 (std for Koha) but other browsers will soon be adding support.
Additional sounds are included for people to modify and play with, but this
is such a simple upgrade I doubt at this time Koha needs another complex
selector so users can add their own sounds. It could be a nice enhancement
later, of course.
Suggest we stick with HTML5 <audio tag because it is a standard and no
plug-ins.
This simple update has been running live for SMFPL.org for almost 2 weeks
Adds the ability to customize CSV exports through the use of a YAML file.
The following customizations are available :
- Preprocessing
- Postprocessing
- Field-by-field processing
The YAML field should be stored in the tools/csv-profiles/ directory and
named after the id of the CSV profile you want to customize.
An example file is provided in that directory.
(cherry picked from commit 76655b5b941f6f6094f705a296f7b68e64d148df)
Galen Charlton [Wed, 17 Feb 2010 11:39:22 +0000 (06:39 -0500)]
set Locale::Currency::Format dep test as DBrev 119
Also fixed bug that prevented updatedatabase.pl
from compiling if Locale::Currency::Format wasn't
already installed. To test to see if module is present,
do
Bugfix: [1/3] overdue_notices.pl does not process all advertised fields
Note: overdue_notices.pl really needs to be completely re-written.
The script does not process all fields advertised in tools/letter.pl
This patch adds code to process all fields advertised as well as any
from the items table.
It also adds two additional tags for use in the letter templates:
<item></item> which should enclose all fields from the biblio, biblioitems,
and items tables.
<fine></fine> which should be enclosed by the item tag and should
enclose a currency identifier per ISO 4217. If this tag is present with
a proper identifier, the fine for that item will be displayed in the
proper currency format. Note: ISO 4217 changes from time to time therefore
all currencies may not be supported. If you find one that is not
supported, please file a bug with the Locale::Currency::Format author
Tan D Nguyen <tnguyen at cpan doe org>.
An example of the implimentation of these two tags in a notice template
might be like:
The following item(s) is/are currently overdue:
<item>"<<biblio.title>>" by <<biblio.author>>, <<items.itemcallnumber>>, Barcode: <<items.barcode>> Fine: <fine>GBP</fine></item>
Which, assuming two items were overdue, would result in a notice like:
The following item(s) is/are currently overdue:
"A Short History of Western Civilization" by Harrison, John B, 909.09821 H2451, Barcode: 08030003 Fine: £3.50
"History of Western Civilization" by Hayes, Carlton Joseph Huntley, 909.09821 H3261 v.1, Barcode: 08030004 Fine: £3.50
Garry Collum [Mon, 15 Feb 2010 15:43:23 +0000 (10:43 -0500)]
Bug 3449: Fixes the perpetual error message that pops up when filtering by tag reviewer.
Duplicates the code for searching by reviewer in the form that is used in searching via a link.
It looks like it was the intention of the original writer to filter by borrower number or by name. Filtering by name was not implemented. Added a FIXME reference to indicate this.
Galen Charlton [Mon, 15 Feb 2010 02:10:25 +0000 (21:10 -0500)]
bug 2885: attempting to add library with existing code now gives error message
If one attempts to add a new library with a code already in use,
an error message is shown. The main library data input by the user
is preserved, allowing the user to try a new code.
This also corrects a glitch in the previous patch concerning
adding a branch category whose code is already in use.
Colin Campbell [Fri, 12 Feb 2010 12:38:46 +0000 (12:38 +0000)]
Change default AUTH_INDEX_MODE to dom
[RM note: DOM is recommended for MARC21 authorities. As of
now, GRS-1 is the only mode supported for UNIMARC authorities.]
dom is the recommended authorities indexing mode in external docs
making it default accepts what appears to be the de facto preference
see Indexdata's documentation for more details on the options
Will Stokes [Sun, 14 Feb 2010 20:31:08 +0000 (09:31 +1300)]
Bug #2162: Step 2, add pagination. Splits results into blocks of 250 results and adds Previous and Next buttons. Achieved using forms, hidden search variables and submit buttons.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Sun, 14 Feb 2010 23:05:45 +0000 (18:05 -0500)]
new test script to help debug template errors
From the POD:
NAME
show-template-structure.pl
DESCRIPTION
This script displays the structure of loops and conditional statements in
an HTML::Template::Pro template, and is an aid for debugging errors
reported by the xt/author/valid-templates.t test. It also identifies the
following errors:
* TMPL_IF/TMPL_UNLESS/TMPL_LOOP with no closing tag
* TMPL_ELSE with no initial TMPL_IF or TMPL_UNLESS
* extra closing tags
* HTML comment of the form <!-- TMPL_FOO ..., where TMPL_FOO is not a valid HTML::Template::Pro tag
Galen Charlton [Mon, 1 Feb 2010 16:19:22 +0000 (10:19 -0600)]
bug 4169: fix item batch modification for MARC21
The MARC21 framework uses $0 for the item withdrawn status. Because
of how the tool had marked the barcode and stocknumber as being
uneditable, this resulted in an off-by-one error, causing the wrong
item fields to be updated.
Fixed by simply not including the uneditable fields in list
of item fields that can be edited - if you can't change the barcode,
there's no point in displaying it in the list of fields.
Also fixed how the bib title/author/ISBN got displayed so that the
withdrawn column gets displayed after an item update.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com> Signed-off-by: Liz Rea <lrea@nekls.org>
Frédéric Demians [Thu, 11 Feb 2010 21:28:41 +0000 (22:28 +0100)]
Bug 4154 - Follow-up
- Modify install-code.pl to install prefs with templates
- Update .po preferences file in order to get last 'en' preferences
For 3.4, I will do a script which will handle together the 3 .po file:
opac, intranet and preferences (and .tt files if necessary). Don't do it
now, since it will change files naming convention.
Bugfix: Make smart-rules.tmpl display zero values in fields.
Since TMPL_IFs evaluate false if the template variable is 0,
smart-rules.tmpl was not displaying zero values in fields where
the db field value was indeed zero which leads to some small confusion.
This patch removes the TMPL_IFs since those fields will always be
populated with some value even if it is zero.
projects / koha.git / log
![14 years agoBugfix: [3/3] [TRANSLATION NEEDED] overdue_notices.pl does not process all advertised...](/gitweb/Members/js/jscripts/bar_r.gif?p=koha.git;a=commit;h=c353d9170769456d32286186bd0adb90fee7800a){kind=link}
![14 years agoBugfix: [2/3] overdue_notices.pl does not process all advertised fields](/gitweb/Members/js/jscripts/bar_r.gif?p=koha.git;a=commit;h=6827107ed48fadac534e34528c6855c65ef48bc4){kind=link}
![14 years agoBugfix: [1/3] overdue_notices.pl does not process all advertised fields](/gitweb/Members/js/jscripts/bar_r.gif?p=koha.git;a=commit;h=599887a1855349de6bafe9c1b6ce155ed9be5fb5){kind=link}
