Galen Charlton [Sun, 14 Feb 2010 23:05:45 +0000 (18:05 -0500)]
new test script to help debug template errors
From the POD:
NAME
show-template-structure.pl
DESCRIPTION
This script displays the structure of loops and conditional statements in
an HTML::Template::Pro template, and is an aid for debugging errors
reported by the xt/author/valid-templates.t test. It also identifies the
following errors:
* TMPL_IF/TMPL_UNLESS/TMPL_LOOP with no closing tag
* TMPL_ELSE with no initial TMPL_IF or TMPL_UNLESS
* extra closing tags
* HTML comment of the form <!-- TMPL_FOO ..., where TMPL_FOO is not a valid HTML::Template::Pro tag
Galen Charlton [Mon, 1 Feb 2010 16:19:22 +0000 (10:19 -0600)]
bug 4169: fix item batch modification for MARC21
The MARC21 framework uses $0 for the item withdrawn status. Because
of how the tool had marked the barcode and stocknumber as being
uneditable, this resulted in an off-by-one error, causing the wrong
item fields to be updated.
Fixed by simply not including the uneditable fields in list
of item fields that can be edited - if you can't change the barcode,
there's no point in displaying it in the list of fields.
Also fixed how the bib title/author/ISBN got displayed so that the
withdrawn column gets displayed after an item update.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com> Signed-off-by: Liz Rea <lrea@nekls.org>
Frédéric Demians [Thu, 11 Feb 2010 21:28:41 +0000 (22:28 +0100)]
Bug 4154 - Follow-up
- Modify install-code.pl to install prefs with templates
- Update .po preferences file in order to get last 'en' preferences
For 3.4, I will do a script which will handle together the 3 .po file:
opac, intranet and preferences (and .tt files if necessary). Don't do it
now, since it will change files naming convention.
Bugfix: Make smart-rules.tmpl display zero values in fields.
Since TMPL_IFs evaluate false if the template variable is 0,
smart-rules.tmpl was not displaying zero values in fields where
the db field value was indeed zero which leads to some small confusion.
This patch removes the TMPL_IFs since those fields will always be
populated with some value even if it is zero.
USAGE
pref-trans init lang
Create a .po file in po directory, named lang-pref.po. This
file contains text to translate extracted from .pref files.
pref-trans update lang
Update a .po file in po directory, named lang-pref.po. This
file contains new text to translate extracted from .pref files.
Previous translated text are kept. There is a minor bug, which can’t
be fixed due to preferences data struture: preferences tab
subsection labels are lost when updating .po file.
pref-trans install lang
Use lang-pref.po file to translate the english version of
preferences files and copy those files in the appropriate
directory.
DESCRIPTION
Koha preferences are stored in a data structure found in
koha-tmpl/intranet-tmpl/en/module/admin/preferences/ files.
Depending of user language, other files are used. This script extract text
from ’en’ preference files, and put them in one .po file. This .po
file can be updated. When completed, a .po file can be applied to create
localized versions of preferences templates.
Owen Leonard [Wed, 10 Feb 2010 17:04:51 +0000 (12:04 -0500)]
Additional changes to fix Bug 3920, XSLTdetailDisplay syspref controls both OPAC and Intranet
This patch adds XSLTDetailsDisplay and XSLTResultsDisplay variables
for the staff client, OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay
variables to the OPAC. Note that the XSLTResultsDisplay doesn't actually
do anything because no one has added an XSLT version of search results
to the staff client.
Chris Cormack [Fri, 23 Oct 2009 22:30:37 +0000 (11:30 +1300)]
Fix for Bug 3730 - Wrong ISO 639-2 Language Code for Portuguese in database
[Patch originally by Ricardo Dias Marques]
Bug 3730 - Wrong ISO 639-2 Language Code for Portuguese in database
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3730
For 3.0.x head of the Git branch, the ISO 639-2 Language Code for
Portuguese in Koha database is wrong.
Specifically, in the table "language_rfc4646_to_iso639", when the
field "rfc4646_subtag" has the value "pt", the field "iso639_2_code"
should have the value of "por" and NOT the current one of "pol"
("pol" refers to "Polish" as correctly also appears for the code "pl",
in the row above the "pt" one).
In my test setups, this showed some serious sequences for people
that choose the Portuguese language in the Web Installer, namely:
- very weird look of Staff client with missing Header and Footer,
that renders the Staff client unusable
- Portuguese translation apparently not getting updated for the OPAC
(for people that do an Upgrade from a previous version)
This patch is for the 3.0.x branch (I tested it with that branch).
For the master branch, I don't have a database setup to create and
test a similar patch but Chris Cormack nicely volunteered to do that.
Thanks Chris!
Galen Charlton [Wed, 10 Feb 2010 12:11:17 +0000 (07:11 -0500)]
bug 4122: make WebBasedSelfCheck functional
The WebBasedSelfCheck preference is now functional - if a user
tries to use /cgi-bin/koha/sco/sco-main.pl if the preference
is not on, they get redirected to the OPAC home page.
Also, the patron image web service now returns HTTP 403 (forbidden) unless
both WebBasedSelfCheck and ShowPatronImageInWebBasedSelfCheck are on.
Galen Charlton [Wed, 10 Feb 2010 13:31:45 +0000 (08:31 -0500)]
bugs 3912, 4144: can now add contracts if dataformat is not metric
Fixed bug in date validation that prevented adding new contracts
if the dateformat syspref was set to something other than 'metric'.
In process, also removed three hand-written date validation routines
in favor of using JavaScript Date objects and the Date_from_syspref
function provided in calendar.inc.
This fixes bug 3912, and partially addresses bug 4144.
Galen Charlton [Wed, 10 Feb 2010 11:27:30 +0000 (06:27 -0500)]
removing test.pl
Following up on patch submitted by Colin Campbell, convinced
myself that this was a throwaway test script comitted in error.
Since it isn't of use otherwise, I've elected to remove it
instead of moving it to misc/split_test.pl as Colin proposes.
Zeno Tajoli [Sun, 17 May 2009 21:26:17 +0000 (23:26 +0200)]
Bug 3162 Fix only for [forward port of tempoary fix 3.0.x]
Note that this patch causes the authority subfield visibility
to match 3.0.x, but at a cost - only two options are available now,
hide all and show all, and much flexibility is lost. This will
need to be improved.
Galen Charlton [Tue, 9 Feb 2010 18:54:29 +0000 (13:54 -0500)]
bug 4145 - fix typo in sysprefs.sql
Fixed following error during new en installation:
ERROR 1064 (42000) at line 217: You have an error in your SQL syntax;
check the manual that corresponds to your MySQL server version for the right
syntax to use near ''XSLTDetailsDisplay','0','','Enable XSL stylesheet control
over details page dis' at line 1
Colin Campbell [Fri, 2 Oct 2009 11:22:47 +0000 (12:22 +0100)]
Bug 2505 Enabled warnings in authorities/*
Fixed obvious warnings generators in scripts
with mismatched comparisons or undefined variables
removed temporary variable selected while ensuring the
comparison it represented was between two defined variables
Colin Campbell [Wed, 21 Oct 2009 08:54:18 +0000 (09:54 +0100)]
Bug 3723 Correct return of Institution in Patron Info Resp
While the comment correctly notes that the order of variable length
fields is not fixed some units expect mandatory fields to
follow the sequence in the protocol definition and fail
parsing otherwise. Moved institution id to its expected
place in the patron information response.
Indented the first half of the if (patron_valid) so its clearer
that two cases are handled here.
Colin Campbell [Wed, 4 Nov 2009 21:15:55 +0000 (21:15 +0000)]
(Bug 3767 - Return error if checkin passed an invalid item
If an invalid item barcode is passed to checkin
the sip2 connection dies. This is because although
no item object is created its mehods are called in Checkin
To maintain the connection properly catch the condition
and return the correct response to the unit
(should also fix Bug #3696 )
Owen Leonard [Mon, 8 Feb 2010 17:35:26 +0000 (12:35 -0500)]
Fix for Bug 4138, Adding or deleting suggestions in the OPAC does not properly refresh the page
- Using redirect() and adding URL parameter to enable the display of
messages on the screen confirming the action.
- Also correcting for JavaScript error in form validation routine.
Galen Charlton [Mon, 8 Feb 2010 18:39:58 +0000 (13:39 -0500)]
Merge branch '3.0.x-to-3.2.0' of /home/koha/koha1/dev into to-push
Forward-porting 3.0.x release notes.
* '3.0.x-to-3.2.0' of /home/koha/koha1/dev:
forward-port rest of changes to 3.0.1 release notes
Adding a translation note.
Adding release notes for 3.0.1
minor update on release notes
Henri-Damien Laurent's release notes and version 3.0.2
Preparing 3.0.3
Updated references to Portuguese translation in Release Notes
Followup release notes
Adding release notes
Update on release notes
Adding 3.0.5 release notes
Reverted because, as it describes itself, this was an incomplete
fix that simply commented out a feature that had been committed to HEAD
and sponsored by a library. Bug 4139 has been opened for the underlying
performance issue.
Colin Campbell [Mon, 8 Feb 2010 16:17:30 +0000 (16:17 +0000)]
Bug 3810 Mail::Sendmail should not fail silently
The return from Mail::Sendmail should always be checked
Output the error message if it fails so we have some
indication of where to start looking if it fails
Colin Campbell [Mon, 8 Feb 2010 15:39:46 +0000 (15:39 +0000)]
Bug 4133 Ensure that orders have a valid quantity received
quantityreceived drives other parts of acq noticeably budget balances
ensure that a number (usually 0) is set in NewOrder
give field a valid default and set as not null
reinterpret exsting nulls in table as zero
Colin Campbell [Fri, 9 Oct 2009 14:32:46 +0000 (15:32 +0100)]
Bug 3697 Return due date (SIP Field AH) in item info
Although the due date of an on loan item was being retrieved
the appropriate field in the Item object was not set
causing the due date not to be returned in the item
information response
Jane Wagner [Thu, 22 Oct 2009 15:21:21 +0000 (11:21 -0400)]
Bug 2576 reopened -- turn off fines elsewhere in OPAC account
The original patch allowed use of the OPACFinesTab syspref to turn off
the Fines tab in the OPAC patron record. However, a column for fines
still appears in the listing of overdues, and as a tab on the line with
Overdues, Holds, Fines, etc. This patch turns off the other instances of
fine columns/displays if the syspref is off.
Jane Wagner [Fri, 30 Oct 2009 13:44:38 +0000 (09:44 -0400)]
Bug 3738 Automate login to web-based self-check system
Some small, single-branch corporate and special libraries use unattended self-checkout stations, and would like to automate the staff login, so that just going to the sco/sco-main.pl URL would bring the self-check up ready for patron use. This patch create three sysprefs, AutoSelfCheckAllowed, and AutoSelfCheckID/AutoSelfCheckPass. If the site wants to allow automated login, staff would then need to create the selfcheck user record and enter that login ID and password into the sysprefs. The kohaclone/opac/sco/sco-main.pl script has been modified to check these sysprefs and pass values (if present and allowed) into the self-check URL. The URL then bypasses the staff login page and comes up ready for checkout, waiting for the first patron barcode.
Bug 3920 - Add 2 syspref to activate XSLT use in OPAC/Intranet
- Add two syspref:
- OPACXSLTResultsDisplay
- OPACXSLDetailsDispay
- Add them to .pref files and dispatch them beetween OPAC and Search
tab.
- Upgrade DB version to 3.2 .113
- Fix something wrong in UNIMARCslim2intranetDetail.xsl
- Display OPAC result and detail pages using those syspref.
projects / koha.git / log
![14 years agoBug 3162 Fix only for [forward port of tempoary fix 3.0.x]](/gitweb/Members/js/jscripts/bar_r.gif?p=koha.git;a=commit;h=1d0bd7fc59f658325c1fa620cf791981853ac643){kind=link}
