From 108cebeea1597d3dba91553b64f83fa21e4b109b Mon Sep 17 00:00:00 2001
From: Julian Maurice <julian.maurice@biblibre.com>
Date: Fri, 20 Jan 2023 17:29:40 +0100
Subject: [PATCH] Bug 11844: Fix QA issues (POD, TT filters, file exec flag)

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 Koha/AdditionalField.pm                           | 11 +++++++++++
 Koha/Template/Plugin/ClassSources.pm              | 15 +++++++++++++++
 installer/data/mysql/atomicupdate/bug-11844.pl    |  0
 .../prog/en/includes/additional-fields-entry.inc  |  2 +-
 4 files changed, 27 insertions(+), 1 deletion(-)
 mode change 100644 => 100755 installer/data/mysql/atomicupdate/bug-11844.pl

diff --git a/Koha/AdditionalField.pm b/Koha/AdditionalField.pm
index 12b0934f78..77a43724cc 100644
--- a/Koha/AdditionalField.pm
+++ b/Koha/AdditionalField.pm
@@ -13,6 +13,17 @@ use base qw(Koha::Object);
 use C4::Context;
 use Koha::MarcSubfieldStructures;
 
+=head1 METHODS
+
+=head2 effective_authorised_value_category
+
+Returns the authorised value category of the additional field or the authorised
+value category of the MARC field, if any.
+
+    my $av_category = $additional_field->effective_authorised_value_category;
+
+=cut
+
 sub effective_authorised_value_category {
     my ($self) = @_;
 
diff --git a/Koha/Template/Plugin/ClassSources.pm b/Koha/Template/Plugin/ClassSources.pm
index 7b424f4905..81063e7acd 100644
--- a/Koha/Template/Plugin/ClassSources.pm
+++ b/Koha/Template/Plugin/ClassSources.pm
@@ -22,6 +22,21 @@ use base qw( Template::Plugin );
 use C4::Context;
 use Koha::ClassSources;
 
+=head1 NAME
+
+Koha::Template::Plugin::ClassSources - Template::Toolkit plugin for Koha Classification Source Object
+
+=head1 METHODS
+
+=head2 all
+
+Return the list of class sources
+
+    [% class_sources = ClassSources.all() %]
+    [% class_sources = ClassSources.all({ selected => $selected }) %]
+
+=cut
+
 sub all {
     my ($self, $params) = @_;
 
diff --git a/installer/data/mysql/atomicupdate/bug-11844.pl b/installer/data/mysql/atomicupdate/bug-11844.pl
old mode 100644
new mode 100755
diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/additional-fields-entry.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/additional-fields-entry.inc
index b16f537090..3b93ad2d04 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/additional-fields-entry.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/additional-fields-entry.inc
@@ -61,7 +61,7 @@
                 [% IF field.marcfield && field.marcfield_mode == 'get' %]
                     This value will be filled with the [% field.marcfield | html %] subfield of the selected biblio.
                 [% ELSIF field.marcfield && field.marcfield_mode == 'set' %]
-                    This value will be saved to the [% field.marcfield %] subfield of the selected biblio.
+                    This value will be saved to the [% field.marcfield | html %] subfield of the selected biblio.
                 [% END %]
             </li>
         [% END %]
-- 
2.39.5