Galen Charlton [Sat, 19 Jun 2010 11:53:59 +0000 (07:53 -0400)]
bug 4896: granular permissions now always on (DB rev 138)
Per the following koha-devel thread, the use of
staff user subpermissions, AKA granular permissions, is
now the default behavior in Koha. This patch removes
the GranularPermissions system preference.
Liz Rea [Wed, 9 Jun 2010 18:27:35 +0000 (13:27 -0500)]
Changing <p> to <span> per gmcharlt's suggestion re: Adding <p class="noholdstext"> tag around the "No Holds Allowed" text to allow for jquery selection/replacement of the text.
The plugin was returning a 25 characters length leader rather than 24
characters. So leader was recreated automatically, removing user update,
before writing biblio record.
Andrew Elwell [Sat, 5 Jun 2010 11:16:51 +0000 (13:16 +0200)]
The start of some POD cleanups in C4/*.pm
If these are acceptable I'll continue - target is to get rid of all warnings
and errors with podcheck and make sure that any man and html formatted pod
docs look 'OK'
Lars Wirzenius [Fri, 4 Jun 2010 02:52:44 +0000 (14:52 +1200)]
Remove dependencies on perl-base.
perl-base is a required package, so it is always installed on a Debian
system, and Debian packages should not depend on it, unless they need
it a specific version, and I don't think we do.
Owen Leonard [Fri, 28 May 2010 14:49:46 +0000 (10:49 -0400)]
Fix for Bug 3081, Url's contain spaces
My investigation finds that the problem in Internet
Explorer was not with the spaces in the URL but
with the spaces in the "name" attribute of the pop-up
window. Converting spaces to underscores allows
the plugin links to work correctly.
Owen Leonard [Thu, 3 Jun 2010 17:37:33 +0000 (13:37 -0400)]
Fix for Bug 3722 - Branch deletion results in incorrect message
A fix was submitted by Nahuel on 23 Nov 2009 and pushed, but
it combined messages for existing patrons and existing items.
This patch defines separate messages for the various cases and
corrects a typo in the original fix which left existing patrons
unreported.
Nicole Engard [Thu, 27 May 2010 03:55:52 +0000 (23:55 -0400)]
bug 4834 split joined preferences
these prefs : FilterBeforeOverdueReport & DisplayClearScreenButton shouldn't be
lumped together - they do two very different things and have nothing to do with
each other.
this patch splits them into two individual preferences.
Lars Wirzenius [Wed, 2 Jun 2010 05:34:24 +0000 (17:34 +1200)]
Upgrade Koha instance database schema when package is upgraded.
If the new version of Koha requires a newer version of the database
schema, the Koha instances will work immediately after the package
is upgraded, rather than after the sysadmin has run koha-upgrade-schema
manually.
Lars Wirzenius [Fri, 28 May 2010 04:29:48 +0000 (16:29 +1200)]
Add tools to update debian/control's build dependencies.
The canonical list of Perl module dependencies are in
C4::Installer::PerlDependencies::PERL_DEPS now. Add a script
(debian/list-deps) to turn that into a list of Debian package names.
Because that is a slow process, and the output rarely changes, do
not do that at build time. Also, doing it at build time would require
modifying debian/control in evil ways.
Instead, add another tool, debian/update-control, which reads the
new file debian/control.in, and adds the output of debian/list-deps to
Build-Depends and creates a new debian/control.
debian/control.in is the master file. If changes are needed, that should
be edited. For performance and convenience reasons, the output is also kept
in git, but don't edit debian/control directly, please. Such changes
might get lost by the next commit by someone else.
Whenever PERL_DEPS changes, debian/update-control should be run as well
and the result committed to git.
This is not quite as automatic as it might be, but should be good enough.
It avoids keeping the list of Perl modules in two places.
Note that since it seems impossible to automatically figure out the Debian
package version that corresponds to a Perl module version, I have not
tried to do that at all.
Added "dialog alert" class to "No Results Found" message on the patron
search so the alert stands out. Previously no css was applied to it so
it was just plain text. Librarians weren't noticing it.
(MT #2565) fix aqplan csv export, and turn off debug
This fix the csv export that doesn't export correctly the budget name, it's empty column.
And it turn off some SQL debug that slow down the result of the page and the csv export.
Lars Wirzenius [Wed, 26 May 2010 06:52:59 +0000 (18:52 +1200)]
Add dependency on apache2-mpm-itk for koha-common.
The way things are set up, each Koha instance runs under its own
user account. At least for now, this requires apache2-mpm-itk.
Later we can investigate other possibilities.
Galen Charlton [Tue, 25 May 2010 21:32:19 +0000 (17:32 -0400)]
removed needless imports of the YAML module
Removed instances of 'use YAML' that were either completely
unnecessary or which were used only in debug code. Also
removed a needless import of Data::Dumper.
Garry Collum [Sun, 23 May 2010 23:55:26 +0000 (19:55 -0400)]
Bug 4805: Fixes multiple subscriptionid's being passed to serials-collection.
This is a replacement patch for my previous patch.
This patch insures that only unique subscriptionids are defined in the serials-edit form. Multiple ids are passed to serials-collection, but not multiple copies of the same id.
Galen Charlton [Tue, 25 May 2010 15:00:29 +0000 (11:00 -0400)]
bug 4311: respect OPACXSLTResultsDisplay
Check OPACXSLTResultsDisplay instead of XSLTResultsDisplay when
determining whether to use the XSLT bib results stylesheet for
OPAC search results.
In the process, added a new $search_context parameter to
C4::Search::searchResults() to specify whether results
are to be served up for the staff interface or for the
OPAC.
Galen Charlton [Tue, 25 May 2010 13:21:24 +0000 (09:21 -0400)]
bug 4018: remove duplicate unAPI link when XSLT bib details display on
The unAPI link is now added only in opac-detail.tmpl. More than
one unAPI link in the same page was causing a bit of indigestion
for Zotero, which interprets multiple unAPI links as specifying
more than one resource on a given page.
Lars Wirzenius [Tue, 25 May 2010 01:44:26 +0000 (13:44 +1200)]
Make koha-create be able to handle manual database creation.
This is necessary if we do not have access to DB server with sufficient
permissions. The DB server is used for other things, that may well be
the case.
Lars Wirzenius [Tue, 25 May 2010 01:44:24 +0000 (13:44 +1200)]
Use /etc/mysql/koha-common.cnf instead of the Debian one.
koha-common.postinst now creates a symlink to the Debian one.
The sysadmin may replace that manually with something that allows
Koha to access a remote mysql server.
Lars Wirzenius [Tue, 25 May 2010 01:44:08 +0000 (13:44 +1200)]
Replace dependencies on koha-dev-env with list of packages.
The dependencies are needed both at build time and at run time. Build
time needs them for running tests. To avoid duplicating the (long!)
list of dependencies, we do a little bit of trickery, and generate
a koha:Depends substvar, from all build dependencies (except debhelper),
and use ${koha:Depends} in the koha-common (not koha) Depends header.
A little bit tricky, but works.