]> git.koha-community.org Git - koha.git/commit
Bug 20529: Fix "Return to results" link broken by a double quote
authorVictor Grousset <victor.grousset@biblibre.com>
Mon, 16 Apr 2018 16:55:48 +0000 (18:55 +0200)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 1 Sep 2021 13:53:41 +0000 (15:53 +0200)
commit125c5da32a4a21e6f1b39e24ee172b9c09d474f0
treecbb32aef20f6a3b786c5bfd2a37f9992023e4979
parent1bd10a4a2e2c25a2b688f898d31f9ee1e6089e40
Bug 20529: Fix "Return to results" link broken by a double quote

(in the search query)

cause: decodeURIComponent used when URI encoding was necessary. (At
least in main usecase of this feature)
It could have been a copy and paste error. From the above
browseRecords() function.

== Test plan ==
1. Search in the staff catalogue «a "alice"»
     Replace a and alice with whatever than will return a result for you
2. Click on the first result
3. Check the "Return to results" link
     It should be like
     staff_url://cgi-bin/koha/catalogue/search.pl?idx=kw&q=a
     This is the bug. Because when clicking the link, your search will be
     'kw,wrdl: a'
     instead of
     'kw,wrdl: a "alice"'
4. Apply this patch.
5. Search in the staff catalogue «a "alice"»
     Replace a and alice with whatever than will return a result for you
6. Click on the first result
7. Check the "Return to results" link
     The link should preserve the full query

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
koha-tmpl/intranet-tmpl/prog/js/browser.js