]> git.koha-community.org Git - koha.git/commit
Bug 33363: Add separate permissions for creating and deleting suggestions
authorKyle M Hall <kyle@bywatersolutions.com>
Wed, 26 Apr 2023 15:21:39 +0000 (15:21 +0000)
committerKatrin Fischer <katrin.fischer@bsz-bw.de>
Fri, 12 Jul 2024 08:21:24 +0000 (10:21 +0200)
commit87b3399812ddbd1a33808215e9a85c151bdda481
tree526eb8ef1cc75c402b2d983535e46c6c2e26d1a1
parenta3f4c9ec8acbf272aba13c53add8b9c6b96de79b
Bug 33363: Add separate permissions for creating and deleting suggestions

There are a number of libraries that would like for their staff to be able to submit (and view existing) purchase suggestions from the borrower record, but not give the staff the ability to edit/manage/delete purchase suggestions.

Test Plan:
1) Apply this patch
2) Run restart all the things!
3) Run updatedatabase
4) Verify anyone with the suggestions manage permissions now has the create and delete permissions as well
5) Verify anyone without the suggestions manage permission has not recieved the new permissions
6) Enable only the create permission for a librarian
7) Verify that librarian can only create new suggestions ( not manage or delete )
8) Enable only the manage permission for a librarian
9) Verify that librarian can only manage existing suggestions ( not create or delete )
10) Enable only the delete permission for a librarian
11) Verify that librarian can only delete suggestions ( not create or manage )

Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Sponsored-by: Cuyahoga County Public Library
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
13 files changed:
api/v1/swagger/paths/suggestions.yaml
installer/data/mysql/atomicupdate/bug_33363.pl [new file with mode: 0755]
installer/data/mysql/mandatory/userpermissions.sql
koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-menu.inc
koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
koha-tmpl/intranet-tmpl/prog/en/includes/header.inc
koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc
koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
koha-tmpl/intranet-tmpl/prog/en/modules/members/purchase-suggestions.tt
koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
members/purchase-suggestions.pl
suggestion/suggestion.pl
t/Koha/Auth/Permissions.t