]> git.koha-community.org Git - koha.git/commit
Bug 20076: (RM follow-up) Fix system preference boolean logic
authorFridolin Somers <fridolin.somers@biblibre.com>
Fri, 14 Jan 2022 01:33:09 +0000 (15:33 -1000)
committerKyle Hall <kyle@bywatersolutions.com>
Fri, 14 Jan 2022 14:27:14 +0000 (09:27 -0500)
commit91f3d5d6c37364cf0b82df6039686e6efe8d7fc7
tree811a03a6ae5649ca85eb59bb42bfdfcd51744b1a
parent141d411ee30bb0db711cec9de34989640c7c67ea
Bug 20076: (RM follow-up) Fix system preference boolean logic

A Yes/No system preference must use 1 for Yes and 0 for No.
So "Send" for 1/Yes and "Don't send" for 0/No.
We add too much problems with double-negation boolean system preferences (such as dontmerge).

Previous patch changed default value to 1 in atomicupdate, do the same
in installer/data/mysql/mandatory/sysprefs.sql

Also to be consistant, sets options = NULL instead of '' in atomicupdate

Also removed useless added empty line in /misc/cronjobs/overdue_notices.pl

Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
installer/data/mysql/atomicupdate/add-system-preference-EmailOverduesNoEmail.perl [deleted file]
installer/data/mysql/atomicupdate/bug_20076-add_system_preference_EmailOverduesNoEmail.pl [new file with mode: 0755]
installer/data/mysql/mandatory/sysprefs.sql
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
misc/cronjobs/overdue_notices.pl