]> git.koha-community.org Git - koha.git/commit
Bug 9422: Don't allow access to 'Upload patron images' when patronimages syspref...
authorKatrin Fischer <katrin.fischer.83@web.de>
Sun, 10 Feb 2019 11:09:08 +0000 (12:09 +0100)
committerLucas Gass <lucas@bywatersolutions.com>
Mon, 11 May 2020 19:17:04 +0000 (19:17 +0000)
commit9ecf51eb43d49e4029d08821a2c360529cbaa65d
treefcc14796e3ee8521ee9416ced7384a8a14fb28b8
parent12bf0c91d1ff15dc2c33cb25c16edbdb5121d740
Bug 9422: Don't allow access to 'Upload patron images' when patronimages syspref is off

In addition to checking the patron image upload permission, this
adds a check for the patronimages system preference to the tools
home page and sidebar.

To test:
- Check that the patron image upload tool only displays when
  - system preference patronimages is set to 'Allow'
    and user is either
  - superlibrarian or
  - has bath_upload_patron_images permission
- Save URL of patron image uploader page
- Turn off patronimages
- Verify you get redirected to the home page of Koha when trying
  to access the page

Note: this redirect is already used by the stock rotation feature.
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
(cherry picked from commit 4ed4b51e4bbbcc0e968c1685a6f4eaeefc6d7e37)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc
koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt
tools/picture-upload.pl