]> git.koha-community.org Git - koha.git/commit
Bug 27708: Unify two item object creation blocks to be stored as hash
authorPetro Vashchuk <stalkernoid@gmail.com>
Wed, 3 Mar 2021 12:34:52 +0000 (14:34 +0200)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 5 Nov 2021 11:17:08 +0000 (12:17 +0100)
commitb4e738a720b71716a9b6c4badbe40a0592a038e7
tree70bdc3254ff2eef4fc54c54e44516fc8e6f30d01
parentcc3a129db81fe009a893c074757ec1df44096dea
Bug 27708: Unify two item object creation blocks to be stored as hash

Previously for existing item data was stored as an object reference and
then treated as one, but for not yet existing item data was stored as
keys in hash reference in the same variable and later it was treated
like an object, hence why it crashed with "no method".
This patch unifies that variable in both cases filled as hash and
treated as such.

To reproduce:
    1) Go to "Administration->System preferences" and change
"AcqCreateItem" to "receiving an order."
    2) Now, go to "Acquisitions" and create a new Vendor,
or use an existing one.
    3) Next, go to "Administration->EDI Account" and add EDI account
(pick that Vendor that you created recently, or the one that you will
use for this test).
    4) Also in "Administration->Library EANs" add EAN if you didn't
have one previously.
    5) Go back to "Acquisitions" and add a new basket to your Vendor
that you will use for this test.
    6) Press "Create EDIFACT order" button. It should throw
"Can't call method "homebranch" on unblessed reference..."
software error.
    7) Apply the patch.
    8) Reload the page that threw software error previously
(or repeat steps 5, 6 if you need another basket),
it should go through now.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Koha/Edifact/Order.pm