]> git.koha-community.org Git - koha.git/commit
Bug 4461: Use KohaAdminEmailAddress pref as 'from'
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 26 Feb 2020 10:08:51 +0000 (11:08 +0100)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Mon, 6 Apr 2020 10:16:51 +0000 (11:16 +0100)
commitfa23374d06f75f47e674cb46298b8e2a8325e404
treef53f7a41c8fc99e049097d60e5501f10ba82d0f2
parent499c6e45d271c507a757deb58d9dd42f4323a47d
Bug 4461: Use KohaAdminEmailAddress pref as 'from'

We usually do not specify the from_address on enqueuing the notice, but
when sending it (from _send_message_by_email). That way a) the code is
centralized (as we must use $patron->notice_email_address) and b) the
email used is the one that is in the DB when the letter is effectively
sent.
Here I guess you need to give it when the notice is enqueued as you want
to default to the koha admin address.

I do not think it's a good idea, we should not send an email with "from"
if not really sent by the user.
We have the borrowernumber anyway to know who filled the form.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
opac/opac-reportproblem.pl