]> git.koha-community.org Git - koha.git/commit
Bug 29736: Don't return empty clubs
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 20 Dec 2021 14:14:56 +0000 (15:14 +0100)
committerAndrew Fuerste-Henry <andrew@bywatersolutions.com>
Tue, 25 Jan 2022 17:53:33 +0000 (17:53 +0000)
commit4520178095b3bfe1e9ba976b2798721f96635052
tree685e5f4a79b834e60fa5eba0770d19106aca851b
parent17a1e5dfda0d59957223a13965c95b031cc83810
Bug 29736: Don't return empty clubs

There is an error when placing a hold for a club without members:
Uncaught TypeError: err.responseJSON.error is undefined

It seems that we should remove clubs without members from the search.

Test plan:
Create 1 club xx with 2 patrons
Create 1 club xxx with 1 patron and cancel their enrolment
Create 1 club xxxx without patron

Place a hold for club "x", only the first one should be returned with
this patch.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit b45e67e03eeffdaa006c693e2e6426d452cbb09e)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Koha/Clubs.pm
reserve/request.pl
t/db_dependent/Clubs.t