From 018a981b9ba4febb9a86ca5c794bff1cbf928d03 Mon Sep 17 00:00:00 2001
From: Nick Clemens <nick@bywatersolutions.com>
Date: Mon, 14 Feb 2022 19:14:58 +0000
Subject: [PATCH] Bug 29282: Add issues and renewals columns to holdings tbale
 on details page

To test:
 1 - Apply patch, restart all
 2 - View a record with items in the staff client
 3 - Note issues and renewals columns not shown
 4 - Click the gear to edit visible columns
 5 - Issues and renewals are present and hidden
 6 - Click to view columns
 7 - Confirm counts show, or 0 if item has not circulated/been renewed
 8 - Circulate/renew an item
 9 - Verify counts increase
10 - Make columns visible by default in Admin->Table settings
11 - Confirm columns show by default on details page

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 admin/columns_settings.yml                                  | 6 ++++++
 koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 4 ++++
 2 files changed, 10 insertions(+)

diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml
index a838a19f9b..5b078c1a73 100644
--- a/admin/columns_settings.yml
+++ b/admin/columns_settings.yml
@@ -364,6 +364,12 @@ modules:
               columnname: holdings_status
             -
               columnname: holdings_lastseen
+            -
+              columnname: holdings_issues
+              is_hidden: 1
+            -
+              columnname: holdings_renewals
+              is_hidden: 1
             -
               columnname: holdings_dateaccessioned
             -
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
index c24c861c03..152fe10898 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
@@ -341,6 +341,8 @@
                 [% END %]
                 <th id="[% tab | html %]_status" data-colname="[% tab | html %]_status">Status</th>
                 <th id="[% tab | html %]_lastseen" data-colname="[% tab | html %]_lastseen">Last seen</th>
+                <th id="[% tab | html %]_issues" data-colname="[% tab | html %]_issues">Checkouts</th>
+                <th id="[% tab | html %]_renewals" data-colname="[% tab | html %]_renewals">Renewals</th>
                 <th id="[% tab | html %]_dateaccessioned" data-colname="[% tab | html %]_dateaccessioned">Date accessioned</th>
                 <th id="[% tab | html %]_datelastborrowed" data-colname="[% tab | html %]_datelastborrowed">Date last borrowed</th>
                 <th id="[% tab | html %]_barcode" data-colname="[% tab | html %]_barcode">Barcode</th>
@@ -532,6 +534,8 @@ Note that permanent location is a code, and location may be an authval.
                         [% END %]
                     </td>
                     <td class="datelastseen" data-order="[% item.datelastseen | html %]">[% item.datelastseen | $KohaDates %]</td>
+                    <td class="issues_field" data-order="[% item.issues || 0 | html %]">[% item.issues || 0 | html %]</td>
+                    <td class="renewals_field" data-order="[% item.renewals || 0 | html %]">[% item.renewals || 0 | html %]</td>
                     <td class="dateaccessioned" data-order="[% item.dateaccessioned | html %]">[% item.dateaccessioned | $KohaDates %]</td>
                     <td class="datelastborrowed" data-order="[% item.datelastborrowed | html %]">[% item.datelastborrowed | $KohaDates %]</td>
                     <td><a href="/cgi-bin/koha/catalogue/moredetail.pl?type=[% item.type | uri %]&amp;itemnumber=[% item.itemnumber | uri %]&amp;biblionumber=[% item.biblionumber | uri %]&amp;bi=[% item.biblioitemnumber | uri %]#item[% item.itemnumber | uri %]">[% item.barcode | html %]</a></td>
-- 
2.39.5