From 3c0cd1458649939eb66d2c258438ce118b2f0ae9 Mon Sep 17 00:00:00 2001
From: Nick Clemens <nick@bywatersolutions.com>
Date: Tue, 11 Jun 2024 12:36:15 +0000
Subject: [PATCH] Bug 37069: OPAC authorities search is stateless

This patch removes cud- from the search op and chanegs the form
submission to GET

To test:
1 - Search authorities on OPAC for 'a'
2 - Click page 2
3 - You get the search form
4 - Apply patch, restart all
5 - Repeat search, confirm it works
6 - Click page 2
7 - Confirm you get next results

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 1a2b7405695e8fff5175b5f04d39e956a272bc16)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
---
 .../opac-tmpl/bootstrap/en/modules/opac-authorities-home.tt   | 4 ++--
 opac/opac-authorities-home.pl                                 | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authorities-home.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authorities-home.tt
index 8dc1c2b9ef..dcaf28b387 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authorities-home.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authorities-home.tt
@@ -32,9 +32,9 @@
                     <div class="col order-first order-md-first order-lg-2">
                 [% END %]
                     <div id="userauthhome" class="maincontent">
-                        <form name="f" action="/cgi-bin/koha/opac-authorities-home.pl" method="post">
+                        <form name="f" action="/cgi-bin/koha/opac-authorities-home.pl" method="get">
                             [% INCLUDE 'csrf-token.inc' %]
-                            <input type="hidden" name="op" value="cud-do_search" />
+                            <input type="hidden" name="op" value="do_search" />
                             <input type="hidden" name="type" value="opac" />
                             <fieldset class="rows">
                                 <legend><h1>Authority search</h1></legend>
diff --git a/opac/opac-authorities-home.pl b/opac/opac-authorities-home.pl
index 8b57bac299..9e617485d2 100755
--- a/opac/opac-authorities-home.pl
+++ b/opac/opac-authorities-home.pl
@@ -48,7 +48,7 @@ my ( $template, $loggedinuser, $cookie );
 
 my $authority_types = Koha::Authority::Types->search({}, { order_by => ['authtypetext']});
 
-if ( $op eq "cud-do_search" ) {
+if ( $op eq "do_search" ) {
     my @input_marclist = $query->multi_param('marclist');
     my @and_or = $query->multi_param('and_or');
     my @excluding = $query->multi_param('excluding');
-- 
2.39.5