From 4484b7d4d96e980a445c687398a363817f4f907c Mon Sep 17 00:00:00 2001
From: Tomas Cohen Arazi <tomascohen@theke.io>
Date: Mon, 30 Mar 2020 09:39:13 -0300
Subject: [PATCH] Bug 25019: Make the ViewPolicy filter initialization standard

This patch makes the ViewPolicy filter use the 'params' accessor instead
of relying of ->{options} which has no accessor. This will allow
interacting with the filter object be similar through all the filters in
the chain.

To test, we just need to verify no behaviour change takes place:
1. Run:
   $ kshell
  k$ prove t/db_dependent/Filter_MARC_ViewPolicy.t
=> SUCCESS: Tests pass
2. Apply this patch
3. Repeat 1
=> SUCCESS: Tests still pass!
4. Sign off :-D

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
(cherry picked from commit e6c829d887b8b6aeda98a7ba57dc9ac04b79a7a3)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
---
 Koha/Filter/MARC/ViewPolicy.pm | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)

diff --git a/Koha/Filter/MARC/ViewPolicy.pm b/Koha/Filter/MARC/ViewPolicy.pm
index e69b7303b7..a963e3f129 100644
--- a/Koha/Filter/MARC/ViewPolicy.pm
+++ b/Koha/Filter/MARC/ViewPolicy.pm
@@ -78,10 +78,12 @@ sub filter {
         push @records, $precord;
     }
 
+    my $params = $self->params;
+    my $interface     = $params->{options}->{interface} // 'opac';
+    my $frameworkcode = $params->{options}->{frameworkcode} // q{};
+
     foreach my $current_record (@records) {
         my $result        = $current_record;
-        my $interface     = $self->{options}->{interface} // 'opac';
-        my $frameworkcode = $self->{options}->{frameworkcode} // q{};
         my $hide          = _should_hide_on_interface();
 
         my $marcsubfieldstructure = GetMarcStructure( 0, $frameworkcode, { unsafe => 1 } );
@@ -153,16 +155,6 @@ sub _filter_field {
     return;
 }
 
-sub initialize {
-    my $self  = shift;
-    my $param = shift;
-
-    my $options = $param->{options};
-    $self->{options} = $options;
-    $self->Koha::RecordProcessor::Base::initialize($param);
-    return;
-}
-
 # Copied and modified from 3.10.x help file
 # marc_subfields_structure.hidden
 # allows you to select from 19 possible visibility conditions, 17 of which are implemented. They are the following:
-- 
2.39.5