From 5d86cc7363e72bc7e61326bd8c50e75d35d09bf0 Mon Sep 17 00:00:00 2001 From: Lucas Gass Date: Mon, 25 Oct 2021 22:52:22 +0000 Subject: [PATCH] Bug 29319: Use Business::ISBN to check ISBNs on addbooks.pl/cataloging search To test: 1. Go to cataloging search and enter something like "7th Heaven". 2. Get an error when searching, Koha thinks you entered an ISBN 3. Apply patch 4. Try the same search, it should be a proper title search now 5. Find some stuff in the catalog with ISBN numbers in them. 6. The search should properly return ISBN13/ISBN10 searches, without with out the '-'. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 14c8d4c230ff96932ab87099f7594f311ffc4562) Signed-off-by: Victor Grousset/tuxayo --- cataloguing/addbooks.pl | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/cataloguing/addbooks.pl b/cataloguing/addbooks.pl index 69a573186e..279acc5c95 100755 --- a/cataloguing/addbooks.pl +++ b/cataloguing/addbooks.pl @@ -40,6 +40,7 @@ use Koha::BiblioFrameworks; use Koha::SearchEngine::Search; use Koha::SearchEngine::QueryBuilder; use Koha::Z3950Servers; +use Business::ISBN; my $input = CGI->new; @@ -108,19 +109,11 @@ if ($query) { my $countbr = 0; my @resultsbr; if ($query) { -# fill isbn or title, depending on what has been entered -#u must do check on isbn because u can find number in beginning of title -#check is on isbn legnth 13 for new isbn and 10 for old isbn my ( $title, $isbn ); - if ($query=~/\d/) { - my $clean_query = $query; - $clean_query =~ s/-//g; # remove hyphens - my $querylength = length $clean_query; - if ( $querylength == 13 || $querylength == 10 ) { - $isbn = $query; - } - } - if (!$isbn) { + my $isbn_valid = Business::ISBN->new($query); + if ( $isbn_valid && $isbn_valid->is_valid() ) { + $isbn = $query; + } else { $title = $query; } ( $countbr, @resultsbr ) = BreedingSearch( $title, $isbn ); -- 2.39.5